GitLab

Now settings page from Chrome OS does not apply uber.css.

BUG=178819,412272

Review URL: https://codereview.chromium.org/613683004

Cr-Commit-Position: refs/heads/master@{#297493}

BUG=

Review URL: https://codereview.chromium.org/613313002

Cr-Commit-Position: refs/heads/master@{#297492}

BUG=404771

Review URL: https://codereview.chromium.org/616923002

Cr-Commit-Position: refs/heads/master@{#297491}

There is a lot of unreached image transport code due to
- TextureImageTransportSurface actually being unused
as a transport surface now (we either use delegated rendering
or composite-to-mailbox)
- Mac using delegated rendering

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/615503004

Cr-Commit-Position: refs/heads/master@{#297490}

Currently even if a valid file is selected the OpenFileDialog is likely
to return an emtpy FilePath, depending on what is in memory after the
sole string returned by the Windows OFD. The code as written assumes
the Windows OFD will always return a null-terminated list of
null-terminated strings when returning successfully from the call to
the OFD. However if you check the MSDN documentation at:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839(v=vs.85).aspx

You will find this is not the case, and the return value depends on the
presence of OFN_ALLOWMULTISELECT in the Flags argument. If that value
is not set, which it is not in the case of single-file selection, then
there is only a single string in |openfilename_.lpstrFile|, and the
code within OpenFileName::GetResult() blows past that single NULL and
into unitialized memory, which ::GetSingleResult then assumes means
an invalid return filename and returns the empty FilePath.

This CL repairs that situation so that GetSingleResult now DCHECKS
that the OFN_ALLOWMULTISELECT is not there and returns the string
directly, and ::GetResult() asserts that the flag is present and
continues to do its multi-value parsing that it was doing before.

BUG=418760
TEST=Launch Chrome, hit CTRL+O to open a file, chose a valid test html
file, observe that the browser doesn't crash and successfully opens that
file.

Review URL: https://codereview.chromium.org/618503002

Cr-Commit-Position: refs/heads/master@{#297489}

This CL depends on blink side CL https://codereview.chromium.org/590183003/

BUG=282016

Review URL: https://codereview.chromium.org/591363003

Cr-Commit-Position: refs/heads/master@{#297488}

BUG=

Review URL: https://codereview.chromium.org/607273002

Cr-Commit-Position: refs/heads/master@{#297487}

BUG=None

Review URL: https://codereview.chromium.org/613243002

Cr-Commit-Position: refs/heads/master@{#297486}

Allow SkiaBitLockers to specify that they should record a bitmap at
a specified scale. Callers that know that they will be replayed at a
given scale factor can specify the final scale during record.

BUG=408557

Review URL: https://codereview.chromium.org/611253004

Cr-Commit-Position: refs/heads/master@{#297485}

Remove assert() from getChildElement() to fix the bug caused by https://chromiumcodereview.appspot.com/575333002/

BUG=418532
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/617973002

Cr-Commit-Position: refs/heads/master@{#297484}

Reenable Valgrind runs for CastTransport unit tests.

R=miu,oshima
BUG=418767
TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/598333003

Cr-Commit-Position: refs/heads/master@{#297483}

* Changes Tab::LoadIfNeeded()/Tab.loadIfNeeded() to return true
  if the call was "handled" and false if it failed.

* DevTools checks if LoadIfNeeded() fails, and bails out if it
  does.

BUG=403592

Review URL: https://codereview.chromium.org/618513002

Cr-Commit-Position: refs/heads/master@{#297482}

BUG=354261
R=brettw
TBR=piman,wtc
NOTRY=true

Review URL: https://codereview.chromium.org/603143002

Cr-Commit-Position: refs/heads/master@{#297481}

BUG=411131
R=navabi@chromium.org

Review URL: https://codereview.chromium.org/614083003

Cr-Commit-Position: refs/heads/master@{#297480}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/612183002

Cr-Commit-Position: refs/heads/master@{#297479}

The compositor adjusts the viewport bounds based on how far the top
controls are shown; however, the resize of the viewport on the Blink
side doesn't happen until a Resize event is received, which is heavily
throttled. This means that when a commit happens before the Resize,
the scroll offsets given to Blink may be outside the maximum bounds
and will be incorrectly clamped.

This CL adjusts FrameView's maximumScrollPosition to account for the
drift in where Blink and the Compositor think the top controls are.

Blink-side: https://codereview.chromium.org/560623002/

BUG=412581

Review URL: https://codereview.chromium.org/563513002

Cr-Commit-Position: refs/heads/master@{#297478}

BUG=None
R=cmasone@chromium.org
TBR=jln@chromium.org
TEST=comparing generated libva files between gyp and gn

Review URL: https://codereview.chromium.org/601923005

Cr-Commit-Position: refs/heads/master@{#297477}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/618873002

Cr-Commit-Position: refs/heads/master@{#297476}

There are a number of key, hot routines in gfx and gfx_geometry. Enable
-O2 for these targets.

BUG=411909,419051

Review URL: https://codereview.chromium.org/612513003

Cr-Commit-Position: refs/heads/master@{#297475}

Some cases are simple enough that a search and replace is sufficient. At the
same time, the fewer patches we have, the less time will be spent rebasing them.

BUG=414189
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/618013002

Cr-Commit-Position: refs/heads/master@{#297474}

They need base.isolate to bring in the VS runtime DLLs.

BUG=414808
R=maruel@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945

Review URL: https://codereview.chromium.org/617983002

Cr-Commit-Position: refs/heads/master@{#297473}

It was possible for us to send it before.

BUG=none
TEST=none
R=ben@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/617513003

Cr-Commit-Position: refs/heads/master@{#297472}

Causing compile failures on Linux GN trybots.

> - Update _api_features.json and _permissions.json to allow the following features in extensions:
>  - declarativeWebrequest,
>  - events
>  - webRequest
>  - webViewRequest
>
> - Move web_view_request_custom_bindings.js and web_view_request.json to extensions.
>
> - Remove ExtensionsAPIClient::GetRuleRegistry() since RuleRegisteryService has been moved to extension.
>
> - Clean up extensions/extensions.gyp.
>
> TBR=sky@chromium.org
> BUG=352293

NOTREECHECKS=true
NOTRY=true
TBR=fsamuel@chromium.org,rockot@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/620623002

Cr-Commit-Position: refs/heads/master@{#297471}

BUG=418859

Review URL: https://codereview.chromium.org/615803002

Cr-Commit-Position: refs/heads/master@{#297470}

The CookieManager startup path needs access to the CommandLine
before initialization.

BUG=331424

Review URL: https://codereview.chromium.org/617883003

Cr-Commit-Position: refs/heads/master@{#297469}

BUG=chromedriver:815

Review URL: https://codereview.chromium.org/594383005

Cr-Commit-Position: refs/heads/master@{#297468}

Instead of going through the Chromium's script 'run_webkit_tests.py'
that lives in webkit/tools/layout_tests and it is just a wrapper around
'run-webkit-tests', call the later directly from
third_party/WebKit/Tools/Scripts/.

As we are removing webkit/ directory, this change is also necessary.

BUG=338338
TEST=None
R=dpranke@chromium.org,bruening@chromium.org

Review URL: https://codereview.chromium.org/608593007

Cr-Commit-Position: refs/heads/master@{#297467}

Revert of Fix swarming of browser_tests and sync_integration_tests on debug windows. (patchset #1 id:1 of https://codereview.chromium.org/617983002/)

Reason for revert:
failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/38020/steps/runhooks/logs/stdio

Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /mnt/data/b/build/slave/Android_Builder/build
Updating projects from gyp files...
gyp: Key 'includes' repeated at level 1 with key path '' while reading /mnt/data/b/build/slave/Android_Builder/build/src/chrome/browser_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/tab_capture_end2end_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome_tests.gypi while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome.gyp

Original issue's description:
> Fix swarming of browser_tests and sync_integration_tests on debug windows.
>
> They need base.isolate to bring in the VS runtime DLLs.
>
> BUG=414808
> R=maruel@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945

TBR=maruel@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/620603002

Cr-Commit-Position: refs/heads/master@{#297466}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b220aa..07d889d

TBR=zmo@chromium.org,eustas@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/620493003

Cr-Commit-Position: refs/heads/master@{#297465}

Some of the problems found by this code can be attributed to activity on
DLLs that are not being monitored.

BUG=362176
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/587923002

Cr-Commit-Position: refs/heads/master@{#297464}

Start printing out the command used to run findbugs to allow for easier
debugging why findbugs might be failing.

BUG=None

Review URL: https://codereview.chromium.org/612883006

Cr-Commit-Position: refs/heads/master@{#297463}

android:permission puts a restriction on launching the activity such
that the launching context must have INTERNET permission. This is
not true launching via "am" on non-rooted devices, and makes no sense
for the public CastShellApk.

R=byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/615923003

Cr-Commit-Position: refs/heads/master@{#297462}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/566063002

Cr-Commit-Position: refs/heads/master@{#297461}

I moved all tests to Win Tests (dbg)(1) in preparation for removing 2, 3, 4, 5, & and Interactive Tests (dbg).

BUG=414808
R=maruel@chromium.org
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/5f7ee2f338c9d7c5616c18e594ec8ef834d718c6

Review URL: https://codereview.chromium.org/618533002

Cr-Commit-Position: refs/heads/master@{#297460}

Dependency on these entries was removed in https://codereview.chromium.org/382313003/

BUG=412890

Review URL: https://codereview.chromium.org/600503002

Cr-Commit-Position: refs/heads/master@{#297459}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/615113002

Cr-Commit-Position: refs/heads/master@{#297458}

Also, restoring ttest constants to original values in ttest_test.

BUG=404088

Review URL: https://codereview.chromium.org/616903003

Cr-Commit-Position: refs/heads/master@{#297457}

They need base.isolate to bring in the VS runtime DLLs.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/617983002

Cr-Commit-Position: refs/heads/master@{#297456}

When we enter overview the shelf is revealed which causes a workspace bounds
change. Normally the maximize mode window manager would update all active
windows to have the new bounds but this effectively undoes the transformation
applied to the window to show it in overview. As such, we defer updating the
bounds until we exit overview mode.

BUG=401664
TEST=WindowSelectorTest.FullscreenWindowMaximizeMode, WindowAnimationsTest.CrossFadeToBoundsFromTransform
TEST=Repro steps in http://crbug.com/401664

Review URL: https://codereview.chromium.org/588193003

Cr-Commit-Position: refs/heads/master@{#297455}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/616943002

Cr-Commit-Position: refs/heads/master@{#297454}