GitLab

Review URL: https://codereview.chromium.org/850853002

Cr-Commit-Position: refs/heads/master@{#313747}

On Android, instead of calling StartRepeatedVariationsSeedFetch()
in chrome_browser_main.cc, this changes the code to instead have
that be called by the first call to OnAppEnterForeground().

This will allow (in a future change) to have the caller of
OnAppEnterForeground() to first set the restrict mode param,
before fetching gets initialized. (Otherwise, fetching was
being initialized too early before the param could be set.)

BUG=452605

Review URL: https://codereview.chromium.org/880263005

Cr-Commit-Position: refs/heads/master@{#313746}

R=dgozman
TBR=nasko

BUG=451004

Review URL: https://codereview.chromium.org/884873004

Cr-Commit-Position: refs/heads/master@{#313745}

The mac toolbar redesign has been implemented to the point where this test can
be cross-platform.  Move it to be so.

BUG=429810
BUG=422381

TBR=sky@chromium.org (moving a file)

Review URL: https://codereview.chromium.org/884473006

Cr-Commit-Position: refs/heads/master@{#313744}

BUG=448790
TBR=phajdan

Review URL: https://codereview.chromium.org/882823006

Cr-Commit-Position: refs/heads/master@{#313743}

Also try to fix old entries when possible and play nice with older
versions

BUG=450589
R=mkwst@chromium.org,marja@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/869613006

Cr-Commit-Position: refs/heads/master@{#313742}

libvpx/VP8 currently allows resizing upward but will crash on codec
teardown in that case; these tests ensure we don't regress when we
remove the workarounds in VideoEncoderVpx.

BUG=134202

Review URL: https://codereview.chromium.org/866533004

Cr-Commit-Position: refs/heads/master@{#313741}

TopSites prepopulated pages are not injected by the embedder via the
TopSitesFactory. The method TopSites::GetPrepopulatedSites() now does return
the sites favicon, thumbnail and color in addition to the URL and title.

TopSitesImplTest now can inject prepopulated pages to the TopSitesImpl thus
enabling the test TopSitesImplTest.BlacklistingWithPrepopulated on Android.

Change TopSites so that it does not inherit from content::NotificationObserver
as it does not need to listen to notification and move the inheritance to
TopSitesImpl (until the code is changed to use observer pattern instead of
notifications).

Remove dependency of TopSitesBackend on content::BrowserThread by injecting a
base::SingleThreadedTaskRunner reference to the corresponding thread via the
TopSitesImpl::Init() method.

Introduce //components/test/data/history and move pristine SQL files used by
the different unit tests there, helping remove dependency of the unit tests
on //chrome.

Move top_sites.{cc,h}, top_sites_database.{cc,h} into
//components/history/core/browser.

BUG=380144, 380157
TBR=sky, dgozman, samarth

Review URL: https://codereview.chromium.org/870063002

Cr-Commit-Position: refs/heads/master@{#313740}

This patch should make the main thread more responsive when the user
is interacting with the device while the page is loading.

Sherrifs if you see an uptick in blink layout test flakes this patch
might be to blame.

I tried to reproduce the flakes I saw in the try runs locally.
With the exception of fast/loader/subframe-removes-itself.html
I was not able to reproduce a flake, however judging by the flakiness
dashboard, that test is already slightly flaky.

BUG=391005

Review URL: https://codereview.chromium.org/882073002

Cr-Commit-Position: refs/heads/master@{#313739}

This is a follow-up fix for:
https://crrev.com/90b41f569db5cff7a8b8d170b81516dd006f57ba

R=wfh@chromium.org
BUG=438157

Review URL: https://codereview.chromium.org/890643002

Cr-Commit-Position: refs/heads/master@{#313738}

Android 5.x does not allow running the gdb executable in
/data/local/tmp. For gdb to be executable by the package
it need to be located in /data/data/{PACKAGE-NAME} which is
allowed to run the exucutable.

BUG=453379

Review URL: https://codereview.chromium.org/884993003

Cr-Commit-Position: refs/heads/master@{#313737}

Review URL: https://codereview.chromium.org/886483005

Cr-Commit-Position: refs/heads/master@{#313736}

Instead of logging full exception we log only message.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/889453006

Cr-Commit-Position: refs/heads/master@{#313735}

-[TabView drawRect:] was called repeatedly to unnecessarily update the glow
that is not changing or should not have changed.

1. Selected tabs don't have glow, so don't redraw on mouseMoved.

2. When dragging an unselected tab, the mouse point relative to the tab view
does not change, so no need to redraw the glow.

3. When a dragged unselected tab slides behind another tab, let the dragged tab
keep the glow instead of the tab in front of it (this is a behavior change).
I think this is the more correct behavior, and we never have to redraw tabs
while dragging.

BUG=452925

Review URL: https://codereview.chromium.org/882193003

Cr-Commit-Position: refs/heads/master@{#313734}

When removing copy requests from a LayerImpl to fulfill the request,
this changes the RenderSurfaceLayerList that CalculateDrawProperties
would output. In particular, the layer would no longer keep itself as a
render target.

Since we fail to do this, the layer becomes !HasCopyRequest(), but keeps
itself as a target in the RenderSurfaceLayerList. Then when we go to
draw again (due to an animation or the like?) we skip appending the
layer's RenderPass since the subtree is hidden, but the layer is still
in the RenderSurfaceLayerList because we didn't recompute draw properties
and the layer copy request was keeping the hidden layer in the list.

This cognitive dissonance causes us to use a null RenderPass as
the target_render_pass in CalculateRenderPasses, which causes a crash as
soon as the (hidden) layer tries to append quads to the null surface.

R=vmpstr, weiliangc@chromium.org
BUG=439649

Review URL: https://codereview.chromium.org/883123003

Cr-Commit-Position: refs/heads/master@{#313733}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7f8106..e9d57a2

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/891473003

Cr-Commit-Position: refs/heads/master@{#313732}

Move the "is popup showing" logic to the platform-agnostic
ExtensionActionViewController. This lets us:
- Have a slimmer platform delegate.
- Implement OnPopupShown/Closed pressed-state logic on mac.
- Add cross-platform popup browsertests.

BUG=429810
BUG=422381

TBR=sky@chromium.org (micro changes to page_action_image_view)

Review URL: https://codereview.chromium.org/869873008

Cr-Commit-Position: refs/heads/master@{#313731}

Since the toolbar frame now includes the proper padding,
icons are a little too eager to show after adjusting the
chevron.  Make them a bit more shy again (hide them if they
have >= 3px not displayed when adjusting the toolbar).

BUG=452475

Review URL: https://codereview.chromium.org/881573004

Cr-Commit-Position: refs/heads/master@{#313730}

Update HTMLViewer for de-clienting of Shell.

Update ServiceRegistryTest.java for de-clienting of MathCalculator.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/883843002

Cr-Commit-Position: refs/heads/master@{#313729}

This removes CrMallocErrorBreak, since in 64-bit mode, Libc's malloc already
makes this case fatal.

BUG=453141
R=mark@chromium.org

Review URL: https://codereview.chromium.org/889583003

Cr-Commit-Position: refs/heads/master@{#313728}

BUG=433787

Review URL: https://codereview.chromium.org/869073003

Cr-Commit-Position: refs/heads/master@{#313727}

Chrome OS needs a dependency on //components/onc

BUG=453451
TEST=compiles
NOTRY=true

Review URL: https://codereview.chromium.org/880393004

Cr-Commit-Position: refs/heads/master@{#313726}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/402448d..5d8388b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890533003

Cr-Commit-Position: refs/heads/master@{#313725}

Cache extension action icons so that they don't have to be
reloaded each time a new view is created (i.e., each time a
new browser or the new overflow menu is opened).

BUG=452958

Review URL: https://codereview.chromium.org/885443004

Cr-Commit-Position: refs/heads/master@{#313724}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce78944..c7f8106

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/885893002

Cr-Commit-Position: refs/heads/master@{#313723}

https://codereview.chromium.org/845663002

BUG=446216

Committed: https://crrev.com/217066c608ea473d2ac70e737c69ff11a0425d44
Cr-Commit-Position: refs/heads/master@{#313248}

Review URL: https://codereview.chromium.org/854203003

Cr-Commit-Position: refs/heads/master@{#313722}

BUG=

Review URL: https://codereview.chromium.org/880373003

Cr-Commit-Position: refs/heads/master@{#313721}

The initial addition to content/browser was needlessly broad.

Review URL: https://codereview.chromium.org/869873006

Cr-Commit-Position: refs/heads/master@{#313720}

R=henrika@chromium.org
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/884873005

Cr-Commit-Position: refs/heads/master@{#313719}

WebRTC 8176:8207
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..1a48d11

Libjingle 8174:8202
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43

This rolls in a revert of a breaking change in Chromium.

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/880553005

Cr-Commit-Position: refs/heads/master@{#313718}

Update the DeviceStatusCollector to no longer report network state. We will
re-enable this for M42 once we've added code to detect an auto-launched kiosk
session.

BUG=452968

Review URL: https://codereview.chromium.org/885853002

Cr-Commit-Position: refs/heads/master@{#313717}

R=asvitkine@chromium.org, vogelheim@chromium.org
BUG=chromium:399580

Review URL: https://codereview.chromium.org/886463009

Cr-Commit-Position: refs/heads/master@{#313716}

This is required for further refactoring (use in symbolize.py), as nm
doesn't provide the section name.

Also, some functions in symbol_extractor.py are not
used yet, they will in the next CLs of the refactoring.

BUG=452879

Review URL: https://codereview.chromium.org/886563002

Cr-Commit-Position: refs/heads/master@{#313715}

Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202 (patchset #2 id:20001 of https://codereview.chromium.org/885003003/)

Reason for revert:
Appears to have broken Mac browser tests:

 - WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams
 - WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs

[75316:29699:0129/074049:FATAL:overuse_frame_detector.cc(388)] Check failed: processing_thread_.CalledOnValidThread().
0   libbase.dylib                       0x0000000119eaf88f base::debug::StackTrace::StackTrace() + 47
1   libbase.dylib                       0x0000000119eaf8e3 base::debug::StackTrace::StackTrace() + 35
2   libbase.dylib                       0x0000000119f09076 logging::LogMessage::~LogMessage() + 70
3   libbase.dylib                       0x0000000119f080c3 logging::LogMessage::~LogMessage() + 35
4   libcontent.dylib                    0x000000012ce82cd5 webrtc::OveruseFrameDetector::TimeUntilNextProcess() + 245
5   libcontent.dylib                    0x000000012c8dfdfd webrtc::ProcessThreadImpl::Process() + 525
6   libcontent.dylib                    0x000000012c8df836 webrtc::ProcessThreadImpl::Run(void*) + 38
7   libcontent.dylib                    0x000000012c6ce390 webrtc::ThreadPosix::Run() + 288
8   libcontent.dylib                    0x000000012c6ce076 webrtc::StartThread(void*) + 38
9   libsystem_pthread.dylib             0x00007fff8fe5f899 _pthread_body + 138
10  libsystem_pthread.dylib             0x00007fff8fe5f72a _pthread_struct_init + 0
11  libsystem_pthread.dylib             0x00007fff8fe63fc9 thread_start + 13

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/2438

Original issue's description:
> Roll WebRTC 8176:8203, Libjingle 8174:8202
>
> WebRTC 8176:8203
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261
>
> Libjingle 8174:8202
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43
>
> TBR=kjellander@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8aa707b5aa26cead2ab4791672163337c92f904b

TBR=kjellander@chromium.org,tommi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/888593002

Cr-Commit-Position: refs/heads/master@{#313714}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9cc2f26..402448d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890563002

Cr-Commit-Position: refs/heads/master@{#313713}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/15e603d..ce78944

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/887663003

Cr-Commit-Position: refs/heads/master@{#313712}

Fixes indentation bug in test runner and switches from using os to
subprocesses.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/884403002

Cr-Commit-Position: refs/heads/master@{#313711}

This is fixing of crashes in libsecret when some of fields from keyring result are absent.

BUG=453218

Review URL: https://codereview.chromium.org/891463002

Cr-Commit-Position: refs/heads/master@{#313710}

If the profile is NULL, the code will hit the CHECK on line 389 anyway.

BUG=414332

Review URL: https://codereview.chromium.org/878143003

Cr-Commit-Position: refs/heads/master@{#313709}

This cl reland Queue commands to the Os to start a video device, originally reviewed in https://codereview.chromium.org/801363002. (patchset 1)
In patchset 2, the issue found in crbug/450382 related to patchset(1) is addressed. |Device| is made into a class and thread checks are added.

BUG=428891,450382,450226

Review URL: https://codereview.chromium.org/862063002

Cr-Commit-Position: refs/heads/master@{#313708}