- 05 Sep, 2019 40 commits
-
-
Gabriel Charette authored
Backport some tests in /media/mojo/services/mojo_audio_output_stream_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/mojo/services/mojo_audio_output_stream_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 891670 Change-Id: I8b0eab2befd64fcaa60ee99ae87db72ec3999839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787238 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693602}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/history/core/browser/sync. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 891670 Change-Id: Iaed82e0b74753a9834462a9a53a6387ffee8c26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786829 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693601}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/sync_bookmarks. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 891670 Change-Id: I1fc5c7a8be02b3cb9b2a722214478cf848491ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786685 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693600}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/reading_list. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 891670 Change-Id: I58149904a141233c2efa5b1b0c001ae3d64355d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786965 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693599}
-
Olga Sharonova authored
This reverts commit ae084e61. Reason for revert: chromium build failure https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/3414 Original change's description: > Update V8 to version 7.8.283. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/681aa450..9ddd0c4c > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I5efb235167c182e0425b29399372f0f14883e2b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786898 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#693524} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I71e75ae25f1f4d03b60b843a45f17bec2c151ef3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787597 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693598}
-
arthursonzogni authored
Document initiated naivgation in a document with a "freeze" handler are immediately evicted. This CL adds a regression test for this. Bug: 1000324 Change-Id: Ibbf620734c111c3e34d5dea930d5df46b8a3db34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783156Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693597}
-
Kenichi Ishibashi authored
crrev.com/c/1786523 added "blink.worker" category and we want to record the category for service worker background tracing. Currently there is only one trace event with no argument and the trace event doesn't contain privacy-sensitive information (just record time spent initializng worker context). Bug: 561209 Change-Id: I98c08aca5117a01e07f458edbcd368e4ff4f1544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787028Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693596}
-
Adam Rice authored
Configure an origin trial for WebSocketStream and add a web_test to verify that it works. BUG=983030 Change-Id: I47cef959acbf488e4e1c73380bf9c4064041ae31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787030Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#693595}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/variations. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 891670 Change-Id: I0c2b85203a26dd11fcef82eafcee333094ad4acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786779 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693594}
-
Gauthier Ambard authored
When the BrowserCoordinator is clearing the presented state, the coordinators which might be presenting a ViewController should be dismissed. This is a first CL doing it for the ReadingListCoordinator. Bug: 988909 Change-Id: I912db5c5e19734ea88423159de159938154c3034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768324Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#693593}
-
Jan Wilken Dörrie authored
The check for the minimum Google Play Services version is no longer necessary, since the minimum version Chrome requires to run at all already supports launching the Password Checkup. Bug: 986317 Change-Id: I52e0b75cad8626a88f83b41229ce545ca4c4085b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784724 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#693592}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/45238d775a23..3bcb567d8f69 git log 45238d775a23..3bcb567d8f69 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 rharrison@chromium.org Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@3bcb567d8f69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1242a6b06e62d0f4e3124e20395888fbe4c36c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693591}
-
Satoshi Niwa authored
See b/140361966 for why we need this. Bug: b/140361966 Test: call the API from tast Change-Id: I8764d43c62c74339b98e7b4c11d97b6b77ce8319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781907 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693590}
-
Fredrik Söderquist authored
When sampling/adding instance times from within the animation engine we want to use SMILTimeContainer::CurrentDocumentTime() rather than SMILTimeContainer::Elapsed(). However the latter should still be used for all event bases and similar. Since most users of SVGSMILElement::Elapsed() still fall into the "event base" category, restore it to its original guise and open-code usage of CurrentDocumentTime() where it's needed. Bug: 1000290 Change-Id: Ie91ae8d5c9c63d03476ba11921777d064b264066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783153Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#693589}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/ozone/platform/wayland. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msisov@igalia.com Bug: 891670 Change-Id: I46bd656689e789f2d2a95b72b1086277ea368209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786964 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#693588}
-
Maciej Pawlowski authored
Since we don't want to modify Firefox's profile data and sql::Database opens files in SQLITE_OPEN_READWRITE mode, copy the source files to a temporary directory and work on copies. Bug: 1000182 Change-Id: I1350d5c967912ca9c9cb424081fa3b2db4c033aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781592Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#693587}
-
Findit authored
This reverts commit 581b273e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 693539 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4MWIyNzNlMzc0M2ZjYmQxNjg3NzVlZGZlZWJhZThiMDkyZmM3MDYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/7906 Sample Failed Step: compile Original change's description: > [webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm > > This CL implements strictly the "Creating Web NFC message" algorithm > described at http://w3c.github.io/web-nfc/#creating-web-nfc-message. > > 1. > Changes the Web IDL definition for NDEFRecordData from > "typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;" > to > "typedef any NDEFRecordData;" > > 2. > Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes > NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit. > Also, the same thing for NDEFMessage and NFCReadingEvent. > > 3. > Changes code flow for Step 10.9 of "9.10.1 The push() method" described > at https://w3c.github.io/web-nfc/#the-push-method. > " > Let output be the notation for the NDEF message to be created by UA, as > the result of passing message to create Web NFC message. If this throws > an exception, reject p with that exception and abort these steps. > " > Previously, > NDEFMessageSource (NDEFMessageInit) -Validity check-> > -Mojo TypeConverter-> Mojom NDEFMessagePtr > Now, > Remove "Validity check" and "Mojo TypeConverter" mentioned above, > instead, we reuse the process of creating NDEFMessage from > NDEFMessageSource (NDEFMessageInit), then the next step converting > NDEFMessage to Mojom NDEFMessagePtr is quite an easy job. > > BUG=520391 > > Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719 > Commit-Queue: Leon Han <leon.han@intel.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> > Cr-Commit-Position: refs/heads/master@{#693539} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=520391 Change-Id: I29fbd5f35999f41bfd1bc776c3c375bf3e6245f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787234 Cr-Commit-Position: refs/heads/master@{#693586}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cf0e2fe12289..4d838a8c279f git log cf0e2fe12289..4d838a8c279f --date=short --no-merges --format='%ad %ae %s' 2019-09-05 chrisforbes@google.com Replace sinh,cosh with implementations in terms of Exp() Created with: gclient setdep -r src/third_party/swiftshader@4d838a8c279f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140501860 Change-Id: I2b0ba77d4bd1a2e6aa4f3c7679baf2f3494737e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693585}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/android/digital_asset_links. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=lizeb@chromium.org Bug: 891670 Change-Id: Iee9e0436437c114e5d4fdc270f7f1851818e14fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787206 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693584}
-
Yuta Kasai authored
This CL simplifies the test with modern utilities like async/await and t.add_cleanup(). This just refactors the test, and doesn't change test behavior. Bug: 678905 Change-Id: I836411a7a3fa16b825de29630ec01d4ea42a1586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784264 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#693583}
-
Kent Tamura authored
This CL removes base/allocator/partition_allocator/*.h dependency from wtf/allocator/partitions.h, which is included by wtf/allocator/allocator.h. This reduces the estimated pre-processed size of wtf/allocator/allocator.h by 460KB. wtf/allocator/allocator.h is included in almost all compilation units in Blink. * Partitions class holds PartitionRoot* pointers instead of PartitionAllocators * Stop inline definitions of the following functions: - TotalSizeOfCommittedPages() - BufferMalloc() - BufferTryRealloc() - BufferFree() - BufferActualSize() - FastMalloc() - FastZeroedMalloc() - FastFree() Their implementations need complete definition of base::PartitionRoot* * Remove unused functions; BufferRealloc(), FastMallocFlags(), and FastRealloc() Bug: 242216 Change-Id: I17b8b155f4c2deb778047e33b1462b7c1ae51e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784242Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#693582}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia27a5c5aa40f5c3fd3ee50c298f8836d8d0fe821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693581}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/bluetooth. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dougt@chromium.org Bug: 891670 Change-Id: I709fd4da61b4c13ef06e658a6a6f438742738937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786682 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#693580}
-
Mohamed Amir Yosef authored
This is in preparation for introducing MultiStoreFormFetcher which will require different logic for computing BestMatches. Change-Id: I66842f4a1cfce2a304a946164482c6e4de3076b8 Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774629Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#693579}
-
Lutz Justen authored
Leaving team, confidently passing the torch to my former team members. Keeping ownership of Kerberos until Felipe and Tom have committer status. BUG=None TEST=None Change-Id: I8432b595ddadc14f3b1a920fde49cadaa30d01af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781585Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#693578}
-
David Staessens authored
This CL removes an outdated comment from the VaapiVideoDecoder. The comment refers to the presence of a VaapiPicture, which has been removed in crrev.com/c/1672081. TEST=None BUG=None Change-Id: I08e4f93fc2687c1b11c58ce0249516db21dc9c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774014 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693577}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/policy. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsorokin@chromium.org Bug: 891670 Change-Id: I6f05a0c6d1a0b99d6ebf65f7022e7b8641090545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786984 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693576}
-
Jan Krcal authored
This CL adds a UMA metric reporting which data types contribute to a sync commit message. The CL also extends expiration for another analogous histogram so that they expire at the same time and we can decide about their future at once. Bug: 998501 Change-Id: I65a2f633df1ab3e0c75bfa13bd88ce1395520fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781149Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693575}
-
Nicolas Ouellet-payeur authored
Change-Id: Ib3fb05fce30550aa2805a0f4bf0dc3db187247e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784859 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#693574}
-
Kenichi Ishibashi authored
WorkerReportingProxy has DidInitializeWorkerContext() just to record this trace event. Since the time spent initializing worker context is generally useful, move the trace event into WorkerThread. A new trace category is added too. This is a follow-up CL of crrev.com/c/1775856 Bug: N/A Change-Id: I97196b76af62a53fee60208512c3b0afabe62700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786523Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693573}
-
Olga Sharonova authored
This reverts commit 18662d71. Reason for revert: broke the tree https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/7906 Original change's description: > [mojo] Simplify BrowserInterfaceBrokerProxy usage > > This change makes the following updates: > - ExecutionContext::GetBrowserInterfaceBrokerProxy() is renamed to > GetBrowserInterfaceBroker() and returns a reference to avoid null checks; > - Overrides in WebLocalFrameClient, EmptyLocalFrameClient, WorkletGlobalScope and > NullExecutionContext now return an 'empty' broker that is valid but not > connected to anything (so remote calls are no-ops). > > Also updates existing call sites. > > Bug: 718652, 997861 > Change-Id: I84ec0e254fe4b094379459501e155cb3f74da945 > > TBR=staphany@chromium.org > > Change-Id: I84ec0e254fe4b094379459501e155cb3f74da945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775374 > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Staphany Park <staphany@chromium.org> > Reviewed-by: Ayu Ishii <ayui@chromium.org> > Reviewed-by: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693550} TBR=dmazzoni@chromium.org,dcheng@chromium.org,jam@chromium.org,mek@chromium.org,nhiroki@chromium.org,rtoy@chromium.org,oksamyt@chromium.org,staphany@chromium.org,ayui@chromium.org Change-Id: Ib569be17b6c78f4284d7155152d35dd5aa4063d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 718652, 997861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787497Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693572}
-
Olga Sharonova authored
This reverts commit 9f7c76d0. Reason for revert: AddSupervisionBrowserTest.ShowConfirmSignoutDialog AddSupervisionBrowserTest.URLParameters failing on Linux ChromiumOS MSan Tests, see https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/15000 Original change's description: > Automated tests for Add Supervision flow ChromeOS code > > This required modifying the classes under test, including > AddSupervisionHandler, AddSupervisionUI, and ConfirmSignoutDialog > to allow them to be tested. > > Bug:982543 > > Change-Id: I3bebada137fe57a63ca090c788fa5a0cb317d22b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771387 > Commit-Queue: Danan S <danan@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693320} TBR=michaelpg@chromium.org,danan@chromium.org Change-Id: Ibe6189ed52f32afb62cdfabbf890857e474de6ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787417Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693571}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/capture/video/linux. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=shik@chromium.org Bug: 891670 Change-Id: I8757c9c2fbc20030fe7eae92c49e943edd68958a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786943 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693570}
-
Miyoung Shin authored
This CL converts RouteProvider{AssociatedPtr, AssociatedRequest} in content to the new Mojo types, and introduces GetRemoteAssociatedInterface(mojo::AssociatedRemote<Interface>*) in ipc_channel_proxy.h Bug: 955171, 978694 Change-Id: Ifc8afca4b05a7f537780b3604893f3f5bf667eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784310Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#693569}
-
David Staessens authored
Added dstaessens@ to the VAAPI owners file. BUG=None Change-Id: Ie55a87eacb553c9f0639d4ce50b5766107d829e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782365Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#693568}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/pepper. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 891670 Change-Id: Idca41d5c4ee76f1c0fd4ccc135acf4dae0481378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787078 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#693567}
-
Gabriel Charette authored
Backport some tests in /chrome/browser/chromeos/extensions/file_manager to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/chromeos/extensions/file_manager. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=austinct@chromium.org Bug: 891670 Change-Id: I3ae02884f2409fe37a5467f6343ab1464fedb5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786900 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#693566}
-
Kai Hsien Boo authored
This CL adds an option to show real-time frame metadata on screen. The design doc is here: go/cca-expert-mode Bug: b:134636934 Test: tast run DUT camera.CCAUIExpert camera.CCAUISettings Change-Id: Ie080cbd2f1c1d1c06adfbcab423448b155deb05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716022 Commit-Queue: Boo Kai Hsien <kaihsien@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693565}
-
Jinsuk Kim authored
The icon for 'show full history' is fetched from the favicon service which returns the resource for desktop. This CL replaces it with the mobile resource of higher dpi. Bug: 999379 Change-Id: I9f3855f16b3a226ff68a7a56c33ac9cde57ea403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782361 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#693564}
-
Hiroshige Hayashizaki authored
- Most of the tests are consuming 1~2 seconds. - img-tag tests are consuming 3~5 seconds but will be splitted into subtests after [1], so timeout might be fixed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548 Bug: 626703, 982148, 982149, 988890 Change-Id: I72ff81ff5d9fcf663d143491b186abc673bdf490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784133Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#693563}
-