- 16 Dec, 2020 40 commits
-
-
Nancy Wang authored
This is the preparing for the full restore file reading function. Add the construct function for RestoreData to convert the JSON format to the RestoreData. Add the unit tests to verify the convert function: RestoreData -> base::Value -> RestoreData. BUG=1146900 Change-Id: I54133e83e9b7abce62c5812cc5e87941e770f958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591987Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837465}
-
Morten Stenshorne authored
Turns out we can actually just walk down the fragment tree and get this right, now that relative positioning is baked into the offsets. We need to disable some workaround code in NGOutOfFlowLayoutPart, however. That code compensated for the discrepancy between how NG layout works and how NG pre-painting works. This discrepancy doesn't exist when LayoutNGFragmentTraversal is enabled. This simplifies code for NG fragment traversal considerably in FragmentPaintPropertyTreeBuilder::UpdatePaintOffset() (to basically a one-liner), and we can back out the laxness added to some past DCHECKs, since this code path is now only run for non-fragment-traversal. We can also stop using the separate absolute_position and fixed_position contexts. The fragment tree structure should match perfectly with the containing block structure. We should also stop using container_for_absolute_position and container_for_fixed_position in LayoutNGFragmentTraversal. Added TODO. Bug: 1043787 Change-Id: I548fe9537b352ea2b0d5fdeb2d6c3eeed9f30a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593110Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837464}
-
Jason Lin authored
When camera privacy switch is on, even if a vm is accessing the camera, the camera is considered inactive since the vm can only get black frames. Bug: b/167491603 Change-Id: I159501040da557661a17d61a1fed4499c74d6907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593795 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837463}
-
Alan Cutter authored
The install path used by offline manifest installation was not updating the WebApplicationInfo according to the InstallParams passed in. This CL fixes that by putting the user_display_mode setting application in the shared ApplyParamsToWebApplicationInfo() helper function that every install path should be using. Bug: 1159306 Change-Id: Ib632621ac3178dd84bbcd805cffe89e438b8572e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593799 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#837462}
-
Bao-Duy Tran authored
Extension-based Input Method Framework (IMF) of Chrome OS and Chromium OS for both 1P and 3P has never supported multiple XKB layouts per input method. Likely this is by design, and has been the case for almost 10 years, presumably ever since the migration to extension-based IMF. As of now, each input method ubiquitously implies one and only one XKB physical keyboard layout, throughout IMF and CrOS. The notion also extends to virtual keyboard and other input modalities, given "input method" is really a suite of inputs-related functionalities in CrOS. Also, certain CrOS components rely on this implication, too. This CL removes all anticipative "plural layouts" that's always been unused. Their existence is misleading and illusive; they'd better be gone in the spirit of YAGNI "you aren't gonna need it". For 3P backward compat, unfortunately "plural layouts" need to be kept in the manifest. NOTE: It doesn't quite make sense to arbitrarily fit "multiple layouts per input method" paradigm into IMF in its current form. It'd require major re-design and overhaul of IMF to do so, and probably also need to consider how extension-based input methods would interact with the new paradigm, and whether 1P ones support such paradigm. A discussion [1] took place 4 years ago to support "multi-layouts per input method", given "the manifest allows a list of XKB layout IDs". It was also when "plural layouts" impls were added [2] but ended up being unused while confusing readers and adding clunkiness ever since. Outcome of the discussion aligns with the points above that IMF in its current form and many 1P IMEs aren't at all ready for "multiple layouts per input methods". The solution back then was an ad-hoc private JS API for specific 1P input methods [3], rather than a generic IMF solution. [1] https://crbug.com/170601 [2] https://chromiumcodereview.appspot.com/13949015 [3] https://codereview.chromium.org/1656083003 Bug: 1134465 Change-Id: Iad6dc717b859748cf58f77a4a1bb3b20212c2c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554280 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#837461}
-
Clark DuVall authored
Defining providers in the base module can improve startup performance by giving the chrome split more time to preload. Now that all providers have been moved to the base module, this CL adds a check to make sure we don't accidentally add any in another module. Bug: 1150600 Change-Id: Ifd49034cbf7f1fce1ad2dd7d562b520e0876e93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591725Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837460}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b528247a5a9e..d224369988e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1154371 Tbr: aboxhall@google.com Change-Id: I56599520baa1f6a3d659118d4880ea7cfc0e982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593601Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837459}
-
Nektarios Paisios authored
When an AXTree of Views is added to the existing forest of accessibility trees, and when AXPosition starts being used more on Chrome OS, we'll need a way to determine if a particular node is at the root of a window-like container, in order to be able to easily jump to its beginning or its end. Window-like containers include webpages, PDFs, browser windows, the App List, and the whole desktop. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ic0d0d36d9aba80e50b171d82e8fc97215a4b1694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575259 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#837458}
-
Zach Trudo authored
Within RecordHandlerImpl::HandleSuccessfulUpload there was unguarded access to a base::Optional member. Bug: chromium:1158638 Change-Id: I57d160c15b0d4b2609772e7f792a2df67151a369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592142 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837457}
-
Tarun Bansal authored
This CL deletes some parts of the resource loading hints preview code. More deletion will come in subsequent CL. Change-Id: I9aa76f6c1db8ba691c7366b5dcdd75895419240c Bug: 1159182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578697 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837456}
-
k.mishra authored
This patch removes data member |mSurfaceCallback| from ContentViewRenderView which is not being used at class level. Bug: None Change-Id: Ib7d55dc13cb767df11cbfaf7c7942edecaa1709d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522794Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#837455}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6661897486a..f600415e9265 2020-12-16 dberris@chromium.org sheriff-config: Support serving anomaly configs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: Ie46bfefce1a2eccd9d772a4717a018cb4d9e7500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837454}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fa506cee933..b528247a5a9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com,btolsch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150600 Tbr: aboxhall@google.com,btolsch@google.com Change-Id: Ie96ce47e9ae6ff53a1d46ecbb05d797be05daabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594125Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837453}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b35ae002390e..fea4c14580b1 2020-12-15 rharrison@chromium.org Fix missing include that causes Skia builds to fail If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I046f7a1bbd48e0c05e9506affcd9f49d1d5718cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593926Reviewed-by:
-
Nicholas Hollingum authored
The InstanceRegistry is the new/preferred way for application providers like borealis to observe their apps' windows. When using the instanceregistry, we also avoid the (potential) pitfall due to us performing all of our window registration in a method called "GetShelfAppId". Bug: b/175152663 Change-Id: I1f7893428d76edc507e6841ebd94ffbb68024867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586445 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837451}
-
David authored
This lets the Chromium PDF viewer get it's ink resources from chormeos/componeonts/media_app_ui/resources/prod/lib/ink which is built internally and shipped into CrOS as part of the media app. The resources themselves are bundled via grit in chromeos_media_app_bundle_resources.h. In doing so we add the BUILD flag enable_use_media_app_ink: * if true, don't build third_party/ink and thus don't create gen/third_party/ink/ink_resources.pak, instead get resources from gen/chromeos/chromeos_media_app_bundle_resources.pak * if false, do what TOT currently does and build third_party/ink This allows us to only ever build 1 set of ink resources into the Chrome OS binary and avoid bloating the OS by ~ +2.4MB. See size increase in http://b/170161460#comment18 for more context. This change also updates the externs of the ink library which works with new ink resources and also the older ink resources (third_party/ink/build) checked into TOT. Regression tested with various builds of TOT, new ink resources & TOT and new ink resources & this cl for the resource plumbing (grd, flags etc) see regression testing in http://b/170161460#comment18 for more context. Note: * currently enable_use_media_app_ink is just = enable_cros_media_app but that might change. * linux-chromeos-chrome trybot will fail until http://cl/347557653 lands and rolls into chromium. There is some time between http://cl/347557653 rolling in and this cl landing which may mean the OS is bloated with 2 copies of ink resources but this should be ok as long as this is done before branch and in reality they will land in O(day) time. Bug: b/170161460, 1150244 Change-Id: I8e01ce9863dd00bcbab7b322ad3cf33c1424ec6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542926Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#837450}
-
Findit authored
This reverts commit aa51435c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837244 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FhNTE0MzVjM2I0MWJkYjk3ZjY5ZmFhYzNmNjE0NDc4MGYyN2U2MWIM Sample Failed Build: https://ci.chromium.org/b/8860789670201602304 Sample Failed Step: unit_tests Original change's description: > Fix the AppWindowLauncherItemController::GetAppWindow crash issue. > > This CL is the 3rd option to resolve the crash of below call stack: > AppWindowLauncherItemController::GetAppWindow(aura::Window*, bool) > AppWindowLauncherItemController::SetActiveWindow(aura::Window*) > AppWindowLauncherController::OnWindowActivated() > > One possible guessing is the AppWindowLauncherItemController object has > been deleted, but still used by AppServiceAppWindowLauncherController. > So modify the destruct function, and set the controller as null in > AppWindowBase. > > BUG=1128491 > > Change-Id: Ied59f857653aa0a136cbe9f903ff79ce5856e34c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586647 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837244} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1128491 Change-Id: Ia518fe2f01bbb128758982250405ffd470008c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594556 Cr-Commit-Position: refs/heads/master@{#837449}
-
Michael Kolomeytsev authored
The test checks window activity which in turn depends on a focus given by OS windowing system. Being run in parallel with other tests it looses the focus very quickly. So the test should be moved to interactive_ui_tests. Bug: 1080602 Change-Id: I39cd0afb41f2841fda467ee1ae89e3ff0dd083bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593370 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Nidhi Jaju authored
This CL changes the status of the ReadableByteStream runtime enabled feature from "experimental" to "stable", so that it is turned on by default. See the Intent To Ship thread at: https://groups.google.com/a/chromium.org/g/blink-dev/c/AQip4hjqt5U/m/OwPgs9NmAgAJ Bug: 614302 Change-Id: Ie224d280b471e3bc8925d188d8cdbc44a8d1240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586290Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#837447}
-
Eugene But authored
Bug: 688063 Change-Id: I427598e4cddad41f3f3628db9507166a30615e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591819 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#837446}
-
Kelvin Jiang authored
DONE - remove feature flag DONE - update tests: some rule limit overrides/rule count constants in tests were changed, and tests for the old per-extension limit were deleted. DONE - enable documentation and enable on stable This CL also promotes the getAvailableStaticRuleCount API function to stable. Bug: 983299 No-Presubmit: True Change-Id: I742e66f2c633b4900ff92ed03bd4f234e95e0169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563238Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837445}
-
Francois Beaufort authored
This CL makes sure NFC operations are suspended if NFC host is created when web_contents is not visible. It also cancels a pending push operation when NFC operations are suspended as described in spec. https://w3c.github.io/web-nfc/#handling-visibility-change Bug: 1156805 Change-Id: I143302d292d904b6a25853cc1ecd4e52898efc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579791Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Gordon Seto authored
Show high visibility dialog when the high visibility button is toggled from the Nearby share subpage. This keeps the behavior consistent with when high visibility is toggled from the tray. Bug: 1154830 Change-Id: I17f6015706bca6f6b7ae85904c768e91923211e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590652 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837443}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f32fbb51e8a1..98b56e604256 2020-12-16 m.maiya@samsung.com Vulkan: Accumulate internal cache stats in renderer 2020-12-15 timvp@google.com Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9 2020-12-15 paulthomson@google.com Tests: update WhatsApp trace 2020-12-15 cclao@google.com Vulkan: Reduce driver uniform data to minimum if specConst is used 2020-12-15 m.maiya@samsung.com Add EXT_clip_cull_distance extension autogen code 2020-12-15 m.maiya@samsung.com Vulkan: Add support for internal cache hit and miss counts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: Manual verification with angle_end2end_testsTest: Test: angle_perftests --gtest_filter="*whatsapp*" Change-Id: Id6d8b649d72bc44003bb7918217c65b4cd17b55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593366Reviewed-by:
-
Hitoshi Yoshida authored
This CL does followings to fix compile errors with new IDL dictionaries - add or replace include files - update GN - fix the way to create a dictionary - fix to check if a member is non-null Bug: 839389 Change-Id: Ic68f2751c06c99204a80f0fa23235cee5d172653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593849 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#837441}
-
Nicholas Hollingum authored
This request came up in crrev.com/c/2586445. We commit the test now, in this cl, to show that the behaviour doesn't change across the refactoring. Bug: b/175152663 Change-Id: I42a20c358e324655fb66b4fb1ec61131b30eab7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584560Reviewed-by:
-
Ahmed Fakhry authored
See explanation on the bug. BUG=1159264 TEST=Tested with the new test case added in https://crrev.com/c/2553873 And observed no crashes. Change-Id: I3b2abe866dbab3ae9e9cb2547c1e48655ccac0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594322Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#837439}
-
Eugene But authored
Bug: 688063 Change-Id: I13f96d3308319fb59038b755273ed4757cce81a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591918 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837438}
-
Alan Cutter authored
Change-Id: I62ddf7f72a80fe99f89d7d71df16c4d497cfb0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592290 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Commit(1e7c2506) has added a presubmit warning to prevent further uses of old downcast helpers. All the occurrences of old downcast helpers are removed from the codebase and these changes are not needed now. Bug: 891908 Change-Id: I0090438d1f8c835b153ae2d6d177389891948991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592539Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I97d10c2b0bd9a0e8ebf6493cc4e26eea9cf47afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594569Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837435}
-
Ryan Keane authored
This CL updates the CastAudioChannelBroker interface to allow for Audio-Audio sync changes to come later without breaking downstream repos that have implementations of this interface. Bug: b/171495618 Change-Id: I5099ee8bf272192c385763148da32d0636b48050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594168 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837434}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/664301800ba2..d6661897486a 2020-12-16 fancl@chromium.org auto-triage: Rebalance and rerun Estimator in anomaly range If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I327a0953062d524d76feecfe14b5a5e1145ed8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594000Reviewed-by:
-
adamta authored
Uses new feed initializer with custom scroll delegate. Reorders component creation in NewTabPageCoordinator so that delegates can be passed appropriately. Renamed DiscoverFeedViewController to DiscoverFeedWrapperViewController for clarity on what it does. Bug: 1114792 Change-Id: Iccdc7bf0efeda2252e0937d8665f1c33b09d9b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593471 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#837432}
-
alanlxl authored
Keep them around until Jan 2021. Bug: 1067048, 937063 Change-Id: Iead89a8a5e21c216dce6b9f37df2b0d98fa487d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592071 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837431}
-
Darren Shen authored
[1] broke virtual keyboard PK simulation in some cases, because the VK was sending VKEY_UNKNOWN as the key_code. Previously, when key_code is VKEY_UNKNOWN, the key_code was inferred from the `code`. However, after [1], we only inferred if the key_code was left out. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2566868 Bug: 1159250 Change-Id: Ied31078e213fe9bc2f5129057d1e1d34e41e2779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592074Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I06764cde4f39d22929099b86f6bab6e6adb390e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592141Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837429}
-
Azeem Arshad authored
This CL fixes two styling issues with the receive confirmation dialog. 1) spacing between progress icon and dashed line 2) Fix outside margin for confirmation page contents. Before Screenshot: https://screenshot.googleplex.com/4vDbAT4uWSdZsZJ.png After Screenshot: https://screenshot.googleplex.com/rjHhgLqBRozaYKa.png Fixed: 1156037 Change-Id: I034605dca9da7da016ad8da091e9c3c1ece16dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593426Reviewed-by:
-
Gary Tong authored
Bumping up to 25% Capacity looks good so far: http://shortn/_0ICs5GbtYR Bug: 1042757 Change-Id: I9ce89c7f8f1c0034660ab64dd58299ffe0d3e80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593596 Auto-Submit: Gary Tong <gatong@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#837427}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_20201215_RC00_ink_swa.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/dvLFoYsVHl4TxGr16CGZ27chK2r007z5LZvhTmtAuIsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Id404bc61300b594e50d0080a077a4819314f4d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594548Reviewed-by:
-
