- 22 May, 2019 40 commits
-
-
rbpotter authored
Like the controls in the sidebar, the custom margins controls should be disabled if the Print Preview is not ready, there is a validation error on the page, etc. Bug: 940386 Change-Id: I2d92c3c13835626b04288c805273ffbcfc3d364b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618641Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662040}
-
Kenichi Ishibashi authored
This CL moves logic to top-level script execution from ServiceWorkerGlobalScope to WorkerGlobalScope so that we can use the same logic among other WorkerGlobalScopes. We will use this functionality to avoid a race condition which could happen when off-the-main-thread shared worker script fetch is enabled. Change-Id: Ib34373fe7864189da5ba4c00d19db2c027ce36cc Bug: 945673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616863 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662039}
-
Vladislav Kaznacheev authored
Some decisions regarding shelf visibility are made based on the current mouse position. It leads to counter-intuitive behavior when mouse events are followed by touch and the cursor is hidden (see bug). Bug: 963977 Test: modified ShelfLayoutManagerTest.AutoHide Change-Id: I82e269db0df0429e73270e28c5f431ffc6f0ca7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623136Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#662038}
-
Donna Wu authored
Whe GetDevices() is the first method call to be made, we should also need to make sure the connection with the DeviceService. Bug: 699790 Change-Id: Ie5d6b8f606fafba7372bffcfffc4d3e13e2f3603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617201 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ba8b68b..90984359 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibeef6c9eeb88ff00dc223c76464a0d89b979a047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662036}
-
Oystein Eftevaag authored
This is what the old crash-based uploader enforced and is a good starting point for the Perfetto-based ringbuffer size as well. R=ssid@chromium.org Change-Id: I05685589d94583434c59f690620af84e314ee313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623492 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#662035}
-
Kinuko Yasuda authored
I think it's just got mixed up but your cross-checking is appreciated. Bug: N/A Change-Id: I88ee161bdadcf732a01082906d87848fd52a90df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621789Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662034}
-
John Budorick authored
Necessary for running arm builds on devices that support aarch64 and arm. Bug: 861509 Change-Id: I87bd1bdae3def36d35313436a7c6f2423532be25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622715 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662033}
-
Eric Willigers authored
OffscreenCanvas shipped in M69. https://chromestatus.com/features/5681560598609920 The flags OffscreenCanvas and OffscreenCanvasText have been stable since https://chromium-review.googlesource.com/1119156 Bug: 563816 Change-Id: Ie212e1c83f0c366ca6a63a34b842481eb9566845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616930 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662032}
-
Yeol Park authored
In order to better convey property object ownership, changed MdTextButton::Create() to return std::unique_ptr. Bug: 948287 Change-Id: Ib48fdaff3e647d0178b46871f0ebbb8fe53075a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612799Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#662031}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I416734d443ad3aa0f99b1df92427166f647d5445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623562 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#662030}
-
Jordy Greenblatt authored
The crbug.com/945632 pointed out that the MultiDevice setup OOBE UI showed an unfortunate behavior in other languages: only one string on the page translated [1]. It turned out there were a few different problems masking one another. First, the start-setup-page element did not bind its translations to I18nBehavior.locale, which is the standard mechanism for passing location data in OOBE. Once that was fixed, it became clear that the OOBE screen 'MultiDeviceSetupScreen' was not notifying any Multidevice Polymer elements of locale updates so the I18nBehavior.locale bindings were not receiving updates. Also, because the buttons and headings were translated in ui_page_container_behavior.js, those translations had to be bound to I18nBehavior.locale separately. I also moved those translations to more visible locations and used the literal string IDs instead of factoring out the string IDs and computing the translations in the UiPageContainerBehavior in an effort to make the data flow more transparent. The next big issue was that the strings with placeholders were not registered appropriately in OOBE localization. This difference didn't become clear until the binding issue was resolved because there was no visible difference in the behavior of the placeholder strings and the other strings until that point. Also, because the registration infrastructure in OOBE uses a totally different API, the placeholder strings were translating correctly post OOBE, which added to the confusion. See multidevice_setup_localized_strings_provider.cc for the relevant change. After this change, the start-setup-page translates strings correctly in OOBE [2] (this is the only MultiDevice screen in the OOBE flow) and post-OOBE [3] along with the password-page [4] and setup-succeeded-page [5]. Once this change is merged into the current branch (i.e. the immediate fire is out), we can simplify multidevice_setup_localized_string_provider.cc by splitting up the strings with placeholders into regular strings and concatenatng them manually in HTML (see crbug.com/961841). [1] https://screenshot.googleplex.com/w2tWTTZJkvj [2] https://screenshot.googleplex.com/dGvFOTQozLH [3] https://screenshot.googleplex.com/9GuB8bwkqS4 [4] https://screenshot.googleplex.com/QGZc9aaEdtE [5] https://screenshot.googleplex.com/FCAWDNTTVn4 Bug: 945632 Change-Id: I141e925e70550b1e33b06aef25ed4f72a06d5988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591965 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#662029}
-
Joshua Peraza authored
By default the option consumes the next flag, which happens to be --native-libs=libcrashpad_handler.so for chrome modern bundle modules. Bug: 960534 Change-Id: I09c3df3c6433a85006c7143256cec2a51e14976e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622661 Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662028}
-
François Degros authored
Bug: 778674 Change-Id: Ic01d71c337c22a0f5b573e01d5525c3405aa8942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623647 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#662027}
-
Alexey Baskakov authored
This CrxInstaller code isn't reachable for bookmark apps: void CrxInstaller::CheckInstall() { // Skip the checks if the extension is a bookmark app. if (extension()->from_bookmark()) { ConfirmInstall(); return; } ... check_group_->Start( base::BindOnce(&CrxInstaller::OnInstallChecksComplete, this)); } Bug: 901226 Change-Id: Iae8c90a7c654bc330a1fc4e2b67807b9ec0e1171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621783Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#662026}
-
Alexey Baskakov authored
Reproduce same params as in bookmark_app_helper.cc See this CL/bug: https://chromium-review.googlesource.com/c/chromium/src/+/1322262 Bug: 901226, 882945 Change-Id: I015dccb6cdfd97f37e763dde0421108aa2b5fbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621785Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#662025}
-
François Degros authored
Bug: 778674 Change-Id: Ic8b5adacfe790a2572dfe8eae3286938b4861aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623726 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This was previously enabled on Android/Adreno and ChromeOS/Mali. The bug affects both Mali-T760 (Samsung Galaxy Note 5 SM-N920I) and Mali-G71 (Huawei P10 VTR-L29). Change-Id: Ie49a3eac5aa8cd185395a0fbbf058c949236781e Bug: 961950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623090Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#662023}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2f0485479008..176c657a6d07 git log 2f0485479008..176c657a6d07 --date=short --no-merges --format='%ad %ae %s' 2019-05-21 tsepez@chromium.org Explicitly check for null parent in CXFA_LayoutPageMgr::CreateViewRecord() Created with: gclient setdep -r src/third_party/pdfium@176c657a6d07 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Iee14efa68dfce23ea5d06f34a5bbb2033b323da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662022}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/851be4808e3f..b5e56574cb70 git log 851be4808e3f..b5e56574cb70 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 lamontjones@chromium.org portage_util.py: less verbose logging. Created with: gclient setdep -r src/third_party/chromite@b5e56574cb70 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I7de3c93c59da34e9b0e6f853ae6bcdf44517712d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622917Reviewed-by:
-
Kai Ninomiya authored
Bug: 965387 Change-Id: I748859108ba4aab13de33751682d80c5cb1cc582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621542Reviewed-by:
-
Erik Luo authored
Adds name-value pairs to SSP's autocomplete, based on CSSMetadata values. - Excludes colors, very-common values ('initial', 'inherit') - Suggestions starting with a hyphen '-' are sorted lower Bug: 931145 Change-Id: I477a5ff48402e78397bcaf506717cbf5c727e612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589076 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#662019}
-
Vlad Tsyrklevich authored
Change-Id: I1af3b4fa809870954b272be1c8c257411734c6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622754 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#662018}
-
Dale Curtis authored
Turns out I should have pulled the latest 28D data for 74 before limiting to !CrOS && !macOS. No regressions are shown in that data anymore, so enable eveywhere. This leaves the flag in for now until we reach stable. BUG=879406 TBR=liberato Change-Id: I48bd5440893ee2c74b8cc54d5575d0347b2b7e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623487Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662017}
-
Nicholas Hollingum authored
This work was originally done by davidriley@, and continued by me. We are intending to add a fuzzed for components/exo code. As a first step, we factor the environment out of the test itself, which will be used by fuzzer code in subsequent CLs. Originally I was going to maintain this branch until fuzzing work was more complete, but ongoing changes to the wayland code are making that troublesome. Bug: 961564 Change-Id: Ia64e079f3f0c2a7709c468d1137d94a8c82870bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605297 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2a7b631482d8..c0c7e2f85bce git log 2a7b631482d8..c0c7e2f85bce --date=short --no-merges --format='%ad %ae %s' 2019-05-22 jiawei.shao@intel.com Add workaround on using non-zero ResolveLevel or ResolveSlice on Metal Created with: gclient setdep -r src/third_party/dawn@c0c7e2f85bce The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I24ec3b07fae5e6aa2ad137c63b7657df206e8ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622916Reviewed-by:
-
Yuly Novikov authored
TBR=kbr Bug: 965730 Change-Id: Ic6acadfb8cadcd423578ccde479a5e97418eafa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622794Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Alex Leung authored
Flush() is propagated from AudioRendererImpl to AudioOutputStream and is used to signal that buffered data can be cleared. On Cast, we plan to buffer data in the AudioOutputSteam and we need an signal form the renderer to flush buffered data when seeking and changing tracks. Bug: b/124402185 Change-Id: Icca917cc8afa7a77419e06c562767d617df36bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604331 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
-
Jiajie Hu authored
This is an entry point defined by the GL_ARB_program_interface_query extension, so it probably makes sense to handle it in the same way as all other entry points covered by this extension. Bug: None Change-Id: I527847b9b173a3110da7e8b374a2e2c94456bc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621846Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aca5b6aca87d..c7e440c0091d git log aca5b6aca87d..c7e440c0091d --date=short --no-merges --format='%ad %ae %s' 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 agable@chromium.org Call new CheckJsonParses in PRESUBMIT Created with: gclient setdep -r src/third_party/depot_tools@c7e440c0091d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id64b9cfa43a9925311c0e0d32a40a1bab218316f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622635Reviewed-by:
-
François Degros authored
Change-Id: Ide11df69ef393bbf6e09f4790a147898cb8976b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623605 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Jun Mukai authored
TBR=tsepez@chromium.org Bug: 958209 Test: trybot Change-Id: Ie013d0356e442980d8216847a3c661445c8535a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617920 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662009}
-
Jun Mukai authored
TBR=sky@chromium.org Bug: 958467 Test: trybot Change-Id: If7d1dad89ce4914483039f1a22d7a5160570975c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623545Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#662008}
-
David Staessens authored
This CL adds a capped perf test to the video_decode_accelerator_perf_tests. This test simulates rendering video frames at the video's frame rate, to create a more realistic usage scenario. TEST=ran new VDA perf tests on nocturne BUG=925714 Change-Id: I73c6444dbe470b6014e775aeeb25867859edd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575056 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662007}
-
Victor Costan authored
The logic in sql::Database::Preload() is a pessimization for modern OS schedulers, as it forces the kernel to read the first few pages of a newly opened database. https://crbug.com/243949 suggests that this method was added without performance testing, just like the more complex SQLite patch that it replaces. This CL sets up a Finch trial that will either prove that we can get rid of the Preload() hack, or give us conclusive data about its usefulness. Bug: 243949 Change-Id: Icfee9aaa3d125af207974536e8e5f5e64a9609ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1438031Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#662006}
-
Arthur Hemery authored
Adding extra information for a url/origin mismatch troubleshooting. See bug for details. Bug: 824649 Change-Id: I3044337d5895759140a7b80d964ffbe6e067739d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611819 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662005}
-
Oystein Eftevaag authored
This reverts commit ceda88d2. Reason for revert: Relanding with disabled test; the crash is a more critical issue. Original change's description: > Revert "Perfetto: Move in-process mode behind a feature flag while investigating crash" > > This reverts commit 719b61da. > > Reason for revert: Causing failures of StartupTracingInProcessTest.TestFilledStartupBuffer on many builders > > Original change's description: > > Perfetto: Move in-process mode behind a feature flag while investigating crash > > > > R=ssid@chromium.org > > BUG=961609 > > > > Change-Id: Ic25d4eb36f90506c8d21abf3df35fb3f11474746 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616447 > > Commit-Queue: oysteine <oysteine@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#660715} > > TBR=oysteine@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 961609 > Change-Id: I6f19fc5f738d9a1b05cb9c76438bed20e5ee45b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619585 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#661284} TBR=oysteine@chromium.org,ssid@chromium.org,sidereal@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961609 Change-Id: I4bedf3c0ed206a3357e376b98cc523d11fff917c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623495Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#662004}
-
Kent Tamura authored
- Replace 'Node' in function names with 'Element' - Replace Node/WebNode arguments with Element/WebElement - Update arguments' variable names. This CL has no behavior changes. Change-Id: I5fb783ad9cf3cbe7944de933d5331f57822c8eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609749Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#662003}
-
Karan Bhatia authored
r658810 added some CHECKs to debug a potential crash in ExtensionWebRequestEventRouter::OnHeadersReceived. Since these crashes are no longer happening, change the added CHECKs to DCHECKs. BUG=960323 Change-Id: I701da45b36332d0c5da8962516c5dbed2a2305ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620527 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662002}
-
Theresa authored
BUG=931496 Change-Id: I0165508f00aede40e4cc072b27dcacb303624924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620696 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#662001}
-
