- 03 Dec, 2019 40 commits
-
-
Alex Cooper authored
This changes pose_reset and input_state attributes that lived on VRPose to instead live on XRFrameData. This de-couples some frame state from VRPose and paves the way for it to be used instead of gfx::Transforms for some entities. Bug: 1017872 Change-Id: I76474845436168a144f929c8cb94bd4a50b15fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945278Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721135}
-
Anqing Zhao authored
Currently, the test cases in this file is not enabled for Chrome OS. This cl is to enable it by following steps. - The request type is decided by current operation system. - Skip verification for specific fields. Bug: 1010213 Change-Id: I3d63e728c7b4a663a7f2ae2147f57b681b9494fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947650Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#721134}
-
Tom Anderson authored
The version of dbus-launch on the bots does not support --exit-with-x11. Instead, send SIGKILL to the daemon's pid to ensure it exits with xvfb.py. Also, PRESUBMIT.py fails due to a URL exceeding the 80-column limit, even though this line is not modified by this CL. Replace the URL with a commit hash to prevent presubmit failures in the future. BUG=1013812,1027852 R=dpranke Change-Id: I974e3aae9282fc593fc8c86cedfe55c684a7e7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949027 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3c399536949..a097c941d4f8 git log e3c399536949..a097c941d4f8 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "TrackEvent: Require track event names to be static strings" 2019-12-03 taylori@google.com Merge "perfetto-ui: Select tracks when selecting time range" Created with: gclient setdep -r src/third_party/perfetto@a097c941d4f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id0de5f3a73b395f2e3def88f5f1d6a27803b9195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721132}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for tracing::mojom::PerfettoService using PendingRemote. Bug: 955171 Change-Id: I99b06720be06acb7b70070d474a6b867fbeac0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939160Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721131}
-
Anqing Zhao authored
In Chrome OS, this policy only takes effect on primary account, other than all accounts. So this setting's value should be changed to False. Bug: 1010213 Change-Id: Ia0a3e999db90041fa52504ad2f1f7ecd1b316ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947725Reviewed-by:
-
Fredrik Söderquist authored
When nudging the presentation time back in InstanceListChanged(), the previous interval could be the active one, so we need to consider it when updating the active state and when compute the next interval time. Bug: 1030309 Change-Id: I5d20878f45dd4e26c5966c816b9ff5c82e4c40b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948938Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721129}
-
Fredrik Söderquist authored
Track the entry to start the (next) search in the 'begin' list from, and make sure we advance to the next one for each subsequent iteration of the loop. This should ensure forward progress is made. Bug: 1029573 Change-Id: I7a3d7564527667cec397a1431b0757674ce75469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946477Reviewed-by:
-
Sean Gilhuly authored
The |gpu_preferences| argument is no longer used in CollectGraphicsInfo, so remove it from the signature and callsites. Change-Id: I73399b711a94dc98983bcea7cb82df8499758028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949063Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#721127}
-
Ali Juma authored
This adds the file as an EG2 target, updates #includes, and replaces calls to helpers that can't be used in EG2. This also adds a webStateLastCommittedURL method to ChromeEarlGrey. Bug: 987646 Change-Id: Ib98baad37b422b36a216b7915a0594b0e76c4062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947048Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#721126}
-
Nikita Podguzov authored
Bug: 943746 Change-Id: Ic54edc8c0475aa1c31ce59b092e356a28ffbc743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937170 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Jasper Chapman-Black authored
Since caspian_web.wasm has grown to about 8MB, it's probably a good idea to cache it via the ServiceWorker. Change-Id: I60f115d8fe2f557d83b7824090330eec1b07c395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949068Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721124}
-
Tien Mai authored
This will change the presubmit checks for policy_templates.json to ensure that policy changes are backwards compatible with policies definitions that have already shipped. Bug: 1026330 Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#721123}
-
Natalie Chouinard authored
Remove feature-specific Password logic from PreferencesLauncher to a dedicated PasswordManagerLauncher class. Bug: 1029194 Change-Id: I202d0156a98d112c97c88495c6edbec5b7fe50cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940610 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721122}
-
Denis Kuznetsov authored
Bug: 1018105, 1014859 Change-Id: I293216a4dfe9f6d56bae7a1dd09f73d74025f72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948840Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#721121}
-
Guillaume Jenkins authored
As mentioned in code review feedback on another spell check CL, the site isolation browser test file is getting large, and spell check stuff takes a good chunk of it. This CL moves the spell check site isolation tests to their own file, which is not compiled if spell check is not enabled. The CL also moves a base test class to its own .h and .cc files, since both the non-spell check and the spell check tests inherit from it. Other CL for context: https://chromium-review.googlesource.com/c/chromium/src/+/1918277 Change-Id: Iaea04af280859e42f916667c767a72ddaefcef92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945276 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#721120}
-
Takumi Fujimoto authored
Disabled on debug build for flakiness. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15567 TBR=antrim Bug: 997685 Change-Id: Ie06d3ca41aa37181b9098dad0466eca551403b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949204Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721119}
-
Eugene But authored
According to Download.IOSDownloadedFileStatusCode UMA metric there is non-trivial number of download failures with 405 http code (Method Not Allowed). This is because DownloadTask always creates NSURLTask with GET HTTP method regardless of the original HTTP method in the request. This CL adds support for POST request, because this is likely the easiest fix for the problem (I would be surprised if PUT and DELETE methods are used for downloads). We can add support for all HTTP methods later if necessary. Bug: 1030164 Change-Id: Ic3023fee44c580af7e4540b9de15ca957d43d047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948283 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721118}
-
Nico Weber authored
Might work after #721015. Bug: 1024203 Change-Id: I9403a404c0027394e2256b51df5c6835dd03bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948494 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721117}
-
Demetrios Papadopoulos authored
Stop waiting on the lazy_load.html loading before expanding a settings subpage. Waiting is unnecessary, and also triggers an unfortunate iron-list behavior where no items are rendered when its dimensions are 0x0 (essentially when hidden). Waiting was introduced at r719484, and by removing the waiting the code works more similar to before, while still triggering the loading of lazy_load.html. Bug: 1029703 Change-Id: Iae1aaaa2eaf9227b61999201a020e60d2d048c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947957Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#721116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aa0bcb82820..be3109961d3d git log 6aa0bcb82820..be3109961d3d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 tandrii@chromium.org Roll bb tool to @ b7405423 Created with: gclient setdep -r src/third_party/depot_tools@be3109961d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030156 Tbr: agable@chromium.org Change-Id: I7e82506f1f6c485a99b8a08f39dd67dd671b9119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947977Reviewed-by:
-
Tommy Li authored
Currently, when we get search suggest results back from ZeroSuggestProvider, nothing is bolded. This is inconsistent with as-you-type search suggestions. The root cause is that we purposely set AutocompleteInput::input_text to an empty string for all ZeroSuggest queries, to avoid leaking the user's current URL. (The URL is separately included in eligible). The lack of bolding is an unintended side effect. This CL fixes that, by re-classifying all the search suggest results that come back with the real input text on the client side. This is primarily intended to improve On Focus Query Refinements, but this will affect all ZeroSuggest modes that return search results from a non-empty omnibox. (Should not affect NTP). Note nothing is bolded at all when the input text is empty (on NTP). Navigational suggestions are not affected by this CL. They are currently not bolded at all. Bug: 963173 Change-Id: I7982c780f4b03f3d2b4992051d291fe1cd86f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947765Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#721114}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abdd0094e0d1..22e4696f2435 Created with: gclient setdep -r src-internal@22e4696f2435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:984694 Tbr: jbudorick@google.com Change-Id: I81c28cc34531836281c9ad1b588bb05095532141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948981Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721113}
-
David Grogan authored
This reverts commit 4fb5e9ec. Reason for revert: Triggered DCHECK !constraint_space.IsIntermediateLayout() || box_->NeedsLayout() Original change's description: > [LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout > > Bug: 635619 > Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716907} TBR=cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 635619, 1027759 Change-Id: I961ca71602f331d2a612d430e9a4ae049e331b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948496Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721112}
-
David Bokan authored
Currently, the code for "latching", deciding which scroller should be targeted and locking to it for the duration of a gesture, and scrolling is entangled together. This makes it difficult to understand and complicates the call flow when gesture scrolling events are handled. This CL splits up DistributeScrollDelta, into two new methods, one to perform the latching, and one to scroll the latched node. It also removes the calls to distribute scroll from Begin/End, which eventually calls into ApplyScroll. These don't actually do anything since there's no delta but were there assuming ScrollCustomization would eventually make them effective. Bug: 1016229 Change-Id: If13e098c2a1fb25e8de27275dfcfc5f18fed4c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944466 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#721111}
-
David Black authored
Timeout may not make sense w/ show-on-scroll enabled. In the chance that timeout may need to be disabled, we'll treat a timeout of zero as indicating desire to disable timeout. Bug: b:139199620 Change-Id: I14c79620542320148e31942fe8c4ae447c74ab65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939841Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#721110}
-
Demetrios Papadopoulos authored
Previously the code relied on some fragile coincidence to work: 1) flags.html was using |flattenhtml| to inline flags.css at build time. 2) flags.html was using absolute chrome://flags/strings.js and chrome://flags/flags.js URLs, to prevent those files from being inlined (which would violate CSP and result in a runtime error). 1 and 2 above resulted in a breakage (runtime error) if one changes <script src="chrome://flags/flags.js"></script> to <script src="flags.js"></script> which is confusing, since those URLs are equivalent and should be treated exactly the same. Removing |flattenhtml| from flags.js GRIT entry fixes the weirdness. This is in preparation of converting this page to use JS modules. Bug: 1029094 Change-Id: I394ce31f082372758ea6d34ce607c0794e27b4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941207 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Majid Valipour authored
At the moment they are mostly flaky but we should/will address them over time. Enabling these will help us collect data on where the failure are and allows us to add new tests. Bug: 878878 Change-Id: I5ede5e9562fc096afbfa5474822f713351ce4ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924907 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721108}
-
Natalie Chouinard authored
This is a purely mechanical rename done with Android Studio. This class is being renamed to adhere to the conventions described in go/clank-preferences-refactor. TBR=gogerald@chromium.org Bug: 1029146 Change-Id: I642f4c0236ac1c034eb62f3ab62ce63a711967ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947394 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721107}
-
Khushal authored
R=ellyjones@chromium.org Change-Id: Ieb33ec9e129f857c128970df6151d8896d66fecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947402 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721106}
-
Alex Cooper authored
There were a few issues here. Most of them either cancelled each other out or (due to overrides) weren't hit. * The comment above XRFrame::getPose was incorrect - This has now been updated, and the parameters were renamed to better match the spec, and hopefully prevent further confusion * XRSpace::getPose was returning other_from_base and not base_from_other - TargetRaySpace and GripSpace actually have overrides that do the right thing in this case, and so were unaffected. - XRReferenceSpace did call up to this, but mostly cancelled out this inversion due to the next issue. * XRReferenceSpace::MojoFromSpace was returning SpaceFromMojo - This caused the error above to not be as noticed. As a result, the xrFrame_getPose test has had it's matrix updated and a new test has been added which should hopefully help catch this. Note that if a grip or target space is supplied as the first parameter to getPose (the common case), the math is being done correctly. Also note that the two inversions for references spaces also mostly cancels each other right. The main issue that was affected is if a reference space with an origin offset was supplied as the first parameter to xrFrame.getPose Fixed: 1030049 Change-Id: I0184607dbd0fef991c382289e1c764f9a1b336a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947629 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: -
Maks Orlovich authored
Change-Id: Iaba25ff639b31955333c216a3900e677c1aa0876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944285Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#721104}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a002a375f2cc..e3c399536949 git log a002a375f2cc..e3c399536949 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 nuskos@google.com Use the provided ArgsTracker rather then the one in the context while parsing Created with: gclient setdep -r src/third_party/perfetto@e3c399536949 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0dd6d5109f294e11adbb47cc9bd14d3245e99df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948532Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db2e7641bed8..b6b7e7b6c8de git log db2e7641bed8..b6b7e7b6c8de --date=short --first-parent --format='%ad %ae %s' 2019-12-03 mtklein@google.com Revert "replace SkColorSpaceXformSteps::Required()" 2019-12-03 fmalita@chromium.org [skottie] Remove defensive seek(0) from Animation ctor 2019-12-03 mtklein@google.com Fix some GCC warnings. 2019-12-03 reed@google.com remove legacy next from iter 2019-12-03 kjlubick@google.com [canvaskit] Add test and extern for MakeImage Created with: gclient setdep -r src/third_party/skia@b6b7e7b6c8de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I37739ac1c744a36fce9939d4052e6612c999d855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949023Reviewed-by:
-
Lijin Shen authored
The CL adds some tests to ensure feature is enabled when checkbox is checked and it can maintain its state when other theme is selected. Bug: 1022210 Change-Id: I27ebe58d6cda4164c2ee5279bc1dac97cffec599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940609 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#721101}
-
Collin Baker authored
Fixed: 1028827 Change-Id: I8d3d3b3134a9f91d86289f16c70d730f0ded34b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948084 Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721100}
-
Victor Hsieh authored
Test: No longer seeing warning at login screen on unsupported device Test: Still seeing warning at login screen on unsupported device Bug: b/144978786 Change-Id: I1c73fbeab03354a4dd3d43bde615fc242c5c46e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946884Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721099}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d5a7f10. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iace936c0121fa354939268551b418795c60c5f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948325Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721098}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca1b0fb895ca..fc2dd45054bf git log ca1b0fb895ca..fc2dd45054bf --date=short --first-parent --format='%ad %ae %s' 2019-12-03 geofflang@chromium.org Link to the autoroller configuration directory in the wrangling doc. 2019-12-03 thakis@chromium.org Remove an unused .gn file. 2019-12-03 flibitijibibo@gmail.com Fix UWP build 2019-12-03 geofflang@chromium.org GL: Make GL_EXT_texture_format_BGRA8888 enableable. 2019-12-03 jmadill@chromium.org Use SwiftShader-based ICD generation. 2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 83af46951202..a4af7676feb0 (1 commits) 2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 979b531e9fff..0a0625a3dca6 (1 commits) 2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 47f3eb42641b..3ed4586044f2 (1 commits) 2019-12-02 jmadill@chromium.org Add new test runner harness. 2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers 2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test 2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource 2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize. Created with: gclient setdep -r src/third_party/angle@fc2dd45054bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026673,chromium:1029091 Tbr: geofflang@google.com Change-Id: Ied89ac010fd38136e3d7b498491d4b5736e7326e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948797Reviewed-by:
-
Takumi Fujimoto authored
This reverts commit 094d246a. Reason for revert: I believe this is causing flaky failures in BackgroundBehaviorTestInstances/WebMediaPlayerImplBackgroundBehaviorTest.AudioVideo: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/84561 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/31980 Original change's description: > Entering Picture-In-Picture re-enables disabled video track if needed. > > This CL makes sure video track disabled by video background track > optimization is re-enabled when entering Picture-in-Picture. > > Bug: 949265 > Change-Id: Id0cca141f262537672f49f8cdc8bc6db5c10e3dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556837 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721018} TBR=beaufort.francois@gmail.com,mlamouri@chromium.org,sandersd@chromium.org Change-Id: I3aea0364af64ffa231dfafde3b519bdb65c4dd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949144Reviewed-by:
-
