GitLab

This is like https://codereview.chromium.org/443483002/ , but that check wasn't
as convincing as it could have been since clang accepts override and final as
an extension in c++98 mode. No intended behavior change.

If your bot can't deal with this, please let me know!

BUG=none
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/555383004

Cr-Commit-Position: refs/heads/master@{#295128}

This prevents racy teardowns that might cause BrowserPlugin to try to delete an invalid
pointer

BUG=none
Test=Open browser sample, and close browser sample. It should not crash.
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/574623004

Cr-Commit-Position: refs/heads/master@{#295127}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/552883002

Cr-Commit-Position: refs/heads/master@{#295126}

This is refactoring some code and also allows add to homescreen to use
<meta name='application-name'>.

BUG=366145

Review URL: https://codereview.chromium.org/568823003

Cr-Commit-Position: refs/heads/master@{#295125}

to be within metrics code

MetricsReportingEnabled checkbox changed code refactored for not-chromeos:
-prefs removed from HTML
-Handler and callback functions added to core_options_handler
-Major refactoring in metrics_reporting_state
-Simple histogram added in metrics_reporting_state without distinguishing the source of the change
-browser_options_handler changed to handle new way of forcing company policies of disabling the checkbox

BUG=401233

NOPRESUBMIT=true
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/506663003

Patch from Gayane Petrosyan <gayane@chromium.org>.

Cr-Commit-Position: refs/heads/master@{#295124}

Avoid using ToInternalValue in computing timings, so that the timings are consistent accross platforms and with javascript performance timings API.

BUG=413672

Review URL: https://codereview.chromium.org/557953006

Cr-Commit-Position: refs/heads/master@{#295123}

My previous checking mistakenly used tabs. replacing
them with spaces as required by the style guide.
https://codereview.chromium.org/545103003/

Review URL: https://codereview.chromium.org/570933004

Cr-Commit-Position: refs/heads/master@{#295122}

This CL makes a few changes in the direction of removing dependencies
on ErrorCode by pushing them up a layer:

- Trap now simply uses TrapKeys directly to store trap function and
metadata instead of needlessly encoding them as ErrorCode.

- MakeTrap returns a bare trap ID and it's instead the caller's
responsibility to encode in an ErrorCode if needed, which is now
handled by ErrorCode's trap constructor.

- Also, ErrorCodeFromTrapId() is replaced by IsSafeTrapId() to answer
the one question that SandboxBPF was interested in knowing about
existing traps.

- Change a few SandboxBPF trap-constructing functions into static
functions since they don't depend on any SandboxBPF instance member
variables.

BUG=414363

Review URL: https://codereview.chromium.org/572753002

Cr-Commit-Position: refs/heads/master@{#295121}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/576503002

Cr-Commit-Position: refs/heads/master@{#295120}

Implements an OutputSurface that uses render-to-texture and overlays
to display the main surface. Buffering of frames is implemented
internally as there is no system-provided surface.

BUG=380861

Review URL: https://codereview.chromium.org/516663003

Cr-Commit-Position: refs/heads/master@{#295119}

Review URL: https://codereview.chromium.org/576823002

Cr-Commit-Position: refs/heads/master@{#295118}

BUG=352290

Review URL: https://codereview.chromium.org/573843002

Cr-Commit-Position: refs/heads/master@{#295117}

I came across this while investigating slowness. Without this we would
end up unnecessarily toggling visibility a couple of times. While not
the end of the world, toggling visibility for the bookmarkbar can take
a while (mostly because it can end up containing a ton of views).

BUG=none
TEST=covered by test now
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/573893003

Cr-Commit-Position: refs/heads/master@{#295116}

BUG=414066
TEST=none

Review URL: https://codereview.chromium.org/557363004

Cr-Commit-Position: refs/heads/master@{#295115}

BUG=none
R= mkearney@chromium.org, smain@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/511963004

Cr-Commit-Position: refs/heads/master@{#295114}

This removes the last known dependency on guava_javalib.

Full list of changes:

r340 Removing guava dependency for the invalidation client (part of an effort to reduce method count in Android applications)
r341 Fixing package name in AndroidListenerManifest.xml and ordering factory methods by corresponding proto field in AndroidService.java

BUG=412673
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/573733004

Cr-Commit-Position: refs/heads/master@{#295113}

BUG=414725

Review URL: https://codereview.chromium.org/577643003

Cr-Commit-Position: refs/heads/master@{#295112}

Refactor the RendererFreezer class so that untestable code is moved into
a delegate and add unit tests.  Modify FakePowerManagerClient so that it
provides more information for tests.

Also use a CancelableClosure for the asynchronous suspend readiness
callback in case we get a SuspendDone before we've had a chance to run
OnReadyForSuspend().

BUG=364339,414396
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/543303002

Cr-Commit-Position: refs/heads/master@{#295111}

BUG=414408

Review URL: https://codereview.chromium.org/562203006

Cr-Commit-Position: refs/heads/master@{#295110}

We should not call PlayerGone only for MSE case, we should call it for all cases.

BUG=414066

Review URL: https://codereview.chromium.org/576813002

Cr-Commit-Position: refs/heads/master@{#295109}

Fix a bug where reording actions in the browser action overflow container can
cause them all to become visible.

BUG=414177

Review URL: https://codereview.chromium.org/570403002

Cr-Commit-Position: refs/heads/master@{#295108}

We now always abort invalid loads. According to UMA, they don't happen
anymore, so this should only affect future bugs.

Also, move the UMA reporting to the right thread.

BUG=none
R=mmenke@chromium.org,mef@chromium.org,nasko@chromium.org

Review URL: https://codereview.chromium.org/572273002

Cr-Commit-Position: refs/heads/master@{#295107}

SpdyNetworkTransactionSpdy*Test has been removed in https://crrev.com/16816010.
SpdyHttpStreamSpdy*Test has been removed in https://crrev.com/17004007.  These
two exclusions are now obsolete.

BUG=118883
NOTRY=true

Review URL: https://codereview.chromium.org/579463002

Cr-Commit-Position: refs/heads/master@{#295106}

These histograms are no longer being monitored, so removing them from Chromium.

 - Net.DhcpWpad*
 - Net.MTPR_*
 - Net.ProxyResolver*
 - Net.ProxyPollConfigurationTime [1]
 - Net.GetProxyForURL*:  [1]

[1] Removed from histograms.xml; the histogram is not present in the code.

Review URL: https://codereview.chromium.org/573893004

Cr-Commit-Position: refs/heads/master@{#295105}

as it provides a loophole around const.

I've removed const from platform_canvas() and sk_canvas(), if
anyone tries to access these from a const instance of Canvas, it
won't compile.

Review URL: https://codereview.chromium.org/560463004

Cr-Commit-Position: refs/heads/master@{#295104}

Make PasswordSyncableServiceTest.* more readable. Add -Wexit-time-destructors warning for the password manager.

Review URL: https://codereview.chromium.org/562833003

Cr-Commit-Position: refs/heads/master@{#295103}

The visibility check was checking the origin of deps[i] instead of
datadeps[i].

Review URL: https://codereview.chromium.org/551843006

Cr-Commit-Position: refs/heads/master@{#295102}

https://chromium.googlesource.com/chromium/blink/+log/8cc576a35676fa4829ee37d9d40e791354e16df1..435acf076b2d5f0243b4a87c5d5ef904ae59bed3
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/572333002

Cr-Commit-Position: refs/heads/master@{#295101}

https://skia.googlesource.com/skia/+log/8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e..a32f1758b7ebd889eecfdc67c935e7edcedc5be3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/574643005

Cr-Commit-Position: refs/heads/master@{#295100}

This updates Chromium's clang version to r216630 with
r216684 cherry-picked to fix an ASan issue.

It also changes the build script for Clang to use CMake
instead of Autoconf. The ASan team say this configuration
is better tested, and it also makes us consistent with
the Windows Clang build which already uses CMake.

BUG=400849
R=thakis@chromium.org
TBR=brettw

Review URL: https://codereview.chromium.org/578623002

Cr-Commit-Position: refs/heads/master@{#295099}

R=agl@chromium.org

Review URL: https://codereview.chromium.org/574033004

Cr-Commit-Position: refs/heads/master@{#295098}

Provide a method to reset the device color profile for tests, and
make TestRunner call it prior to each layout test.

This to reset the Page color profile to its default state, to let
Page choose the default color profile, rather than TestRunner.

BUG=369787,368663

Review URL: https://codereview.chromium.org/561453004

Cr-Commit-Position: refs/heads/master@{#295097}

This contains an ancient version of gold, which has not been
updated since 2012. Back in times the NDK didn't provide a 64-bit
version of the linker for Android.
This seems to be unused today. It's cleanup time.

BUG=

Review URL: https://codereview.chromium.org/572233003

Cr-Commit-Position: refs/heads/master@{#295096}

the path to the canvas instead of using the canvas's built in round rect
function. Changing these to the canvas round rect could allow skia to
optimize their drawing.

This change switches the status bubble to the canvas round rect.

Review URL: https://codereview.chromium.org/568343002

Cr-Commit-Position: refs/heads/master@{#295095}

Configure Breakpad to run in-process on Yosemite by setting the
BREAKPAD_IN_PROCESS option.

Roll breakpad r1359 -> r1375.

r1375 Mac: Add support for in-process crash reporting to Breakpad.
r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
r1373 Update processor.gyp file with new files added as part of microdump
r1372 Introduce stub microdump processor classes.
r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
r1370 Extract DumpContext base class from MinidumpContext
r1369 Back out trunk r1367.
r1368 Adding possibility for client to upload the file
r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
r1366 constructor init list in wrong order in CrashGenerationServer
r1365 update svn:ignore
r1364 make "make install" also install headers and pkgconfig files
r1363 Set 32 bits iOS app to use vm_region_recurse_64.
r1362 update svn:ignore lists
r1361 Update lss from r24 to r31.
r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.

BUG=414239

Review URL: https://codereview.chromium.org/571663002

Cr-Commit-Position: refs/heads/master@{#295094}

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/571373002

Cr-Commit-Position: refs/heads/master@{#295093}

Blink now has methods that don't take the rect out-param so use those.
Then we can delete the old methods with the out-param in blink.

R=vmpstr
BUG=413479

Review URL: https://codereview.chromium.org/572873005

Cr-Commit-Position: refs/heads/master@{#295092}

For apps v1, authentication involves navigating away from the app and
then back again, so loading browser_test.js before authentication doesn't
work. I don't know why this is a recent regression though--AFAICT it should
have been failing from day 1.

BUG=414498

Review URL: https://codereview.chromium.org/571273002

Cr-Commit-Position: refs/heads/master@{#295091}

Blink CL https://codereview.chromium.org/559423002/ depends on this.

BUG=406094

Review URL: https://codereview.chromium.org/564423002

Cr-Commit-Position: refs/heads/master@{#295090}

NESTABLE_ASYNC APIs
(https://codereview.chromium.org/536503002/) to log NetLog
entries in Tracing. This CL is a part of the effort to get
NetLog data into Tracing.

Design Doc:
https://docs.google.com/document/d/1Z2uqj59UEts5IiXX78mkdU4kd6e7kE3JUKPoDK97bVs/edit?usp=sharing

BUG=399701

Review URL: https://codereview.chromium.org/468083004

Cr-Commit-Position: refs/heads/master@{#295089}