- 20 Feb, 2020 40 commits
-
-
Alex Newcomer authored
Change-Id: I41431331a7aca745ee58edd116fbc9328ca3a178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065335 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#743077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e4d24728146d..69ac3898ce66 git log e4d24728146d..69ac3898ce66 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 tvanderlippe@chromium.org Reland "Fix TS + Ninja integration" Created with: gclient setdep -r src/third_party/devtools-frontend/src@69ac3898ce66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02e620928e0b1d5948793b60808506b28135dd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743076}
-
Jan Wilken Dörrie authored
This change modifies CompromisedCredentialProvider to make use of the SavedPasswordsPresenter to be able to merge compromised credentials with passwords present in the password store. Bug: 1044726 Change-Id: I8dd6dd52306efb7ecc81f11061ad4793e54fe7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063019 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743075}
-
Sergey Poromov authored
[Sheriff] Mark virtual/web-components-v0-disabled/external/wpt/dom/ranges/Range-mutations-dataChange.html timeout Test flaky on Mac and Linux debug bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/86971 TBR=masonfreed@chromium.org No-Try: true Bug: 1016457 Change-Id: I61295e3c4e55c675a1c0c8831f05576178a0102b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066544Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743074}
-
Jamie Madill authored
This reverts commit 648288e2. Reason for revert: Suspected for flaky crash hitting WebGL tests. See bug. Bug: 1054357 Original change's description: > [Sampling profiler] Apply metadata to samples before first contentful paint > > Requests that the sampling profiler apply metadata to samples between > navigation start and first contentful paint, at the time when first > contentful paint is sent to the browser process. This metadata will > support analysis of execution during page load. > > This change introduces monotonic time interfaces for the required metrics > because the existing interfaces are limited to 1ms resolution. If used > they would result in up to 2% of samples being misidentified as occurring > during loading when they weren't, or vice versa. > > Bug: 1034756 > Change-Id: Ibb39877ecfc52a1e5327204c39c3b0ce0f1b8ccd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042324 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742717} TBR=sullivan@chromium.org,wittman@chromium.org,bmcquade@chromium.org,npm@chromium.org,schenney@chromium.org Change-Id: I83e655350d8537934b7715efdd3a576266c80e72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066061Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#743073}
-
Vasilii Sukhanov authored
Bug: 1050659,1053093 Change-Id: Ia39d8f37ece8ba9c3a7f89830a20819c4eec3c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064550 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743072}
-
Dominique Fauteux-Chapleau authored
Bug: 1042319 Change-Id: Ic242cb0528b111612cbe22de7ed24f55bc026522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062616Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#743071}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2801bf43716e..b0e9cd6645e1 git log 2801bf43716e..b0e9cd6645e1 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 39e685ccd37e..c357af84c7cb (1 commits) Created with: gclient setdep -r src/third_party/angle@b0e9cd6645e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I5e0806928ee5b2236a9ec8b6b79132a2cb8e5e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066305Reviewed-by:
-
Artur Kochowski authored
Calculation was using only the height part of preferred size while ignoring the width. Depending on situation this might have caused method to return size that was either too small or too big. There is no visible bug in Chromium because this method is called multiple times and width returned from CalculatePreferredSize is later set to be the same value. Change-Id: I573ea709bb2f3fdadaa36cf71e8bddbe80ec3f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056823Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#743069}
-
Sergey Poromov authored
This reverts commit e0723ae5. Reason for revert: "capture_unittests" failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17155 Original change's description: > Skip 3A for still capture if ZSL is enabled > > This CL skips the wait for 3A-convergence (AE, AF, AWB) when > Zero-Shutter Lag (ZSL) is enabled. When configuring streams, camera HAL > adapter would add a private usage flag to the configured still capture > streams. Video Capture Device (VCD) would then use this private usage > flag to determine if ZSL is enabled. If ZSL is enabled, we skip 3A when > trying to construct a capture request. > > BUG=b:130851309 > TEST=Tested on kukui and verified VCD is able to get ZSL availability > through the private usage flag. > > Change-Id: I751a432b099fb1e012fbd65e54f57901d508225c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919530 > Commit-Queue: Jasmine Chen <lnishan@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743048} TBR=dcheng@chromium.org,shik@chromium.org,hywu@chromium.org,lnishan@google.com,wtlee@chromium.org Change-Id: I5386db19de0e1a4e93828c2ab81a53f51ee7a08d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:130851309 Bug: 1054385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066618Reviewed-by:
-
Sergey Poromov authored
The tests are flaky. Sample run: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2669 TBR=eugenebut@chromium.org Bug: 1054372 Change-Id: I017acc96b29650cc944f26f3c5a538a89432ac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064946Reviewed-by:
-
Wez authored
New //base primitives are being added under //base/util, which has its own unit-tests suite, so we should be running that. Bug: 1020698 Change-Id: I5126381cf2fc1fdf3a5b6e466cd994d23167f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062420 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#743066}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07a0ee92..b86395aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaefa7f1b4d9ba267c76bccb41d9e54912145be6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743065}
-
Maksim Moskvitin authored
This CL is a part of ObjectId -> Topic API migration. It's a pure refactoring and there should be no behavioral changes. Bug: 1029698 Change-Id: Ieab9c5a76c009a3ec93dd2a8737b9f9b6119a101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059376Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#743064}
-
Jose Lopes authored
This callback is meant to be called every time a new key is registered, thus it must be a repeating callback, as documented in: https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=502d7a8bc634c4248b7cc2f43e2305eee7213d94&l=51 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib852f03ab2f862d02d0e09be95626090cee60d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035960 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743063}
-
Kai Ninomiya authored
This reverts commit 51f4efc9. Reason for revert: rmtree fix was reverted Original change's description: > Roll CTS and fix extract_expectation_names.py > > https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 > > Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743007} TBR=kainino@chromium.org,robertma@chromium.org,enga@chromium.org,rmhasan@google.com Change-Id: I2fee3ed2df610c3fc0e385725e3ae0e86718f745 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066464Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743062}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b1e6dfe. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 9431619c "Clipboard Tests: Update DOCTYPE to lowercase." 76ee218c "Split html/.../query-encoding/ tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3be8ea0796671ac0c3d75dbff05e05b403fbfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066204Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743061}
-
Andrey Zaytsev authored
Also removed the version updater callback argument as it does not need to be created outside of CheckUpdates(). Bug: 1015841 Change-Id: I4a2bb4a23ce1c24e1a8358c641b797be0a79a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049982 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#743060}
-
Mugdha Lakhani authored
Design Doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Before screenshot here: After screenshot here: https: //drive.google.com/open?id=0B486O0P6jAtRZ0ptUEJXemUwczNjTjlGejFPZ1ZaZS02RXFr https: //drive.google.com/a/google.com/file/d/15sHXrBgFOUAT5p2gccLHfIyP5ELYRsXV/view?usp=sharing Bug: b/64863368 Change-Id: I05b8cc3c878f930d0c18b69a4f84ac43a10b2592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873631 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#743059}
-
Marc Treib authored
If Sync-the-feature is enabled, there is only a single, combined storage for passwords. So we should not offer the account storage in this case, and if the opt-in already exists it should be ignored. This CL adds the necessary "!IsSyncFeatureEnabled()" checks plus corresponding tests. Bug: 1024332 Change-Id: I496ecb902297983d51526a74211ff1b754376e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062981Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743058}
-
Rayan Kanso authored
This is needed for the stale manifest use case. Bug: 1045588 Change-Id: I7deb018afa062f829cc13247ab7faaa86da8a129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050274Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743057}
-
Benoît Lizé authored
The global memory dump is fetched once per memory metrics recording, and never re-used. However the global dump is never reset, wasting memory. Bug: 1054360 Change-Id: I04f65427194068e579cd87938d4cf65af9bd0962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056820 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#743056}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/631436b3c1f2..e4d24728146d git log 631436b3c1f2..e4d24728146d --date=short --first-parent --format='%ad %ae %s' 2020-02-20 wolfi@chromium.org Use 1000 not 1024 for kB and MB calculations 2020-02-20 rajasekar89be@gmail.com DevTools: fix Reveal in Network panel does not work if filter was set before Created with: gclient setdep -r src/third_party/devtools-frontend/src@e4d24728146d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035309,chromium:1044651 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16768ffe4e11ce0765d328c2fc64718de3f76e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065653Reviewed-by:
-
Antonio Gomes authored
BUG=704136, 919392 Change-Id: Id91b5c49e96ecae45b1c10f96d99b74e7c64a75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064748Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743054}
-
sandromaggi authored
Bug: 1053606 Change-Id: I5051770b0ecb8c1b6d2a91ed31f9b533277c13de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062287Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#743053}
-
Sergey Poromov authored
chromeos-eve-chrome consistently fails: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3756 Bug: 1054340 Bug: 1000351 Change-Id: I51d89786926f48f7bdab4884bf27bf6b495d4947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065003 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#743052}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adeb0b9fdd32..189bea09d5ac Created with: gclient setdep -r src-internal@189bea09d5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99835ef74504f6366491dc97b73b897b54147bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743051}
-
Jan Wilken Dörrie authored
While base::Value switched to checked iterators in its list API, base::ListValue still used unchecked std::vector<Value>::iterators. This change fixes this oversight and slightly improves the checked iterator interface by making the comparison operators non-members, thus allowing implicit conversions on both arguments. Bug: 990059 Change-Id: I7b3bb4573300fe7f391c6b911817448f8aee7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060672 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743050}
-
Keishi Hattori authored
Introduces HeapMojoReceiverSet which is a wrapper around mojo::ReceiverSet. And uses it for ManifestManager. Bug: 1052319 Change-Id: I683567f0352c9b60811263a662bda85e31299426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063615 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Jasmine Chen authored
This CL skips the wait for 3A-convergence (AE, AF, AWB) when Zero-Shutter Lag (ZSL) is enabled. When configuring streams, camera HAL adapter would add a private usage flag to the configured still capture streams. Video Capture Device (VCD) would then use this private usage flag to determine if ZSL is enabled. If ZSL is enabled, we skip 3A when trying to construct a capture request. BUG=b:130851309 TEST=Tested on kukui and verified VCD is able to get ZSL availability through the private usage flag. Change-Id: I751a432b099fb1e012fbd65e54f57901d508225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919530 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#743048}
-
Sergey Poromov authored
This reverts commit 00abf52b. Reason for revert: Failures on Mac ASan 64 Tests: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60954 Original change's description: > Always use a white theme for System App popup settings pages > > Bug: 1033339 > Change-Id: Ia8f0c24deb742d04b0a10bb4fbcb4c3322ea1547 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065776 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742992} TBR=alancutter@chromium.org,joelhockey@chromium.org Change-Id: I6152c170c342622e8c53a5566e8b9d2488ebe1c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065005Reviewed-by:
-
Peter Kasting authored
Bug: 815016 Change-Id: I68fe2e15917ae11ee46e4090b64fdba3ae25a5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066151 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Jose Lopes authored
This callback is called in: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=aa249ef6fe237699a94759d51dfa5f3cd2b55966&l=852 which is in the context of the method: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=aa249ef6fe237699a94759d51dfa5f3cd2b55966&l=590 which is bound repeating, so it can be called multiple times: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=bfd9a7897bf5085cdab7041c8df7077b35156b97&l=576 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I180addc28f5d7034d9bb7c46833cc34ed195e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036099 Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Sergey Poromov authored
This reverts commit 2eb368c0. Reason for revert: Win7 Tests build failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 Sample run: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64350 Original change's description: > Implement FileSystem.rmtree for long paths on Windows > > Changes blinkpy filesystem tests to use remove_contents instead of > rmtree. remove_contents calls into rmtree, but > (1) retries several times to delete the files, and > (2) throws by default instead of silently swallowing errors. > This improves all of the tests. Additionally, the retrying was > actually necessary to pass many tests (files were otherwise still > locked during teardown). > > Extends the test_long_paths test to check spaces and apostrophes. > > FileSystem.rmtree is now implemented on Windows by just calling > a shell with "rmdir /s /q". This is necessary, because > shutil.rmtree doesn't work for \\?\C:\ style "extended-length" paths > on Windows, and several other implementations I tried didn't work: > - Loop using os.walk. os.walk doesn't support long paths, and > though it seemed to work on the bots, it failed tests locally. > - Recursive using os.listdir. os.listdir also doesn't support long > paths. > > Tested on dawn-win10-* try job on crrev.com/c/2050036/17. > Found in dawn-win10-* try jobs on crrev.com/c/2050036/4. > > Change-Id: I7c67bb12305a41244829e35293edfc88901b76f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058065 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742961} TBR=kainino@chromium.org,robertma@chromium.org Bug: 1054331 Change-Id: Iec3f75c925598f37a228771371b08616cb0d97d5 No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064997 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Omar Morsi authored
chrome://settings/certificates should display hardware-backed for a certificate if it is saved on a hardware-backed slot and its private key is stored in the TPM. CL:1967781 introduced kKeyInSoftware attribute for private key which can be used to check whether the key is wrapped by the TPM or not. This CL introduces: 1- Taking advantage of the kKeyInSoftware attribute to check if a private key is hardware-backed or not. 2- Adds support for requesting certificate information list from NSS certificate database. Gathering certificates information is done asynchronously. 1- net_unittests --gtest_filter=NSSCertDatabase* 2- unittests --gtest_filter=CertificateManagerModel* 3- Manually by checking that when importing and binding a client certificate with EC key on a TPM version 1.2, it doesn't display (hardware-backed) in chrome://certificate-manager beside the certificate anymore. Bug: chromium:1043083 Test: Change-Id: I3b2551ae04d5ddadbee28cab823bcbb4278480be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022945 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#743043}
-
Antonio Gomes authored
In order to do this, a couple of remarkable changes took place: - The body of RenderFrameImpl::DownloadURL() and SaveImageFromDataUR() have been moved down to blink::LocalFrame. Note that there were other RenderFrameImpl methods that used to call RenderFrameImpl::DownloadURL() - namely RenderFrameImpl::BeginNavigation. In order to keep this code chain unchanged, WebLocalFrame interface got a DownloadURL() method added, so that it can forward calls to LocalFrame::DownloadURL() from there. - content/renderer/render_frame_impl_browsertest.cc: RenderFrameImplTest got its ctor extended similarly to RenderViewImplTest's (in render_view_browsertest.cc). Now it is possible to inject a custom blink::mojom::LocalFrameHost instance, and catch DownloadURL() mojo call. - web_test_download_manager_delegate.cc: In order to run web_tests that trigger download, we could try to intercept LocalFrameHost for web_tests. Instead, the CL lets the browser/ to handle it. The flow is content requests a download. Mojo calls take place. RFHI::DownloadURL gets called and then DownloadManagerImpl. Particularly, for every download that gets started by the renderer, DownloadManagerDelegate::CheckDownloadAllowed is called. This CL added an extra parameter to this method, in order to idenfity that the download was trigger by the renderer (ie the web_test in case), and then replied to the renderer accordingly. See WebTestDownloadManagerDelegate::CheckDownloadAllowed() for details. - DownloadURL() plumbing methods were removed from WebFrameTestClient, WebFrameTestProxy, WebLocalFrameClient, EmptyLocalFrameClient, LocalFrameClientImpl, LocalFrameClient, ChromeClient. - t_p/blink/public/mojom/frame/frame.mojom: In the normal case - see LocalFrame::DownloadURL() - all members of the blink.mojom.DownloadURLParams struct are filled properly. However, there is another call site - see LocalFrame::SaveImageAt - where only |data_url_blob| struct member is filled, leaving all others "null". |url| is nullable so it is fine, but all others cause crashes on unittests if they are not mark as "nullable" accordingly. - web_frame_test.cc: It implements a BlobRegister instance that intercepts the creation of blink::mojom::Blob, or use FakeBlob instead. Given that the content of the Blob is known, and made of bytes only, it reads off the contents from DataElements. The test also implements a custom blink::mojom::LocalFrameHost instance, so it intercepts mojo calls to DownloadURL() and act accordingly. BUG=1041083 Change-Id: I279bdc142624a0efb6be31535d505e9f6cabe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028708Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743042}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I808d0c2c5a99e8c068227645e03c8a619310da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058932 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Change-Id: Ibdce0a751ec9754fac8395feb1168e85db6ea9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064909Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743040}
-
Mirko Bonadei authored
As mentioned on [1], WebRTC uses xcode 10.2 in buckets/webrtc.fyi.star and this may cause the problem mentioned on crbug.com/1052347. [1] - https://bugs.chromium.org/p/chromium/issues/detail?id=1050976#c23 Bug: 1050976 Change-Id: I3e08b4dcce0c9ef8b92f2ac14a822a62ffa3803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056817Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#743039}
-
Mitsuru Oshima authored
* A window frame should have rounded corners only in normal state, (floating state). All other state won't need them so can be opaque window. * Don't apply this logic if the opacity is explicitly specified (not kInferred) * Old code removed the rounded corner only for maximized/fullscreen. Instead, this CL checks if it's normal. * Consolidated the occlusion region update code for transparent window to WindowState. * Update DCHECK in Window::SetOpaqueRegionsForOcclusion to allow resetting. Bug: 1022544 Test: covered by unit tests. Also tested on the device. OOBE, login screen, arc windows works as intended. Change-Id: Ia8e067945732b81294c3e6733121d433e3087f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059089 Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743038}
-
