GitLab

Use setUpO3DParam_ instead of createParam so that the "o3d." names can be used by serialization.js;
simpleviewer calls Pack.destroy which can fail.
Implement o3d.Matrix4Composition.
Typos in curve loading.
Review URL: http://codereview.chromium.org/3020030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53985 0039d316-1c4b-4281-b951-d872f2087c98

Moving DataSource destruction to the UI thread appears to just leak
memory at shutdown. Finding another way...

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3060024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53979 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49702
TEST=Integrated PDF plugin should work on Linux Chrome, and --register-pepper-plugins works on Linux even with sandbox enabled.

Review URL: http://codereview.chromium.org/3031011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46662
TEST=Manually test ui_tests.PepperTester.Pepper3D and npapi_pepper_test_plugin.
Review URL: http://codereview.chromium.org/3067007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53976 0039d316-1c4b-4281-b951-d872f2087c98

Fixing execute permissions issue.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3017036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53974 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3052019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3068004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

http://codereview.chromium.org/3053017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53967 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53965 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3030022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53963 0039d316-1c4b-4281-b951-d872f2087c98

1) Make it actually work again.
2) Change the model so that it doesn't get into an infinite recursion cycle
   trying to update the model, notify observers, and then re-update.

BUG=49320
TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there.
TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there.
TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages.

Review URL: http://codereview.chromium.org/3023023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53961 0039d316-1c4b-4281-b951-d872f2087c98

Set the initial focus when the task manager first activates and shows.  Also, send our custom accessibility events in NativeControl's Focus() method.
BUG=50401
TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager
Review URL: http://codereview.chromium.org/3038031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3013038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53958 0039d316-1c4b-4281-b951-d872f2087c98

	* Make sure we don't import cookies with identical creation times.
	* DCHECK that duplicate cookie list insertion succeeds (it
	  silently didn't when there were not unique creation times.)
	* Confirm that we eliminate all the duplicats we find on cookie
	  import.
	* Make Methods allowing setting of creation time private.
	* Create performance test for import (involved refactoring
	  backing store mock.)

This change does increase the performance cost on import, and hence adds
to startup time.  However, the increase for importing 15000 cookies was only
5 ms, so I think that's acceptable to prevent crashes.

rdsmith-macbookpro:~/tmp $ perfparse base_perf_import.txt new_perf_import.txt
                                     base_perf_import.txt   new_perf_import.txt
CookieMonsterTest.TestImport
  Cookie_monster_import_from_store   26.36 +/- 0.88         31.38 +/- 1.1

BUG=43188
TEST=net_unittest --gtest_filter=CookieMonsterTest.* (including two new tests.), Linux & Windows

Review URL: http://codereview.chromium.org/3070001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50266
TEST=None
Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3046028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53956 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3009027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53954 0039d316-1c4b-4281-b951-d872f2087c98

XIB changes: Make the InfoBubbleView the same size as the NSView it's contained in.

BUG=50520
TEST=none

Review URL: http://codereview.chromium.org/3061024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53953 0039d316-1c4b-4281-b951-d872f2087c98

Use the new NaClMainForChromium() from the NaCl tree, instead of
sel_main.cc in the Chromium tree.

Use the new variant of RegisterInternalNaClPlugin() that can receive
multiple functions instead of just one.

This depends on r2744 from NaCl.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=Chromium's nacl_ui_tests

Review URL: http://codereview.chromium.org/3039016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50466
TEST=OptionsUITest test should pass on official builder in addition to main waterfall.

Review URL: http://codereview.chromium.org/3015035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53950 0039d316-1c4b-4281-b951-d872f2087c98

Broke ChromiumOS ARM build, reverting. Errors from log:
remoting/client/plugin/chromoting_scriptable_object.cc: In member function 'virtual bool remoting::ChromotingScriptableObject::HasProperty(const pp::Var&, pp::Var*)':
remoting/client/plugin/chromoting_scriptable_object.cc:48: error: NULL used in arithmetic
remoting/client/plugin/chromoting_scriptable_object.cc: In member function 'virtual bool remoting::ChromotingScriptableObject::HasMethod(const pp::Var&, pp::Var*)':
remoting/client/plugin/chromoting_scriptable_object.cc:63: error: NULL used in arithmetic

BUG=50248
TEST=write javascript to manually setup connection.

Review URL: http://codereview.chromium.org/3064009

TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/3020038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53949 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2870076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53948 0039d316-1c4b-4281-b951-d872f2087c98

The problem was the LogBoundConnectJobToRequest() sets
SOCKET_POOL_BOUND_TO_CONNECT_JOB after RemoveConnectJob() ends
SOCKET_POOL_CONNECT_JOB. Since there is no chance to return to the event loop,
it is safe (although fragile), to store the last connect job record and access
that on SOCKET_POOL_BOUND_TO_CONNECT_JOB.

Also, after fixing the DNS issue, it became apparent that what was being
measured as connect time actually included more than just the TCP connect. So I
fixed that as well.

BUG=50229
TEST=LoadTimingObserverTest.*

Review URL: http://codereview.chromium.org/3028026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53945 0039d316-1c4b-4281-b951-d872f2087c98

Quick fix for window sizing under resolution independence on Mac. Scrolling and the "more" arrows are still broken, but this at least makes things usable.

Re-committing of r53272, but this time with more... correctness.

Original review: http://codereview.chromium.org/3029020

BUG=http://crbug.com/19476
TEST=run app under high-res, click bookmark bar button, see that the popup is sized to hold the buttons.

Review URL: http://codereview.chromium.org/3061021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/49668
TEST=turn up resolution; make sure dot is crisp and clear

Review URL: http://codereview.chromium.org/3066009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53943 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: http://http://codereview.chromium.org/2856066/show

Review URL: http://codereview.chromium.org/3058020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manually and trybots.
Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3069001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53937 0039d316-1c4b-4281-b951-d872f2087c98

Native Client.  This removes the special sandbox commands as well
as all special code.

This CL replaces http://codereview.chromium.org/2881016/show which
was rolled back because of problems on Mac OS X 10.5.  Those problems
were addressed in Native Client and pulled into Chrome with a DEPS
file update in http://codereview.chromium.org/2881034/show which was
committed as Chrome revision 53711.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=344
TEST=all tests pass, including nacl_ui_tests

Review URL: http://codereview.chromium.org/3077003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53936 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=50512

Review URL: http://codereview.chromium.org/3075005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48980
TEST=green mac_valgrind bot
Review URL: http://codereview.chromium.org/2883039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53934 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3031026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53933 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49836
TEST=Enable FlashBlock, block all plugins and go to a site with a flash animation. No crashy!

Review URL: http://codereview.chromium.org/3020031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53932 0039d316-1c4b-4281-b951-d872f2087c98

Original revert was an attempt to diagnose a build bustage, but this wasn't the cause.

Review URL: http://codereview.chromium.org/3012028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53931 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3043026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50336
TBR=glider
Review URL: http://codereview.chromium.org/3081003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50504
TEST=Less reports on Memcheck UI bots
TBR=glider
Review URL: http://codereview.chromium.org/3075004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16128
TBR=glider
TEST=Valgrind unit on Mac should become greener
Review URL: http://codereview.chromium.org/3074006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53927 0039d316-1c4b-4281-b951-d872f2087c98

Trying to track down cause of XP Perf bot regression.

Review URL: http://codereview.chromium.org/3081002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53926 0039d316-1c4b-4281-b951-d872f2087c98

XP Perf test regression diagnostic - http://build.chromium.org/buildbot/waterfall/builders/XP%20Perf%20(1)/builds/9081

This reverts commit r53882.

Review URL: http://codereview.chromium.org/2884043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53925 0039d316-1c4b-4281-b951-d872f2087c98