GitLab

So we can use trybots for the big copy in a followup CL.

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8933017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24126
TEST=none
Review URL: http://codereview.chromium.org/8898016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114295 0039d316-1c4b-4281-b951-d872f2087c98

This moves us to the same cross platform utility methods as views and
cocoa, and fixes a DCHECK().

BUG=102772
TEST=none


Review URL: http://codereview.chromium.org/8917029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114292 0039d316-1c4b-4281-b951-d872f2087c98

This time, try doing the work in uniquely named temp directories rather than blocking.

BUG=107291
TEST=Watch for build failures while extracting d3dx9_43.dll, D3DCompiler_43.dll, or xinput1_3.dll.

Review URL: http://codereview.chromium.org/8890072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114290 0039d316-1c4b-4281-b951-d872f2087c98

Warn user if he attempts to register a web request filter without having any
host permissions for the extension. We don't try a full subsumption test (you
may register for a broader set of URLs than you have host permissions). This is
just a simple check that you have any host permissions at all, which should
help a careless developer to see his problem.

BUG=104435
TEST=no


Review URL: http://codereview.chromium.org/8931006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114289 0039d316-1c4b-4281-b951-d872f2087c98

want some of the functionality that used to be there.

BUG=98716

Review URL: http://codereview.chromium.org/8905010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114288 0039d316-1c4b-4281-b951-d872f2087c98

To work around some unit tests that use ExtensionService but don't
provide an IO thread that SocketController now needs to completely
tear itself down, we allocate SocketController lazily and DCHECK on
destruction that there is an IO thread message loop. This is a
reasonable compromise for getting the benefit of lifetime management
by sticking SocketController in ExtensionService.

BTW, aa said putting random crap in ExtensionService wasn't a good idea.
Our chickens are coming home to roost. As platform APIs get bigger,
we should provide our own dumping ground for these classes, and then
callers won't get hung up in surprising lifetime issues like this one.

BUG=106969
TEST=existing unit/heap/mem checks should cover us. Verified memcheck behavior manually.


Review URL: http://codereview.chromium.org/8925001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106614
TEST=See bug.

Review URL: http://codereview.chromium.org/8872051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24158
TEST=NONE

Review URL: http://codereview.chromium.org/8931005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=chrome builds in a cros chroot (for tegra2).


Review URL: http://codereview.chromium.org/8912012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114283 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that use of GAIA names are considered when handling desktop shortcut changes. Beefed up ProfileInfoCacheTest with a verifier class to ensure this.

BUG=106261
TEST=On Windows, create a new user and sign him into sync with a GAIA account. Ensure that the desktop shortcut changes with the synced GAIA name. Ensure that changing the profile's name or avatar updates the shortcut. Ensure that deleting the profile deletes the shortcut.

Review URL: http://codereview.chromium.org/8894005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114282 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily a rename, with the exception that the initialization of ProxyResolver (i.e. the javascript runtime environment for the PAC script) is no longer done inside of ProxyScriptDecider.

The motivation for doing this is to make it possible to poll our automatic proxy settings (PAC URLs or WPAD) in the background, _without_ needing to feed the scripts into the javascript parser for validation.

There likely won't be any user-visible consequence of this change, however the new mechanism is weaker than the original -- it is possible for the PAC selection to now choose a PAC script which fails to parse as javascript, even though there was a later fallback choice which does parse. This should be rare though (the bad response would need to contain the substring "FindProxyForURL").

BUG=TODO (bugtracker down right now)
Review URL: http://codereview.chromium.org/8896019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114281 0039d316-1c4b-4281-b951-d872f2087c98

ANGLE sends them on lost device, so we don't want to break because of them.


BUG=107369
TEST=


Review URL: http://codereview.chromium.org/8879059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24015
TEST=Manual: see bug description; all grids in WebUI should be layout properly.


Review URL: http://codereview.chromium.org/8923001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114279 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8930016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114278 0039d316-1c4b-4281-b951-d872f2087c98

 This is necessary as widget now needs shell to activate.

BUG=none
TEST=interactive_ui_tests no longer crashes.

Review URL: http://codereview.chromium.org/8937007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114277 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 11079a47.

Revert "Fix build after code changed from underneath."

This reverts commit 93b43a2c.

Revert "Moar build fix."

This reverts commit bf84b576.

Revert "Fix the fix."

This reverts commit 4aecf275.

R=csilv@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8937011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106932
TEST=Manual

Review URL: http://codereview.chromium.org/8885030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105773
TEST=no fuzzy favicons, bug 107269 does not occur

Review URL: http://codereview.chromium.org/8921035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114273 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8938009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8933015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114271 0039d316-1c4b-4281-b951-d872f2087c98

Add an EncryptIfDifferent method that only encrypts something if the underlying
unencrypted data is either different or encrypted with an old key. Modify sync
encryption code to use this method instead of their own difference checks.

Because of this change, we also now always ensure the nigori has the full set of
encryption keys during any SetPassphrase call

BUG=107297
TEST=sync_unit_tests, cryptographer's unit_tests

Review URL: http://codereview.chromium.org/8759019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8907022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114268 0039d316-1c4b-4281-b951-d872f2087c98

Options2 is a copy of the resources for and implementation of chrome://settings that will be pared down significantly for UberPage (see bug).

BUG=100885
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114267 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=

Review URL: http://codereview.chromium.org/8822017

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8898028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114265 0039d316-1c4b-4281-b951-d872f2087c98

Making profile avatars and names sync. This is done by moving these two properties into profile preferences and making them syncable. The profile observes changes to these prefs and pushes them to the profile info cache.

The initialization of these prefs and of the info cache is done in two steps. First, the profile prefs are setup with values generated by the profile info cache. This causes the profile to try to push the changed values to the info cache, but since the profile isn't in the cache, it fails 


BUG=87658
TEST=ProfileManagerTest.InitProfileUserPrefs, Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other.

Review URL: http://codereview.chromium.org/8883030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114263 0039d316-1c4b-4281-b951-d872f2087c98

never allowed to use these ports anyways, this wasn't a
security issue, but just doesn't seem like a good idea.

BUG=93326

Review URL: http://codereview.chromium.org/8898008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://bugs.webkit.org/show_bug.cgi?id=74290
TEST=chrome --enable-threaded-compositing


Review URL: http://codereview.chromium.org/8912002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114260 0039d316-1c4b-4281-b951-d872f2087c98

This application icon index values are being changed from ints to StringOrdinals to decrease the potential number of syncs required when icons are moved, by only needing to change 1 StringOrdinal instead of all the integers.


BUG=61447
TEST=Open up an instance of chromium with multiple application icons and ensure
that icons can still have their page and order changed. There should be no
behaviour change.


Review URL: http://codereview.chromium.org/8198003

TBR=csharp@chromium.org
Review URL: http://codereview.chromium.org/8898027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114257 0039d316-1c4b-4281-b951-d872f2087c98

... Convert copy-and-pasted unit tests into TYPED_TESTs."

This reverts commit 20543ba5.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114255 0039d316-1c4b-4281-b951-d872f2087c98

We are suspecting this has side effects on official builds.

If so, this is a configuration error. Trying out to be sure.

TBR=timurrrr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8898023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114251 0039d316-1c4b-4281-b951-d872f2087c98

Exclude extension unpacking since it accesses the FS.

BUG=93109
TEST=Install an extension from the Web Store.


Review URL: http://codereview.chromium.org/8921023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114248 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r113922.

Win Canary has been failing to link due to OOM since the weekend.  While this was not the original cause, it might be making things worse.  Speculatively remove for now.

Also changes render_widge_host_view to use Owned() instead of Passed().

BUG=none
TEST=existing.

Review URL: http://codereview.chromium.org/8931008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114247 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit bae6675d.

TBR=piman@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8931009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114245 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114244 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erik.corry

Review URL: http://codereview.chromium.org/8935003

TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/8907020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114243 0039d316-1c4b-4281-b951-d872f2087c98

Extract common code from StringPiece and StringPiece16 into a templated base class. Convert copy-and-pasted unit tests into TYPED_TESTs.

The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice.

The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h .

BUG=87634
TEST=

Review URL: http://codereview.chromium.org/8659047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114242 0039d316-1c4b-4281-b951-d872f2087c98

edit link steals focus from menu item which hides edit link button in focus-out-event handler, so, it misses the click event.

BUG=107348
TEST=As described in the bug.

Review URL: http://codereview.chromium.org/8933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114241 0039d316-1c4b-4281-b951-d872f2087c98

Removing plugin data is different to removing only LSO data. Moreover, we call
out to content::PluginDataRemover to do the work: we should have an external
name here that's consistent.

This CL's tests depend on http://codereview.chromium.org/8907015/ 
landing. It shouldn't be landed until that patch is approved. 

BUG=107355
TEST=

Review URL: http://codereview.chromium.org/8907018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8930012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114239 0039d316-1c4b-4281-b951-d872f2087c98