- 09 Nov, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium f692adcf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I78ac9c7e1655a7f118c60849c823946c5733c365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527962Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825538}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1030c88a4bb8..7b6396aaef5b 2020-11-09 miu@chromium.org Standalone Receiver: Integration with ApplicationAgent. 2020-11-09 jophba@chromium.org Add Control Protocol Schemas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I750aa5a82820505d61ea33642b815212c8b9a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825537}
-
Mohamed Adel authored
Change-Id: I435792f47b3d257a4f47fa3f11862dcedbef29cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526460 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825536}
-
Mark Mentovai authored
FruitCo advises that the oah names are deprecated in favor of the Rosetta ones. Bug: 1145672, 1145792, 1142017 Change-Id: I55892a5d9904c718068ecbd2485e7909b57e9a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527964Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825535}
-
David Benjamin authored
Change-Id: Ic8481b3b139e2837683cf917929b7b89ac2c9fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527792 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#825534}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b7f81867ddd..1d532cbd0baa 2020-11-09 primiano@google.com base: set TCP_NODELAY to TCP sockets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibbe152b4bb16110f1ba552e2e91fbba0cc3e2a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525756Reviewed-by:
-
Jacob Kopczynski authored
They aren't in use in any console but are still checked for by the hooks BUG: chromium:1127088 Change-Id: Ibd13b00cfa23b56a3245035bf5b86533705112bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527942 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#825532}
-
Austin Eng authored
This reverts commit c3c7a75c. Reason for revert: FastCall crash on x86 was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2520902 Original change's description: > Disable webgl_conformance_fast_call_tests > > The test suite is failing on Win10 FYI x86 Release (NVIDIA) bot since it > landed. Add rule to stop it from running there. > > Bug: 1144751 > Change-Id: I69fac186a3eacb8dcd262ba88a0d3e29d927908f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512290 > Commit-Queue: kylechar <kylechar@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: kylechar <kylechar@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823265} TBR=ynovikov@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144751 Change-Id: Id055d1bc2eba4e8cbaa93f2677a8988a7744c92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527009Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#825531}
-
Dominique Fauteux-Chapleau authored
Bug: 1109242 Change-Id: I0dc66e30b9936ee9beabea5c61d586890751ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523690Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825530}
-
Ana Salazar authored
Add screen recordings video files type to holding space. Screen recordings are video captures of the contents of the user display. These files will be added in to the screen captures area of the holding space tray and will be treated in the same way as screenshots. Bug: 1144927 Change-Id: I0f47d1670b1bcd0e43d514325962ef3669a84901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518411Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825529}
-
behdad authored
This reverts commit 4d2c7974. Changes since revert: - Code cleanup: Multiple containers are replaced by a map from Frame_id to FrameState, which tracks the number of AddNewFrame/AddResults/Resets received regarding the frame. - Order of variable definition change in scheduler_test_common.h (for dropped_counter) which was causing destruction of FrameSorter prior to Acks being recorded and frames being flushed in some of the scheduler tests. - Added a new test for when reset happens in middle of two AddNewFrame calls with the same frame_id, which depending on the order of acks received afterwards could results into Dcheck failures (initial implementation would not cover such cases). [cc/metrics] Introduce FrameSorter. The begin-frames do not always terminate in the same order as they start. For example, a frame that does not have any updates can terminate earlier than a previous frame that had an update and is awaiting presentation. This can make it tricky to measure dropped-frames in a sliding window. To make this easier, introduce a FrameSorter, that makes sure the sliding-window can process the frames in order, regardless of when they are terminated. BUG=1138552, 1144480, 1145636 Change-Id: Icb8898b0185baa2fa1c8d0c4619f9576acc07fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518696Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825528}
-
wutao authored
Bug: b/171071314 Test: Added new test helper and fixes tests. Change-Id: I22c9fe099025a51c999f2d8fbfa12d983f0aa5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505670 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825527}
-
David Maunder authored
PersistedTabDataStorage is an interface which enables different types of PersistedTabData to be backed by different types of storage. This CL implements the interface for a Level DB data store. The Level DB database is persisted_state_db in native. Bug: 1140773 Change-Id: Ie63dbd4e9fbeb08f1e55e1a2722a47d9566f5d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504215 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#825526}
-
Evan Stade authored
Bug: 1144109 Change-Id: Iba055d3a9876b80f0da828409e2f21b1c5940a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521156 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825525}
-
Collin Baker authored
On restore, a tab could be placed between tabs of another group. This fixes it by placing restored tab to the right of the group. Fixed: 1109368 Change-Id: Ifbc72e92f6539f15e0f92551b3ccfa4735935f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522114Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#825524}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0bec1380d03d..9b7f81867ddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I555b3751d6a5b8d2a39d637fcfeee8170dc04fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527544Reviewed-by:
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/33ece0a9f897..5fa7c4e22c1b $ git log 33ece0a9f..5fa7c4e22 --date=short --no-merges --format='%ad %ae %s' 2020-11-06 wtc Quiet the find_package(libyuv) call 2020-11-06 wtc Miscellaneous cleanup 2020-11-06 wtc Fix miscellaneous comment nits 2020-11-06 wtc Remove disableGridImages from avifDecoder 2020-11-06 sorairolake apps: Add version option 2020-11-06 wtc Move assignment of header->av1C.chromaSamplePosition 2020-11-06 wtc Add #error if AVIF_CODEC_AOM_DECODE/ENCODE undefined 2020-11-06 wtc Cosmetic: Move code to be with related code 2020-11-06 wtc Change avifDecoderReadItem to take avifIO as input 2020-11-06 jdrago Add BEST_QUALITY and FASTEST upsampling filters for easier high-level control over libyuv and filters (...) 2020-10-22 jdrago Fix accidental stomp of AVIF_PLATFORM_LIBRARIES CMake variable 2020-10-22 jdrago Fix various macOS/clang build issues 2020-10-22 jdrago Expose libyuv availability to API and cmdline tools 2020-10-22 jdrago Basic libyuv support, first pass 2020-10-22 wtc Fix a crash in avifJPEGRead() on fopen() failure 2020-10-19 wtc Link with {ZLIB_LIBRARY} after ${PNG_LIBRARY} 2020-10-16 wtc Remove unneeded libs and includes for svt and aom 2020-10-15 wtc Add size_t casts to fix MSVC x86 compiler warnings 2020-10-15 jdrago Various fixes to SVT-AV1 PR #369 2020-10-15 jon add SVT-AV1 encoder Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: I5f6478281b769124d8f1b975b3d3dc27a70bc7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524292 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825522}
-
Antonio Gomes authored
Dependency/include graph: - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org TBR=oshima@chromium.org Change-Id: I9a174c9daa9674380605805649496039d543a0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521706Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#825521}
-
Roman Arora authored
- Change search field font to inherited one - Move shortcut text to a side in a div Bug: 1145608 Change-Id: I6e6926c9d7a6a843072950e2fd0f31eaaf0df747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521097 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825520}
-
Mark Pearson authored
This reverts commit 96a972a1. Reason for revert: PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch is flaky on https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 It failed 4 out of the last 25 builds. https://screenshot.googleplex.com/8bGbnEgxTnyrXk9 When I say failed, I mean it failed on both the original run and the re-run (i.e. failed twice in a row), which turns the bot read. The failures look like [ RUN ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch [20276:19520:1109/002722.827:ERROR:device_event_log_impl.cc(211)] [00:27:22.827] Bluetooth: bluetooth_adapter_winrt.cc:1073 Getting Default Adapter failed. ../../chrome/browser/net/private_network_request_browsertest.cc(171): error: Value of: GetAddressSpaceFeatureBucketCounts(histogram_tester) Expected: has 1 element that has a first field that is equal to WebFeature::kAddressSpaceLocalEmbeddedInPublicSecureContext, and has a second field that is equal to 1 Actual: {} Stack trace: Backtrace: `anonymous namespace'::PrivateNetworkRequestBrowserTest_RecordsAddressSpaceFeatureForFetch_Test::RunTestOnMainThread [0x00007FF66FF0A4D5+1211] (o:\chrome\browser\net\private_network_request_browsertest.cc:168) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF673CD884D+683] (o:\content\public\test\browser_test_base.cc:770) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF673B2F126+4442] (o:\chrome\browser\chrome_browser_main.cc:1664) ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF673B2DF05+65] (o:\chrome\browser\chrome_browser_main.cc:1033) content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF672089943+73] (o:\content\browser\browser_main_loop.cc:991) content::StartupTaskRunner::RunAllTasksNow [0x00007FF67242BE1F+61] (o:\content\browser\startup_task_runner.cc:41) content::BrowserMainLoop::CreateStartupTasks [0x00007FF6720886AC+594] (o:\content\browser\browser_main_loop.cc:905) content::BrowserMainRunnerImpl::Initialize [0x00007FF67208B38A+126] (o:\content\browser\browser_main_runner_impl.cc:130) content::BrowserMain [0x00007FF672086E9D+161] (o:\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00007FF6729DADC5+89] (o:\content\app\content_main_runner_impl.cc:521) content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6729DBA61+849] (o:\content\app\content_main_runner_impl.cc:1008) content::ContentMainRunnerImpl::Run [0x00007FF6729DB6E2+330] (o:\content\app\content_main_runner_impl.cc:886) content::RunContentProcess [0x00007FF6729DA561+805] (o:\content\app\content_main.cc:372) content::ContentMain [0x00007FF6729DA8DE+61] (o:\content\app\content_main.cc:398) content::BrowserTestBase::SetUp [0x00007FF673CD8452+1772] (o:\content\public\test\browser_test_base.cc:605) InProcessBrowserTest::SetUp [0x00007FF673A1EFA6+398] (o:\chrome\test\base\in_process_browser_test.cc:347) [20276:19520:1109/002727.767:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown. [ FAILED ] PrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetch, where TypeParam = and GetParam() = (5267 ms) Original change's description: > [CORS-RFC1918] Selectively re-enable broken test. > > This change enables the test except when a conflicting feature is > enabled. It improves on the status quo (test disabled everywhere) until > the underlying failure can be fixed, letting the test run on all CI bots > except for the offending Network Service bot. > > Bug: chromium:1142865 > Change-Id: I4bb870d04c6b35961c1c32d9d3549d03afeaa3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519693 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824400} TBR=mmenke@chromium.org,titouan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1142865 Change-Id: I65320686b457fcbe21211c0091abf9218a728b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528123Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Daniel Cheng authored
This eliminates the need to cast the scoped enumeration to an integral type, and updates the enum to use the kMaxValue convention which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION() Bug: 742517, 1047547 Change-Id: I35c9d7cc03d15bcec530b599b459a94e4f975672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524932Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825518}
-
yjliu authored
Bug: 1147099 Change-Id: Ib8c822644ee3f12b75c585cfa07a255594974b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527842 Commit-Queue: Jun Liu <yjliu@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#825517}
-
Brian Malcolm authored
BUG=chromium:1095910 Change-Id: Ib7079bb2c2c32e3923366e95a48345745e243623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525859 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825516}
-
Cathy Li authored
Change-Id: Iff1cbc45639609b911cb3b56d72504988c5791bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526930Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#825515}
-
Bruce Dawson authored
The linux archive for bisecting of builds has not been added to since March of 2016. This leads to cryptic error messages and confusion, as seen here, when trying to debug builds since then: https://groups.google.com/a/chromium.org/g/chromium-dev/c/IHfbPh0iYwE This change adds range checking so that if the reason for a lack of sufficient builds to bisect is specifying out-of-range revision numbers there will be a helpful error message. It also adds a special-case check for linux and suggests linux64 as an alternative. Another bit of confusion in that same thread was the specifying of branch numbers instead of revision numbers. Since the ranges for these numbers do not overlap (and will not overlap in the next century) this change prints a message about revision versus branch numbers if the max_rev is less than the available bisect range. There are still an infinite number of ways of misusing bisect-builds.py but this should clean up a few of the ones which have been hit. Change-Id: I774e912fe131ae6fce360301fc053d0a3d0f9852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524293Reviewed-by:
-
Etienne Bergeron authored
This CL is fixing a corner case detected by the render_text_api_fuzzer. The eliding of an invalid email address is triggering a DCHECK to tail. const size_t split_index = email.find_last_of('@'); DCHECK_NE(split_index, base::string16::npos); The RenderText API is assuming a well formatted email when eliding with ELIDE_EMAIL. There is no guarantee that the user input will be formatted correctly and this can leads to strange crashes. This CL is 1) Adding support for invalid email 2) Adding unittests to cover basic cases of ELIDE_EMAIL 3) Replace the use of GetStringWidthF by GetStringWidthForText which ensures the styles/fonts (and glyph_width_for_test) are propagated R=msw@chromium.org,gab@chromium.org Bug: 1085014, 1146455 Change-Id: I669b7388b5ffa561d4585e7fbea9212c95671a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523411 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#825513}
-
Sergey Ulanov authored
1. Increased size used for input buffer collections used in decryptor and video decoder from 512kB to 1MB (see linked bug). 2. Reduced input buffer size used in the audio decryptor from 512kB to 128kB 3. Removed code that sets min_buffer_count_for_camping for input buffer collections in video decoder and decryptor. min_buffer_count is set to 2 instead. 4. Removed code that sets packet_count_for_(server|client) in the buffer constraints passed to StreamProcessor. These values are currently ignored in decoder and decryptor. Overall these changes reduce total amount of memory allocated for contiguous buffers during video playback, while allowing for larger video packets. Bug: b/172081397 Change-Id: Ieaa550fa86f8c276cc4dcb945249a364a0a2c74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519150 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825512}
-
Kenneth Russell authored
kbr leads the WebGL and khushalsagar the OOP-raster portions of this interface and should be able to approve changes to it. Bug: 1063437 Change-Id: I003cd3ab137d2768ab65cf7c0aa56b91e95d3733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524122Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#825511}
-
Alex Moshchuk authored
Previously, when LockProcessIfNeeded() was called for SiteInstances without a site, it only ensured that the resulting process has an allow-any-site lock. However, when LockProcessIfNeeded() is called on the same process more than once, such as when it gets reused by different BrowsingInstances with blank SiteInstances, this is insufficient. We also need to call IncludeIsolationContext() to inform ChildProcessSecurityPolicy of new BrowsingInstances. This is required for relanding https://crrev.com/c/2446370, where ChildProcessSecurityPolicy will start keeping track of a list of BrowsingInstances for each process, and not doing this would lead to mismatched process locks and crashes. Bug: 1135539 Change-Id: Ie7b5320cb5a2101d9685169cf6eba254178165fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523732 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825510}
-
Ionel Popescu authored
This CL updates the default background-color of the popup to transparent instead of white. Doing this we avoid having a white flash on popup open when dark color-scheme is used, as the default background color of the popup is white. For more details: http://crrev.com/c/2517730. Bug: 1114272 Change-Id: Ia9676bba7c343bd0b18f9be4ea38d94dcacc3899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525601Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Toni Barzic authored
BUG=None Change-Id: I8618a3cd47732d94ed7e43ab64cceaf6108e9c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524061Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL adds an argument option to modularization LOC stat generator script so it can output the result to a specified file in json format. Also relocated the script under //tools/android. Bug: 1146478 Change-Id: I6d24b467e7ac64116461aec7780f6fb9a20da03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521982Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825507}
-
Akihiro Ota authored
This change: 1. Adds logic to localize the practice area 2. Adds tutorial strings to chromevox_strings.grdp 3. Removes unused strings, such as those spoken after a key sequence is pressed. 4. Removes the text fields lesson, which was initially added as a proof-of-concept. 5. Removes practice area state announcements, which was also initially added as proof-of-concept. Bug: 1075752, 1143480 Change-Id: Ia564736023530b87a604d1e12164eda1ad96528a AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520168 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825506}
-
Nate Chapin authored
Merge NavigatorPresentation and Presentation, so that Presentation is the Supplement<Navigator> Simplify eager initialization from ModulesInitializer. Currently, ModulesInitializer calls PresentationReceiver::From(), which calls NavigationPresenation::presentation() to initialize the NavigatorPresentation, Presention, and PresentationReceiver. It then reads the PresentationReceiver off the Presentation and returns it, even though the return value is unused. After this CL, ModulesInitializer calls Presention::presentation(), which initializes both Presention and PresentationReceiver, and still ignores the return result. This also makes Presention explicitly aware of the conditional initialization of PresentationReceiver based on Settings. Change-Id: I4ee01f0b501eb1cb8a2c49de0ed62cfab75bd895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518761Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#825505}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I690e9976244794f766c60bd9c7ba28461cbbce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523730 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825504}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bashi@chromium.org Change-Id: Id51f8577aaf6248d49a8378cbf14e97d7e69f1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526904 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825503}
-
Ali Juma authored
This deletes the SafeBrowsingAvailableOnIOS feature flag since the feature has been enabled by default and shipped to 100% of Stable. This also deletes code related to detecting WebKit-provided Safe Browsing warnings, since WebKit-provided Safe Browsing is disabled unconditionally. Bug: 1028755 Change-Id: Idae751f84aa274ffdd8b17a5660a752fa19de8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522907Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#825502}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b674f8a27725..934ac6ebdf6b 2020-11-09 gavinmak@google.com [depot_tools] Add --fork-point when computing merge-base 2020-11-09 sokcevic@google.com Set default branch in fake_repos 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111269,chromium:1144918 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I52c22bb41b43627128dad628dd3dec4b977af9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527665Reviewed-by:
-
Eric Orth authored
Another case of the apparently poor job I did adding in the malformed vairant of HttpsRecordRdata. ServiceFormHttpsRecordRdata::IsEqual() did not check if the input was malformed before casting to service form. Fix is to check before casting, and also to use the AsServiceForm() helper instead of a raw cast, as the helper has the CHECKs designed to make bugs like this obvious. Fixed: 1146873 Change-Id: I5222a09c9c032bc163ca1beebf4bf1e0504ccad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526931 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#825500}
-
My Nguyen authored
Amharic, Bengali and Burmese are still under discussion Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/8yAKy4aHVk8hLSp Bug: 889763 Change-Id: If1256942d3f57cef5c6fa563937605bf374179b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524804Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825499}
-
