- 09 Mar, 2020 40 commits
-
-
Kent Tamura authored
This CL renames HTMLSelectElement::OptionToBeShown() to OptionToBeShownForTesting() because it is used only by testing code. This CL has no behavior changes. Bug: 1052232 Change-Id: I8522a59be99958be526fd59f4494860755666254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094520Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#748131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a77d0ef73e6b..43f79a1d77b2 Created with: gclient setdep -r src-internal@43f79a1d77b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I102ada0f3cbb2c20e4acb64c414418620230d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094680Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748130}
-
Kenichi Ishibashi authored
The bug was fixed and we don't observe flakiness any longer. Remove the instrumentations. Tbr: kinuko@chromium.org Bug: 946719 Change-Id: I7f31002516f2507a7205ab5c2680ebcf3f748e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094375 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#748129}
-
S. Ganesh authored
The display name changes from the format "Google Chrome Elevation Service" to "Google Chrome Elevation Service (GoogleChromeElevationService)". Bug: 1059459 Change-Id: I3505a1c2fea6deee66e7d2395a7e9594e76dc95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092671 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748128}
-
Hiroki Nakagawa authored
This CL makes DedicatedWorkerHostFactoryImpl use its |parent_execution_origin_| (renamed to |creator_origin| by this CL) for starting a dedicated worker instead of an origin passed from a renderer process. This was not feasible before because |parent_execution_origin_| is provided from parent's |RenderFrameHostImpl::last_committed_origin_| that is set during navigation commit. Worker creation IPC from the renderer to browser could race with navigation commit, and could see the wrong last committed origin. Now this is feasible. This is because worker creation IPC is now tied with RenderFrameHostImpl's BrowserInterfaceBroker that is re-bound during navigation commit[*]. This ensures that worker creation requests issued before the navigation commit are discarded by the previous BrowserInterfaceBroker, and new requests via the new BrowserInterfaceBroker are scoped to the new last committed origin. [*] The call path between binding BrowserInterfaceBroker and updating the last committed origin is as follows. These are synchronously done. - RenderFrameHostImpl::DidCommitNavigation() re-binds the interface broker https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/render_frame_host_impl.cc;l=7489;drc=d54ee0c3d25dfc644282b50c5f57e23b7ab4dda4?originalUrl=https:%2F%2Fcs.chromium.org%2F -> RenderFrameHostImpl::DidCommitNavigationInternal() -> NavigatorImpl::DidNavigate() -> RenderFrameHostImpl::DidNavigate() -> RenderFrameHostImpl::SetLastCommittedOrigin() Change-Id: Id69c3d66e50aa8cbb7fee520a1479b28970de1c6 Bug: 906991, 1030909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971660Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#748127}
-
Alan Cutter authored
This is part of an experimental implementation of tabbed web app windows hidden behind the DesktopPWAsTabStrip flag. This CL adds a UI option for Chrome OS that lets users assign individual web apps to be opened in the experimental tabbed window. Because this option is experimental and users may turn the flag off at any time we do not store this setting in the same place as the launch container setting. Instead we store it in a per web app "experimental_tabbed_window_mode" pref. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=436695&signed_aid=pNFo1z1fXrwGgoTkDSgTXA==&inline=1 Bug: 897314 Change-Id: Ie0a9417e38fd0cfc593d93b5b97224742b37d841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086465 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#748126}
-
Kei Nakashima authored
LinkedListInVector maintains a linked list in a vector. It uses prev/next indices instead of pointers. Implemented iterators and insert functions. Change-Id: I7e15734b5c209618c4760efe65b7e68f1f827b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089543Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#748125}
-
Noel Gordon authored
Some styles need to be avoided if Files app <html> is in a .col-resize CL:1851789 to avoid scrollbars. Detect with simpler class selector. Bug: 992819 Change-Id: Ic38a719ea5d6d8fd485d81f398630e0fad3ef1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094464 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748124}
-
Raul Tambre authored
__hash__() isn't defined by default in Python 3 if __eq__() is user-defined. This fixes NameStyleConverter being unhashable in Python 3. The default __hash__() in Python 2 is defined in terms of id(self), i.e. identity-based hashing. However, since the custom __eq__() is defined in terms of value equality, this is probably unintended and a bug. Thus this CL also changes behaviour by defining __hash__() in terms of hash(self.original), i.e. value-based hashing. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 80, in <module> json5_generator.Maker(FeaturePolicyFeatureWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 44, in __init__ fp_origin_trial_dependency_map[feature['name']].append( TypeError: unhashable type: 'NameStyleConverter' Bug: 941669 Change-Id: Ie7811c7a5e0620376bf01c0d91a2c14043c85293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093491 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:Kent Tamura <tkent@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#748123}
-
Findit authored
This reverts commit 63c4f9f5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 748116 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzYzRmOWY1NDU1NDEyOGEwOGM3ZWU1YTU3N2I1YjBhZmRlMjZjZjMM Sample Failed Build: https://ci.chromium.org/b/8886328647561495520 Sample Failed Step: compile Original change's description: > Adds slotAssignmentMode to the shadow root bindings. > > Prior to this CL, the previous implementation of imperative slot API uses > 'slotting' as an optional parameter for Element.attachShadow(). However, > based on the feedback by JanMiksovsky@ in > https://github.com/w3c/webcomponents/pull/866, the parameter should be > changed to 'slotAssignment' to make it align with other members, > assignNodes(), assignElements(). I agree with this feedback. > > This CL updates the following: > 1. update bindings where the previous 'slotting' was used to > 'slotAssignment'. > 2. Updated the enum type of slotAssignment. It should be, > SlotAssignmentMode [auto | manual]. > 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated > global-interface-listing-expected.txt. > 4. Modify existing tests from using slotting to slotAssignment. > 5. Removed test that'll be covered by > external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html. > https://chromium-review.googlesource.com/c/chromium/src/+/2083742 > I'll update this CL with the correct > slots-imperative-slot-api.tentative-expected.txt once that CL lands. > > Bug: 869308 > Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376 > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748116} Change-Id: I180387fec3b6ad9d9306d20f57783e16657b39de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094815 Cr-Commit-Position: refs/heads/master@{#748122}
-
Rachel Wong authored
Bug: 1014839 Change-Id: Id8d23da26d5d5fa796f3f53e921ac1d7adccb34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093958Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748121}
-
Jiewei Qian authored
This CL adds support for system web apps to enable origin trials. It uses WebAppTabHelper to enable origin trials on ReadyToCommitNavigation. Works when launching SWA from shelf or when being navigated to in a tab. Under the hood, it adds a new ForceEnableOriginTrials method to NavigationHandle, which sets the origin trials for this navigation. Internally, the trials are saved to commit_params. When RenderFrame commits this navigation, it passes the origin trial information to blink via WebNavigationParams. The DocumentLoader then enables the provided trials. Fixed: 1024655,1043842 Change-Id: I4030575c21454c0addb4953992149cdd4ee6ffe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038511Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#748120}
-
Abhijeet Kandalkar authored
This CL has two goals to use new downcast helper for blink::LayoutTextControl & blink::LayoutTextControlSingleLine. Bug: 891908 Change-Id: I721ae55a1252a79b03575d5f2cd1c2a7ad3a0727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016697 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c56950442dd1..1987b8f36714 git log c56950442dd1..1987b8f36714 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 51b2800bb317..b44162fdbb25 (2 commits) Created with: gclient setdep -r src/third_party/skia@1987b8f36714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Id18407bd88522b3e1fd3b85d0e97232d6c940913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04f7bfc4192f..39be828c846a git log 04f7bfc4192f..39be828c846a --date=short --first-parent --format='%ad %ae %s' 2020-03-09 deadbeef@webrtc.org Add commas between codec parameters in VideoReceiveStream logging. 2020-03-06 zetilovn@google.com Remove old FakeVP8Encoder alias. Created with: gclient setdep -r src/third_party/webrtc@39be828c846a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic2af139fde4855d8507d2f79f98b55883c493c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094678Reviewed-by:
-
Yu Han authored
Prior to this CL, the previous implementation of imperative slot API uses 'slotting' as an optional parameter for Element.attachShadow(). However, based on the feedback by JanMiksovsky@ in https://github.com/w3c/webcomponents/pull/866, the parameter should be changed to 'slotAssignment' to make it align with other members, assignNodes(), assignElements(). I agree with this feedback. This CL updates the following: 1. update bindings where the previous 'slotting' was used to 'slotAssignment'. 2. Updated the enum type of slotAssignment. It should be, SlotAssignmentMode [auto | manual]. 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated global-interface-listing-expected.txt. 4. Modify existing tests from using slotting to slotAssignment. 5. Removed test that'll be covered by external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html. https://chromium-review.googlesource.com/c/chromium/src/+/2083742 I'll update this CL with the correct slots-imperative-slot-api.tentative-expected.txt once that CL lands. Bug: 869308 Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748116}
-
Mitsuru Oshima authored
3000x2000 panel uses the scale factor that procuess 1332x888 dp size. This scale causes 1px larger vertical size when ceiled due to very small error (2000.00012207..) Bug: 1050105, b/149022007 Test: covered by unittets. Change-Id: I745ca422dc5f35474dc64d489631a20f34f65b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071177Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748115}
-
Maggie Cai authored
This test is flaky on https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2309. BUG=1059645 TBR=tkent@chromium.org Change-Id: I3e96afa16ec0f7781aac489dffe744b3066fdf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094418Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748114}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/213a50aaa32d..0268f16c7e98 git log 213a50aaa32d..0268f16c7e98 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@0268f16c7e98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a251bf318d489edc0c9545e0664efd1db6b0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094677Reviewed-by:
-
Makoto Shimazu authored
Currently Cross-Origin-Embedder-Policy header is parsed in ServiceWorkerNewScriptLoader when launching a new service worker. However, the COEP in the response header for the main script isn't applied for the network loader created on launching a service worker because the network loader is created before starting to load the main script. This CL is to pause the service worker's script evaluation until the main script is loaded. Once the main script loaded, new subresource loaders are created by using the COEP value, and they are sent to the service worker. Imported scripts also need to refer to the new value, but the loaders are in different place (ServiceWorkerScriptLoaderFactory), so it'll be addressed in a later patch. Bug: 1039613 Change-Id: Ice82eef86beec2f2f5c5e91f3aa136229f14c3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029403 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748112}
-
Yuzu Saijo authored
This CL intends to change the existing android-bfcache bot which runs on FYI waterfall to use the release build. Our long term goal is to make this a CQ bot. Bug: 1042160 Change-Id: Ie92a9e9da01cd5eb21162c3e7d40f5c2b6a889a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087862Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#748111}
-
Maggie Cai authored
This reverts commit 10bfb977. Reason for revert: This CL seems cause build failure since https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4651 Original change's description: > Origin policy: implement window.originPolicyIds > > This plumbs the origin policy IDs from the net-side OriginPolicyContents > through to the renderer, where they get exposed on Window. This does not > yet tackle WorkerGlobalScope, but it does add idlharness tests for it, > which fail for now. > > Bug: 1057123 > Change-Id: Ie611f03bab99ccdaa6221733d9305cf2323a129e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089994 > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747893} TBR=dcheng@chromium.org,domenic@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057123 Change-Id: I341fd06c5587bc05ea110307251ad9eb19365433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093453Reviewed-by:
-
Ting Shao authored
Add perf tests to cover more Cache Storage APIs and also extend WorkerTestHelper to support measuring time in worker. All the Cache Storage perf tests cost 33 seconds on a machine: CPU: Intel Core i7-4790 @ 3.6 GHZ RAM: 32G Design doc: https://docs.google.com/document/d/1bGBWHAsIsrQ0hrjU7oEVAcGSBS9gFSPcDL9nVWXDeeE/edit Bug: 1019097 Change-Id: I0c5adb9524d75dd8a7d84e10a14ef55a3b941473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008191 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748109}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ff3f116a334..a77d0ef73e6b Created with: gclient setdep -r src-internal@a77d0ef73e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I828160c34daa49c287446713332486646488de18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094539Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f82a6e5ffe7..213a50aaa32d git log 2f82a6e5ffe7..213a50aaa32d --date=short --first-parent --format='%ad %ae %s' 2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@213a50aaa32d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf72885acc2831c515a574e37b55e373ad793ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094675Reviewed-by:
-
Maggie Cai authored
This test is flaky on multiple builders. And I cannot find a CL that look suspecious. Disable this test for now. BUG=1059632 TBR=nasko@chromium.org Change-Id: I19c7a021f526833a5187f17361c4b07d88f77a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094518Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I6c4859b2213f37ff6fdbffb37177513e80448f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094459Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748105}
-
Kent Tamura authored
and rename it to MaximumOptionWidthMightBeChanged(). This CL has no behavior changes. Bug: 1052232 Change-Id: Ifb891a8c0bfb916075f44460ef85be301982932c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094475Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#748104}
-
Maggie Cai authored
This reverts commit 4e6e084b. Reason for revert: This CL is likely to cause the build failure for https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3799 and https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/68656 (first failure linked). Original change's description: > Use Mojo for Pointer Lock Requests > > Pointer lock requests were still using the old IPC workflow. This > updates the call to use Mojo. > > Bug: 1042293 > Change-Id: I5b3b58b56f37fd8ea3fb5960579340fc0d72514a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028453 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748021} TBR=sky@chromium.org,danakj@chromium.org,dcheng@chromium.org,scheib@chromium.org,sammc@chromium.org,dtapuska@chromium.org,odejesush@chromium.org,jameshollyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042293 Change-Id: I38dd8c8c881e03c878fa9c85846e04f35ff6f661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094517Reviewed-by:
-
Jiawei Shao authored
This patch implements the destructor of Blink::GPUDevice so that when it is destroyed in Blink, all the related data structures in both the client and service side of WebGPU command buffer can also be destroyed. BUG=chromium:996713 Change-Id: Ibe11aabf395d2dfa33ae3ccfa404d250ffd4c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088690Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#748102}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ibe7d51b4b2afe9697ca689ab9998433ab7eba5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094189 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748101}
-
Luciano Pacheco authored
Fixes: 1058532 Change-Id: I5acbc019aed63ebf55394bb2bc4bc8654e136439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094578 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748100}
-
Yu Han authored
Previous to this CL, Imperative shadow DOM Slot API was put on hold. A previous implementation is still in place but disabled. Since then, in 2019 TPAC F2F, the Imperative Slotting API behavior has been updated. This CL adds new test cases which reflects this new behavior for Imperative Shadow DOM API. They are turned off for now, but will be enabled one by one as its functionality gets implemented. This is the post for I2P: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TNYIAu5E_M4 Bug: 869308 Change-Id: Ie875a3eb2b349942b6aa51af387460c470572491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083742 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
-
Raul Tambre authored
../../base/containers/checked_range_unittest.cc(49,17): error: call to 'size' is ambiguous static_assert(size(array) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::__1::array<int, 5>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::__1::array<int, 5>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ ../../base/containers/checked_range_unittest.cc(62,17): error: call to 'data' is ambiguous static_assert(data(il) == range.data(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1932,22): note: candidate function [with _Ep = int] constexpr const _Ep* data(initializer_list<_Ep> __il) noexcept { return __il.begin(); } ^ ../..\base/stl_util.h(146,20): note: candidate function [with T = int] constexpr const T* data(std::initializer_list<T> il) noexcept { ^ ../../base/containers/checked_range_unittest.cc(63,17): error: call to 'size' is ambiguous static_assert(size(il) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::initializer_list<int>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::initializer_list<int>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ ../../base/containers/checked_range_unittest.cc(164,17): error: call to 'size' is ambiguous static_assert(size(array) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::__1::array<int, 0>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::__1::array<int, 0>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ Bug: 752720 Change-Id: Icac3e6118db2e2fefa288ce23386b75714d1b979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094295 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: -
Noel Gordon authored
The iconSet property of most volume types is empty, but we expect that third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System Providers) should provide icons in their iconSets. File System Providers icons are filtered via CSS, to try and create an "active" state icon for their directory tree tab [1]. The filtered icon can have poor visual quality, depending on the icon, but ANDROID_FILES, DOCUMENT_PROVIDERS icons are left alone - we do not try and filter them. Make File System Providers join the party, do not try and filter them either. [1] iconsSets do not provide "active" icon variants. Bug: 992819 Change-Id: I675f465d25ac45afdb669657d3a22c24a02ecf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094516Reviewed-by:
-
Sara Kato authored
Test: None (build passes) Bug: None (internal cleanup) Change-Id: I91e3351f2ac345c34f5e8f36566fa7f541a08275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094577Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748096}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I205ee64f8fc092002c0a4f5ba3d7479b771859d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094537Reviewed-by:
-
Hugo Benichi authored
This patch removes net.mojom APIs and fields only used in ARC N: - NetworkConfiguration mac_address: the host mac_address of a network is now completely hidden in ARC P. - GetDefaultNetwork and DefaultNetworkChanged: ARC P is multinetwork aware and always need the full list of connected services. BUG=b:149716479 BUG=b:145960788 TEST=Compiled, flashed eve, ran CtsNetTestCases. Change-Id: I3368d620d44dd910aae7a12c84c207c3d5cb6cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086362Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#748094}
-
Jae Hoon Kim authored
If Plugin VM was installed prior to DLC support being added, PluginVM will fail to launch as the rootfs components will be removed. This CL updates the launch flow to attempt installing the Plugin VM DLC if the dispatcher fails to launch. This also allows us to recover from unexpected errors where the DLC module might get uninstalled or fail to be updated. BUG=b:150867372 TEST=out/Default/unit_tests && out/Default/browser_tests # with PluginVM filters Change-Id: I9ed6287bf1a35d38778003e8f629166fa5b8dfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090619 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/475b9d0fb796..c56950442dd1 git log 475b9d0fb796..c56950442dd1 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 martin@mainframe.co.uk fall back to vswhere.exe to find msvc Created with: gclient setdep -r src/third_party/skia@c56950442dd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I3f4713ddfadee630ece8ccef553d0488aa2543a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094536Reviewed-by:
-
