Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 01 May, 2017 6 commits
    • avi's avatar
      Switch SupportsUserData uses to use unique_ptr. · 83fe36db
      avi authored 
      The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2847353002
Cr-Commit-Position: refs/heads/master@{#468268}
      83fe36db
    • thestig's avatar
      Disable 2 flaky tests. · e578e69e
      thestig authored 
      - NSS/ClientCertStoreTest/CertAuthorityFiltering
- DeviceDescriptionServiceTest.TestCleanUpCacheEntries

BUG=716730,716810
TBR=mattm@chromium.org,zhaobin@chromium.org

Review-Url: https://codereview.chromium.org/2850083002
Cr-Commit-Position: refs/heads/master@{#468267}
      e578e69e
    • bashi's avatar
      Record swap metrics · 4159f36e
      bashi authored 
      This CL adds SwapMetricsObserver which records swap rates and reports
them as platform-specific metrics. The purpose of adding these metrics
is to measure the impact of actions we take to free up memory. If we
aggressively free up memory under high memory pressure, we may touch
pages which are already swapped out (or compressed). In such cases
thrashing could happen and we are making the situation worse.
Swap rates and page compression/decompression rate would be good
indicators of thrashing. Metrics will be recorded every 60 seconds.

This CL only adds metrics for Android/ChromeOS/Linux. Follow-up CLs
will add them for macOS.

BUG=617492

Review-Url: https://codereview.chromium.org/2824133002
Cr-Commit-Position: refs/heads/master@{#468266}
      4159f36e
    • raymes's avatar
      Make media permission requests go through the PermissionManager · 96988fae
      raymes authored 
      This CL adds a feature flag which, when enabled, causes media requests to call
into PermissionManager::RequestPermissions in order to display a permission
prompt (among other things). The feature flag is added because this results in
the UI changing, and also won't work on Android until we have unified the
permission request codepaths (see https://crbug.com/606138).

BUG=596786

Review-Url: https://codereview.chromium.org/2829123003
Cr-Commit-Position: refs/heads/master@{#468265}
      96988fae
    • tkent's avatar
      wpt-import: Fix a failure on "git add" · 9b549cec
      tkent authored 
      This CL fixes a regression since r467828. It changed the working directory, but
it missed to update relative path in "git add" argument.

BUG=710535
TBR=jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2848183002
Cr-Commit-Position: refs/heads/master@{#468264}
      9b549cec
    • thestig's avatar
      Revert of Change ScopedFeatureList to overrides FeatureList not reset... · 6c14f269
      thestig authored 
      Revert of Change ScopedFeatureList to overrides FeatureList not reset (patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )

Reason for revert:
Mac ASAN bots reporting use-after-free errors.

Original issue's description:
> Change ScopedFeatureList to overrides FeatureList not reset
>
> The current situation is that using ScopedFeatureList resets to an
> empty feature list and then enables/disables an explicit list of
> features.
>
> That's never what you want for browser tests (or other higher-level
> tests) since it effectively overrides higher-level test configurations
> (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> specifically test a feature).
>
> In this patch:
>
> 1. Keep SFL::Init, SFL::InitWithFeatureList,
>    SFL::InitFromCommandLine reset to empty list but add warning to
>    remind developer should use them with care.
> 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
>    SFL::InitWithFeatures to not reset but override current FeatureList
>    with given enables/disables.
>
> We also add unit tests for ScopedFeatureList.
>
> BUG=713390
>
> Review-Url: https://codereview.chromium.org/2834583002
> Cr-Commit-Position: refs/heads/master@{#468210}
> Committed: https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e8981e6738881a9

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390

Review-Url: https://codereview.chromium.org/2850073002
Cr-Commit-Position: refs/heads/master@{#468263}
      6c14f269
  3. 30 Apr, 2017 13 commits
  5. 29 Apr, 2017 21 commits