GitLab

We had some non-const references that broke the style guide. This
patch removes them.

BUG=551696

Review URL: https://codereview.chromium.org/1434403006

Cr-Commit-Position: refs/heads/master@{#360603}

This method has the common code to update SignedCertificateTimestamps
This code was duplicated in openssl and nss.

QUIC will be calling the following method soon.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1452053005

Cr-Commit-Position: refs/heads/master@{#360602}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/767df2b5..f6d90d29

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1459173002

Cr-Commit-Position: refs/heads/master@{#360601}

This has been pointed out in https://goo.gl/CRH4Dz.

This CL unifies the imorts/includes for url_scheme_util.h in particular,
to keep the result of the other CL consistent.

There are likely more files like that in the code-base, but switching
them all would require scripting. The benefits are not clearly supporting
such effort.

R=eugenebut@chromium.org
BUG=514241

Review URL: https://codereview.chromium.org/1458073002

Cr-Commit-Position: refs/heads/master@{#360600}

BUG=370966,558025

Review URL: https://codereview.chromium.org/1455063003

Cr-Commit-Position: refs/heads/master@{#360599}

- Moving tests to use EmbeddedTestServer where possible.
- net::test_server::EmbeddedTestServer references to net::EmbeddedTestServer
- Using server.Start() instead of server.InitializeAndWaitUntilReady()
- Renaming test_server() to be spawned_test_server() or embedded_test_server()
- Enabling tests disabled due to SpawnedTestServer compatibility

BUG=496825
TBR=brettw@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/1431653003

Cr-Commit-Position: refs/heads/master@{#360598}

We had callers of SetIsDraftMode, but no code that actually queried
for that metadata. This helps us get rid of platform_device.h.

Since [Set]IsPreviewMetafile() is only used on Mac, remove ifdef
that also built those functions on Windows.

BUG=543755
R=halcanary@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/1457033002

Cr-Commit-Position: refs/heads/master@{#360597}

During the tests, the changes to the content width cause the page scale
factor to be changed to fit the content. We lock the page scale factor
to prevent this from happening and impacting performance.

The performance regression is caused by the sending of notifications
upon all changes to page scale factor whereas previously, these
notifications would not have been sent.

See https://codereview.chromium.org/1408393003/ where this behaviour
was changed.

BUG=555151

Review URL: https://codereview.chromium.org/1457013002

Cr-Commit-Position: refs/heads/master@{#360596}

This instrumentation is no longer providing any value for the jank dashboard.

BUG=436671

Review URL: https://codereview.chromium.org/1456123002

Cr-Commit-Position: refs/heads/master@{#360595}

It was done in https://codereview.chromium.org/1149243005/

Review URL: https://codereview.chromium.org/1461763003

Cr-Commit-Position: refs/heads/master@{#360594}

Including some cleanups:
 use forward declaration, remove STLDeleteValues. use scoped_ptr in std::map

R=rockot@chromium.org
BUG=555865

Review URL: https://codereview.chromium.org/1452793002

Cr-Commit-Position: refs/heads/master@{#360593}

Implements AddStartupEventsForTelemetry() in startup_metric_utils.cc for in-coming startup telemetry benchmarks using TBM.

BUG=539287
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1410943005

Cr-Commit-Position: refs/heads/master@{#360592}

telemetry_tests

Also remove telemetry_perf_unittests on win xp platform since we no
longer support win xp on perf waterfall.

BUG=507796

Review URL: https://codereview.chromium.org/1461833002

Cr-Commit-Position: refs/heads/master@{#360591}

base::CommandLine will DCHECK if it sees a flag with uppercase letters.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1452823009

Cr-Commit-Position: refs/heads/master@{#360590}

Add a call to SetFillsBoundsOpaquely(false) in
ToolbarButton::AddInkDropLayer() and
AppMenuButton::AddInkDropLayer(). This prevents
a black background appearing (indicating
non-painted regions) when the buttons show a
focus rect and ripple simultaneously.

Furthermore, in ToolbarButton::AddInkDropLayer(),
schedule a repaint on the parent layer once the
ink drop is added. This prevents a stale image
from remaining visible, which appears to overlap
with the current image drawn on the newly-created
layer for image().

BUG=551492,546683
TEST=manual

Review URL: https://codereview.chromium.org/1460733002

Cr-Commit-Position: refs/heads/master@{#360589}

We haven't used WebKit's committer list for anything in a long time.

BUG=none

Review URL: https://codereview.chromium.org/1455883005

Cr-Commit-Position: refs/heads/master@{#360588}

This makes tilt get populated per the Pointer Events spec with a Wacom
Intuos Pro M Pen.

BUG=557952
TEST=Wacom Intuos Pro M Pen on Chromebook Pixel with
  --enable-blink-features=PointerEvent
  & http://rbyers.github.io/eventTest.html

Review URL: https://codereview.chromium.org/1456063003

Cr-Commit-Position: refs/heads/master@{#360587}

- Removes the Context argument from places it isn't needed.
- Removes everything related to about://sync as there are now better
  ways to access sync state.
- Have just TIMEOUT_MS and INTERVAL_MS.
- Some other misc cleanups.

BUG=556621

Review URL: https://codereview.chromium.org/1451813002

Cr-Commit-Position: refs/heads/master@{#360586}

Fetching metadata is heavy, and it may cause calling stat() even though
it's not needed (is_directory is obtainable without stat()).

This CL adds the option. Backends will be updated to reflect it separately.
Also, as another step base::File::Info will be replaced with storage::Entry
or something similar with scoped_ptr's as members, to avoid reading
a member which was not requested in |fields|.

TEST=All current tests pass. But not really used yet, as backends ignore it.
BUG=558191

Review URL: https://codereview.chromium.org/1455403003

Cr-Commit-Position: refs/heads/master@{#360585}

Revert of More regular Platform implementations in unit tests. (patchset #12 id:220001 of https://codereview.chromium.org/1456873003/ )

Reason for revert:
Compile break on Win x64 Builder (dbg):

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj.rsp /c ..\..\third_party\WebKit\Source\platform\testing\TestingPlatformSupport.cpp /Foobj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj /Fdobj\third_party\WebKit\Source\platform\blink_platform_test_support.cc.pdb
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(202) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(654) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(644) : while compiling class template member function 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38) : see reference to function template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(55) : see reference to class template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled

Original issue's description:
> More regular Platform implementations in unit tests.
>
> R=haraken,jbroman
> BUG=
>
> Committed: https://crrev.com/3e197be3a60195ac2267f3293084fa36c5706503
> Cr-Commit-Position: refs/heads/master@{#360583}

TBR=jbroman@chromium.org,haraken@chromium.org,tkent@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1464493002

Cr-Commit-Position: refs/heads/master@{#360584}

R=haraken,jbroman
BUG=

Review URL: https://codereview.chromium.org/1456873003

Cr-Commit-Position: refs/heads/master@{#360583}

Cr-Commit-Position: refs/heads/master@{#360582}

This logic in documents diverge from CHromeActivity behavior for
archaic reasons (crbug.com/451672). Making documents show/hide
in the same time as all other ChromeActivities with this change.
Verified that the previous bug that caused the bheavior divergence
no longer exists after this CL.

BUG=546182

Review URL: https://codereview.chromium.org/1455343002

Cr-Commit-Position: refs/heads/master@{#360581}

Use form signatures to look up forms in |form_structures_|, which is
guaranteed to be valid.

BUG=557713,557740,557800
TEST=Existing

Review URL: https://codereview.chromium.org/1457793002

Cr-Commit-Position: refs/heads/master@{#360580}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/88939fd8..767df2b5

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1459863002

Cr-Commit-Position: refs/heads/master@{#360579}

That way, we can delete the private values on the listener in the right
context

R=haraken@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1419313003

Cr-Commit-Position: refs/heads/master@{#360578}

This CL addresses the comments reported in:
https://codereview.chromium.org/1391583002/
https://codereview.chromium.org/1391583002/#msg62

BUG=537138

Review URL: https://codereview.chromium.org/1455113002

Cr-Commit-Position: refs/heads/master@{#360577}

Also a few minor fixes reported by cpplint.

BUG=502346

Review URL: https://codereview.chromium.org/1415223002

Cr-Commit-Position: refs/heads/master@{#360576}

Revert of Roll WebRTC 10685:10707, Libjingle 10671:10707 (patchset #1 id:1 of https://codereview.chromium.org/1456393002/ )

Reason for revert:
Reverting since there are still build warnings in the output.

Original issue's description:
> Roll WebRTC 10685:10707, Libjingle 10671:10707
>
> WebRTC 10685:10707
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..0f714d5
>
> Libjingle 10671:10707
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3ecea8a..17fe6f9
>
> TBR=
> BUG=
>
> Committed: https://crrev.com/e8af106460019f9cf7c96d9122f0c214be6066ec
> Cr-Commit-Position: refs/heads/master@{#360568}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1462013002

Cr-Commit-Position: refs/heads/master@{#360575}

+ Add deadbeef@ as owner.
+ Remove hellner@ as owner.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/app/webrtc/mediastreamsignaling.h&l=28

Review URL: https://codereview.chromium.org/1460933003

Cr-Commit-Position: refs/heads/master@{#360574}

Don't try to show the focus ring on other platforms than Chrome OS.

R=dtseng@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1453133002

Cr-Commit-Position: refs/heads/master@{#360573}

Review URL: https://codereview.chromium.org/1459853002

Cr-Commit-Position: refs/heads/master@{#360572}

* a11y: TalkBack still says things like "Settings button" when tapped, as the Button is the view on top
* RTL is handled, the icon is placed on the right when the system is in RTL mode

BUG=554073

Review URL: https://codereview.chromium.org/1441723002

Cr-Commit-Position: refs/heads/master@{#360571}

What we want to do is to instantiate some templates of
<T> with T's full definition, in Member<T>::get() and
Member<T>::checkPointer().
To guarantee that template instantiations come after
T's definition, we put static_assert() in Member<T>.
See the change in platform/heap/Handle.h.

To achieve the condition, this CL does either of
1) move implementation of methods using Member<T> from .h to .cpp
2) include necessary .h
(1) can change inline definitions to outline definitions,
and it may regress performance a bit.

BUG=556947

Review URL: https://codereview.chromium.org/1455943002

Cr-Commit-Position: refs/heads/master@{#360570}

The type name in the |USING_FAST_MALLOC| macro is currently not used,
which allowed a few typos to sneak in. This fixes those to prevent
compile errors in case the type name is used in the future.

Review URL: https://codereview.chromium.org/1461743004

Cr-Commit-Position: refs/heads/master@{#360569}

WebRTC 10685:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..0f714d5

Libjingle 10671:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3ecea8a..17fe6f9

TBR=
BUG=

Review URL: https://codereview.chromium.org/1456393002

Cr-Commit-Position: refs/heads/master@{#360568}

https://html.spec.whatwg.org/#document

After this change, setting document.cookie to null will stringify to
"null", so it's simply like setting a cookie by that name. This matches
Firefox Nightly and Edge.

BUG=497307

Review URL: https://codereview.chromium.org/1458753003

Cr-Commit-Position: refs/heads/master@{#360567}

BUG=558341
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1462873002

Cr-Commit-Position: refs/heads/master@{#360566}

BUG=545480
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1453293003 .

Cr-Commit-Position: refs/heads/master@{#360565}

https://chromium.googlesource.com/chromium/src/+/6546ae27

BUG=128055
TBR=davve@opera.com

Review URL: https://codereview.chromium.org/1461023002 .

Cr-Commit-Position: refs/heads/master@{#360564}