- 24 Oct, 2016 40 commits
-
-
jamesr authored
This adds trace entries for loading imports and for blocking on an import for longer than 20ms. These make gn's tracelog significantly easier to understand when imported files take a long time to process. For example, in the Chrome build on Mac //build/toolchain/mac/BUILD.gn blocks for ~240ms running sdk_info.py because //build/config/mac/mac_sdk.gni runs that script and //ui/base/BUILD.gn blocks for ~350ms because it is waiting for the import lock on mac_sdk.gni to be released. Without these traces, it is not immediately obvious why //build/toolchain/mac/BUILD.gn is running that script and it is very unclear why //ui/base/BUILD.gn takes so long. Review-Url: https://codereview.chromium.org/2424233002 Cr-Commit-Position: refs/heads/master@{#427151}
-
yusukes authored
Also remove an extra 'explicit' qualifier in arc/. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2447773003 Cr-Commit-Position: refs/heads/master@{#427150}
-
ericrk authored
Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2442963002/ ) Reason for revert: Looks like the tests use --force-gpu-rasterization, which overrides the blacklist. I think we still need this suppression. See: https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/2567 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28ATI%29/builds/6394 Original issue's description: > Remove GpuRasterization.BlueBox suppression for Win/AMD. > > GPU rasterization has been disabled on this configuration. > > BUG=653538 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=zmo@chromium.org > > Committed: https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df > Cr-Commit-Position: refs/heads/master@{#426972} TBR=zmo@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653538 Review-Url: https://codereview.chromium.org/2443283002 Cr-Commit-Position: refs/heads/master@{#427149}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e64d0caf..1f4fc5c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2445743002 Cr-Commit-Position: refs/heads/master@{#427148}
-
kylechar authored
Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests. FakeDisplaySnapshot has builder that makes it more readable. Delete an unncessary build target along with TestDisplaySnapshot. Tests should be unchanged for the most part. One test was split into two tests where two very different behaviours were being checked. Also update tests to use C++11 features where possible. Mostly replacing raw pointers with unique_ptr<> and NULL with nullptr. BUG=none Review-Url: https://codereview.chromium.org/2407153008 Cr-Commit-Position: refs/heads/master@{#427147}
-
sunyunjia authored
AutoscrollForSelection is triggered when selecting text and dragging mouse out of the container. However, we don't want selecting text in a fixed-position element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find the object is inside a fixed-position element, we should prevent AutoscrollForSelection from happening. BUG=655489 Review-Url: https://codereview.chromium.org/2441683002 Cr-Commit-Position: refs/heads/master@{#427146}
-
sataya.m authored
Adding rootlayerscrolls-specific test expectations for these test cases virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-parents.html virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-self.html virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll.html BUG=651793 Review-Url: https://codereview.chromium.org/2412013003 Cr-Commit-Position: refs/heads/master@{#427145}
-
jam authored
The previous fix depended on ensuring we add hooks to all the code paths that cause the first active WebContents to get added to the tab strip. We're still missing some code paths. So instead restore the old behavior. Even though it did miss navigation starts, fix that by using the time from NavigationHandle for PlzNavigate. This should restore the metrics for non-PlzNavigate case. For PlzNavigate, the start timings were already different regardless from non-PlzNavigate because of how navigations are structured very differently. This change shouldn't affects things too much for PlzNavigate though, because the only difference should be the IPC time from the renderer to the browser thread. BUG=650349 Review-Url: https://codereview.chromium.org/2448553002 Cr-Commit-Position: refs/heads/master@{#427144}
-
emircan authored
On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. Review-Url: https://codereview.chromium.org/2431223011 Cr-Commit-Position: refs/heads/master@{#427143}
-
chfremer authored
* Moved files video_capture*.* from media/base to media/capture * Split out video capture related part from media/base/ipc/media_param_traits* into new files media/capture/ipc/capture_param_traits*. * Added include for newly created file to content/common/view_messages.h This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.7.2pre. This is in preparation for CL1.7.2, see [2]. BUG=584797 TEST=media_unittests, content_unittests, capture_unittests [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://codereview.chromium.org/2405423002/ Review-Url: https://codereview.chromium.org/2415703002 Cr-Commit-Position: refs/heads/master@{#427142}
-
sclittle authored
Design doc: https://docs.google.com/document/d/1691W7yFDI1FJv69N2MEtaSzpnqO2EqkgGD3T0O-pQ08/edit?usp=sharing This CL introduces support for issuing a range request for just the first few bytes of an image, and showing a translucent gray box of the same size as the image in the image's place if the original image's dimensions can be decoded from the returned range. Currently, this behavior is only activated via a blink-settings flag. In the future, features such as Data Saver will activate this functionality to save data for users. BUG=605350,605351 Review-Url: https://codereview.chromium.org/2423683002 Cr-Commit-Position: refs/heads/master@{#427141}
-
mahmadi authored
before: https://screenshot.googleplex.com/KjwA5O8fX2D.png after: https://screenshot.googleplex.com/eRH0ibx9yKe.png BUG=651121 Review-Url: https://codereview.chromium.org/2431553003 Cr-Commit-Position: refs/heads/master@{#427140}
-
einbinder authored
BUG=none Review-Url: https://codereview.chromium.org/2442843003 Cr-Commit-Position: refs/heads/master@{#427139}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b44976ebd44e3bd838900b904cb6a68124467365 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/0d401b1e358f376f4b19afb9ff26c6f99d68af40 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/66cdab51e19ccc92d7b35f341466fffc38918e96 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/70d11c3759a5113bd2c26a1026467021caac6327 git_cl: fix GetPreferredTryMasters() feature (nodir@chromium.org) recipe_engine: https://crrev.com/19b97eb65b25648c4101c279e30f2aa9d7754844 Refactor expectations of properties recipe_module. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2447813004 Cr-Commit-Position: refs/heads/master@{#427138}
-
spqchan authored
- Moved the animation logic from FullscreenToolbarController into a new class - Replaced DropdownAnimation with SlideAnimation BUG=643418 Review-Url: https://codereview.chromium.org/2430403003 Cr-Commit-Position: refs/heads/master@{#427137}
-
flackr authored
BUG=644833,651305 Review-Url: https://codereview.chromium.org/2450473002 Cr-Commit-Position: refs/heads/master@{#427136}
-
rouslan authored
If the user launches a payment app from expanded payments UI and cancels the payment in the app, then the payments UI should again be expanded. BUG=658222 Review-Url: https://codereview.chromium.org/2441833003 Cr-Commit-Position: refs/heads/master@{#427135}
-
mgersh authored
Calling enableNetworkQualityEstimator() first is no longer required. Review-Url: https://codereview.chromium.org/2444083002 Cr-Commit-Position: refs/heads/master@{#427134}
-
ericwilligers authored
Observer lists now support range-based for loops. BUG=655021 Review-Url: https://codereview.chromium.org/2444753002 Cr-Commit-Position: refs/heads/master@{#427133}
-
benwells authored
BUG=542537 Review-Url: https://codereview.chromium.org/2445643002 Cr-Commit-Position: refs/heads/master@{#427132}
-
haraken authored
BUG=626703 TBR=dmazzoni@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2444793004 Cr-Commit-Position: refs/heads/master@{#427131}
-
dschuyler authored
This CL replaces a var counter for fetching cookie data with javascript promises. The counter had issues with reentrancy, while promise arrays are more robust. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2439233002 Cr-Commit-Position: refs/heads/master@{#427130}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2443803002 Cr-Commit-Position: refs/heads/master@{#427129}
-
mfoltz authored
This CL uses the last committed origin of a frame making a presentation request, instead of the full URL. Frames created in script have an empty last committed URL. Note the following: - Only the origin is used from the frame URL presentation request (that is why this change is safe). PresentationRequest should be converted to use url::Origin instead of GURL to avoid unnecessary conversions. Tracked in crbug.com/632623. - Is it possible for a frames to not have a last committed origin? If so, the strict checking for valid, non-empty origins will need to be relaxed. - TODO: Add functional tests in a separate patch. BUG=658409 Review-Url: https://codereview.chromium.org/2433283005 Cr-Commit-Position: refs/heads/master@{#427128}
-
dmazzoni authored
BUG=654221 Review-Url: https://codereview.chromium.org/2432583002 Cr-Commit-Position: refs/heads/master@{#427127}
-
krasin authored
BUG=568891 Review-Url: https://codereview.chromium.org/2445033002 Cr-Commit-Position: refs/heads/master@{#427126}
-
chrishtr authored
BUG=651511 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 NOTRY=true (added after it passed on all CQ bots except android which failed because of Java heap error) Review-Url: https://codereview.chromium.org/2444593002 Cr-Commit-Position: refs/heads/master@{#427125}
-
mbrunson authored
Adds DeviceChanged callback for BluetoothAdapter::Observer in Device. Logs received DeviceChanged events in console. BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2404623002 Cr-Commit-Position: refs/heads/master@{#427124}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2441223002 Cr-Commit-Position: refs/heads/master@{#427123}
-
estade authored
BUG=633986 Review-Url: https://codereview.chromium.org/2441043003 Cr-Commit-Position: refs/heads/master@{#427122}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2439273002 Cr-Commit-Position: refs/heads/master@{#427121}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d43e1baaf06..dd582ea2140c $ git log 4d43e1baa..dd582ea21 --date=short --no-merges --format='%ad %ae %s' 2016-10-24 jbudorick [dependency manager] Add an update script. 2016-10-24 bpastene devil: Change in type of temp dumped in device monitor to float. 2016-10-24 nednguyen Update ChromeTracingAgent exception handling BUG=649481,657674 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2444033002 Cr-Commit-Position: refs/heads/master@{#427120}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/294a734a5f12..9a032fa2628e $ git log 294a734a5..9a032fa26 --date=short --no-merges --format='%ad %ae %s' 2016-10-19 vigneshv vp9_bitstream: Encode tiles in parallel 2016-10-21 marpan vp9: Nonrd variance partition: increase threshold for using 4x4 avg. 2016-10-20 marpan vp9: Speed=8 real-time: Keep the bias_golden feature on. 2016-10-20 vigneshv Add vp9cx_set_ref to .gitignore 2016-10-20 marpan vp8: Apply gf target-size boost only when refresh_golden_frame = 1. 2016-10-19 marpan vp8: Adjust threshold to set the gf_noboost flag. 2016-10-17 marpan vp8: Add control for gf boost for 1 pass cbr. 2016-10-18 jzern Revert "vp9_bitstream: Encode tiles in parallel" 2016-10-18 jzern third_party: roll libwebm snapshot 2016-10-17 jzern Revert "third_party: Roll libwebm snapshot." 2016-10-10 kaustubh.raste Optimize sad_64width_x4d_msa function 2016-07-14 urvang Fix warnings reported by -Wshadow: Part1: vpx_dsp directory 2016-10-12 linfengz add vpx high bitdepth convolve8 NEON intrinsics optimization 2016-10-14 marpan vp9: Non-rd variance partition: add condition for 64x64 split. 2016-10-17 fgalligan third_party: Roll libwebm snapshot. 2016-10-07 vigneshv vp9_bitstream: Encode tiles in parallel 2016-10-13 jianj VP8: Add realtime speed to datarate_test.cc 2016-10-14 jimbankoski Drop empty frames. 2016-10-12 linfengz add vpx_highbd_convolve_{copy,avg}_neon() 2016-10-13 marpan vp8: Adjust thresholds in VP8/DatarateTestLarge tests. (...) R=johannkoenig@google.com Review-Url: https://codereview.chromium.org/2443993002 Cr-Commit-Position: refs/heads/master@{#427119}
-
wychen authored
Diff since last roll: https://github.com/chromium/dom-distiller/compare/d16a68c1b8...072fe57b48 Picked up changes: 072fe57 Recognize H4 to H6 as headings as well 52047b4 Avoid using getClassName() to avoid issues with <svg> 8cf93ce Bump ChromeDriver version to 2.24 d876125 Add gen_mhtml_corpus.py to convert MHTML to eval corpus 8b33c8b Amend "Fix partially hidden article" 3fd2017 Strip unwanted classNames from all nodes BUG=593457,599121,647098,658038 Review-Url: https://codereview.chromium.org/2447453002 Cr-Commit-Position: refs/heads/master@{#427118}
-
reillyg authored
I'm removing the IPC database ID as part of the Mojo conversion so reusing it for the IndexedDBConnection ID just makes things confusing. Note that the database observer IPCs don't actually make use of this ID so this patch stops sending it. BUG=627484 Review-Url: https://codereview.chromium.org/2438233004 Cr-Commit-Position: refs/heads/master@{#427117}
-
juncai authored
When the Bluetooth adapter is off, the chooser will show: "Turn on Bluetooth to allow pairing", the whole text is a link. This CL modifies code to make only "Turn on Bluetooth" a link. And the "to allow pairing" text is not a link. I uploaded some screenshots in the issue page. BUG=658094 Review-Url: https://codereview.chromium.org/2439453006 Cr-Commit-Position: refs/heads/master@{#427116}
-
twellington authored
This CL adds basic scaffolding for passing quick action data from the native ContextualSearchDelegate to Java through the search term resolution response. BUG=657063 Review-Url: https://codereview.chromium.org/2440843002 Cr-Commit-Position: refs/heads/master@{#427115}
-
dcastagna authored
https://chromium.googlesource.com/chromiumos/platform/minigbm.git/+log/f9e7c4c8..3345977b git log f9e7c4c8..3345977b --date=short --no-merges --format='%ad %ae %s' 2016-09-16 hoegsberg@chromium.org minigbm: add new GBM_BO_IMPORT_FD_PLANAR 2016-10-19 gurchetansingh@chromium.org minigbm: Remove SCANOUT flags from YV12 2016-10-17 gurchetansingh@chromium.org minigbm: mediatek: add required Android buffers 2016-10-13 gurchetansingh@chromium.org minigbm: i915: make Y-tiling default 2016-10-13 gurchetansingh@chromium.org minigbm: rockchip: Enable required Android buffers 2016-09-30 gurchetansingh@chromium.org minigbm: add vgem backend 2016-09-23 gurchetansingh@chromium.org minigbm: rockchip: enable NV12 for Android 2016-09-22 gurchetansingh@chromium.org minigbm: i915: enable required Android buffers 2016-09-12 gurchetansingh@chromium.org minigbm: Fix the flag situation 2016-08-24 gurchetansingh@chromium.org minigbm: Implemented cros_gralloc 2016-10-06 gurchetansingh@chromium.org minigbm: More sophisticated gbm_bo_map/gbm_bo_unmap 2016-10-09 vapier@chromium.org Revert "Add new GBM_BO_IMPORT_FD_PLANAR" 2016-09-16 hoegsberg@chromium.org Add new GBM_BO_IMPORT_FD_PLANAR 2016-10-05 gurchetansingh@chromium.org minigbm: quick and dirty implementation of gbm_bo_map/gbm_bo_unmap 2016-07-28 akshu.agrawal@amd.com minigbm: Add AMDGPU minigbm driver 2016-08-29 gurchetansingh@chromium.org minigbm: Map and unmap correct size 2016-08-29 gurchetansingh@chromium.org minigbm: Added YV12 for Mali platforms 2016-08-29 gurchetansingh@chromium.org minigbm: Fix switch statements 2016-08-05 dcastagna@chromium.org Add XBGR8888 to rockchip supported formats. 2016-08-19 gurchetansingh@chromium.org minigbm: Added support for multiplane import 2016-07-19 gurchetansingh@chromium.org minigbm: Add YV12 for i915 2016-08-16 gurchetansingh@chromium.org minigbm: Added gralloc API to internal API 2016-08-16 gurchetansingh@chromium.org minigbm: Remove drv prefix from static backend functions 2016-08-12 gurchetansingh@chromium.org minigbm: Add mmap() in backends 2016-08-03 gurchetansingh@chromium.org minigbm: Add userspace reference counting 2016-08-05 gurchetansingh@chromium.org minigbm: Refactored minigbm on top a private API 2016-05-19 vince.h@nvidia.com minigm: add kind C32_2CRA and set it as default 2016-07-14 gurchetansingh@chromium.org minigbm: One buffer for NV12 BUG= Review-Url: https://codereview.chromium.org/2444993002 Cr-Commit-Position: refs/heads/master@{#427114}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/826167111f80..19b91531e912 $ git log 826167111..19b91531e --date=short --no-merges --format='%ad %ae %s' 2016-10-24 scroggo Add support for multiple frames in SkCodec 2016-10-24 caryclark fix a few more fuzzes 2016-10-24 borenet Fix RecreateSKPs recipe to correctly fail when the upload fails 2016-10-24 caryclark nc seal breaks simplify 2016-10-24 brianosman Rename all color space factories from New* to Make* 2016-10-24 borenet Add infra recipe module, use for updating Go DEPS 2016-10-24 caryclark formalize host debugging Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=reed@google.com Review-Url: https://codereview.chromium.org/2445773002 Cr-Commit-Position: refs/heads/master@{#427113}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/1c15a9fc2eb174464aca9734d1440496d98482dc Recipe writes chartjson results to file instead of flag (eyaich@chromium.org) https://crrev.com/8b65c34f07490a0ddebdf96d0e755821c876847b Make bisect not break when buildbucket.get fails. (robertocn@chromium.org) https://crrev.com/eb46e3c1bfd1a8dcc9be13eb857e374aa9f5c66e Never use the hermetic xcode toolchain for iOS recipes. (erikchen@chromium.org) https://crrev.com/86c5ac5eecf8c7ad492fb0219de6464b4485ccb9 Add the recipe_modules/blimp for integration bot (shenghuazhang@chromium.org) https://crrev.com/c6a8b4ce03b47b60f3a5dd1cd0ce681b7a15f3ff Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/859520fa8a53099b5a0f440b8ed18568c26c945c Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/3d11b0b0d75276f52c0a5fe566d5db650ced71f0 Use allow_build_without_goma option in chromium module (tikuta@chromium.org) https://crrev.com/6a6a57ff4c914c89b15b84be4a4fe327b75adc38 V8: Raise timeout for slow bots. (machenbach@chromium.org) https://crrev.com/16345f36599e348f48986eb5fcd2d651d359dc17 WebRTC: Remove audioproc test. (kjellander@chromium.org) https://crrev.com/351d5f2131c2bd1ad46017be7ac1a168251a96d4 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/d975b30c20b53879bf466d9c82a59813ea8122e6 Automatically CC folks listed in CC= lines. (bradnelson@chromium.org) https://crrev.com/99e2cdf47a3f1083bde35d7553fda218fd7f37d6 Print failure reason when git cl try can't trigger jobs on a CL. (qyearsley@chromium.org) https://crrev.com/6468b9068b721bd466d0e802c73fdc94dd9d949a Make git cl patch work with binary files. (skobes@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2450493002 Cr-Commit-Position: refs/heads/master@{#427112}
-