GitLab

Bug: 976007,969960
Change-Id: Iaad780b29bc1e43274a61549c851c98d15e01174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664149
Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670154}

Change PixelResourceTestCase to a struct that can independently specify
the renderer type and the raster type. This will make it easier to add
Skia Vulkan as a renderer option.

Bug: 963446
Change-Id: Ibcd87d5c2adbcee1a0940387c924adbb54875e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664104Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670153}

This reverts commit 65941216.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[DevTools] Roll inspector_protocol and migrate to std::vector."
> 
> This reverts commit 3a73cee4.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector."
> > 
> > This reverts commit dc15ca61.
> > 
> > Reason for revert: suspected to be causing link failures on android
> > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so
> > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408
> > 
> > Original change's description:
> > > [DevTools] Roll inspector_protocol and migrate to std::vector.
> > > 
> > > New revision: 83b1154a9661d22bba9a368d368214cc20880419
> > > 
> > > This updates the usages of the protocol types to the new
> > > definitions, using std::vector-based implementations
> > > of protocol::Array.
> > > - In many places we can now use the C++11 style for( : ) loops.
> > > - We use std::make_unique for creation.
> > > - We use emplace_back to insert elements, which sometimes
> > >   allows us to create strings etc. in place.
> > > - Accessing strings in arrays is cheaper, since vector[i]
> > >   returns a reference (protocol::Array::get made a copy!).
> > > - One can assert equivalence of vectors with strings
> > >   in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz"));
> > > - Overall the code is shorter, as the vector API is
> > >   more concise.
> > > 
> > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628
> > > Commit-Queue: Johannes Henkel <johannes@chromium.org>
> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > Reviewed-by: Leonard Grey <lgrey@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#669857}
> > 
> > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org
> > 
> > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Commit-Queue: Ben Pastene <bpastene@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#669922}
> 
> TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org
> 
> Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168
> Reviewed-by: Johannes Henkel <johannes@chromium.org>
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#670151}

TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org

Change-Id: I8aa1016737e46461bbd7917d645b14a26f8f3abe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663847Reviewed-by: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670152}

This reverts commit 3a73cee4.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[DevTools] Roll inspector_protocol and migrate to std::vector."
> 
> This reverts commit dc15ca61.
> 
> Reason for revert: suspected to be causing link failures on android
> "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so
> eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408
> 
> Original change's description:
> > [DevTools] Roll inspector_protocol and migrate to std::vector.
> > 
> > New revision: 83b1154a9661d22bba9a368d368214cc20880419
> > 
> > This updates the usages of the protocol types to the new
> > definitions, using std::vector-based implementations
> > of protocol::Array.
> > - In many places we can now use the C++11 style for( : ) loops.
> > - We use std::make_unique for creation.
> > - We use emplace_back to insert elements, which sometimes
> >   allows us to create strings etc. in place.
> > - Accessing strings in arrays is cheaper, since vector[i]
> >   returns a reference (protocol::Array::get made a copy!).
> > - One can assert equivalence of vectors with strings
> >   in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz"));
> > - Overall the code is shorter, as the vector API is
> >   more concise.
> > 
> > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628
> > Commit-Queue: Johannes Henkel <johannes@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Leonard Grey <lgrey@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#669857}
> 
> TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org
> 
> Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669922}

TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org

Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168Reviewed-by: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670151}

We now use an unordered_set to cache the hash of successfully compiled shaders in memory.
So that when querying COMPILE_STATUS we don't have to always do shader compile if the shader object is not present even if the linked program is in cache.

Some very simple profiling (improved investigation):
(Detailed profiling data and some explanations could be found here: https://docs.google.com/spreadsheets/d/1_kAuC9lJ5QGxuKiM_hHF77rS7rmukAErr_hotF8EHd4/edit?usp=sharing)
For a javascript program that creates and links 100 programs (200 different shaders in total, no randomized constant introduced)
and query the compile status of shaders afterwards:

1. The first launch:
There will be no difference between the cached version and no-cache version.
Because there's no program cache at all. All shaders will get compiled in DoLinkProgram.
The gpu::gles2::Shader instance will stays in memory.
Future DoGetShaderiv calls where pname == GL_COMPILE_STATUS will directly access the gpu::gles2::Shader instance for whether it's valid or not.

The query time for 200 shaders is ~36ms.
(Time taken number afterwards all stands for query COMPILE_STATUS of these 200 shaders)

2. Refresh the page:
Now there will be cache hit happened when program link so that shaders won't get compiled at program linkage.
As a result, querying COMPILE_STATUS now in no-cache version will lead to shader->DoCompile,
which would take ~400ms.
For the cached version, as successfully compiled shaders have their hash stored in an unordered_set,
There's no shader compilation happen, we simply look at if there's an entry of the shader hash in that set,
which would take ~50ms.

If the javascript program continues to query COMPILE_STATUS after the first query (though unlikely in a real-world scenario)
The cached version will take slightly more time (~50ms) because it didn't have the compiled shader in memory but keeps looking into the unordered_set for shader hash.
While no-cache version simple accesses gpu::gles2::Shader instance (~40ms).


Future update on Angle might be needed as well.

Bug: 775247
Change-Id: I08629e99a603c29d9a4e332b602bf669e074939a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593640
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670150}

Add regression test for the case where the loading hints arrive
late in Blink. A new HTML file is added that loads resources
using link-rel preload. The existing browsertest fails in
that case.

Bug: 891328
Change-Id: Id100da5b7c16c357132dcbf875d1d2048968c7c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663355
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670149}

A nice side-effect of this change is that it moves complexity out of
RenderProcessHostImpl.

Originally reviewed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1654238

Change-Id: I9ce1fafebef8f314c6603ab122dab9a777b2e839
Bug: 967834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660157Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670148}

I initialized the TestBrowserThreadBundle with REAL_IO_THREAD in
crrev.com/c/1658644 to get around some fuchsia-specific behavior. That
wasn't the correct way to fix it, this CL is.

Bug: 974365
Change-Id: I55a2d533654f15d9280215bf26e652e1163be74b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662968Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670147}

This reverts commit ff7bc1fd.

Reason for revert: SetTimeDialogBrowserTest.All

Original change's description:
> Only allow timezone changes when done button is clicked
> 
> Instead of changing the system timezone when a new value is selected on
> the list, it is only applied when the set date time dialog is closed.
> This is necessary to ensure that only parents can change time and
> timezone settings for children.
> 
> Bug: 921145
> Change-Id: If5f3460381fc60607741828e59912c669af05a9b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658858
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#670069}

TBR=xiyuan@chromium.org,agawronska@chromium.org,hgrandinetti@chromium.org

Change-Id: I1d839ca4446c4f79d0809d1fa6e402a5f657abe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664110Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670146}

The test used to just check if the request succeeded or not, but didn't
look at the response body which since M73 was getting blocked by CORB.

This CL:
- Makes the test actually inspect/verify the response body
- Use resource type that is not covered by CORB

Bug: 940068
Change-Id: I755bb445e5241f1082f3981ac8506aaf185d64da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650283
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670145}

Layers added beneath views weren't handled in
WindowReorderer::ReorderChildWindows(). When this method was called,
any layers beneath would end up incorrectly stacked above all other
sibling layers. This bug surfaced recently with an ink drop painting
above its view.

This CL exposes a View method that returns all layers associated with
it that should be immediate children of its parent.
ReorderChildWindows() is modified to call this instead of simply
restacking the view's main layer.

Bug: 973243
Change-Id: I65b5a3266bbe20afe9adb5db4acf709c6c506b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663037
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670144}

Samples that will be published along with xr-barebones.html:
 - magic-window.html
 - teleportation.html
 - gamepad.html

For those samples, cleanup the code and add some comments. Also update
the OT token referenced by those pages so that they work with the M76
OT.

Added some scripts that assemble the subset of samples and upload them
to the bucket where they are hosted.

Also fixed an issue with teleportation.html that caused the initial
scene displayed in the inline session to be at floor-level instead of
head-level.

Bug: 966565, 954388, 974041
Change-Id: Ia21b2833351d44ec4633d2cbebaf6c673abd4c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662848Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670143}

Checks if a user should be notified that Lite mode now optimizes HTTPS
pages for Lite mode users when HintsFetcher is first enabled if it has
not already been shown. This ensures that when HintsFetcher is enabled
for Lite mod users that they see the infobar that describes this
change before hints are fetched from the remote optimization guide
service.

Bug: 943846
Change-Id: Id9887c4d3994a87bf516c11414637538e2d7e90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663053Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670142}

Today, FlingBooster works by observing gestures during a fling. While it
decides whether or not the fling will be boosted, the incoming gestures
are filtered. This leads to a loss of responsiveness in this period.

In this CL, we radically simplify the FlingBooster/FlingController. We
no longer defer gestures during an active fling. When a FlingCancel is
received, the current fling is immediately stopped. The fling booster
still tracks gestures in the same way but allows them to be dispatched
so that scrolling remains responsive. If a fling occurs and meets all
the existing criteria for boosting, we start a new fling and add the
previous fling's velocity to it.

This change makes scrolling feel more responsive during a fling and also
significantly simplifies the fling and gesture code since we're no
longer modifying the gesture stream.

Change-Id: I47c0466861395f2064c4ce68d300955afd3668ec
Bug: 905593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630537Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Auto-Submit: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670141}

This reverts commit 44984340.

Reason for revert: crbug.com/976331

Original change's description:
> [AdTagging] Add support for asynchronous stacks in AdTagging
> 
> What: Label async tasks as ad or not.
> 
> Why: So that the AdTracker knows if a running task is due to an async
> task registered while ad script was on the stack.
> 
> How: Modified the async probes to take a AsyncTaskId* instead of a
> void*. The AsyncTaskId* stores the bit of whether ad script was on
> the stack at the time of creation. This is *much* better than the
> previous approach (https://crrev.com/c/1291232) in that there are no
> memory leaks, no extra map lookups, and we don't have to worry about
> cancelasynctask being called. It does require a modification to all
> probe locations to hold a AsyncTaskId member.
> 
> Bug: 851531
> Change-Id: I92e25b3ab3b8746611c3a3f9a9a7265bab4a601e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648886
> Commit-Queue: Josh Karlin <jkarlin@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669884}

TBR=dgozman@chromium.org,alph@chromium.org,japhet@chromium.org,jkarlin@chromium.org

Change-Id: I36397d0e78d33fb3522301ff4e11b27cb679fdda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664201Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670140}

Web content now performs substitutions as configured in System
Preferences → Keyboard → Text, including quotes, dashes, and custom
replacements.

To do:
- Add standard Edit menu options (see TextEdit).
- Maybe: tweak about how substitutions work with undo.
- Maybe: support reverting and changing suggestions via the standard UI.
- Maybe: offer automatic spelling and grammar correction.
- Probably: more! This is just a first pass.

Bug: 42434
Change-Id: I35ed072a9a390296f9ab250c788e11b9147dc24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652661Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670139}

This CL completes the UI option for Button_GM2; resolves remaining comments in CL 1653575.

Bug: 963148
Bug: 974811
Change-Id: Ia340a7bfca850e05be3473a2e04b3eb46737776c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661376
Commit-Queue: Haohao Wang <hhw@google.com>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670138}

This is the last CL implementing functionality for
authenticatorBioEnrollment, finishing off with CTAP2.1 §5.7.8,
removing enrollments. Implementation is almost identical to the
rename command, just without the name parameter.

Change-Id: I0d3b608cb08766f32a22f8287842b1dbb0ce461b
Bug: 974046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658759Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Matthew Webb <noviv@google.com>
Cr-Commit-Position: refs/heads/master@{#670137}

Eliminated the OWNER enum from Ash because it is not used and
can be replaced by USER.

Bug: 713380
Change-Id: Ic9c8e9dd42ea15d604e3c711893bdeaae2a48f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654488Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670136}

This CL adds PageMsg_UpdatePageVisualProperties and causes it to be
sent to all renderers for a page when the viewport is resized. At
present, the mainframe renderer continues to act on the viewport size it
receives via RenderWidget::SynchronizeVisualProperties, but any oopif
renderers receive it via RenderViewImpl::OnUpdatePageVisualProperties().

This CL also removes ResizeVisualViewport from the WebWidget API and
moves it to the WebView API.

Bug: 939050, 599688
Change-Id: I04097ea936e8d87792155278c9c1b8823f6aaf45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621868Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670135}

These will be used for a simple sequencing analysis.

Bug: 976066
Change-Id: I93df27f382e2ed5c630294742e473a1390c0e220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663013
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670134}

Change-Id: Icbbf7bc4a242f89eb6be5841783c14c116f42c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660040Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670133}

supported_proivder_type will be used to change the behavior of OPEN_APP action
and Android media action.

Currently, we always send ANDROID_APP as supported_provider_types which enables
launching media intent. The plan is to rollout in M77 instead of M76.

This changes will be cherrypicked into M76 to disable the feature in M76 and
enable with a finch experiment.

Bug: b:135487605
Test: Manual
Change-Id: Ia07ccf425126be9433c7d4043f3780dd39107713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663396Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670132}

This CL removes unneeded includes from tab.h and tab.mm, and removes
unneeded dependencies from tabs/BUILD.gn.

Forward declarations were added to tab_private.h and tab_view_delegate.h
to correct for types that were coincidentally included alongside them.

Change-Id: I8ba0a260cede6212935308414f46a28c47db1ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664073
Auto-Submit: Mark Cogan <marq@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670131}

Bug: 972063
Change-Id: Iae4119912493dcc796eb7d7d5b0e2502442b6f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663138Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670130}

This uses a rare-data pattern to reduce the size of a layout result.

On 64-bit machines this is almost a 50% reduction (120 -> 64).
On 32-bit machines I think this reduces it to 48.

There is a slight (~1%) performance regression on microbenchmarks due
to this change.

Bug: 962108
Change-Id: Ia673fa34b986f851c53b6becc44025e16891d12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648887
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670129}

Now invoking CRLSet::CheckSPKI, CRLSet::CheckSerial, and
CRLSet::IsExpired().

Change-Id: Id4586bfbd42e45d7d917822cf2a30ef6d1eafa11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648826
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670128}

This reverts commit 3fb285c9.

Reason for revert:  "This does break tests in 32-bit/dbg/linux, but that's a config we don't care about and that we're removing the bot for. The previous clang had codegen issues on arm64/ios which is a platform we do care about"

Original change's description:
> Revert "Roll clang 362913:363450."
> 
> This reverts commit 76c3585f.
> 
> Reason for revert: The clang roll is causing a lot of test failures from interactions with Skia, and causing reduced test coverage/red bots.
> 
> Original change's description:
> > Roll clang 362913:363450.
> > 
> > Ran `tools/clang/scripts/upload_revision.py 49b965079b18f8aa485dd1156dd088d40b7ee465`.
> > 
> > TBR=hans
> > 
> > Bug: 974267
> > Change-Id: If292a3e2317da54558f02275a84aefead03aad9d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660964
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#669515}
> 
> TBR=thakis@chromium.org,hans@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 974542
> Change-Id: I0feae2b830dfada03388d77f366934825497516a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663740
> Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
> Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669965}

TBR=thakis@chromium.org,hans@chromium.org,huangdarwin@chromium.org

Change-Id: I58b4ee33151f0b905ecfa48e5e83f6b5f2f44263
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664992Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670127}

This is about an undocumented quirk. I raised
https://github.com/whatwg/quirks/issues/46 for it.

LayoutNG currently cannot handle this situation, because we don't store
the inline-size to use in replaced percentage resolution (only the
block-size). However, I find it hard to believe that there'd be any
specific expectations to how this is supposed to work if a table cell
has a definite block-size, and a descendant establishes an orthogonal
writing-mode root. So just ignore it and use regular percentage size
resolution in these cases.

Bug: 967069
Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670126}

value_or seems to be causing a crash when we call
UpdateForegroundColor. If we remove them then this
should fix the crash.

BUG=974866

Change-Id: Iead32cb863ae28fe10cb66552edc89af74ca0cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664635
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670125}

https://android.googlesource.com/platform/external/perfetto.git/+log/df7d31c06e36..c0d17117afe9


git log df7d31c06e36..c0d17117afe9 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 lalitm@google.com metrics: Fix metric protos


Created with:
  gclient setdep -r src/third_party/perfetto@c0d17117afe9

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iedab37405bf4ec81e715e3c168ce26edd3791aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664108Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670124}

These metrics are used for internal dashboarding.

BUG=975870

Change-Id: Ieae3e7ca5e89cad391912b0d2c2b9c5e88aa9569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663077Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670123}

This reverts commit 343f32e3.

Reason for revert: crbug.com/976241 

Original change's description:
> Hook up the delay load failure function in the renderer processes.
> 
> This allows getting a crash report when failing to delay load a DLL.
> 
> Example of the stack trace that this will provide:
> chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28]
> chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939]
> chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\content\renderer\renderer_main_platform_delegate_win.cc @ 37]
> chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305]
> chrome_child!RtlUnwind+0x470
> chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164]
> chrome_child!blink::DWriteVersionSupportsVariations+0x7f
> chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc
> 
> Bug: 970893
> Change-Id: I922d5a3f7e62c7e25f954405bedd967678dd7a50
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655909
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669339}

TBR=dcheng@chromium.org,wfh@chromium.org,sebmarchand@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 970893
Change-Id: I6a7dfd2ae97d6538d65888c04d8af36a356ae7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663363Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670122}

This reverts commit 9d54112e.

Reason for revert: This was only needed for Beta.

Original change's description:
> Fix the use of RENDERER_SKIA_VK where it isn't supported
> 
> Prior to this CL, the build was broken for Windows Arm64 and
> Windows x86, and Jumbo/non-Jumbo builds. See comment at [1].
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1660122
> 
> Change-Id: I2cc0a84dd94f119c11a556c9670c261ca3086e6f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660958
> Auto-Submit: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669408}

TBR=ericrk@chromium.org,masonfreed@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I28b154a5154edabd7779661bea67c047b109da3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663176Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670121}

See the video here: https://photos.app.goo.gl/VMTsEWxSmzfqfuGJ6
When there's only one window, the highlight is movable with keyboard
arrow keys. It shouldn't animate, or the animation should be different
(bump for example).

R=sammiequon@chromium.org

Bug: 970319
Test: manual

Change-Id: I8c43c7fdedc5ba042f7c0ae1eb2032602ada033c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663533
Commit-Queue: Danton Vu <dantonvu@google.com>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670120}

Carry over a few known expected fonts we have in font_fallback_win.cc on
the Blink side.

Bug: 947059
Change-Id: I9811ac33cc2bc65d35df283999812080ac93bc98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664148
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670119}

https://skia.googlesource.com/skia.git/+log/c34d993b62a5..f91aeb259e09


git log c34d993b62a5..f91aeb259e09 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 egdaniel@google.com Move a bunch of gpu files out of include/private and into src/gpu.
2019-06-18 borenet@google.com [infra] Fix Go builds
2019-06-18 fmalita@chromium.org [skottie] Add support for motion tile phase
2019-06-18 rmistry@google.com [skottie-wasm-perf] Command line application to measure perf
2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ed2c978cdeef..d7303797becf (1 commits)
2019-06-18 rmistry@google.com [skottie-wasm-perf] Date.now() has millisecs precision, we need microsecs


Created with:
  gclient setdep -r src/third_party/skia@f91aeb259e09

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bsalomon@google.com

Change-Id: I268282c25f891873ae426e2180a3c800fdb76232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663683Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670118}

-[SigninInteractionControllerTestCase testDismissSigninFromSettings]
-[SigninInteractionControllerTestCase testDismissAdvancedSigninSettingsFromAdvancedSigninSettings]
-[SigninInteractionControllerTestCase testDismissSigninFromBookmarks]
-[SigninInteractionControllerTestCase testDismissAdvancedSigninBookmarksFromAdvancedSigninSettings]
-[SigninInteractionControllerTestCase testDismissSigninFromRecentTabs]
-[SigninInteractionControllerTestCase testDismissSigninFromRecentTabsFromAdvancedSigninSettings]
-[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcher]
-[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcherFromAdvancedSigninSettings]
-[SigninInteractionControllerTestCase assertOpenURLWhenSigninFromView:tapSettingsLink:]

Related to: crrev.com/c/1626860

Change-Id: Ice0e675926141d2a6b59fdeba3a3f80d8215bd92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664551Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670117}

Removes:
* ServiceWorker.URLRequestJob.FallbackedRequestMode
* ServiceWorker.URLRequestJob.MainResource.Result
* ServiceWorker.URLRequestJob.MainResource.StatusZeroError
* ServiceWorker.URLRequestJob.Subresource.Result
* ServiceWorker.URLRequestJob.Subresource.StatusZeroError

This is dead code following the launch of S13nServiceWorker.

Bug: 975818, 975435, 975331, 926114
Change-Id: Ia75a4627e7c0d7bc872e9e2f4bccb4fdd1abecff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663458
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670116}

Currently sync state is requested from AndroidSyncSettings. This class
only reflects local Android sync settings and doesn't get updated if
sync is disabled for dasher account by domain administrator.

ProfileSyncService#canSyncFeatureStart is the correct method to check if
sync is enabled. Correspondingly IdentityDiscController should observe
sync state through ProfileSyncService.SyncStateChangedListener.

BUG=976089
R=mastiz@chromium.org,twellington@chromium.org

Change-Id: Ibe1913c6743d1c6438945f0391ac8a21bfb03f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663376Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670115}