GitLab

RunAllPending() is deprecated and we should switch to RunUntilIdle().

BUG=131220
TBR=ajwong@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11421172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161958


Review URL: https://chromiumcodereview.appspot.com/11348254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170463 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11299275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170462 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170461 0039d316-1c4b-4281-b951-d872f2087c98

Getting FATAL:image_skia.cc(388)] Check failed: CanRead() in EnableAppModeTest

control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11416284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170460 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170451 - [content shell] add support for testRunner.canOpenWindows and disallow opening windows per default for layout tests

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11411282

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11414260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170459 0039d316-1c4b-4281-b951-d872f2087c98

This will hide the popup when the browser changes size or location. Also add some tests for the WidgetObserver for the function we are observing with.


BUG=


Review URL: https://chromiumcodereview.appspot.com/11308124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161941
TEST=No visible functionality changes.


Review URL: https://chromiumcodereview.appspot.com/11280239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170455 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes all the usages of deprecated SendReplyMessage() method from
WebIntentsDispatcher API.

This was a TODO for smckay.

R=gbillock@chromium.org
TBR=jam@chromium.org # for trivia API removal.

Review URL: https://codereview.chromium.org/11419233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170452 0039d316-1c4b-4281-b951-d872f2087c98

[content shell] add support for testRunner.canOpenWindows and disallow opening windows per default for layout tests

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11411282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170451 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170449 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/11413168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170446 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces a MockGeolocationArbitrator class for use
with the GeolocationProvider unittests. This avoids having to
instantiate dependencies of the GeolocationArbitrator to test the
GeolocationProvider.

This will make it easier to add a unit test for 
https://codereview.chromium.org/11312210/

TEST=Existing
BUG=

Review URL: https://chromiumcodereview.appspot.com/11412194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170444 0039d316-1c4b-4281-b951-d872f2087c98

FileBrowserFunction::GetLocalPathsOnFileThreadAndRunCallbackOnUIThread()
is used for two purposes. One is to parse file system URL (|file_path| field),
and another is to resolve to the cache file path of Google Drive files (|local_path| field).

The patch aims to separate the former use cases from the latter, before I'll
add one more tweak here for selected path names in "Save as" dialog (see issue 140425).

BUG=163075
TEST=Verify view/zip/copy-from-drive/copy-to-drive/format/mount-zip function works on Files.app.

Review URL: https://chromiumcodereview.appspot.com/11414222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170443 0039d316-1c4b-4281-b951-d872f2087c98

TEST=CanonicalCookie*
BUG=163349

Review URL: https://chromiumcodereview.appspot.com/11308270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143702

Review URL: https://chromiumcodereview.appspot.com/11348305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170441 0039d316-1c4b-4281-b951-d872f2087c98

We should use the size info for hasVideo if we already have that information

BUG=121898


Review URL: https://chromiumcodereview.appspot.com/11412251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170440 0039d316-1c4b-4281-b951-d872f2087c98

I wanted to wire up a WebPreferences modifying testRunner method, and XSSAuditorEnabled will make >100 tests pass

BUG=111316
TEST=most of http/tests/security/xssAuditor passes


Review URL: https://chromiumcodereview.appspot.com/11316244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36778
TEST=manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/11415201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170438 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the following issue:
- TestSharder.SetupSharding() in run_java_tests.py wasn't calling
  the super class' SetupSharding() method which kills host_forwarder. The call
  to Forwarder.KillHost() was moved to RunShardedTest() which isn't supposed to
  be overridden. This should be more robust.

Additionally in case '$ host_forwarder kill-server' failed for any reason,
Forwarder.KillHost() now falls back to pkill.

BUG=163036


Review URL: https://chromiumcodereview.appspot.com/11421149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170437 0039d316-1c4b-4281-b951-d872f2087c98

On some platforms, we want to unschedule after a swap until the ack, but the
DeferDraws mechanism allows us to delay the unschedule until we actually need to
access the back buffer. Up to now, only commands that *write* to the framebuffer
were considered, however we also need to consider *reads*. This fixes that.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11412262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170435 0039d316-1c4b-4281-b951-d872f2087c98

The pointer can be NULL when the detailed view creation
failed (SystemTrayBubble::UpdateView => !bubble_view_->has_children() => Close).

BUG=163518

Review URL: https://codereview.chromium.org/11428100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170434 0039d316-1c4b-4281-b951-d872f2087c98

IBusConfigClient can not always initialize synchronously, because there is a case that the ibus-config daemon is not running.

BUG=158265
TEST=ran chromeos_unittests

Review URL: https://chromiumcodereview.appspot.com/11413165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170432 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157916

Review URL: https://chromiumcodereview.appspot.com/11299261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170429 0039d316-1c4b-4281-b951-d872f2087c98

We fire update/change notifications to the observers attached to the FileSystemOperationContext, but the current code creates a new FileSystemOperation (and thus FileSystemOperationContext) for the source URL. This results in no update/change modifications in the destination filesystem in cross-filesystem operation cases.

BUG=163540
TEST=manual

Review URL: https://codereview.chromium.org/11316265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160939


Review URL: https://chromiumcodereview.appspot.com/11316133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163548
TEST=n/a

Review URL: https://chromiumcodereview.appspot.com/11316266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170426 0039d316-1c4b-4281-b951-d872f2087c98

Note: The link in the bubble takes you to the chrome://extensions page but does not highlight the extension you clicked on. 

BUG=153137
TBR=ben
TEST=Install an extension with a content script, such as Google Dictionary or Turn of the lights. You should see a puzzle piece in the Omnibox indicating how many content scripts are running on the page. Click the puzzle piece to see a list of extensions running the content scripts.


Review URL: https://chromiumcodereview.appspot.com/11348304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170425 0039d316-1c4b-4281-b951-d872f2087c98

Based on the EME spec, init_data is optional in GenerateKeyRequest(). Update AesDecryptor to support this.

BUG=162759
TEST=added test in AesDecryptorTest to test this case.


Review URL: https://chromiumcodereview.appspot.com/11434025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170424 0039d316-1c4b-4281-b951-d872f2087c98

It's already included by base/gtest_prod_util.h

TBR=jam@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11428090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170423 0039d316-1c4b-4281-b951-d872f2087c98

When --enable-encrypted-media is not set, NeedKey event should not be fired from media pipeline. Also, the decoder should declare decode error or unsupported error instead of waiting for decryptor to be set/initialized.

BUG=
TEST=tested EME test page with --enable-encrypted-media set and not set.


Review URL: https://chromiumcodereview.appspot.com/11414138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162571


Review URL: https://chromiumcodereview.appspot.com/11419243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170421 0039d316-1c4b-4281-b951-d872f2087c98

LauncherModel.AddIndices is failing in the bots: http://build.chromium.org/p/chromium.win/builders/Win%20Aura/builds/24835/steps/ash_unittests/logs/stdio

BUG=160605
TEST=LauncherModel.AddIndices, LauncherViewTest.AddPanelHidesTabbedBrowser, LauncherViewTest.PanelsHideLast


Review URL: https://chromiumcodereview.appspot.com/11348201

TBR=flackr@chromium.org
Review URL: https://codereview.chromium.org/11299272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170420 0039d316-1c4b-4281-b951-d872f2087c98

- Add and fix comments
- Make some members private
- Make some members const
- Move GetResponseHeadersAsString() to anonymous namespace

BUG=163544
TEST=none

Review URL: https://codereview.chromium.org/11421170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170419 0039d316-1c4b-4281-b951-d872f2087c98

The smoothness benchmark mean frame times were off because they would attempt to smoothScrollBy to the scrollHeight, but you need to subtract the viewport height to get the correct scrolling distance. Because smoothScrollBy doesn't stop when you hit the bottom of the page, the duration of the scroll gesture was longer than it should be. This made the numbers worse for shorter pages.

BUG=162922
TEST=Run a smoothness_benchmark.

Review URL: https://codereview.chromium.org/11412266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170418 0039d316-1c4b-4281-b951-d872f2087c98

This is a step to getting DMP running in Windows.

BUG=159993


Review URL: https://chromiumcodereview.appspot.com/11418237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170417 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wez@chromium.org

BUG=163542

Review URL: https://codereview.chromium.org/11411279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170416 0039d316-1c4b-4281-b951-d872f2087c98

This makes the ChromeOS keyboard F<number> keys produce keycodes such as
BROWSER_BACK, VOLUME_UP, POWER, etc. We can then remove special-cases for
ChromeOS accelerator bindings, and allow the same bindings to work on all
platforms including ChromeOS. The ChromeOS keyboard, and external keyboards
with these extra keys will also rely on and fire the same bindings for these
keys, unifying the code path.

The other advantage of this, is that now ChromeOS does not need to bind
F<number> keys in a non-standard way. So, an external keyboard plugged
into a Chromebook can still use the F<number> keys in the same way as they
would when it was plugged into their desktop. This behaviour isn't yet
possible, as the event rewritter is not aware if the event came from the
ChromeOS keyboard or an external keyboard, but is a 1-line change once this
information is known.

Lastly, when the Search key acts as Function key option is enabled from
https://codereview.chromium.org/11421055/ then Search-1 through Search-0
produce the keycode F1 through F10, and Search-- and Search-= produce F11 and
F12. This allows applications to easily rely on these keys and consume them the
same way on desktop as on a Chromebook.

R=yusukes@chromium.org
BUG=162268
TEST=unit_tests:EventRewriter.TestRewriteFunctionKeys
Depends on: https://codereview.chromium.org/11421055/

Review URL: https://chromiumcodereview.appspot.com/11417144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170415 0039d316-1c4b-4281-b951-d872f2087c98