- 29 May, 2019 40 commits
-
-
Nikita Podguzov authored
Move platform-specific code to corresponding components by adding display_name in PrinterBasicInfo. Bug: 921093, 947171 Change-Id: I9526b77fcc507b8e2eca54e49cea6b8d764a9a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538431 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#664182}
-
Aya ElAttar authored
Bug: 947621 Change-Id: I1283fb12cd4b335762e7c53c9ba9fbcdb9204649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609709Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#664181}
-
Balazs Engedy authored
This CL concludes the work to restrict the API to secure browsing contexts. It removes the `RestrictDeviceSensorEventsToSecureContexts` flag that could previously be disabled manually to re-enable the API in non-secure contexts, tests that verified the behavior with this flag disabled, as well as all deprecation warnings. Bug: 932078 Change-Id: I742ab162e97017e47b44dfe72e99ef9c24178b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632329Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664180}
-
Balazs Engedy authored
The hypothesis is that the system-level geolocation setting may be turned off on some bots (or by other tests), which then results in the per-origin permission prompt being suppressed as it is triggered without user gesture. This CL overrides the system-level setting to be on for the duration of the test. Bug: 957902 Change-Id: Ia7c3ae27eac87b4dbae0eda328748b59682aefb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632256Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664179}
-
Alan Cutter authored
Change-Id: I5892dee108f3a68c4b7436b2893d37f09d49040e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634289 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4470cd8b405..673784153395 git log e4470cd8b405..673784153395 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 guidou@webrtc.org Add jitterBufferDelay and jitterBufferEmittedCount stats for video Created with: gclient setdep -r src/third_party/webrtc@673784153395 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I90cf09164dbab30e1add14ff23c0e1e506f90dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664177}
-
Koji Ishii authored
It looks like dholbert thinks the test is wrong, see the description of crbug.com/965740. TBR=cbiesinger@chromium.org NOTRY=true Bug: 965740 Change-Id: I60ffe13c36962fb97e0acf0ad37ca097ba6955e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634513Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#664176}
-
Friedrich Horschig authored
This CL wires the address controller up with the manual filling controller. To do that, it splits the bridge function "OnItemsAvailable" which is responsible to propagate the items to the address sheet. The usage of that split is demonstrated in https://crrev.com/c/1614202. The details might change again once the visibility are more fletched out (see https://crbug.com/965478). This CL introduces proper metrics for fields that are contained in sheets. Minor clean-up: the CREDIT_CARDS suggestion type had no representation in enums.xml, so I renamed it and put it in there - along with the new ADDRESS_INFO type. Bug: 926372, 962548 Change-Id: I93fde325d7a462f74a8c86023d607033ba9a6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631651 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#664175}
-
Jan Wilken Dörrie authored
Similarly to r663436 this change implements aliasing the nested autofill::PasswordForm enums to their Mojo equivalent and gets rid of now unneeded type conversions and performs minor clean-ups. TBR=sdefresne@chromium.org Bug: 962853 Change-Id: I7046bb41386b4f1fc53e2127d5c0df84871ca6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631369 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#664174}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7182085..a2dee8aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id85834dd523450d8a0d1dcc9f0b277431e2806c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634609Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664173}
-
Dominic Farolino authored
This reverts commit 35562075. Reason for revert: http://crbug.com/966140 Illustrates that this changes makes it possible for stale-while-revalidate requests to fail the CHECK_EQ in SetReferrer that ResourceFetcher calls into. Since we're near the branch point, the safest thing is to revert this change, and re-land it with a fix once it is discovered. Original change's description: > Set ResourceRequest's referrer string and policy separately > > This should be the final CL for 863769. Before this CL, there > are situations where we eagerly set a ResourceRequest's `Referer` > with ResourceRequest::SetHttpReferrer, sometimes invoking > SecurityPolicy::GenerateReferrer(...). These calls are equivalent > to the Fetch Standard calling into "determine request's referrer" > algorithm. > > After this CL, we opt to set a ResourceRequest's referrer policy and > string members separately as much as possible, minimizing the number > of calls into ResourceRequest::SetHttpReferrer(SecurityPolicy...). The > Referer header will finally be generated when ResourceFetcher calls > into SetReferrer (equivalent to "determine request's referrer" > algorithm). > > This CL also adds more CSS security tests regarding the `Referer` header. > The only observable effect from this CL is that some shared worker referrer > policy tests start passing because we invoke SetReferrer at the right time. > > R=yhirano@chromium.org > > Bug: 863769 > Change-Id: I5f1e6a16f79259c175ec2f9190b84385434f9478 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601813 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#661802} TBR=kinuko@chromium.org,yhirano@chromium.org,domfarolino@gmail.com,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863769 Change-Id: If34aa47908799e741d76ad7c03182442001413c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632612Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#664172}
-
Anders Hartvoll Ruud authored
The old system was designed for the top/right/bottom/left use-case, and then heavily abused for other uses cases which didn't fit (i.e. cases where a matching StylePropertyShorthand didn't exist). The new approach makes it possible to configure the mapping function (the "resolver") and the list of physical properties that mapping operates on (the "physical_group"), independently of whether or not there's a usable StylePropertyShorthand for a given use-case. Change-Id: I7110fa5998456ee6e803a31645a9506d6498218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631394 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#664171}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ca8e3d7c153e..4e61a3c6fa08 git log ca8e3d7c153e..4e61a3c6fa08 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 swiftshader.regress@gmail.com Regres: Update test lists @ ca8e3d7c Created with: gclient setdep -r src/third_party/swiftshader@4e61a3c6fa08 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I84581954b6430a34e42eda643df2acfba53c626b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634409Reviewed-by:
-
Koji Ishii authored
These are tests added by Mozilla. Most tests show different behavior for `webkit-line-clamp` between Blink and WebKit. Gecko seems to have landed in Nightly[1]. Blink failures seem related with inline continuations. WebKit renders nothing for most tests, which I can't explain what is going on. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=866102 TBR=eae@chromium.org NOTRY=true Bug: 305376 Change-Id: If6e001e440a1c9a4fd1303c355c1bb7745e577a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634573Reviewed-by:
-
Martin Robinson authored
In order to fix this issue, we need to undo a change where list markers were rolled into the text of the list item. This also exposes an issue with boundary analysis. It seems that the platform-independent boundary analysis code can sometimes return text offsets in anchors other than the one corresponding to the ATK text. This change addresses those two related issues in order to fix the ATKText interface. We also remove one test for an issue that is no longer present with these changes. Bug: 962498 Change-Id: I7f4e7284e5d212d4eb1b56dad51944cbe03457f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630686Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#664168}
-
Rakina Zata Amni authored
Removing since we're not pursuing Invisible DOM anymore. Bug: 873057 Change-Id: I466b161bb997624704ae866b0f59741d32391784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633870Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#664167}
-
Mike West authored
`fast/writing-mode/text-combine-line-break.html` began failing on Mac bots somewhere in the range https://chromium.googlesource.com/chromium/src/+log/643cb72034fb069695bda8dfb3e8f1af35069923%5E..a9d08087510ec8ce3f6f098a64aed29d93f9ee2d?pretty=fuller&n= * http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/43396 * http://build.chromium.org/p/chromium.mac/builders/WebKit%20Mac10.13%20(retina)/builds/14811 * http://build.chromium.org/p/chromium.mac/builders/Mac10.13%20Tests/builds/13959 * http://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/23420 * http://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/38409 Given the nature of the failure (`0` => `-0`), I suspect https://chromium-review.googlesource.com/c/chromium/src/+/1614448, but it doesn't cleanly revert. Updating text expectations, and assigning to wangxianzhu@chromium.org for investigation. TBR=wangxianzhu@chromium.org Change-Id: Ic37fc83ee6feaaf558ec9bd5e3b3010323c17948 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634849 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#664166}
-
Mario Sanchez Prada authored
While working on other parts of the code I found that the declaration and definition of this method in RenderFrameImpl is not in the rigth place, let's just move it down where it belongs for clarity. Bug: 939943 Change-Id: I1fcfd176d64e23e450f87f69a70c3b9e9309b661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632226Reviewed-by:
-
Maggie Cai authored
This CL turns off the intent picker flag by default so it will not be launched in M76. BUG=939205 Change-Id: I1d332b69e588f422765b1b666e4cd32ab4c3492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634510 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a91e38ab868..77bb464a49a4 Created with: gclient setdep -r src-internal@77bb464a49a4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I9ec2e6f3e994bc05496ff039b834abcf3027d89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664163}
-
Satoshi Niwa authored
https://screenshot.googleplex.com/9DeatA2rSaw.png Bug: 64281746 Test: N/A Change-Id: I7f7af3159cc64dd77895eb8354a210ca887fe3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631535 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664162}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I912f6943460dc6ff483757e21d57a652e20cb9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634376Reviewed-by:
-
Yi Su authored
This CL moves the delegate method "didFailProvisionalNavigation" of WKNavigationDelegate from CRWWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: Ia638555c29ead38944f26f527e9712ff02cb27df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631384 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664160}
-
Tsuyoshi Horo authored
This CL introduces CrossOriginReadBlockingChecker in InnerResponseURLLoader to run the CORB check using CrossOriginReadBlocking::ResponseAnalyzer. InnerResponseURLLoader is a URLLoader which returns a prefetched signed exchange's inner response. This CL also introduces the following changes in CORB related codes under services/network/: - Stop using net::URLRequest in ResponseAnalyzer. Use GURL "request_url" and base::Optional<url::Origin> "request_initiator" instead. This is because InnerResponseURLLoader doesn't use net::URLRequest. - Stop passing ResourceResponse to SanitizeBlockedResponse(). Pass ResourceResponseInfo* instead. This is because InnerResponseURLLoader doesn't use ResourceResponse. - Add comments about SubresourceSignedExchangeURLLoaderFactory in GetTrustworthyInitiator()'s comment. This URLLoaderFactory is used to load prefetched subresource signed exchanges. This URLLoaderFactory is created in the browser process while processing the navigation to a prefetched main signed exchange, and is passed to the renderer process. So this URLLoaderFactory knows the actual initiator of the subresource requests. This URLLoaderFactory keeps the initiator as |request_initiator_site_lock| which is similar to URLLoaderFactoryParams's |request_initiator_site_lock|. Bug: 935267,963752 Change-Id: I0f6d6ce50fb4a3436f3f3061b95151102859b9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623615Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664159}
-
Ian Kilpatrick authored
This merges the two vectors into one using a new struct "ChildWithOffset". There might be a (slight) positive perf impact with this change, as well as a (very slight) decrease in stack. Bug: 635619 Change-Id: I44a981bcf36379ffd94a1490c532c6b70a343e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633019 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#664158}
-
Ian Kilpatrick authored
NGLayoutInputNode::Layout was only used for inflow children of the NGBlockLayoutAlgorithm. This inlines this function (which was a manual method dispatch). This also saves a little (16-bytes) of stack. Bug: 962034, 964926 Change-Id: If227ccf714afb121105875f17f10d6e493365930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629700 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00365de163d6..2b650797a992 git log 00365de163d6..2b650797a992 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a4545bae..b3e0873d (467 commits) Created with: gclient setdep -r src/third_party/skia@2b650797a992 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I62ff27d38544d2ea55d0d34d1167b8345d8c4204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634369Reviewed-by:
-
Anand K. Mistry authored
BUG=926138 Change-Id: I2ffc9b261ac1e81ef0791676b28b3c7c293a8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628500Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664155}
-
Eric Seckler authored
The perfetto service now provides a signal for clearing of incremental state. This patch plumbs the signal into our data sources down to the event sink. Bug: 928738 Change-Id: If4bfb5329eb50e8222cd670ed4a0ece0ad25081e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632213Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Fergus Dall authored
Currently we show the finished message as soon as we learn the packagekitd transaction has completed. This can lead to a noticeable delay before the app being (un)installed is removed/added to the launcher. This CL delays this until all pending app list updates that were running when the operation finished, have themselves finished. This CL depends on changes to cros_system_api in crrev.com/c/1612877 Bug: 937748 Change-Id: I57a36a5e71c7f4e96e2d1ab825ff3f20e05c33a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611434 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#664153}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b97d193baafa..2ee83757a109 git log b97d193baafa..2ee83757a109 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 tikuta@chromium.org [autoninja] use custom status in non-windows too Created with: gclient setdep -r src/third_party/depot_tools@2ee83757a109 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic24465fc92b2a90b9bb132744d3b40da31bd34bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633638Reviewed-by:
-
Yutaka Hirano authored
Move the class so as to platform/loader can use it. Bug: 963306, 914739 Change-Id: I647fc6bfe13c7c895e48842861cb3b84d4e49a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634134Reviewed-by:
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9c6f6cc701b1..ad9db8abe4e8 $ git log 9c6f6cc70..ad9db8abe --date=short --no-merges --format='%ad %ae %s' 2019-05-15 sidereal vm_tools: Notify chrome about pending app list updates 2019-05-16 ljusten kerberos: Add ClearAccounts() method 2019-05-21 briannorris shill: drop ad-hoc support 2019-05-23 dtor system_api: add new_name field to RegisterVm name for Plugin VMs 2019-05-24 dtor system_api: remove STORAGE_CRYPTOHOME_DOWNLOADS from concierge API 2019-04-30 dtor system_api: remove storage_location from concierge's export/destroy 2019-02-08 xiaochu dlcservice: make Install API async Created with: roll-dep src/third_party/cros_system_api Change-Id: I6df087b0cd0eeed70dc0a4da186b20937c4a6252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633693 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
-
Leo Zhang authored
Before a large code refactoring in IME service, convert it to new Mojo types first in order to avoid any conflict during the refactoring with an ongoing Mojo types converting. TEST= /out/ime/chromeos_unittests --gtest_filter=ImeServiceTest* Bug: 837156 Change-Id: I8ae669cb2fe9da980364696675278d3dc1e9516b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632131 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664149}
-
Adam Rice authored
This reverts commit 1f54c905. Reason for revert: Speculative fix for https://crbug.com/968005 (ExtensionApiTest.ChromeRuntimeOpenOptionsPage test failing on MSAN bots) Original change's description: > [Extension test] Add ability to load event_page extension as SW extension. > > Add a flag to RunExtensionTest so that an existing event page based > test extension can be loaded as SW based extension. This can be > used to run extenision tests with Service Worker based extensions. > > This CL also converts runtime/open_options_page/ test extension to event > page extension and demonstrates that the extension be loaded > as SW extension and the corresponding test > ExtensionApiTest.ChromeRuntimeOpenOptionsPage passes with the flag in > ServiceWorkerBasedBackgroundTest.ChromeRuntimeOpenOptionsPage. > > Doc: https://docs.google.com/document/d/1PvXZ7VGRGdmd1s99SFByn9NCGj0GAiBhhPmfjj35ZeI/edit# > > Bug: 967899 > Change-Id: I8821d1c9fa22795b8fe0f65f1bd073a034e24431 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626455 > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664062} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org Change-Id: Ia818e2881a2802e981246c93d205a0ffb9ff9096 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634509Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#664148}
-
Kyle Horimoto authored
An earlier design planned to pass a "cellular network GUID" parameter to StartActivation(), but this is no longer the case, since activation should be allowed even if the device has no SIM card (and thus, no cellular network). This CL removes the parameter; a follow-up CL adds the implementation for this function. Bug: 961084 Change-Id: Ie3026c2b8400f79bd317becb0fc71c5bf740bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629124 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#664147}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15de9f2c..b7182085 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadee9e0c334d3dcb3ba643cfcff29205232f68c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633714Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: Ia465f59ed333d66ebda5fd2f6eeaaa5682ceeb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630385Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b4620d4523a..1a91e38ab868 Created with: gclient setdep -r src-internal@1a91e38ab868 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I4fda48e84b36fb4ad159d83a4616b78bd0695e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633637Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/5ba891aba76f..c7b49740a0c4 git log 5ba891aba76f..c7b49740a0c4 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dneto@google.com Remove dead file (#632) Created with: gclient setdep -r src/third_party/shaderc/src@c7b49740a0c4 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Id7cc856ca25d4b2a9a13c09ef11d50c51abe5692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633635Reviewed-by:
-
