GitLab

Automates all the manual tests from https://crbug.com/887523, which all
relate to omnibox text entry and navigation while in the VR browser.

Bug: 887523
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0db4cc10def31779b8a59f63e2a1f227cf0a6e29
Reviewed-on: https://chromium-review.googlesource.com/c/1263433Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597168}

Change-Id: I9674404c054854d0653a0f2cd61a3b52a85707a8
Reviewed-on: https://chromium-review.googlesource.com/c/1265077Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597167}

Reland "If the caret is at the boundary of a misspelling, getting > > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work

If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu.
On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word.
When any of the above keystrokes are pressed, the user hears the whole word.
It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu.
The result is that many screen reader users might have the mistaken believe that our spell checker is broken.
Tested: Manually, unit tests, layout tests
Bug: 790828

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I847419f299e1a56c4e32a7d00368f663f66072ff
Reviewed-on: https://chromium-review.googlesource.com/c/1252247Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597166}

Some of the tests make assetions on pref values, but they were doing so without
guarantees that the latest value were available. To solve the proble, I forced
the pending values to be written to the prefs and moved the assertion to the
callback that is invoked when this operation has finished.

Bug: 891573
Change-Id: I76411e6d93f061b12af2144cc88e9339531dd3a0
Reviewed-on: https://chromium-review.googlesource.com/c/1261995
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597165}

Before this patch, WebController could not find the form data if that
form data was in an iframe. The logic that cleaned up the selector of
the element that was clicked on to pass to GetElementFormAndFieldData
didn't trigger, as the frame index reported in FindElementResult was 0.

This patch takes another approach: it always only pass the last selector
to GetElementFormAndFieldData, which should make sense, since we're in
the same context as the element that was clicked on.

With this patch, Autofill works even when forms are in an iframe.

Bug: 806868
Change-Id: Ic7deaf863373659e9143c38cf01a6ca1406e6521
Reviewed-on: https://chromium-review.googlesource.com/c/1264600
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597164}

Remove DelayRequestsOnMultiplexedConnections from field trial testing
config since the experiment is now default enabled in Chromium.

Bug: 836552
Change-Id: I9c0e0e233a47f9a92ea0562b77f6dcadea727e5b
Reviewed-on: https://chromium-review.googlesource.com/c/1259963Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597163}

Change-Id: I6dbc74bfa3e1cd27b9893c1d55c3e9277dc08d32
Reviewed-on: https://chromium-review.googlesource.com/c/1261968Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597162}

Bug: 888996
Change-Id: I00f30d4e2ea06be82d5f8872b2e31cf6a6bd1415
Reviewed-on: https://chromium-review.googlesource.com/c/1263556Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597161}

Before this patch, WaitForDomAction could get into situation where
rounds was < 0 and crash in debug mode. This could happen if timeout_ms
was very small or at the end, if the element was not found.

This patch fixes the round counting and dchecks.

With this patch, WaitForDomAction won't crash in debug mode when the
element cannot be found.

Bug: 806868
Change-Id: I308883441876df66225550b9ddc43d1894a48de6
Reviewed-on: https://chromium-review.googlesource.com/c/1264576Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597160}

If chrome crashes on startup, the test itself will fail gracefully
after ~7 min. Bumping timeout let's us hit that reliably, and lets the
test do some cleanup. (Instead of killing it early.)

R=jbudorick

Change-Id: I9c23198e3267b3a438b9a41daadb4ba70e20de4d
Reviewed-on: https://chromium-review.googlesource.com/c/1262799Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597159}

The rest of the strings in the Preview Page Info dialog don't have
periods at the end, so remove this one too.

Bug: 871839
Change-Id: I3d70e667aaace71df1586bf670c03e1fac55d02e
Reviewed-on: https://chromium-review.googlesource.com/c/1264935Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597158}

https://android.googlesource.com/platform/external/perfetto.git/+log/4c11f3dcc855..f8ef3c03bb5d


git log 4c11f3dcc855..f8ef3c03bb5d --date=short --no-merges --format='%ad %ae %s'
2018-10-05 lalitm@google.com Merge "trace_processor: fix sorting of events in sched tracker"


Created with:
  gclient setdep -r src/third_party/perfetto@f8ef3c03bb5d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ibd2a135f8f13d9e6401a5eb19c145500a27a766f
Reviewed-on: https://chromium-review.googlesource.com/c/1264631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597157}

A line was accidentally left out when moving code in the previous cl [1] resulting in outputs from the previous query not being cleared when making a new query when the `Show incomplete results` option was enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1252324

Change-Id: I12f8465898171badff2e6c4f69fcbcaf121f680b
Bug: 891303
Reviewed-on: https://chromium-review.googlesource.com/c/1264815Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597156}

Three video related tests are failing flakily on the Android FYI
trybots. Failures have been seen on Nexus 9 and Nvidia Shield primarily,
so will set them flaky for nvidia boards.

TBR: kbr@chromium.org
Bug: 891456
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I64d768be4cabf246b6e0ab007c87c2292a8adf42
Reviewed-on: https://chromium-review.googlesource.com/c/1263037Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597155}

Before this patch, the overlay was displayed when Autofill Assistant was
created.

This is confusing: the overlay is meant to reflect the fact that scripts
are running, but no scripts are running at that point and there might
never be any scripts.

With this patch, the overlay is only displayed when a script is run.

Bug: 806868
Change-Id: I2e1916a0253efb164b4b000c92f2cfef6a1703ad
Reviewed-on: https://chromium-review.googlesource.com/c/1264677Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597154}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/060ca87d..949f77f4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5cfbc94e8650675582b8f2e6169b9cb6943e6e93
Reviewed-on: https://chromium-review.googlesource.com/c/1264735Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597153}

This reverts commit e9f339db.

Reason for revert: issue has been solved.

Original change's description:
> [WPT export] More temporary logging to debug crash
> 
> The working theory is that the locale isn't correctly set in the
> Python process. The interactive shell on the bot does have a UTF-8
> locale, but the environment of the Python process could be different. To
> verify this, we add some more logging to wpt-export.
> 
> This CL will be reverted once the issue is resolved.
> 
> Bug: 891831
> Change-Id: Ice6478a2b4f3805f2a68b4e2b782f0f23e9aeb99
> Reviewed-on: https://chromium-review.googlesource.com/c/1261974
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596782}

TBR=qyearsley@chromium.org,robertma@chromium.org

Change-Id: Icf05a7a7163a948fba10ff3991df2ccc34b4865a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891831
Reviewed-on: https://chromium-review.googlesource.com/c/1265017Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597152}

Using wpt-import in Chromium 72378c90.
With Chromium commits locally applied on WPT:
65d72632 "Make DTMF tone change more deterministic"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25878

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I01f5467192473c33c0fbec6d80115159657bba63
Reviewed-on: https://chromium-review.googlesource.com/c/1264738
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597151}

Speculative fix to single process mash content_browsertests
start-up hang by allowing nested task while waiting for display.

Bug: 892173
Change-Id: Ia146293d8f2553cd8233feae80786e56402c7c55
Reviewed-on: https://chromium-review.googlesource.com/c/1262925Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597150}

Add two UKM fields to Media.Engagement.SessionFinished to
track the total playbacks from audio contexts and media
elements.

BUG=887619

Change-Id: Icb1ed1300114b09737bab2393b5c3d40e870fc5f
Reviewed-on: https://chromium-review.googlesource.com/c/1236924Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597149}

BUG=892436

Change-Id: I1576d16bb1c370710a6374482fd146e639145b91
Reviewed-on: https://chromium-review.googlesource.com/c/1263353Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597148}

Change-Id: I7c061bdd3c4cc4ee084b0a9311a0c1d65f533494
TBR: dcheng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1259290
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597147}

Opening a drop-down menu in a webpage will create a new
RenderWidget with a new LayerTreeHostImpl, whose value
of the top_controls_shown_ratio_ (initialized to 0) will
be pushed to the browser when a new compositor frame is
generated. This will cause top-chrome to hide briefly
on opening the menu which will result in closing the
menu immediately.

This CL fixes the issue by allowing only the main frame
widget to set the shown ratio.

BUG=891471
TEST=Manual, added a new browser test.

Change-Id: I8ead7f903d56e68523a7654abc21aa6e5ca7b690
Reviewed-on: https://chromium-review.googlesource.com/c/1258348Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597146}

Ensure the print button starts out with a default "Print" value instead
of waiting for the destination to load to display text.

Bug: 892093
Change-Id: I1ca54476107a112ac4cccde463b8f1def1e6e501
Reviewed-on: https://chromium-review.googlesource.com/c/1262619
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597145}

The current implementation of find in the the PDF viewer will not find
a match for text, if the matching text in the document is broken over
two lines. This is rooted in the fact that the page text will have
extra characters like \r and \n representing the line break in it.

This CL adds in collapsing all line breaks and whitespace regions into
single ' ' characters when searching. A test has been added to confirm
that searching over line breaks works correctly.

Originally landed as https://chromium-review.googlesource.com/c/1258042
Reverted in https://chromium-review.googlesource.com/c/1262618, due to
an old version of the CL being landed.

BUG=chromium:58402

Change-Id: Iad69ab5e9965658f89df4b209dba06a322b15374
Reviewed-on: https://chromium-review.googlesource.com/c/1262658
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597144}

Only DetachTimeFg16x is added because it is the most
different variation from control, while other variations
test values in between.

Bug: 847501
Change-Id: Ifbf70af688249d48772779229e2af56a12e1b274
Reviewed-on: https://chromium-review.googlesource.com/c/1263042Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597143}

TBR: weiliangc@chromium.org
Bug: none
Change-Id: I0809911bbd85d7b7431c052422ce28437b33af4a
Reviewed-on: https://chromium-review.googlesource.com/c/1264817
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597142}

https://skia.googlesource.com/skia.git/+log/b3ce196a4d9d..032f2756df64


git log b3ce196a4d9d..032f2756df64 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@032f2756df64

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Icf07e3b693c664b66ab4b8b2228ff08c55672549
Reviewed-on: https://chromium-review.googlesource.com/c/1264630Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597141}

The tests are failed due to FieldTrialSynchronizer is created early and posts
task to BrowserThread::UI before the UI thread is initialized. In this case,
the FieldTrialSynchronizer doesn't need to post task to UI thread since the
renderers are not created yet.

Bug: 892636
Change-Id: Ib7d46709f3fca6a749b82d0ba2f601dcf551a8d0
Reviewed-on: https://chromium-review.googlesource.com/c/1264737
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597140}

The same anchor element may be stored more than once in
anchor_element_metrics_sender. Use a HashSet to avoid
duplicate storage. This allows the
navigation prediction logic in browser process is unable
to accurately determine the visibility ratio of a target
HREF.

Change-Id: I087e653f15094f8e32d66daa0d2cc6464d90f306
Bug: 891719
Reviewed-on: https://chromium-review.googlesource.com/c/1258822Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597139}

Style sharing is gone. No need for SetUnique here.

Change-Id: I1959397a2939ee2ab86e7301ac4fb5a47a8cd100
Reviewed-on: https://chromium-review.googlesource.com/c/1264581Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597138}

This is a reland of 581a728b
Fix for the revert in http://crrev.com/c/1264175

Original change's description:
> synthetic gesture: Allow high-frequency dispatch.
>
> For synthesized scroll/drag/pinch gestures, dispatch the events
> at a high frequency (120Hz) so that there's at least one event in
> each frame. Dispatching events at a lower frequency (60Hz) means
> the timer can go out of sync with begin-frame, and so there can
> be frames where there was to event dispatch. Our telemetry code
> reports this as jank, which is incorrect. Dispatching at a higher
> frequency for the scroll/drag/pinch gestures resolves this issue.
>
> BUG=783034
>
> Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223
> Reviewed-on: https://chromium-review.googlesource.com/c/1255152
> Reviewed-by: Victor Miura <vmiura@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596507}

TBR=vmiura@, nzolghadr@, lanwei@ since reland without changes

Bug: 783034
Change-Id: I7cb96177df54729b24f5414c897cca97456e9484
Reviewed-on: https://chromium-review.googlesource.com/c/1263882Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597137}

This is a first step in moving the system-wide metric measurement code out of base/process/

TBR: jam@chromium.org, dalecurtis@chromium.org
Bug: 891864
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I615190d5413937640a7bd29b68b18028445e4c88
Reviewed-on: https://chromium-review.googlesource.com/c/1260003Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597136}

The dropdown shouldn't be closed on random clicks on Mac.
The focus changes are already handled by the cross-platform code.

Bug: 888491
Change-Id: Ic5d40f7de3ae32270716e2df33e9944a1120bc75
Reviewed-on: https://chromium-review.googlesource.com/c/1264595Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597135}

Bug: 887914
Change-Id: I2e5c1be711c9242b5efc9a8d8013c95334bba0fb
Reviewed-on: https://chromium-review.googlesource.com/c/1264679Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597134}

Bug: 806868
Change-Id: Idc3b29bd5278166644650d7a248db0112be1373a
Reviewed-on: https://chromium-review.googlesource.com/c/1258166
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597133}

AcceleratorDelegate's only purporse was to create AcceleratorRouter and
route events to it. This made sense early in on mash work, but the separation
is no longer useful. So, I removed AcceleratorDelegate and made
AcceleratorRouter implement ::wm::AcceleratorDelegate.

Renamed AcceleratorRouter to PreTargetAcceleratorHandler, to better indicate
when this class is called and what it handles.

Renamed AshFocusManagerFactory::Delegate to PostTargerAcceleratorHandler.
Again, this better indicates it's responsibilities. PostTargerAcceleratorHandler
also deals with focus changes, but I figure the name
PostTargerAcceleratorHandler is better than Delegate.

BUG=none
TEST=covered by tests

Change-Id: Ib92dd35b4bb87b8c0772a499564ee7d6e86c2175
Reviewed-on: https://chromium-review.googlesource.com/c/1263417
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597132}

When a ServiceWorker script passes a Response back to FetchEvent.respondWith()
the browser must get the resulting Response body data back to the outer
network loader.  For non-blob bodies this is currently done by creating a new
mojo::DataPipe and copying the body into its producer handle.  The pipe's
consumer handle is then passed back to the outer loader.

In many cases, however, there is already a mojo::DataPipe for the Response
body created by the network code.  Its sub-optimal to allocate a new pipe and
copy data across to it in these cases.

This CL will attempt to extract the underlying mojo::DataPipe from the
Response and pass it directly back to the outer loader.  Currently this will
only trigger for cases where the FetchEvent.preloadResponse is passed to
respondWith().  In the future, however, we should be able to make this work
for "pass-through" cases where the Response is produced by fetch().  That
work is ongoing in https://crrev.com/c/1251841.

R=kinuko@chromium.org

Bug: 884807
Change-Id: I5a2964ff2e9463492ef72e5b48c5f383ebf36a86
Reviewed-on: https://chromium-review.googlesource.com/c/1239394
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597131}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates Android's WarmupURLFetcher and the
respective unittests away from URLFetcher.

Also, the CL relax an NOTREACHED scenario in TestSharedURLLoaderFactory,
now that some tests call ::Clone on it.

Bug: 879777
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7b1664a141e409cc2cf43fe8a79eb771e9a9988b
Reviewed-on: https://chromium-review.googlesource.com/c/1251641
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597130}

This already happens for enterprise, guest and legacy supervised users.
This change hides powerwash section also for managed child accounts.

Bug: 891493
Change-Id: I3b573c56f2e09d4e9220415a1df0b191fe5d6cd0
Reviewed-on: https://chromium-review.googlesource.com/c/1258262Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Bruno Santos <brunoad@google.com>
Cr-Commit-Position: refs/heads/master@{#597129}