- 28 Sep, 2018 40 commits
-
-
Peter K. Lee authored
Official build with Firebase enabled uses variants to specify which Info.plist to use as resource for Firebase. This causes a conflict as two bundle_data have the same output path. Move the dependency on ios_firebase_resources_target to the definition of the "chrome" target, behind the check for use of the variants to prevent this conflict. Patchset 1 is the original CL http://crrev/c/1250924 by sdefresne from which this CL is cloned from. TBR=sdefresne@chromium.org, justincohen@chromium.org Bug: 845383 Change-Id: I0e74f04f27708eb970c61b1048cb2492c45cbba4 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1252321 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#595187}
-
Chong Zhang authored
Some tests (e.g. ArcSessionManagerTest.ConsumerAccount) are already flaky on waterfall, and we don't want them here to avoid confusions. Bug: 881976 Change-Id: Iddc8fd5f18ab6abe54038a5078750bf16968c272 Reviewed-on: https://chromium-review.googlesource.com/1252011Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595186}
-
Vasilii Sukhanov authored
Bug: 890336 Change-Id: I649336ca32aa4b23b8859a06f44bdf8dc7a6da26 Reviewed-on: https://chromium-review.googlesource.com/1251464 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#595185}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/656cefe65d62..f88f49d2a52e git log 656cefe65d62..f88f49d2a52e --date=short --no-merges --format='%ad %ae %s' 2018-09-28 mtklein@google.com Revert "Have Renderer use combined path code" 2018-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e8dd07969872..af0f31d3a909 (2 commits) 2018-09-27 csmartdalton@google.com Cleanup resource flags 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 122919bddd98..e8dd07969872 (4 commits) 2018-09-27 bungeman@google.com Detect macOS font smoothing behavior. 2018-09-27 egdaniel@google.com Remove assert about top left origin in lazy image generator unique key. 2018-09-27 herb@google.com Have Renderer use combined path code 2018-09-27 nathanrogers@google.com Fix a typo in SkISize comments 2018-09-27 bsalomon@google.com Reland "Change how GrTextureOp computes outset vertices." 2018-09-27 scroggo@google.com Make SkCodec truly default to sRGB 2018-09-27 borenet@google.com [infra] Add nightly UpdateGoDEPS Created with: gclient setdep -r src/third_party/skia@f88f49d2a52e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:858861,chromium:887372 TBR=bsalomon@chromium.org Change-Id: I4800ec89e6f922e57489b97b2672cf009c93dd34 Reviewed-on: https://chromium-review.googlesource.com/1250949 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595184}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0aa6f4e3a57..32381e30ef56 git log f0aa6f4e3a57..32381e30ef56 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 stevenperron@google.com Handle decoration groups with no decorations. (#1921) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@32381e30ef56 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iac1c369a62c44201f68dabec0be16659431390e7 Reviewed-on: https://chromium-review.googlesource.com/1252262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595183}
-
Theresa authored
Add an animtion for the button appearing and disappearing. Also animate the button when the URL is focused/unfocused. BUG=889536 Change-Id: I7ca53c2e41da3bedab5b07a133ab4475887c3e17 Reviewed-on: https://chromium-review.googlesource.com/1246944 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#595182}
-
Torne (Richard Coles) authored
The supported version of the Android NDK now provides sys/ucontext.h for all architectures, and we no longer need to provide our own definitions. Keep the ones used by PNaCl but update the defines to no longer use them on Android. Bug: 437330 Change-Id: Ia46c746b17b72261842284d4fed3772fea3a96ef Reviewed-on: https://chromium-review.googlesource.com/1252243Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595181}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7453eba4feb2..d525ef309fca git log 7453eba4feb2..d525ef309fca --date=short --no-merges --format='%ad %ae %s' 2018-09-28 perezju@chromium.org [pinpoint_cli] Add isolate_service module. Created with: gclient setdep -r src/third_party/catapult@d525ef309fca The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: Ic1f1490a93133c829095aa4f3d53710bf58a6fa7 Reviewed-on: https://chromium-review.googlesource.com/1250945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595180}
-
Fabio Tirelo authored
Bug: 874094 Change-Id: Id80332c84f574b70ba0b0e50f54aebb681276082 Reviewed-on: https://chromium-review.googlesource.com/1251229Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595179}
-
Egor Pasko authored
This is a followup to crrev.com/595106, realizing that there are ~80 more lines to change. The same (anti)pattern is found in: shell> git grep '\\\\\\/' -- '*.py' # my job is counting slashes android_webview/support_library/PRESUBMIT.py mojo/PRESUBMIT.py native_client_sdk/PRESUBMIT.py third_party/blink/PRESUBMIT.py third_party/blink/renderer/bindings/PRESUBMIT.py Not updating these files now because: 1. lazy 2. allowing the world where this might break 3. will shoot those at different OWNERS Bug: None Change-Id: Ib9d9209098147fa9a36bb179a138b625ad2ff3d6 Reviewed-on: https://chromium-review.googlesource.com/1251629Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595178}
-
Jialiu Lin authored
The incognito mode profile should be aware of the user's advanced protection status (from original profile) if the user signs into Chrome. Bug: 887754 Change-Id: Ic4dec677f9adf1464b8c7398934f2d10cb62323b Reviewed-on: https://chromium-review.googlesource.com/1247001Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#595177}
-
Matt Wolenetz authored
In 1240638e, AVC keyframeness analysis result in MP4 was used instead of MP4 keyframe metadata, but the conversion of the AVC frame to Annex-B (and the conditional injection of SPS/PPS) still relied upon the MP4 keyframe metadata. Since that metadata could be incorrect, decode errors could occur on some decoders due to missing SPS/PPS data for incorrectly muxed AVC keyframes. This change performs the bitstream analysis as part of frame conversion, after converting to Annex-B, but before the conditional SPS/PPS injection, and uses the analysis's keyframe result (if determined) to condition the injection instead of the MP4 keyframe metadata. BUG=889311 Change-Id: I1ef327ef7d399d5a9da552e0da4a58b0f0b04435 Reviewed-on: https://chromium-review.googlesource.com/1250171 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595176}
-
Troy Hildebrandt authored
Keys and entries can currently be loaded separately, but never at the same time, meaning it requires separate calls to LoadKeys/LoadEntries to get keys and entries. Some users of ProtoDatabase have resorted to storing the keys in the entries to get around this. This CL adds LoadKeysAndEntries(WithFilter) that returns both at the same time. ProtoDatabase's new LoadKeysAndEntriesCallback gives back a vector of string/proto pairs. Bug: 883409 Change-Id: Id624bbdeb356395c6ce679528d85c1f934a9772e Reviewed-on: https://chromium-review.googlesource.com/1228305 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595175}
-
Chris Palmer authored
De-confuse the terminology. Bug: None TBR: avi, caitkp, rdevlin.cronin, eugenebut, dalecurtis, mmenke, jsbell, foolip, tsepez, dcheng Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: I47f32cdd2e937c0f0014a4813a4ddfd74b049d73 Reviewed-on: https://chromium-review.googlesource.com/1247227 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595174}
-
Jeffrey Kardatzke authored
This is a temporary solution to taking screenshots for tast-tests that will work properly on ARM devices as well as deal with hardware overlays. Longer term the plan is to implement this via the DRM API with a write-back connector and then use that from the CLI screenshot program. BUG=chromium:849438,chromium:880597,chromium:887016 TEST=tast run graphics.Screenshot (after updating it to use this) Change-Id: I3919822599338e4786c715d7b0419742417b83c2 Reviewed-on: https://chromium-review.googlesource.com/1247181 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595173}
-
Avi Drissman authored
BUG=none TBR=wittman@chromium.org Change-Id: If60be20e1ef4e59838be04821eec0b30eba4d2be Reviewed-on: https://chromium-review.googlesource.com/1252242Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595172}
-
Avi Drissman authored
BUG=880210 TEST=as in bug Change-Id: I9f305084bf9f6b146d0323baeabc4437466857df Reviewed-on: https://chromium-review.googlesource.com/1252241Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595171}
-
Francois Doray authored
TBR=acondor@chromium.org Bug: 890380 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibce268155e198a855e6815bced44578001b8279e Reviewed-on: https://chromium-review.googlesource.com/1252083Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595170}
-
Ben Pastene authored
Bug: 876587 Change-Id: I340c12102a697d6f1b710594111536de564a338c Reviewed-on: https://chromium-review.googlesource.com/1239354 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595169}
-
Tonko Sabolčec authored
This CL includes: - Enable feature for deleting corrupted passwords - Enable feature for preventing overwriting the encryption key - Disable feature that recovers passwords for Sync users (covered with the new feature) - Update tests Bug: 791541 Change-Id: I1726515dbd74ad2fa64ef1abf419e88c65d48bf0 Reviewed-on: https://chromium-review.googlesource.com/1240300 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#595168}
-
Xida Chen authored
We have num_of_active_touches_for_test in both TouchActionFilter and InputRouterImpl class which are used in InputRouterImplTest only. This CL makes InputRouterImplTest a friend class to TouchActionFilter so that we can just access its private member. This CL is a code cleanup, there is no behavior change introduced. Bug: None Change-Id: I768a5e293f5c16d1f1d39af7e2abf161f35e669d Reviewed-on: https://chromium-review.googlesource.com/1246274Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595167}
-
Avi Drissman authored
This reverts commit f7e423bf. Reason for revert: This was a speculative fix, thinking that perhaps WillClose() wasn't getting called. But it is, and all the correct calls are being made (see https://bugs.chromium.org/p/chromium/issues/detail?id=880210#c16) so this code only complicates things. Original change's description: > Make sure to unblock a WebContents during a mass dialog closure. > > BUG=880210 > > Change-Id: I44e80bc0866fef5370936db3f2cb4d3eacf620f2 > Reviewed-on: https://chromium-review.googlesource.com/1241094 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594135} TBR=avi@chromium.org,wittman@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 880210 Change-Id: Ibbd669649add66e0bc4052eb6b04c845ffb40f38 Reviewed-on: https://chromium-review.googlesource.com/1249389Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595166}
-
Torne (Richard Coles) authored
The cleanup was already done in https://codereview.chromium.org/92903003 but the associated comment wasn't removed. Also fix a comment typo I spotted in the original CL. Bug: 290992 Change-Id: I27fdd333169234f3ac2816f96bda2c94d0bb21f2 Reviewed-on: https://chromium-review.googlesource.com/1252162Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595165}
-
Caroline Rising authored
Highlighting was previously added to buttons with anchored widgets. This is not the desired effect for promo buttons. This change makes the highlighted function overridable and removes the button highlight for the feature promo bubbles. Bug: 888462 Change-Id: I79077bf9e7f30543eee6ae87db0785e9a0e08051 Reviewed-on: https://chromium-review.googlesource.com/1246144 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595164}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 10a65146. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25463 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ifa85ef7ed34ebed1c59a1839ced1db8da4ebfd4d Reviewed-on: https://chromium-review.googlesource.com/1251984 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595163}
-
Gang Wu authored
Bug: 867770 Change-Id: If1d986bfc6f77320d04701dac341c4a8f6f0fda2 Reviewed-on: https://chromium-review.googlesource.com/1250094 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#595162}
-
Boris Sazonov authored
This CL adds ApiCompatibilityUtils.createLayerDrawable and LayerDrawableCompat. createLayerDrawable creates LayerDrawableCompat on Android K and earlier versions and falls back to regular LayerDrawable on newer versions. LayerDrawableCompat overrides mutate() method to work around an issue in LayerDrawable.mutate() when the bounds of child drawables aren't properly copied during the mutation. This issue would force ImageView to appear empty if it contains a LayerDrawable and this drawable is mutated. Bug: 890317 Change-Id: I3479a304917df1873645ccfda7102475981eff5b Reviewed-on: https://chromium-review.googlesource.com/1251544Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595161}
-
Daniel Erat authored
In an attempt to make login failures easier to debug, update several messages describing progress and errors to include string descriptions of numeric codes: Policy validation failed: 2 Session manager operation failed: 5 Failed to retrieve cros policies. Reason: 5 Resolved state to: 13 Bug: 888520 Change-Id: I8c331c6af7f68dd2e0aa7cdfc98336f4af27f9c2 Reviewed-on: https://chromium-review.googlesource.com/1249730Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#595160}
-
Koji Ishii authored
This is a reland of 5cae37b5 Two tests that were changed from Failure to Crash turned out to be flaky, they do not crash on linux-xenial-rel. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3698 Original change's description: > [LayoutNG] Make constraint space for column balancing intermediate > > Fragment caching and paint needs to know if fragments created > for a constraint space are for the regular layout that are to > be painted, or it's for intermediate computation. > > Since the layout results for column balancing should not be > painted, this patch marks so. > > This change alone doesn't fix all weird paint data > inconsistencies when block fragmentation is turned on. Other > issues need further investigation. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 > Reviewed-on: https://chromium-review.googlesource.com/1250685 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595051} TBR=mstensho@chromium.org Bug: 714962, 890326 Change-Id: I3ed406ee0ab34f63e3c5b6a7352dac44274014f9 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1251682Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595159}
-
Joel Einbinder authored
Bug: 875173 Change-Id: Ifd08a9fe6c6ba08af9f98f92570f523987959e5a Reviewed-on: https://chromium-review.googlesource.com/1250170Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#595158}
-
Manas Verma authored
This is a reland of d54e0de4 Original change's description: > [Autofill] Browser Tests for Sign-in After Local Save. > > Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt. > > Bug: 855186 > Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7 > Reviewed-on: https://chromium-review.googlesource.com/1196918 > Commit-Queue: Manas Verma <manasverma@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592227} Bug: 855186 Change-Id: Id7258331f021a1f69dd84f7f6e6fc77b01f0885d Reviewed-on: https://chromium-review.googlesource.com/1241558Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#595157}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6ff2f64702dc..f0aa6f4e3a57 git log 6ff2f64702dc..f0aa6f4e3a57 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jaebaek@google.com Fixed Validator adjacency bug for OpPhi (#1922) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f0aa6f4e3a57 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78346971e87db385689ea12bb6666c6d5f9c5b9f Reviewed-on: https://chromium-review.googlesource.com/1251983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8241a7599974..82b404766db2 git log 8241a7599974..82b404766db2 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 chowes@google.com Fix symlink to build_dlc script 2018-09-28 saklein@chromium.org cros_choose_profile: remove unused argument 2018-09-28 saklein@chromium.org build_stages.InitSDKStage: update chroot Created with: gclient setdep -r src/third_party/chromite@82b404766db2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6e27b62cb504b4ab991850a84fb9d308a4eaa9c1 Reviewed-on: https://chromium-review.googlesource.com/1251986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595155}
-
John Z Wu authored
Additional ones to follow. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2181ea6891f17692d74765ff7f806420b43e8983 Reviewed-on: https://chromium-review.googlesource.com/1226368 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#595154}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/fb86b888ef1c1265719208fd6c27a53ceb4920f7..13fd627449cefbae7576d4b145cb24fac303fc7d BUG=890115 Change-Id: Id0a70faca0e68750a73551abf2ab79dc09a970e4 Reviewed-on: https://chromium-review.googlesource.com/1251333 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#595153}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id72e1a333e00d9bc21dfdbdcce9bde2928b5aa1a Reviewed-on: https://chromium-review.googlesource.com/1252082 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595152}
-
Rune Lillesveen authored
Change-Id: I83b5fb8ff7219d5846d85ebd3f8e1e9ba695b6c5 Reviewed-on: https://chromium-review.googlesource.com/1251381Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595151}
-
Tetsui Ohkubo authored
According to spec, network's tray icon size changed from 16dip to 20dip, and we no longer have 2dip padding around network icons. Also, because of that, new we can remove 1dip y-axis adjustment of |top_left| badge e.g. "LTE" for cellular network. For detail, see the screenshot in the bug. TEST=manual BUG=889589 Change-Id: Ib5eee3d05116e9deff936e6cb5287de9ac68a2de Reviewed-on: https://chromium-review.googlesource.com/1250381Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595150}
-
Devlin Cronin authored
Move the musicManagerPrivate API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. TBR=gab@chromium.org (comment update in chrome_pref_service_factory.cc) Bug: 877240 Change-Id: Id4bec073d3f9698682f40720852843fa03347900 Reviewed-on: https://chromium-review.googlesource.com/1220326 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#595149}
-
Bailey Berro authored
- Adds the correct link for the network file shares help page. The content on the target page is still being updated. Bug: chromium:889830 Change-Id: I583ed05c144d5938c4c9acdadb4515e1828bc8f3 Reviewed-on: https://chromium-review.googlesource.com/1249824Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595148}
-