- 06 Jun, 2019 40 commits
-
-
Matthew Cary authored
The recent refactoring CL crrev.com/c/1613297 introduced unnecessary duplication of file descriptors. Worse, those descriptors could leak, eventually leading to resource exhaustion. As an added bonus, several legacy uses of SharedMemory and SharedMemoryHandle are updated to the new API. See crbug.com/965455 for a motivating example of leaky file descriptors. Bug: 849207, 971575 Change-Id: I8b6c06689d99a12c97af19bd3eabdb0918b1ba22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645301 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#666626}
-
Kinuko Yasuda authored
This reverts commit 7c7006f2. Reason for revert: Sorry, this was a wrong one! Original change's description: > Revert "Use physical coordinate types for frame and document geometries" > > This reverts commit 34f126fe. > > Reason for revert: For reverting https://chromium-review.googlesource.com/c/chromium/src/+/1643911, whose tests are broken on multiple Mac bots > > Original change's description: > > Use physical coordinate types for frame and document geometries > > > > We are already using physical coordinates for frame and document > > geometries. This CL just changes the type of the geometry data. > > > > This includes > > - removal of LayoutRect/LayoutPoint version of frame coordinate mapping > > functions, > > - change callsites of frame coordinate mapping functions to use > > physical coordinate types, > > - change of type of ScrollIntoView parameter and return values. > > > > R=bokan@chromium.org,skobes@chromium.org > > TBR=aboxhall@chromium.org for simple passive change under renderer/modules/accessibility > > TBR=fserb@chromium.org for simple passive change under renderer/modules/canvas > > > > Bug: 969383 > > Change-Id: Id6e70c672cc1a6402cf2baff55e62ffd076d3736 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639527 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Steve Kobes <skobes@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666515} > > TBR=wangxianzhu@chromium.org,bokan@chromium.org,skobes@chromium.org > > Change-Id: Iac97429979a11db020e08104b4aeeba598168e41 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 969383 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647504 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666620} TBR=kinuko@chromium.org,wangxianzhu@chromium.org,bokan@chromium.org,skobes@chromium.org Change-Id: If733ff62d650e0265f4b258caafdee6f8b0fdbcb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647509Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666625}
-
Eero Häkkinen authored
This allows to simplify Write methods in NativeFileSystemFileHandleImpl. Bug: 957214 Change-Id: I4e1ba58a7f904ebe5f60d355f20cdd6c5cb497bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645782Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#666624}
-
Dominick Ng authored
This CL allows Chrome OS to query ARC for whether a PWA has a supported related app available and installable. If it does, the installation action redirects to the Play Store. A Finch kill-switch to disable the behaviour is also added. BUG=969560 Change-Id: I7f2d748836400aecec40655e25de0e2f901c4432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642753Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#666623}
-
Leon Han authored
This CL just renames NFCWatchOptions to NFCReaderOptions according to the new spec definition, in preparation for the next step to implement NFCReader Javascript interface. http://w3c.github.io/web-nfc/#dom-nfcreaderoptions The spec change: https://github.com/w3c/web-nfc/commit/023d6c39f2ccd4dfd1541c259e7810a2b03af762 BUG=520391 Change-Id: I9614c5075c98334a9e573972666c6bd942bd1392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638934 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#666622}
-
Leon Han authored
This CL switches the existing enum NFCWatchMode to NDEFCompatibility which is newly defined at http://w3c.github.io/web-nfc/#dom-ndefcompatibility and updated the behaviors implemented in Device Service accordingly. Now we just use it for watch operations, in the future we'll be using it for push operations as well. BUG=520391 Change-Id: I82cf736d1a57044e9fd59a350b748b99548f9a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628537 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666621}
-
Kinuko Yasuda authored
This reverts commit 34f126fe. Reason for revert: For reverting https://chromium-review.googlesource.com/c/chromium/src/+/1643911, whose tests are broken on multiple Mac bots Original change's description: > Use physical coordinate types for frame and document geometries > > We are already using physical coordinates for frame and document > geometries. This CL just changes the type of the geometry data. > > This includes > - removal of LayoutRect/LayoutPoint version of frame coordinate mapping > functions, > - change callsites of frame coordinate mapping functions to use > physical coordinate types, > - change of type of ScrollIntoView parameter and return values. > > R=bokan@chromium.org,skobes@chromium.org > TBR=aboxhall@chromium.org for simple passive change under renderer/modules/accessibility > TBR=fserb@chromium.org for simple passive change under renderer/modules/canvas > > Bug: 969383 > Change-Id: Id6e70c672cc1a6402cf2baff55e62ffd076d3736 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639527 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666515} TBR=wangxianzhu@chromium.org,bokan@chromium.org,skobes@chromium.org Change-Id: Iac97429979a11db020e08104b4aeeba598168e41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647504Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666620}
-
Jose Dapena Paz authored
We are setting kAlive and kDead values assigning values that are bigger than the maximum signed int32. It is better to use uint32_t in this case. Bug: 819294 Change-Id: If72b48291a66a3a9db24b4c8e2d11d31936a66ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645772Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#666619}
-
François Degros authored
Bug: 778674 Change-Id: Ib270ab8c6f7ddc916d724ae8e0d64bbce22031ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647643 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666618}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3e96934da3a34bffff180238ee4d40d383bdcb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666617}
-
François Degros authored
Bug: 778674 Change-Id: Ib2227b40a8f68080bbc0116d23654286ed8a2d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646804 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666616}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e4a2c7e255e..d1cb1f425b4b git log 2e4a2c7e255e..d1cb1f425b4b --date=short --no-merges --format='%ad %ae %s' 2019-06-06 jbudorick@chromium.org Remove duplicate devil OWNERS file. 2019-06-06 ntfschr@google.com Devil: treat eng builds as always root 2019-06-06 dberris@chromium.org SheriffRedux: Use google-auth when polling Created with: gclient setdep -r src/third_party/catapult@d1cb1f425b4b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:968886,chromium:953181 TBR=skyostil@google.com Change-Id: If3b546984e9d5e92149a6e15ead493b04d9e5d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666615}
-
François Degros authored
Bug: 778674 Change-Id: Ic0e6c4588bb7258a87d7817196ef554591e62e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647642 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666614}
-
François Degros authored
Bug: 778674 Change-Id: I26adb7ae525b1965280b60479095de3e8a32562e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647640 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666613}
-
Jan Wilken Dörrie authored
This change implements a native TouchToFillController. This class will be invoked whenever the Touch to Fill sheet should be shown in the Android UI. A change implementing the Java side will follow. Bug: 957532 Change-Id: I3beccecf68f501b7374b1a6c16c7daf229913500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640546Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#666612}
-
François Degros authored
Bug: 778674 Change-Id: I14c981ffc87b504e5dd1dfca57097e627a72a06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647641 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666611}
-
Eric Willigers authored
Web Platform Tests for the computed values of the min-block-size/min-inline-size, and max-block-size/max-inline-size properties. https://drafts.csswg.org/css-logical/#dimension-properties Change-Id: I8377da7f48575a64365af26ed6467411a63eac0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637004 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#666610}
-
François Degros authored
Bug: 778674 Change-Id: I9481d1204ad9d8392121c91c7f55ff2f1d2260cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647639 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a406538f2fc..bde6efc8bb94 Created with: gclient setdep -r src-internal@bde6efc8bb94 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I0c803d6085014b7985f795b4a4098904ef45d095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647674Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666608}
-
Jun Mukai authored
Since Mash / WS is gone, the window finder class can be significantly simplified. This CL does this simplification. Also moves ash/wm/window_finder.h to ash/public/cpp; this file would be helpful for others. Bug: none Test: trybot Change-Id: I0dc745c3f5b5ae8d09afbea6930e6203dac29e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645178Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#666607}
-
Alexander Hendrich authored
This CL adds hendrich@chromium.org and voit@google.com as OWNERS for the loginScreenUi API. Bug: 957573 Change-Id: I367b6d7111ba5454ee4ee14505c8500adcc20c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645293Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#666606}
-
Hiroki Nakagawa authored
This CL enables PlzDedicatedWorker for following tests: - fast/workers - wpt/referrer-policy/ Bug: 971173 Change-Id: I2d53323a8c73b9c695b525725c883928459a5896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647499Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#666605}
-
Jay Harris authored
In future, this will allow applications to query information about how they were launched. Currently, the promise is hard coded to resolve to { cause: 'default', files: [] }. The mojom security review requires that new services be as complete as possible, hence the stubbing that is going on here https://chromium.googlesource.com/chromium/src/+/master/docs/security/mojo.md#Do-not-define-unused-or-unimplemented-things (a previous CL was rejected due to having an incomplete mojo service: https://chromium-review.googlesource.com/c/chromium/src/+/1597516). This CL is a part of file-handling https://github.com/WICG/file-handling/blob/master/EXPLAINER.md Bug: 829689 Change-Id: I03d07d47b5b4c29d8367f465a34e439262e37dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621418Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#666604}
-
Antoine Labour authored
Bug: 969201 Change-Id: I3f827c60721cbccbf0b318fea9b4d90b644e2ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639541 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666603}
-
François Degros authored
Bug: 778674 Change-Id: I7e9586b21be4db311fadd06b2fbd457daf9711b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647498 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666602}
-
François Degros authored
Used const/let instead of var. Passed to ExitParser's constructor an object that actually implements the expected interface MetadataParserLogger. Bug: 778674 Change-Id: I788216a1cd835808550e5031ed96837e2f379786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647497Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#666601}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53391a59f797..2e4a2c7e255e git log 53391a59f797..2e4a2c7e255e --date=short --no-merges --format='%ad %ae %s' 2019-06-06 dberris@chromium.org SheriffRedux: Vendor requests-toolbelt 2019-06-06 dberris@chromium.org SheriffRedux: Vendor requests library Created with: gclient setdep -r src/third_party/catapult@2e4a2c7e255e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:953181 TBR=skyostil@google.com Change-Id: I618424659ce7dea2f9614df6c4b3de468ef02b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666600}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I850dae0aa824b12a07d9b74be41b2bc74e8227df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646542Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#666599}
-
Xianzhu Wang authored
Now force windows editing behavior. TBR=xiaochengh@chromium.org Bug: 966731 Change-Id: I8af3aa3ae0744e6e2a650002eae47fc77b6f88fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646889Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666598}
-
Peter Kotwicz authored
This CL: - Introduces generation of R.color.background_color from the JSON config via mustache - Renames manifest_mustache_pass to mustache_pass BUG=969591 Change-Id: Ic434dc69673dfab19559c59894a3686db58b4e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644752 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666597}
-
Yoichi Osato authored
This patch rename the mojo function and related functions to avoid mixing up/down flow controls. Bug: 967524 Change-Id: I423fa153a410862654ef12d5a68bc9a83dd7b92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644912Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666596}
-
Leon Han authored
This CL lets ServiceWorkerGlobalScope rely on ServiceWorkerGlobalScopeProxy rather than ServiceWorkerGlobalScopeClient to call WebServiceWorkerContextClient functions, then we remove ServiceWorkerGlobalScopeClient completely. BUG=931142,920854 Change-Id: I9f952b95af1e7d00c1cc9dead1d7c45322a20964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643047 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666595}
-
Manuel Rego Casasnovas authored
In r666210 we fixed the dimensions of <select> elements with size containment. However the fix was not covering the case when you set "contain: size" to an already existent <select> element. To fix this we need to reset the options width in LayoutMenuList::UpdateOptionsWidth(). BUG=966673 TEST=external/wpt/css/css-contain/contain-size-select-002.html Change-Id: I162134ff050d64e9ff1d824b5747adafb9a993c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647152Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#666594}
-
Sammie Quon authored
This happens for mirrors because we only scale by x for both x and y dimensions, so some windows (ones with insets) that don't scale the same way on the two axes end up having a transparent zone underneath. Also, for WindowPreviewView the view is shifted after the above is fixed. It's because the top inset is used in calculations, but is already taken care of in WindowMirrorView. Test: manual Bug: 962893 Change-Id: Idd2e4676be10de0306aefc7fb112db3a01d9bf1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647138 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#666593}
-
Miyoung Shin authored
This is a part of moving media recorder implementation to blink. This CL moves content/renderer/media_recorder/audio_track_* files to blink and replaces some implementation with blink variant. - std::vector -> blink::Vector - base::Thread -> blink::Thread - main_render_thread_checker_ -> IsMainThread() - base::BindOnce, base::Bind -> WTF::Bind, WTF::BindRepeating - base::RefCountedThreadSafe -> WTF::ThreadSafeRefCounted - Remove base::test::ScopedTaskEnvironment Bug: 960665 Change-Id: I3465f79d8fe052408f2367894c1675dc9025a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637025 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#666592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e86e1fed26da..0a406538f2fc Created with: gclient setdep -r src-internal@0a406538f2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I305d1ffdb5010ee5b1dab0c63d1b061728da3784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666591}
-
Darren Shen authored
In a previous patch we moved //ash/keyboard/ui/OWNERS to //ash/keyboard/OWNERS, but forgot to update other files that pointed to the old path. Bug: 961568 Change-Id: I7d800c56ac4f1010a22912985c45534977173d29 No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647072 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#666590}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d71ff5db15ed..53391a59f797 git log d71ff5db15ed..53391a59f797 --date=short --no-merges --format='%ad %ae %s' 2019-06-06 dberris@chromium.org SheriffRedux: Vendor google-auth 2019-06-05 crouleau@chromium.org Revert "Fix media video playback metrics." Created with: gclient setdep -r src/third_party/catapult@53391a59f797 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:971441,chromium:965682 TBR=skyostil@google.com Change-Id: I06b3040a003d3658f53b5f733be8dda8951d76bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666589}
-
Eric Willigers authored
When a web page is downloaded in Android, and then shared using WebShare, the "file name" reported to WebShare starts with "https://". This patch allows such files to be shared. Bug: 965461 Change-Id: If1922c81ade874bb7b8be06d88361e10b2db248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624525Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#666588}
-
Takuto Ikuta authored
I intended to make CQ builderless instead of CI in https://chromium-review.googlesource.com/c/chromium/src/+/1645452 Bug: 954450 Change-Id: I27d546b8ce8e619915133c66e08203f80ee167d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647635 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#666587}
-