GitLab

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/2410df4..fa849a2

$ git log 2410df4..fa849a2 --date=short --no-merges --format=%ad %ae %s
2016-12-14 hbos@webrtc.org Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.
2016-12-14 henrika@webrtc.org Adds basic Bluetooth support to AppRTCMobile
2016-12-14 johan@webrtc.org Run 'git cl format --full' on Base64.
2016-12-14 danilchap@webrtc.org Remove deprecated RTPSender::SendPadData
2016-12-14 johan@webrtc.org Remove static cast from H264SpropParameterSets.
2016-12-14 ivoc@webrtc.org Improvements to the reliability of the echo detector perf test.
2016-12-14 johan@webrtc.org Add vector<uint8_t> to Base64 decoded data types.
2016-12-14 aleloi@webrtc.org Delete webrtc/transport.h.
2016-12-14 peah@webrtc.org Corrected access of null pointer in audioproc_f: The previous CL that added the ability to add and artificial nearend signal had an issue with null pointer access.
2016-12-14 henrika@webrtc.org Removes verification of audio parameters on Android
2016-12-14 nisse@webrtc.org Revert of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2569393004
Cr-Commit-Position: refs/heads/master@{#438551}

BUG=672229

Review-Url: https://codereview.chromium.org/2571023003
Cr-Commit-Position: refs/heads/master@{#438550}

This change prevents reloads being shown an offline preview. This does
not prevent other previews from being shown. A reload on an offline
preview is still considered to be non-opt out for the blacklist unless the user hit "show original".

BUG=672237

Review-Url: https://codereview.chromium.org/2563493002
Cr-Commit-Position: refs/heads/master@{#438549}

Made the following arguments / attributes non-nullable to match the spec.

History#pushState argument title seemed to be never used by our code.
https://github.com/whatwg/html/issues/2174

BUG=662005

Review-Url: https://codereview.chromium.org/2569663005
Cr-Commit-Position: refs/heads/master@{#438548}

This is just a refactoring change, there should be no change in behavior yet.

Currently Chrome accessibility support is basically off of on. This change
adds some additional accessibility mode flags so we will be able to selectively
enable just part of accessibility support. See the linked bug for more details.

The idea of casting the accessibility mode bitmask to an enum of all possible
valid accessibility modes doesn't really make sense anymore as the number of
possible valid permutations is now large, so I'm eliminating
AccessibilityModeHelper and making AccessibilityMode into just an integer
type rather than an enum.

Following changes will implement support for these new modes and enable
tracking and manually toggling their usage.

BUG=672205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2558933002
Cr-Commit-Position: refs/heads/master@{#438547}

(Includes some unrelated minor cleanup)

BUG=671302

Review-Url: https://codereview.chromium.org/2572013003
Cr-Commit-Position: refs/heads/master@{#438546}

This extends MessageEvent to allow ServiceWorker as a type of source
attribute according to the changes in HTML and replaces the existing
ServiceWorkerMessageEvent code usage with this extended MessageEvent.

Related spec issue: https://github.com/w3c/ServiceWorker/issues/989
Related spec change:
 - HTML: https://github.com/whatwg/html/pull/1944
 - SW: https://github.com/w3c/ServiceWorker/commit/6c68bd87bdfd153186a5b9904e31676c56730e2f
Related WPT: https://github.com/w3c/web-platform-tests/pull/4186

Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Xp9hmKyuOrI

BUG=659074

Review-Url: https://codereview.chromium.org/2466513002
Cr-Commit-Position: refs/heads/master@{#438545}

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2571753002
Cr-Commit-Position: refs/heads/master@{#438544}

The parameter defines a fraction of page loads that should have extended
performance measurements enabled. ContentSubresourceFilterDriverFactory uses it
for each main-frame navigation as a probability for enabling
|measure_performance|, which then gets distributed to all
DocumentSubresourceFilter's corresponding to (sub-)frames of the page.

If the variation parameter is not present or malformed, the extended performance
measurement is switched off.

BUG=672519

Review-Url: https://codereview.chromium.org/2569693002
Cr-Commit-Position: refs/heads/master@{#438543}

with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2555213004
Cr-Commit-Position: refs/heads/master@{#438542}

TSAN.

BUG=582277

Review-Url: https://codereview.chromium.org/2566273002
Cr-Commit-Position: refs/heads/master@{#438541}

Makes simple improvements to RecentTabHelperTest:
- Use ASSERT calls in some cases where test code would crash later if
  the expectation was not met.
- Added missing check of model().is_loaded().
- Update and reenable the DownloadRequest test.

BUG=674184

Review-Url: https://codereview.chromium.org/2571633003
Cr-Commit-Position: refs/heads/master@{#438540}

This change enables refactoring of AudioInputRendererHost and
surrounding code.

In this CL:
* Cleaned up instances of handling DCHECK errors in AudioInputRendererHost, see style guide https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#CHECK_DCHECK_and-NOTREACHED
* Sanitize volume in AudioInputRendererHost::OnSetVolume.
* Generalized AudioInputController::Factory interface and made sure the factory is used for all the factory methods of AudioInputController.
* Removed skipping authorization check for fake devices in AudioInputRendendererHost
* Removed unused weak_factory member of AudioInputRendererHost.
* Added unit tests for AudioInputRendererHost.

BUG=653861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2531333005
Cr-Commit-Position: refs/heads/master@{#438539}

Revert of [DevTools] Migrate storage domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2572933002/ )

Reason for revert:
Manually confirmed that this patch breaks Lighthouse.

Original issue's description:
> [DevTools] Migrate storage domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
> Cr-Commit-Position: refs/heads/master@{#438449}

TBR=caseq@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2576643003
Cr-Commit-Position: refs/heads/master@{#438538}

Revert of Set overflow: auto in StyleResolver::styleForDocument. (patchset #1 id:1 of https://codereview.chromium.org/2571893003/ )

Reason for revert:
This breaks compiles on Android Cast bot: https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/58645

Original issue's description:
> Set overflow: auto in StyleResolver::styleForDocument.
>
> Without this, the call to setStyle in Document::updateStyle would temporarily
> mark the LayoutView as overflow: visible.  With root layer scrolling this causes
> PaintLayerScrollableArea to remove the scrollbars.
>
> This change has no effect on the document's final overflow style, which comes
> from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).
>
> BUG=672335
>
> Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
> Cr-Commit-Position: refs/heads/master@{#438533}

TBR=bokan@chromium.org,szager@chromium.org,skobes@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672335

Review-Url: https://codereview.chromium.org/2570293003
Cr-Commit-Position: refs/heads/master@{#438537}

The introduction of an interface allows dependent classes
(MostVisitedSites) to inject doubles in tests.

BUG=619584

Review-Url: https://codereview.chromium.org/2570783003
Cr-Commit-Position: refs/heads/master@{#438536}

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469

Review-Url: https://codereview.chromium.org/2574213002
Cr-Commit-Position: refs/heads/master@{#438535}

It is possible to have |GestureScrollUpdate| and |GesturePinchUpdate| in the same
|GestureScrollBegin/End| sequence. This CL coalesces multiple GSUs and GPUs into 1
GSU and 1 GPU using matrix transformation.

e.g.
|GSB| -> |GSU| -> |GSU| -> |GPU| -> |GSU| -> |GSE|
becomes
|GSB| -> |GSU|* -> |GPU|* -> |GSE|

* means coalesced events.

Note that we have to go through the matrix when there are 2 adjacent pinch events
with different pinch point as they would coalesce to 1 scroll event and 1 pinch event.

BUG=661601

Review-Url: https://codereview.chromium.org/2552853002
Cr-Commit-Position: refs/heads/master@{#438534}

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Review-Url: https://codereview.chromium.org/2571893003
Cr-Commit-Position: refs/heads/master@{#438533}

This LayoutObject type is only used for non-outermost SVGSVGElements, so
no need to do runtime checks of the type.

Review-Url: https://codereview.chromium.org/2570293002
Cr-Commit-Position: refs/heads/master@{#438532}

https://skia.googlesource.com/skia.git/+log/65115a1b1a5c..60c05f98aa22

$ git log 65115a1b1..60c05f98a --date=short --no-merges --format='%ad %ae %s'
2016-12-13 herb Mark the leaf classes of GrOp final.
2016-12-14 bsalomon Change ConstructorInitializerWidth in .clang-format from 4 to 8
2016-12-14 robertphillips Replace TextureType with SkBackingFit
2016-12-14 robertphillips Make filterMaskGPU use GrTextureProxy
2016-12-14 robertphillips Add asDeferredTexture & asDeferredRenderTarget helpers to GrSurfaceContext
2016-12-14 mtklein Revert "Revert "SkNx basically always is fast now.""
2016-12-14 mtklein Revert "Revert "clamp to premul when reading premul sRGB""

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2571923004
Cr-Commit-Position: refs/heads/master@{#438531}

We shouldn't ask people to pipe insecure URLs to python3.

(https://llvm.org is itself problematic since it has a SHA-1
certificate. That too should get fixed, but, in the meantime, curl still
accepts SHA-1 and probably isn't going to raise its bar anytime soon,
even though Chrome 56 will.)

BUG=none

Review-Url: https://codereview.chromium.org/2570333002
Cr-Commit-Position: refs/heads/master@{#438530}

There's a bunch of weird glitches right now that cause the text to flip to the left. AFAICT, these two changes fix all of them:
1) Set the alignment of the text field directly.
2) RFC 3987 requires us to set the writing direction of URLs to LTR so that we get שלום.com instead of moc.שלום. This appears to change the alignment of the string if it's not set explicitly. So: set it explicitly.

BUG=648554, 673362

Review-Url: https://codereview.chromium.org/2555783002
Cr-Commit-Position: refs/heads/master@{#438529}

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.

Review-Url: https://codereview.chromium.org/2570093002
Cr-Commit-Position: refs/heads/master@{#438528}

BUG=

Review-Url: https://codereview.chromium.org/2536313003
Cr-Commit-Position: refs/heads/master@{#438527}

When CronetUrlRequest is canceled asynchronously in a callback without
being paused, we might already have a onSucceeded() callback in the
executor's queue. If that is the case, we won't have a onCanceled()
callback. This led to test flake. This CL adjusts the test expectation
and adds a comment.

R=pauljensen@chromium.org

BUG=657415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2572693003
Cr-Commit-Position: refs/heads/master@{#438526}

This cl wires up media controls given a web contents -> AX tree mapping.

Actions:
startDuckingMedia: requests the associated MediaSession start ducking. This gets passed back to the MediaSessionController which eventually relays the new volume multiplier.
stopDuckingMedia: same as above with volume multiplier set to 1.0.
resumeMedia: resumes suspended media
suspendMedia: suspends currently playing media

Events:
mediaStartedPlaying
mediaStoppedPlaying

Note: to see this work, use flag --enable-default-media-session

This would allow a client extension to:
- duck audio on a specific web contents
- observe when a media session is started/stopped

For ChromeVox, we can then allow audio not coming from the TTS extension or the ChromeVox extension (e.g. earcons) to be ducked. This also allows us to duck web contents in the background, longer running media sessions, foreground web contents based on a key command, after a tts start event, etc.

TEST=observe events; play media, stop media; verify media started/stopped come through. Explicitly call start/stop ducking; verify audio ducks/unducks. Also, call resume/suspend and verify audio resumes/suspends.
BUG=621697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2550593003
Cr-Commit-Position: refs/heads/master@{#438525}

Revert of [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image (patchset #5 id:80001 of https://codereview.chromium.org/2570823002/ )

Reason for revert:
Broke Linux NVidia GPU FYI bot. See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29

Original issue's description:
> [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting
>
> BUG=672719
> TEST=conformance2/rendering/read-draw-when-missing-image.html
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73
> Cr-Commit-Position: refs/heads/master@{#438477}

TBR=zmo@chromium.org,kbr@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672719

Review-Url: https://codereview.chromium.org/2578633002
Cr-Commit-Position: refs/heads/master@{#438524}

Review-Url: https://codereview.chromium.org/2565173007
Cr-Commit-Position: refs/heads/master@{#438523}

TEST=Compiles and all tests pass.
BUG=b/33185812

Review-Url: https://codereview.chromium.org/2570283002
Cr-Commit-Position: refs/heads/master@{#438522}

BUG=654129
R=bashi,peria

Review-Url: https://codereview.chromium.org/2573013002
Cr-Commit-Position: refs/heads/master@{#438521}

The cl predicts if a GSE is going to be followed by a fling or not.
If a fling is going to happen the scrolling layer is not cleared while
processing the GSE.

To predict a fling, GSE is not sent when a wheel event with phase ==
phaseEnded arrives. Instead the send_scroll_end_ timer starts.
If the next wheel event is in momentumPhase, the timer stops and
the GSE with |mayPrecedeFling = true| is sent immediately.
Otherwise, it will be sent with |mayPrecedeFling = false| when the
timer callback is triggered.

To test it, use the --enable-features=TouchpadAndWheelScrollLatching
runtime flag.

BUG=526463
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2486673008
Cr-Commit-Position: refs/heads/master@{#438520}

BUG=634542

Review-Url: https://codereview.chromium.org/2572873002
Cr-Commit-Position: refs/heads/master@{#438519}

There is a gap between when DisplaySnapshots get freed and when
DisplayConfigurator gets an updated list of DisplaySnapshots.
DisplayChangeObserver would try to use the pointers to freed memory if
the touch input-devices changed which might crash chrome.

Erase all entries in DisplayConfigurator::cached_displays_ before the
memory is freed.  It looks like DisplayConfigurator::cached_displays_ is
only used as part of either display configuration or for associating
touchscreens. There shouldn't be any other display configuration
happening between when cached_displays_ is freed and when new display
snapshots are added in DisplayConfigurator::OnConfigured(). Add a check
in DisplayChangeObserver::OnTouchscreenDeviceConfigurationChanged() if
there are no display snapshots then don't do anything to avoid passing
an empty list of ManagedDisplayInfos to DisplayManager.

BUG=669226

Review-Url: https://codereview.chromium.org/2571543002
Cr-Commit-Position: refs/heads/master@{#438518}

https://pdfium.googlesource.com/pdfium.git/+log/974b4a6c4bce..a9caab94c1f1

$ git log 974b4a6c4..a9caab94c --date=short --no-merges --format='%ad %ae %s'
2016-12-14 tsepez Avoid the ptr.reset(new XXX()) anti-pattern
2016-12-14 dsinclair Verify precision length before converting to string.

BUG=673336

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2574833003
Cr-Commit-Position: refs/heads/master@{#438517}

This fixes an issue where the old RenderView is reused by a new remote
subframe. We shouldn't be leaking resources, because now we are already
hiding the unused RenderView in the renderer, when the local main frame
gets detached and the WebViewFrameWidget is closed.

BUG=638375
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2496233003
Cr-Commit-Position: refs/heads/master@{#438516}

Both target now use ARC, so merge them into a single target in
preparation of upstreaming.

BUG=None

Review-Url: https://codereview.chromium.org/2571113003
Cr-Commit-Position: refs/heads/master@{#438515}

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862

Review-Url: https://codereview.chromium.org/2573983002
Cr-Commit-Position: refs/heads/master@{#438514}

Disable flaky test virtual/mojo-loading/http/tests/navigation/image-load-in-unload-handler.html on Linux.

TBR=foolip@chromium.org

BUG=674048

Review-Url: https://codereview.chromium.org/2574163002
Cr-Commit-Position: refs/heads/master@{#438513}

This patch introduces a typemap for video_accelerator.mojom struct and allows to use arc::ArcVideoAcceleratorDmabufPlane directly without having to convert from the arc::mojom::DmabufPlane.

BUG=665723
TEST=Ran YT and confirmed that histograms/Media.ArcGpuVideoDecodeAccelerator.InitializeResult is zero on chell and minnie

Review-Url: https://codereview.chromium.org/2513973002
Cr-Commit-Position: refs/heads/master@{#438512}