- 26 Apr, 2018 40 commits
-
-
Timothy Loh authored
This patch adds install_time and last_launch_time fields to the Crostini registry. These will be used in the app launcher's recently launched apps list, where currently Crostini apps do not appear. As we would also like the Terminal to appear in the recents list, this patch makes the registry support the Terminal, returning it in both GetRegistration and GetRegisteredAppIds. We don't need to keep track of Terminal install time as it is just a fallback for apps that haven't been launched. Internally, we only store the last launched time, so methods in the registry need to be careful they don't expect all pref entries will have all the standard fields. Bug: 821662, 836137 Change-Id: I43f34434afe61bd80c165c3a42047b184f96fcbe Reviewed-on: https://chromium-review.googlesource.com/1027292 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#553945}
-
Nicholas Verne authored
The install progress now has feedback messages in the dialog. The view also closes automatically on completion Bug: 822507 Change-Id: I962c9975a19fb322c611c9a02c5e2cc7ab21e06b Reviewed-on: https://chromium-review.googlesource.com/1029559 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#553944}
-
Hayato Ito authored
http/tests/devtools/elements/shadow is running several tests for shadow dom's distribution used in devtools. shadow-distribution.js is failing with the IncrementalShadowDOM flag. TBR=kochi,rakina Bug: 776656 Change-Id: Id780279b397c91bf3af7136727d36f83e1179565 Reviewed-on: https://chromium-review.googlesource.com/1029392 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#553943}
-
Mike West authored
Currently, we're setting the "site for cookies" only by looking at the top-level document. We ought to be verifying that the ancestor frames are same-site before doing so. We do this correctly in Blink (see `Document::SiteForCookies`), but didn't do so when navigating in the browser. This patch addresses the majority of the problem by walking the ancestor chain when processing a NavigationRequest. If all the ancestors are same-site, we set the "site for cookies" to the top-level document's URL. If they aren't all same-site, we set it to an empty URL to ensure that we don't send SameSite cookies. Bug: 833847 Change-Id: Icd77f31fa618fa9f8b59fc3b15e1bed6ee05aabd Reviewed-on: https://chromium-review.googlesource.com/1025772Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#553942}
-
Christopher Cameron authored
We encounter the following stack when destroying the RWHVMac RenderWidgetHostViewMac::Show WebContentsImpl::WasShown WebContentsImpl::UpdateWebContentsVisibility ... -[NSView removeFromSuperview] RenderWidgetHostViewNSViewBridgeLocal::~(dtor) RenderWidgetHostViewMac::Destroy This is problematic, as WebContentsImpl::UpdateWebContentsVisibility will make a bunch of calls on RenderWidgetHostViewMac that all assume that we are not mid-tear-down. To avoid this, make the call to -[NSView removeFromSuperview] be a delayed callback. That way the call will happen after the RWHVMac has been entirely destroyed, and UpdateWebContentsVisibility will no longer have a RWHVMac to call back into. Bug: 834931 Change-Id: I88412173b005dfdc26026db6b4c12b31e6541e7c Reviewed-on: https://chromium-review.googlesource.com/1025396Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#553941}
-
https://skia.googlesource.com/skia.git/+log/6b043cb9cc1a..e56ced15da1d $ git log 6b043cb9c..e56ced15d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id2dee163a22eb35ed4b84db6d3c2b7dddc9dfc99 Reviewed-on: https://chromium-review.googlesource.com/1029770 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553940}
-
Xiaocheng Hu authored
The member is always equal to: LineLayoutAPIShim::LayoutObjectFrom(inline_box_->GetLineLayoutItem()) Hence, this patch removes it for better code health. Bug: 822575 Change-Id: Ib9c231daa8658aa2b9212e9754bd50c76b0affbc Reviewed-on: https://chromium-review.googlesource.com/1026643 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553939}
-
Hayato Ito authored
This is a follow-up CL for http://crrev.com/c/1025155. SelectorQuery updates distribution only for traversing a flat tree. Bug: 776656 Change-Id: I07312acc73abdc593a7ef81f04761bacc3d978d0 Reviewed-on: https://chromium-review.googlesource.com/1029560Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 837127 Change-Id: Iee15da96b578ca1385440716ae5b733f30559f68 Reviewed-on: https://chromium-review.googlesource.com/1029564 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553937}
-
Lucas Furukawa Gadani authored
The blink public API should not expose internal blink types outside of blink. By disallowing this dependency by default we avoid accidentally exposing those types. Change-Id: I68883f3d7716b2309cadf32db8e5599d2fe5c8cb Reviewed-on: https://chromium-review.googlesource.com/1028573Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553936}
-
Michael Lippautz authored
This frees up the regular HeapIncrementalMarking flag for implementing an initial incremental marking strategy. Bug: chromium:757440 Change-Id: Iee924ef718f450b4d1e865ef6880242f501376fb Reviewed-on: https://chromium-review.googlesource.com/1028273Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553935}
-
Koji Ishii authored
From manual review of the build 4999. 13 files now match to their base expectations. They were removed. TBR=eae@chromium.org, atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icddb99362241928d6fefcf30868a0c198b552fd3 Reviewed-on: https://chromium-review.googlesource.com/1029752 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#553934}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc67d955. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." 52308ad8 "Deprecate document.origin" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16265 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/encoding kojii@chromium.org: external/wpt/css/css-text/overflow-wrap TBR=markdittmer No-Export: true Change-Id: I1813bf668f8d6d876ec5b2dd078069c80cc00a48 Reviewed-on: https://chromium-review.googlesource.com/1029730 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553933}
-
Xiangjun Zhang authored
CastRemotingConnector depends on MediaRouter, which should not be created when MediaRouter is disabled by an admin policy. Bug: 836042 Change-Id: Ibd03b5f7c0cb875173cb8c6c573f34a12f0e22b4 Reviewed-on: https://chromium-review.googlesource.com/1026252Reviewed-by:
Adam Parker <amp@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#553932}
-
Joel Hockey authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie4c4d27298742436b68c2dec05749d64abf317ab Reviewed-on: https://chromium-review.googlesource.com/1029471Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#553931}
-
Timothy Loh authored
This patch adds support for storing the StartupWMClass and StartupNotify fields in the Crostini Registry, and expands the algorithm for matching windows to Crostini apps to use these fields. We match startup ids against desktop file ids as the code for launching apps in the container sets DESKTOP_STARTUP_ID to the desktop file id. Bug: 821662 Change-Id: I34ba361a167cd5907d76cfbfed57e3903bbf9cfd Reviewed-on: https://chromium-review.googlesource.com/1021063 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553930}
-
Matt Falkenhagen authored
ServiceWorkerNewScriptLoader was using the ptr then letting it fall out of scope. ServiceWorkerScriptLoaderFactory still held a ptr to the factory which is strongly bound, so the factory shouldn't die anyway, but it seems safer if ServiceWorkerNewScriptLoader holds the cloned ptr too throughout its life. I'm not sure if this is actually needed for ExtensionURLLoaderFactory, but it seems possible to write a factory that would fail if the cloned ptr falls out of scope. Bug: 836129 Change-Id: Id7b4ab9d72bb758fe639e963e2747f915e67aea3 Reviewed-on: https://chromium-review.googlesource.com/1029271Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/23dc90b81efb..197d52949eed $ git log 23dc90b81..197d52949 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 geofflang Wrap all preprocessor code in the angle namespace. Created with: roll-dep src/third_party/angle BUG=chromium:836820,chromium:801364 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I4e73dc6ca51b5b8863fbcd0b266f8cd1a5df2500 Reviewed-on: https://chromium-review.googlesource.com/1029194Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553928}
-
Gyuyoung Kim authored
The flaky failure of the test seems to be due to not waiting long enough after resuming work again. This Cl changes the workaround logic to actually wait until the javascript work again (or let the test fail by timing out otherwise). Bug: 832191 Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00 Reviewed-on: https://chromium-review.googlesource.com/1011744 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
-
Renee Wright authored
This CL adds a preference called kCrostiniEnabled (= "crostini.enabled") and sets it to true when Crostini is installed. Bug: 833125 Change-Id: I58f27113e49cdcbc1c4aaf99f5aa4096fcdab902 Reviewed-on: https://chromium-review.googlesource.com/1013843 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553926}
-
https://pdfium.googlesource.com/pdfium.git/+log/7132ee35925f..9b8b217e6f8f $ git log 7132ee359..9b8b217e6 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 tsepez Replace reinterpret_cast with static_cast where possible 2018-04-25 hnakashima Make XFA Caret become immediately visible when moved. 2018-04-25 rharrison Use local for return value in factory method 2018-04-25 rharrison Don't store CE (comment extension) block data when decoding GIF 2018-04-25 thestig Use a bool in FindBit() in the fax codec. 2018-04-25 thestig Add PostScript PASSTHROUGH options to FPDF_SetPrintMode(). 2018-04-25 thestig Use PredictorType in more places. Created with: roll-dep src/third_party/pdfium BUG=chromium:835608,chromium:833168 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib59b785d5d3425a110c42e7af4b7eb1533232813 Reviewed-on: https://chromium-review.googlesource.com/1029189Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553925}
-
Hirokazu Honda authored
BUG=chromium:834170 TEST=VDA/VEA/JDA/JEA unittest built scueessfully for Chrome OS on both x86 and ARM platforms TEST=made sure for other platforms by CQ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I480220047ac23e4c26ee4dfff0ac2ef3bac70f6b Reviewed-on: https://chromium-review.googlesource.com/1016222Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553924}
-
Rakina Zata Amni authored
TBR=qinmin@chromium.org Bug: 837104 Change-Id: I8f59a618815ce71de395af29795b891529a75ef4 Reviewed-on: https://chromium-review.googlesource.com/1029554Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553923}
-
Tsuyoshi Horo authored
Bug: 836832 Change-Id: I2930377b31e99e82704aa4d5e27780181c38c3ba Reviewed-on: https://chromium-review.googlesource.com/1028530 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/25af671a3d7d..6b043cb9cc1a $ git log 25af671a3..6b043cb9c --date=short --no-merges --format='%ad %ae %s' 2018-04-26 angle-skia-autoroll Roll third_party/externals/angle2/ f827123d9..197d52949 (2 commits) 2018-04-25 fmalita [skottie] Add support for inverse mask paths 2018-04-25 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8eedebdf..840f47ea8 (5 commits) 2018-04-25 enne Fix GrAAConvexTessellator trying to fan a 0 point ring 2018-04-25 bsalomon Reland "Revert "Add arcs as a specialized geometry to GrShape."" 2018-04-25 liyuqian Remove SkASSERT(fConvexity == kUnknown_Convexity) due to racing 2018-04-25 bsalomon Make SkString::appendf safe for long strings. 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 2c9b55f..ba9fcb3 (1 commits) 2018-04-25 reed fix android-framework 2018-04-25 csmartdalton Remove the MSAA path renderer Created with: roll-dep src/third_party/skia BUG=chromium:830038 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I027b96e1a3a856ef003b64a2fbc01864671fea9b Reviewed-on: https://chromium-review.googlesource.com/1029611Reviewed-by:
-
Darren Shen authored
This patch introduces a new ash::Shell::ReloadKeyboard() method that reloads the IME without recreating a KeyboardController. It destroys the keyboard UI window instead and replaces it with a new one. We use this for accessibility prefs. The accessibility VK and normal VK are different, so when we switch between the two, we have to reload IME. Bug: 731537 Change-Id: I2388839206a48d81873f4bc6e7cf1ad2d0ed30f6 Reviewed-on: https://chromium-review.googlesource.com/1025532 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#553920}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f2142eff8c0..2acf49579846 $ git log 2f2142eff..2acf49579 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 ehmaldonado Revert "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id9901636e94a10f8218b33afa2579f93796c2c41 Reviewed-on: https://chromium-review.googlesource.com/1029351Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553919}
-
Peter Kotwicz authored
The android.app.Activity passed to the BasicNativePage constructor is always a ChromeActivity. This CL changes the type of the parameter to the BasicNativePage constructor to ChromeActivity. This enables removing an always-true "instanceof ChromeActivity" if() statement. BUG=835294 Change-Id: I7e63c26ae1d1eb53aa7e5be71174310320c6b471 Reviewed-on: https://chromium-review.googlesource.com/1021993 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553918}
-
Luciano Pacheco authored
This CL fixes the keyboard navigation when using screen reader/ Chromevox. The main fix is to force focus on the cr.ui.Tree/DirectoryTree element when navigating with Chromevox keyboard shortcut "Search+right arrow", before the focus was staying on "body" element so Tree couldn't handle the keyboard events to expand/collapse directories. It's a series of small fixes. 1. Fix text read by Chromevox when navigating on directories, it was reading all sub-directories names, instead of only the current focused directory's name, fixed by adding |id| to each entries' label element, to make existing |aria-labelledby| attribute work for screen reader. This was broken because we overwrite the |innerHTML| from |cr.ui.TreeItem|, losing the |id|. 2. Listen to |click| event on DirectoryTree and forces the focus to it when the focus/activeElement is the "body" element. This happens when Chromevox issues the |click| event when user press "Search+right arrow". 3. Replace |cr.ui.Tree|'s |role| attribute from "group" to "navigation", which is a "landmark" type which is recommended [1]. This required to change |cr.ui.Tree| to not overwrite existing |role| attribute. [1] - https://developers.google.com/web/fundamentals/accessibility/how-to-review#take_advantage_of_headings_and_landmarks Bug: 755278 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If33be610e1d28f0a69205ee148783328a367fe80 Reviewed-on: https://chromium-review.googlesource.com/985772 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553917}
-
Nicholas Verne authored
Concierge client's long-running StartContainer method is terminated by one of two signals: ContainerStarted or ContainerStartupFailed. After this change, CrostiniManager can respond to the failures as well as the successes. Bug: 822507 Change-Id: Ic86f8876d084029436a99a3e0500a306d7cea54c Reviewed-on: https://chromium-review.googlesource.com/1026950Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#553916}
-
Hwanseung Lee authored
according to previous git log[1], it looks likes used to store test files in official Chrome build gs:// drops. these files haven't been touched in a long time. and it seems like not used any more. [1]https://codereview.chromium.org/545103003 Bug: 829975 Change-Id: Ida8e887c64d4d18b7eb877f3cda2001a1871b844 Reviewed-on: https://chromium-review.googlesource.com/1027598Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#553915}
-
Koji Ishii authored
This patch changes visual rect of NGPhysicalTextFragment to include its frame rect. Legacy does so, but NG did not when it was first implemented due to the lack of understanding. After reviewing test results, it turns out that by not doing so, background and decorations on space characters are affected by this difference because space characters do not have glyph bounding box, which results in empty visual rect. Includes rebaselines that improve the rendering. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I888f8b27680aa1ff806cca15c84919461c06fc31 Reviewed-on: https://chromium-review.googlesource.com/1027012Reviewed-by:
-
tzik authored
In C++17, noexcept keyword is a part of the function type, and that causes a pattern match failure on base::Bind implementation. This CL fixes the failure by falling it back to bare function cases. Bug: 752720 Change-Id: I98c71977fa3fd759956c86e394fb9e30179c951c Reviewed-on: https://chromium-review.googlesource.com/1027530Reviewed-by:
-
Peter Boström authored
The generic icon should be shown when there's only one (non-signed in) user. We need to listen for add/remove profile events so we can detect whether a generic icon should be shown or not for existing windows as well. Bug: chromium:822070 Change-Id: Ia84feb13dd10b4459aeff326e2fd6e1d29698a76 Reviewed-on: https://chromium-review.googlesource.com/1028981Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553912}
-
Katie D authored
Because language -> voice pref is a DICTONARY type pref, this change extends settings-dropdown-menu to work with dictionary prefs given a new parameter, prefKey. When set, prefKey tells the settings dropdown which key in the dictionary is associated with the value it represents. This is not yet hooked up to the Text-to-Speech controller. In addition, we don't yet define default voices per language. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6b7ae800ed6f0230076da5d65114d305fc1dc64d Reviewed-on: https://chromium-review.googlesource.com/1020456 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#553911}
-
Maggie Chen authored
The callback function UpdateGpuInfoOnIO is added to the DX12/Vulkan info collection path. The data is now saved in gpu_info of the browser process. Both DX12 and Vulkan info collection functions are removed from the about:gpu path. The data can be found in the gpu info. There is no need to call these two functions again. BUG=775983 TEST=manual,Chrome://histograms R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6716aed172c8c6821f60124fb9cedc0c2e2b5079 Reviewed-on: https://chromium-review.googlesource.com/1026946Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553910}
-
Yoichi Osato authored
Bug: 766694, 523952 Change-Id: Ic794281024e97783d9f2bde6f2ca6c7f2eefdbb8 Reviewed-on: https://chromium-review.googlesource.com/1027551Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#553909}
-
Kevin Marshall authored
This change uses the tempfile library to manage temporary named files instead of using a DIY try/finally approach. Bug: 832849 Change-Id: I439ff29edfb0e8791202604d56f891827d79f0a2 Reviewed-on: https://chromium-review.googlesource.com/1029212Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#553908}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad0b2d2757e8..48a13aacf880 $ git log ad0b2d275..48a13aacf --date=short --no-merges --format='%ad %ae %s' 2018-04-25 dgarrett remote_try: Use luci_builder build config value. Created with: roll-dep src/third_party/chromite BUG=chromium:832747 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I100607416aef078b66dbe44a837db19069ca5ecb Reviewed-on: https://chromium-review.googlesource.com/1029352Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553907}
-
Tetsui Ohkubo authored
This is a reland of 59692b72 Change from original CL (PS#1): Fix use-after-free in unit test. Original change's description: > Observe ClockModel directly from DateView/TimeView > > This CL changes DateView and TimeView to directly observe ClockModel. > It removes unrelated logic from SystemTrayItem and makes embeding these > views easier. > > TEST=ash_unittests > BUG=none > > Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462 > Reviewed-on: https://chromium-review.googlesource.com/1025615 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553433} TBR=stevenjb@chromium.org Bug: none Change-Id: I0c609729e5ccc7fea66a696b57a689097f3465af Reviewed-on: https://chromium-review.googlesource.com/1029390 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#553906}
-
