- 03 Mar, 2020 40 commits
-
-
Makoto Shimazu authored
This reverts commit 79fca1ef. Reason for revert: Flakiness of TracingControllerTest. Filed crbug.com/1057896 Original change's description: > perfetto: Switch to SMB-based startup tracing > > Switch from StartupTraceWriter(Registry) and their thread-local buffers > to startup tracing using producer-supplied shared memory buffers. Each > ProducerClient allocates their own SMB now, which is provided to the > service when the ProducerClient connects. > > With this new mechanism, we're aiming for simpler code with fewer race > conditions and hopefully fewer chances for data loss, see design doc > for details. > > Note that this breaks startup tracing with the Perfetto system daemon. > At the moment, no tooling uses this, so we can probably remove support > for the time being. To add it back, we would have to: > - start tracing with an SMB allocated by PosixSystemProducer. In > sandboxed processes, we can allocate the SMB before the sandbox comes > up, or later via mojo's broker (and then somehow plumb it through > perfetto's IPC mechanism), or allocate it in the browser + pass an FD > to it via the cmdline when spawning. > - attempt to connect to the system service using this SMB. > - bail out, stop and restart the session with a service-provided SMB if > the system service doesn't support producer-provided SMBs (and thus > fails to adopt the producer-provided SMB). > > Design doc (incl. security review): > https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit > > Related Perfetto-side patches: > https://android-review.googlesource.com/c/platform/external/perfetto/+/1218420 > https://android-review.googlesource.com/c/platform/external/perfetto/+/1196779 > > Bug: 1006753, 941318 > Change-Id: I3fa7657d57bbf7261d7d504df8895edfc02d9f3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978682 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745556} TBR=skyostil@chromium.org,eseckler@chromium.org,mpdenton@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006753, 941318, 1057896 Change-Id: Ia7547a2665f59883b6ac0f87097270f8b0635643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084037Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746279}
-
Haiyang Pan authored
Bug: 1057150 Change-Id: I0506b69083f327f7f4fcb40005d8828f2e004888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083438Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#746278}
-
Austin Tankiang authored
Auth timeout needs to prevent the access token fetcher from calling its callback to prevent |get_access_token_callback_| from being called twice. Add a test to test this case as well. Bug: 1057897 Change-Id: Ib082cd5685cdaf95ba2fa92f4afc85387a306875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082228 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#746277}
-
Hiroki Sato authored
ChromeVox ignored a node with text longer than 1500 chars. This changes TtsBackground to split such a long text into smaller chunks and makes these texts announced. Bug: b/150426797 Test: browser_tests --gtest_filter="ChromeVoxTtsBackgroundTest.*" Change-Id: I942e27a7222c9e401a70ad141efd4cac4af4b8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081646 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746276}
-
Clemens Backes authored
These histograms provide insights into wasm usage in the wild and should be kept (see issue and linked document). Drive-by: Fix wrong spelling of wasm. R=isherman@chromium.org Bug: chromium:1053285 Change-Id: Ieb9011171b2c1ff44193935603a93f6beacebc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083180Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746275}
-
Kenichi Ishibashi authored
This struct is going to be used between content/ and the storage service. Convert it to a mojo struct so that it can be used from content/ and the storage service. Bug: 1016064 Change-Id: Id3f0bc87a0f315cd8b7dd567a19de7b978fb5839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066406 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#746274}
-
Clemens Backes authored
These histograms are not interesting any more and can be removed. Other wasm histograms will be extended in another CL. R=isherman@chromium.org Bug: chromium:1053285 Change-Id: Ibe25b8b63fb00208118aaeb2df669910da941ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082555Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746273}
-
Sergey Silkin authored
This reverts commit 8a6b0ccd. Reason for revert: Update the test but keep it disabled until https://bugs.chromium.org/p/chromium/issues/detail?id=1047994 is fixed. Original change's description: > Revert "Update and enable CanSetupH264VideoCallOnSupportedDevice." > > This reverts commit 0fce13aa. > > Reason for revert: It broke the chromium.webrtc bot (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Tests%20(dbg)%20(K%20Nexus5)/5712) > > Original change's description: > > Update and enable CanSetupH264VideoCallOnSupportedDevice. > > > > - Ensure that call actually uses H264 by checking codec type in > > video track stats. > > > > - Enable CanSetupH264VideoCallOnSupportedDevice test. > > > > Bug: webrtc:11244, 1047994 > > Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Commit-Queue: Sergey Silkin <ssilkin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742572} > > TBR=hta@chromium.org,mcasas@chromium.org,guidou@chromium.org,ssilkin@chromium.org > > Change-Id: I4ea3badad7ed564801a458263eb6366991f2924c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:11244, 1047994 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063135 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742621} TBR=hta@chromium.org,mcasas@chromium.org,guidou@chromium.org,armax@chromium.org,ssilkin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11244, 1047994 Change-Id: I1b6d5c02f5b7230d8834d042d2605022f1fd8758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075617Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8121d27b297c..b19408040143 git log 8121d27b297c..b19408040143 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 66a8fb00..13184a2d (377 commits) 2020-03-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ff60abaf62b4..b84969ad69c3 (6 commits) 2020-03-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 416d37452275..176f3a3dbbc9 (2 commits) 2020-03-03 herb@google.com Search for Strike at head of LRU first Created with: gclient setdep -r src/third_party/skia@b19408040143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I66e54ef782225884461191b31bc15d0ebb1c36ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746271}
-
Kenichi Ishibashi authored
This struct is going to be used between content/ and the storage service. Convert it to a mojo struct so that it can be used from content/ and the storage service. Bug: 1016064 Change-Id: Iefe90e4d293936f349e932696cf0213f144655db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059752Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746270}
-
Zhuoyu Qian authored
Bug: 1043716 Change-Id: I58d87c5beee9d9e2d14f78a81a6edb0f9d128039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074845Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#746269}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa1b2c63..fc542822 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57223538cfe43866f0aa49221d1856e4ae4a6be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083058Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746268}
-
Makoto Shimazu authored
This reverts commit 63964fe6. Reason for revert: Failed to compile on linux-chromeos-chrome. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3680 Original change's description: > Refactor the session managers by using SessionManagerObserver > > Use a new class 'UserSessionInitializer' to handle common initialization > logics in 'ChromeSessionManager' and 'UserSessionManager'. Whenever > profiles are loaded, corresponding methods in the observer will be > triggered. > > Bug: 977489 > Change-Id: I24259636906d80cfbec48268eb0c68aa851a4df7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044278 > Commit-Queue: Anqing Zhao <anqing@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746258} TBR=xiyuan@chromium.org,anqing@google.com Change-Id: Iab6d9b65871a4866dabfb20d66bacaca6df0cedf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083780Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746267}
-
Jimmy Gong authored
- The scrollable behavior is not used for this dialog as the items in the list do not require updates. - Fixes a bug where two scrolls bars are visible when zoomed in. Bug: 1055733 Change-Id: Ib28babbf5dbdf3aedf5bff4aec7875918de997d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083056Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#746266}
-
Tsuyoshi Horo authored
This CL introduces ResourceSnapshotForWebBundle mojo interface and GetResourceSnapshotForWebBundle() method in LocalFrame mojo interface. This method will be used to create a web bundle file. Design Doc: https://docs.google.com/document/d/1O1fH7ev2NwRqOVd_WjEtv4JaI6fA4x6G3ogfz6Hi9Pc/edit# This is the working-in-progress CL: https://crrev.com/c/1994848 - The browser process will call GetResourceSnapshotForWebBundle() to get the Mojo endpoint of the interface. - The browser process will pass the Mojo endpoint to the utility (data decoder) process. - The utility process will calls the methods of the interface using the passed Mojo endpoint, and will generate a Web Bundle file. Basically this CL implements GetResourceSnapshotForWebBundle() method using the existing page serialization logic for MHTML generation. For web bundle generation, we need to change the serialization logic: - Subframe URL replacement - Style element URL replacement - Shadow DOM support But this CL doesn't implement the web bundle specific logic. We will create another CL to implement them. Bug: 1040752 Change-Id: Ia7470de2cd1e418d8bc2d393f5136042145f62d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060360Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746265}
-
Christopher Lam authored
This CL replaces cros_colors and cros_palette the new JSON5 generated color format. This CL also adds GN generation targets and plumbs the generated CSS file through to OS Settings. Bug: 1018654 Change-Id: I5ef6b3f76c48aa59eac54163b085cd555b18369a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035483 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746264}
-
Zhuoyu Qian authored
This CL update the functions SandboxFileSystemBackendDelegate::Next and ObfuscatedFileUtil::Next to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: Ib48ef509f171906bffa38f643f573aa647874831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007321 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746263}
-
John Chen authored
Rename test webkit_layout_tests to blink_web_tests, and update related tools and docs. Bug: 914213 Change-Id: I13031dee55409da093f8450db834c3c4595f579e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040050 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#746262}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d084ea93b6c9..83762b21dbd2 git log d084ea93b6c9..83762b21dbd2 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 deadbeef@webrtc.org Use NetworkToHost32 instead of HostToNetwork32 to translate PPID. Created with: gclient setdep -r src/third_party/webrtc@83762b21dbd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic2665c9cb248b27f2f6fc97013d0ae964dbdc28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084103Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746261}
-
Livvie Lin authored
Match the naming convention of SSL blocking pages for consistency. Design doc: go/security-interstitial-cleanup Bug: 1042467 Change-Id: Ie6f26e8f5494bfcbdc3cd7a76e99dbd967f74dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076759Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746260}
-
Raul Tambre authored
Specify the defaults of Python 2 explicitly, so it also works on Python 3. Need to use codecs.open() because Python 2's open() doesn't support the "errors" argument. Traceback (most recent call last): File "../../services/device/public/cpp/usb/tools/usb_ids.py", line 90, in <module> table = ParseTable(opts.input) File "../../services/device/public/cpp/usb/tools/usb_ids.py", line 20, in ParseTable input = input_file.read().split("\n") File "C:\Program Files\Python38\lib\codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb4 in position 544490: invalid start byte Bug: 941669 Change-Id: Ie0789d68d574b7baa5c31d81ae846773630cd7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082511 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#746259}
-
Anqing Zhao authored
Use a new class 'UserSessionInitializer' to handle common initialization logics in 'ChromeSessionManager' and 'UserSessionManager'. Whenever profiles are loaded, corresponding methods in the observer will be triggered. Bug: 977489 Change-Id: I24259636906d80cfbec48268eb0c68aa851a4df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044278 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746258}
-
Anand K. Mistry authored
Also change |mount_id| to be a string to accommodate smbfs. Oh, and add a browser test. Bug: 1054704 Change-Id: I7c5b8eee7886093cde6b0088de489f8f91fb8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076862 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746257}
-
Dominic Farolino authored
This CL renames kNoReferrerWhenDowngradeOriginWhenCrossOrigin to kStrictOriginWhenCrossOrigin. It was generated via the following: git grep -l 'kNoReferrerWhenDowngradeOriginWhenCrossOrigin' | \ xargs sed -i '' -e 's/kNoReferrerWhenDowngradeOriginWhenCrossOrigin/kStrictOriginWhenCrossOrigin/g' R=estark@chromium.org, jochen@chromium.org Bug: N/A Change-Id: Iead49f11e74852d2b08cdf60c04f948d5910d642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082856Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#746256}
-
John Lee authored
When a drag enters with tab group data from another window, the tab strip will create a placeholder TabGroupElement and use it to move elements around. Bug: 1048894 Change-Id: I9a93996745bae6b56f47851a906efd4243d174cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076762 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746255}
-
Hitoshi Yoshida authored
Updates included files of IDL dictionaries from {component}/xxx/foo.h to bindings/{component}/v8/v8_foo.h for coming new code generator. Bug: 839389 Change-Id: I9f3f1c88dc6dfc2b4dd278f0038c753ae5834b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083779 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#746254}
-
nancy authored
This is the preparing for removing ArcAppIconLoader. AppServiceAppIconLoader is used to replace ArcAppIconLoader to load app icons for all apps. AppServiceAppIconLoader doesn't call OnAppImageUpdated to update for the default icon, so remove the DCHECK. Fix the browser tests, because AppService uses mojom, so add run loop to to wait AppService to load the app. BUG=10161599 Change-Id: Ifbd799911016c386fb9b3b34bfd98bffbd5d9c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081635 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e92ada58142f..042cbe61eee3 Created with: gclient setdep -r src-internal@042cbe61eee3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I42263810cb2e9d4bc2934fa57de83056ab5c719a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746252}
-
danielng authored
Adding basic UI elements as outlined in the PRD attached to the bug. Note that these are not final, or to spec (as no spec exists yet), and it is all behind an experimental flag. Bug:1016193 CQ-DEPEND=CL:2079711 Change-Id: I6ec7fee8247342688d883e7ad6d0c6a05940cb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079718 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#746251}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/777e146564b4..8121d27b297c git log 777e146564b4..8121d27b297c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 mtklein@google.com stick to 256-bit ymm on skx 2020-03-02 mtklein@google.com allow FMA discovery 2020-03-02 senorblanco@chromium.org Dawn: increase maximum texture size in caps to 8192. 2020-03-02 fmalita@chromium.org [skottie] Text anchor point grouping support 2020-03-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-03-02 bsalomon@google.com Prevent unbounded listener growth on SkPixelRefs. 2020-03-02 mtklein@google.com hoist1 2020-03-02 mtklein@google.com auto-detect MCPU 2020-03-02 benjaminwagner@google.com [infra] Upgrade iPhone6 to iOS 12.4.5 2020-03-02 mtklein@google.com basic hoisting 2020-03-02 robertphillips@google.com Revert "Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp" 2020-03-02 mtklein@google.com noalias for params, inbounds for GEPs 2020-03-02 reed@google.com remove bones from SkVertices 2020-03-02 robertphillips@google.com Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp 2020-03-02 jvanverth@google.com Fill in most D3DCaps texture property queries. 2020-03-02 brianosman@google.com Restore logic to check for .git in ANGLE BUILD.gn 2020-03-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-03-02 csmartdalton@google.com Add a bindBuffers() call to GrOpsRenderPass 2020-03-02 rmistry@google.com [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 scroggo@google.com SkJpegCodec: Gracefully handle malloc failure 2020-03-02 bsalomon@google.com Avoid unbounded listener growth on SkImage_Lazy when textures are purged 2020-03-02 borenet@google.com [recipes] Move DM flags logic into gen_tasks_logic/dm_flags.go 2020-03-02 nifong@google.com Patch public.bzl change from cl/298337962 2020-03-02 brianosman@google.com (Manual) Roll third_party/externals/angle2 4dc19c38c0c5..ff60abaf62b4 (51 commits) 2020-03-02 csmartdalton@google.com Reland "Move setupGeometry() from GrGLGpu to GrGLOpsRenderPass" 2020-03-02 fmalita@chromium.org [skottie] Stroke dash support 2020-03-02 robertphillips@google.com Standardize behavior of ops that implement onPrePrepare 2020-03-02 jlavrova@google.com Bugs: skia: 9968 2020-03-02 borenet@google.com [recipes] Reland DM recipe changes with fix Created with: gclient setdep -r src/third_party/skia@8121d27b297c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I4183f95c25f7725aa678f4116950b69c60c6a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746250}
-
Kent Tamura authored
HTMLSelectElement still needs these functions because accessibility code and testing code call them. This CL has no behavior changes. Bug: 1052232 Change-Id: Id34b9fa50138ed2193d57eadaa80f43206c87e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082226Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746249}
-
Hirokazu Honda authored
RequestEncodingParametersChange() can configure the same bitrate and framerate as the last configured values. Since VaapiVieoEncodeAccelerator logs them every RequestEncodingParametersChange(), it floods chrome logging. As we are not interested in the unchanged values, this CL makes VaapiVEA log the framerate and bitrate only if they vary. Bug: None Test: appr.tc/?vsc=h264&debug=loopback Change-Id: Ie0354bc92b919c2bfcb4d2131de29e8e2736a4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082741Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746248}
-
Mohsen Izadi authored
If handling of an event leads to producing a compositor frame, an UMA histogram is recorded measuring the time between the event timestamp and presentation of the corresponding frame to the screen, in the form of "EventLatency.<EventType>.TotalLatency". In future, we will add appropriate break-down metrics, too. Bug: 1054007 Change-Id: If85f99fb83172337c21b374073a3c2d098c2fd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018704Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746247}
-
Yuki Shiino authored
This is a reland of 783ef8ee Original change's description: > bind-gen: Implement V8DOMConfiguration::InstallConstants > > Implements V8DOMConfiguration::InstallConstants for context- > dependent property installation. > > Bug: 839389 > Change-Id: I3f67010e247ff4b1719cafec37b0865c9e05aa75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081729 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745959} Bug: 839389 Change-Id: I39fabb9ea119b2c40d87ea8f9478f23c543290ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083778Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746246}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4576851428dd..a3b6fd06f9d7 git log 4576851428dd..a3b6fd06f9d7 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 ehmaldonado@google.com Reland "my_activity.py: Run using vpython3 by default." Created with: gclient setdep -r src/third_party/depot_tools@a3b6fd06f9d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4bd4f5c6cff0dd17afc492eb70cf2d2b8536f2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083810 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746245}
-
Mary Ruthven authored
The python script attached to the bug was used to generate version strings for all images. BUG=chromium:728134 TEST=None Change-Id: I1618d7307b25acd0ccfa7b81d5bd67147ded2260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083926Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org> Cr-Commit-Position: refs/heads/master@{#746244}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/35785308a451..80f55e974204 git log 35785308a451..80f55e974204 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jmadill@chromium.org Expose glGetInteger64vEXT. 2020-03-02 lexa.knyazev@gmail.com Add OES_draw_buffers_indexed autogenerated wrappers and validation redirects. 2020-03-02 geofflang@google.com Add scripts for rolling and generating Android.bp for AOSP 2020-03-02 tobine@google.com Vulkan:Disable FramebufferVk cache on Apple 2020-03-02 geofflang@google.com Change commit_id 'check' back to looking for .git files. Created with: gclient setdep -r src/third_party/angle@80f55e974204 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ib3254a0c0272fa7c88cccd8e29f498ba6dcf951c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746243}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1059f43a379f..06b6db68ff7e git log 1059f43a379f..06b6db68ff7e --date=short --first-parent --format='%ad %ae %s' 2020-03-02 rharrison@google.com Rolling 6 dependencies and updating expectations (#990) Created with: gclient setdep -r src/third_party/shaderc/src@06b6db68ff7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Idb6968073363fc86cfd8e9d597bd4a9c203f4d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746242}
-
Theodore Dubois authored
R=karandeepb@chromium.org Bug: 1026733 Bug: 1042650 Change-Id: I37da28a4e02d6eed97ba1b458b68803fa95084b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026932 Commit-Queue: Theodore Dubois <tbodt@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Theodore Dubois <tbodt@google.com> Cr-Commit-Position: refs/heads/master@{#746241}
-
Joel Hockey authored
We will record which settings have been changed from defaults each time settings are fetched. Bug: 1056444 Change-Id: Iea61d82f9d440e05d11785490d01657b207fd7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082416Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#746240}
-