GitLab

This enables better detection of small-byte buffer-overreads.

Bug: 489301
Change-Id: I568136a4bd2f44984f92e9bd3b4e4c6911db610b
Reviewed-on: https://chromium-review.googlesource.com/951742Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541238}

Record whether the UserEventService is ready when a consent is recorded.
This should always be true as the service is created on startup.

Bug: 819218
Change-Id: I3ea4e7574d100d3fb7f6746172e8bb10b5be0f06
Reviewed-on: https://chromium-review.googlesource.com/951482
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541237}

This reverts commit f04d3bde.

Original change's description:
> Revert "Exclude unused java classes from gvr_common_java aar"
> 
> This reverts commit dbc48ca4.
> 
> Reason for revert: Getting NoClassDefFoundError on Nougat https://chromium-swarm.appspot.com/task?id=3c01bdd86290b710&refresh=10&show_raw=1
> 
> Original change's description:
> > Exclude unused java classes from gvr_common_java aar
> > 
> > As far as I can tell this filters the rest of the unused java classes.
> > 
> > Please revert this CL if you see ClassNotFound Exceptions.
> > 
> > diagnose_bloat summary:
> > MonochromePublic.apk_Breakdown (-4,097 bytes)
> >     +1,731 bytes Zip Overhead
> >         -1 bytes Package metadata size
> >     -5,827 bytes Java code size
> > MonochromePublic.apk_Specifics
> >    -15,137 bytes normalized apk size
> >    -11,040 bytes main dex size
> > 
> > Bug: 944791
> > Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4
> > Reviewed-on: https://chromium-review.googlesource.com/944791
> > Reviewed-by: Brandon Jones <bajones@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#540549}
> 
> TBR=mthiesse@chromium.org,bajones@chromium.org
> 
> Change-Id: I1b4b8c2d4acaaa9eafde507ceeb32293a164ac2b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 944791
> Reviewed-on: https://chromium-review.googlesource.com/946653
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540672}

TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 944791
Change-Id: I17e5095e0298d20bdd3876473e673f4ed5f07e5c
Reviewed-on: https://chromium-review.googlesource.com/951826
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541236}

Additional U2F tokens from other manufacturers.

Bug: 818807
Change-Id: Ieb20c0b433b00bb3a0b4f65519d9b978b8c81b80
Reviewed-on: https://chromium-review.googlesource.com/952071Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541235}

Events would get marked as consumed when on top of the resize controller.
Deal with that situation so that we allow the resize to occur on
disabled form controls.

BUG=762709

Change-Id: I17f8ae25541f9e4665d4a4bbcfef9e719f12f454
Reviewed-on: https://chromium-review.googlesource.com/951911Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541234}

CL [1] deleted annotations_xml_downstream_caller.py, but there was still a
reference to it in the data list of traffic_annotation_auditor_unittests.  This
was causing isolate_tests to fail on Linux Xenial [2].

[1] https://chromium.googlesource.com/chromium/src/+/6fda5d5ea134a58d5f1053d649762b3896837827
[2] https://ci.chromium.org/buildbot/chromium.fyi/Linux%20Xenial/45

BUG=789768
TBR=rhalavati@chromium.org

Change-Id: I00b2d6d12092f1942b09aa657bae518678ec17de
Reviewed-on: https://chromium-review.googlesource.com/952030Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541233}

Bug: 817800
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ied1f28e727320ed100851fc2aef06dfbdd07798a
Reviewed-on: https://chromium-review.googlesource.com/951714Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541232}

https://chromium.googlesource.com/webm/libvpx.git/+log/edc9a4687699..c6fcb9bb94ea

$ git log edc9a4687..c6fcb9bb9 --date=short --no-merges --format='%ad %ae %s'
2018-03-03 jzern disable vp9_highbd_iht{4x4_16,8x8_64}_add_neon
2018-03-03 jzern disable vp9_iht8x8_64_add_neon
2018-03-03 jzern disable vp9_iht16x16_256_add_neon
2018-03-02 marpan vp9-svc: Disable partition_reuse unless 2x2 scale.
2018-03-01 marpan vp9-svc: Fix to downsampling filter phase_shift.
2018-02-28 jzern iadst16x16_256_add_half1d: fix array size
2018-02-26 linfengz Add vp9_iht16x16_256_add_neon()
2018-02-26 jzern datarate_test: correct last_pts_ref_ type
2018-02-26 linfengz Fix a bug in create_s16x4_neon()
2018-02-22 linfengz Clean test/dct_test.cc with testing::Combine
2018-02-21 jianj VP9 SVC: Datarate test for dynamic bitrate change.
2018-02-20 linfengz Add vp9_highbd_iht8x8_16_add_neon()
2018-02-20 johannkoenig remove deprecated 'register' keyword
2018-02-12 jianj vp9_cx_iface: Remove else when returning from the other branch.
2018-02-12 jianj VP9 ROI test clean up regarding bool type flag.
2018-02-05 kylesiefring Fold adds in 16->32-bit converts in SSE2/AVX2 fDCT

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I90e68cab836f548e9d8502ed5c06191791d505a5
Reviewed-on: https://chromium-review.googlesource.com/952085Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#541231}

Bug: 818454
Change-Id: I77f6ea60f38ad8956d7f7e042c57202f3f41a07c
Reviewed-on: https://chromium-review.googlesource.com/951749
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541230}

Bug: 819246
Change-Id: Ie99c44c871d6f3a747abb3555c96310deb164d2f
Reviewed-on: https://chromium-review.googlesource.com/951890Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541229}

They are needed for continuing work on the componentized UI.

Bug: 773928
Change-Id: I1240cf9ae8afc9befdcf89ada7fbaed5340132d2
Reviewed-on: https://chromium-review.googlesource.com/951638Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541228}

Check to see if the Biquad AudioParam values are all constant for the
duration of the render.  If they are, we can skip computing the filter
coefficients for the render and just compute the one constant value.

Using https://jsfiddle.net/8vo0gbav/87/ as a test, CPU usage is
reduced from 35-38% down to 25-28% CPU.  The bulk of the change is
from calling BiquadDSPKernel::UpdateCoefficients less often. It was
accounting for 17.8% but is now just 2%. (According to perf top on
linux.)

Bug: 813504
Change-Id: I1e58dc433f7c03d4e0daa13a195b90328e03312a
Reviewed-on: https://chromium-review.googlesource.com/951628Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541227}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I79138c2e9d75eb72daee228b191e16f43eb95b83
Reviewed-on: https://chromium-review.googlesource.com/951966Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541226}

This reduces number of conversions from LayoutRect to FloatRect during
raster invalidation and PaintChunksToCcLayer.

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibc8e0cd0d79fdf08aad2a4711cc53d2fcb22f3ca
Reviewed-on: https://chromium-review.googlesource.com/949964Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541225}

Now Mojo CDM is enabled by default on desktop platforms (when library
CDM is enabled), remove kMojoCdm feature.

Will start to remove pepper CDM support in later CLs.

Bug: 772160
Change-Id: Id5b0692db992500d97cd5902f1ddd97147ab97d9
Reviewed-on: https://chromium-review.googlesource.com/946430Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541224}

Bug: 791086
Change-Id: I916508fc5cf0c16543decd3f8197d034f2a4e6d8
Reviewed-on: https://chromium-review.googlesource.com/941963
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541223}

ash::Shell::drag_drop_controller_ is reset before widgets and window
containers are closed. aura::client::SetDragDropClient null is called
later, after windows close. Thus if closing any window triggers a
call to GetDragDropClient it will access deleted memory.

This code has been refactored multiple times, including this 2013 CL
to change the window close order:
https://chromium.googlesource.com/chromium/src/+/8b3e3d8f101deab32cc3482ad752e99802efe109

and this 2016 CL that moved SetDragDropClient as part of the mustash
"wm common" refactor:
https://chromium.googlesource.com/chromium/src/+/29f31715ad035be45c19469afe2012209cb92125

Fix by moving SetDragDropClient to immediately before the controller
is reset, which means it is reset in the same class that allocates
the object. All calls to GetDragDropClient check the pointer for null
before access. If someone adds a call and doesn't check for null it
will cause a crash instead of UAF, which seems better.

Bug: 818603
Test: asan interactive_ui_tests, see bug
Change-Id: I6d1a468dceff26da36e5c7c4af4962941db46a87
Reviewed-on: https://chromium-review.googlesource.com/951622Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541222}

This reverts commit d553b24a.

Reason for revert: Too many pending builds, will reland once drained.

Original change's description:
> Ramp up cast_shell_linux on LUCI to 100%.
> 
> Bug: 731556
> Change-Id: Id416d395958f0b3529816f17ca0d35203f863065
> Reviewed-on: https://chromium-review.googlesource.com/950023
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541215}

TBR=jchinlee@chromium.org,jbudorick@chromium.org

Change-Id: I364807043e712551a28d9b2a6ebbe114eba1e0e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731556
Reviewed-on: https://chromium-review.googlesource.com/952283Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541221}

WebContents::GetDelegate may return null in some cases (see issue
for repro cases).

Bug: 756527
Change-Id: Iad30cccd1246c59fd035b86305c21e46bd57f404
Reviewed-on: https://chromium-review.googlesource.com/951903Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541220}

Moves a single Bluetooth test under the wpt/http/ directory to its
rightful place under wpt/bluetooth.

BUG=509038

Change-Id: I9eaa21858c74fedba2a91c508b4097609f8c69a6
Reviewed-on: https://chromium-review.googlesource.com/951882
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541219}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5dc7db08f808..7224dea74d49

$ git log 5dc7db08f..7224dea74 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ifcb05d4b1eca7a5b271dfc3a1141fb51ca3345ca
Reviewed-on: https://chromium-review.googlesource.com/952083Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541218}

Bug: 819123
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I35712fb750e941ff14801c41441289b2591911dd
Reviewed-on: https://chromium-review.googlesource.com/951898Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541217}

changes:
Move IconDecodeRequest from inner class of ArcPlayStoreSearchResult to
a separate class, since this class is also used for in app search.

Bug: 818902
Test: tested that play store search still works
Change-Id: Iaa53007b363d82d496115abb5fac64eba5109c1d
Reviewed-on: https://chromium-review.googlesource.com/950006Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#541216}

Bug: 731556
Change-Id: Id416d395958f0b3529816f17ca0d35203f863065
Reviewed-on: https://chromium-review.googlesource.com/950023Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541215}

- Guard DCHECK-only code with DCHECK_IS_ON() to reduce several
  instructions in official build.

- Inline GrowCurrentBeginItemVisualRect().

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I259049465bf0505a4098feac29d73405c922861d
Reviewed-on: https://chromium-review.googlesource.com/951897Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541214}

Added basic support to download home to be able to fetch thumbnails from
the offline pages backend. It doesn't have any caching which will be
added in future CLs.

Bug: 817853
Change-Id: I2885f649fb240fa9a28328b6af83a7e49897b092
Reviewed-on: https://chromium-review.googlesource.com/946904Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541213}

On devices which already match the media requirements, the test fails as
handleMediaChange is never called. Instead, set the pointer and hover types to
None so that updating the types later is guaranteed to trigger the matchMedia
handler.

Bug: None
Change-Id: I8fa91ecef9c1f372d1b04abfbc540a7b9c0fc3c2
Reviewed-on: https://chromium-review.googlesource.com/951860Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541212}

Because we do a slow flush when we reopen a connection, this prevents
a ~50ms startup cost if a connection is already open, which is important
especially when recording clock sync markers.

I've verified locally that this fixes a ~50ms clock sync latency
regression.

TBR=nednguyen@google.com

Bug: 816470
Change-Id: Icab77977faa61755945883cf50613bfe1e575182
Reviewed-on: https://chromium-review.googlesource.com/946674
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541211}

Bug: 796650
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1dc50ba6eb8e7b2f01992fdcee5ade2d7c6f35e1
Reviewed-on: https://chromium-review.googlesource.com/940432
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541210}

This allows an app (Chromecast, e.g.) to change the multiplier and better
control ducking behavior.

Bug: internal b/69630398
Test: Ran on Android Things speaker with different multipliers,
      observed proper ducking volume.

Change-Id: I5078fd11606a5d648aca9b17938c3c8caefd3826
Reviewed-on: https://chromium-review.googlesource.com/942055Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541209}

This CL fixes issue with anonymous function calling
a member function without object in GCC version < 6.4.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61636

Bug: 819294

Change-Id: I29a9e14a5160a3c9c658dc76f7f167c74e1c2b41
Reviewed-on: https://chromium-review.googlesource.com/945995
Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541208}

https://pdfium.googlesource.com/pdfium.git/+log/9600a771999d..a32145f1f16b

$ git log 9600a7719..a32145f1f --date=short --no-merges --format='%ad %ae %s'
2018-03-06 dsinclair Rename core/fxcrt IFX files to Iface

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I50775e5dd706eb1bb41406688324858086da365a
Reviewed-on: https://chromium-review.googlesource.com/951825Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541207}

https://webrtc.googlesource.com/src.git/+log/8d9dcb1c8935..12eb85881c86

$ git log 8d9dcb1c8..12eb85881 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4a9593a5506beb7a1e89cb67da61c089a69405db
Reviewed-on: https://chromium-review.googlesource.com/951891Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541206}

This switches SVGResource away from inheriting IdTargetObserver, and
makes it have one as a member instead. This should make future
subclassing of SVGResource easier (avoiding GC mixins.) It also has the
side-effect of allowing the SVGURIReference framework to be reused.

Bug: 769774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77fed36a06b846f3cd4cbb7722faa3de1b081f59
Reviewed-on: https://chromium-review.googlesource.com/947956Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#541205}

Bug: 819267
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I14ef4bab4b43a64f959d12bb82ceb82095e5a261
Reviewed-on: https://chromium-review.googlesource.com/951896Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541204}

This covers the basic feature set needed for the simplified input API.
Minor details like naming may shift as we continue discussing the API
shape, but the majority of this code is likely to remain relevant.

Bug: 812287
Change-Id: I41c452f015c2dec08f123e6970920058fb2a728a
Reviewed-on: https://chromium-review.googlesource.com/919150
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541203}

Bug: 818216
Change-Id: If959c872723ce79ba03adee13c247cf8382f8551
Reviewed-on: https://chromium-review.googlesource.com/951365
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541202}

This reverts commit 2b0c7b40.

Reason for revert: https://chromium-review.googlesource.com/950466 re-fixed the crashpad bug, so we should be good to land this again.

Original change's description:
> Revert "Add range checks for `StringPiece`."
> 
> This reverts commit c8bccdf1.
> 
> Reason for revert: This change has r540894 as dependency. However, r540894 was reverted in r541006, just before this patch landed. Since this currently causes failures on Mac due to crashpad errors, I am reverting this change for now.
> 
> Original change's description:
> > Add range checks for `StringPiece`.
> > 
> > Range check `operator[]`, `front`, `back`, and  `remove_{pre,suf}fix`.
> > 
> > Bug: 817982,818376,818844
> > Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824
> > Reviewed-on: https://chromium-review.googlesource.com/945049
> > Commit-Queue: Chris Palmer <palmer@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#541012}
> 
> TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org
> 
> Change-Id: I7d5c2ca050869aff8dca4ba6b724761172aa1d83
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 817982, 818376, 818844
> Reviewed-on: https://chromium-review.googlesource.com/950822
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541060}

TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org,jdoerrie@chromium.org

Change-Id: I50637027781401fc96b75bb749c5baa80dcc14a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817982, 818376, 818844
Reviewed-on: https://chromium-review.googlesource.com/951868Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541201}

Subresource filter may skip the first page due to race condition. In
order to reproduce the issue add a |sleep| function call inside
|CreateOrOpenHelper::RunWork| for an indexed ruleset file.

A sequence of events for ruleset file setup is:
1. |RulesetService::OpenAndPublishRuleset| posts a |CreateOrOpen| task
   from UI thread to task schedulers blocking pool (BP) on browser
   start.
2. |RulesetService| receives a result of a |CreateOrOpen| task in
   |RulesetService::OnOpenedRuleset| on UI thread and calls (with a long
   callstack) |VerifiedRulesetDealer::Handle::SetRulesetFile|
3. |VerifiedRulesetDealer::Handle::SetRulesetFile| is called on UI
   thread. It posts |VerifiedRulesetDealer::SetRulesetFile| task to BP.

i.e. UI (start) -> BP (open file) -> UI (delegating) -> BP (setup dealer)

A sequence of events for checking of ruleset file is:
1. |AsyncDocumentSubresourceFilter| is created on navigation response
   processing on UI thread. It posts |Core::Initialize| task to BP.
2. |AsyncDocumentSubresourceFilter::Core::Initialize| checks dealer the
   verified dealer data.

i.e. UI (nav. response) -> BP (check dealer)

Navigation response on UI is always happened after the start. If
navigation response happens before the open file result delivered to UI
thread the first page will not get subresource filter feature. Otherwise
subresource filter works properly.

The proposed fix is to eliminate "UI (delegating)" stage and perform file
opening and dealer setup together using
|VerifiedRulesetDealer::Handle::TryOpenAndSetRulesetFile|.

The fix shouldn't affect the first page open time so as
|ActivationStateComputingNavigationThrottle| already waits for ruleset
file opening due to operations ordering on BP.

Please let me know if I should fail a bug. I haven't found this issue in
the tracker.

Change-Id: If54b9cdfddd8adb9b17cb6da80d8199721ff669b
Bug: 817308
Reviewed-on: https://chromium-review.googlesource.com/939161Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541200}

Change-Id: I76f7fe718913f3e7e2c8bef1d1e5463d0d31c240
Reviewed-on: https://chromium-review.googlesource.com/951962Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541199}