GitLab

The Java DistilledPagePrefs observers are wrapped in a
native observer, which is only deleted when the observer is
removed again. Since the reference to this native observer
wrapper is kept in a Java map with the real Java observer as
the key, the second time addObserver(foo) is called with the
same observer, the first reference is lost, and the native
object is leaked. 

For example, the following would leak a native object:
addObserver(foo);
addObserver(foo);
removeObserver(foo);
removeObserver(foo);

It is already safe to remove an observer if it is not
currently an observer, and this CL ensures that an observer
can only be added once, so the second calls to
addObserver(foo) and removeObserver(foo) will be no-ops.

addObserver and removeObserver will return a boolean based
on whether they have successfully completed the operation.

BUG=383630

Review URL: https://codereview.chromium.org/426153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391071

Review URL: https://codereview.chromium.org/442173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223859

Review URL: https://codereview.chromium.org/447923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287906 0039d316-1c4b-4281-b951-d872f2087c98

Ports most of the sync GYP targets to GN.  Adds comments in the original
GYP files pointing to the new GN targets.  Fixes some TODOs in other
files that were blocked on sync GN support.

Adds several new linkable targets to the GN build.

The android-specific parts of sync have not been converted yet.

TBR=nyquist,rogerta
BUG=

Review URL: https://codereview.chromium.org/439533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/443703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287904 0039d316-1c4b-4281-b951-d872f2087c98

If the star in the Location Bar is already in the correct state, then there's
no need to perform a complete redraw.

This was responsible for ~50% of extraneous location bar redraws, which was
consuming ~5% of cpu cycles on start up.

BUG=393819

Review URL: https://codereview.chromium.org/442343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287902 0039d316-1c4b-4281-b951-d872f2087c98

Plugin logic expects redirects to have headers, and gets very confused
when they're missing.

BUG=345160

Review URL: https://codereview.chromium.org/422233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287901 0039d316-1c4b-4281-b951-d872f2087c98

API which enables the exchange short messages with nearby devices.

This is the audio handling code of the copresence core component. We'll be
open sourcing this code in phases, this is the first part. This CL includes
the code for the directive handler for copresence, and all related classes.
Including blundell@ for the OWNERs review to add this component.

R=dalecurtis@chromium.org, derat@chromium.org, jochen@chromium.org, xiyuan@chromium.org, blundell@chromium.org
BUG=365493

Review URL: https://codereview.chromium.org/419073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394532
TEST=unit_tests

Review URL: https://codereview.chromium.org/444543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287899 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287897 0039d316-1c4b-4281-b951-d872f2087c98

This patch rolls trace-viewer to r1445.

TBR=nduca
NOTRY=true

Review URL: https://codereview.chromium.org/444103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287896 0039d316-1c4b-4281-b951-d872f2087c98

to track server config expiration from 1 minute to 30 days.

Minor cleanup of names and description of server config expiry
and use of inchoate ClientHello.

Fixed wtc's comments for CL:
  https://codereview.chromium.org/413363005/

R=jar@chromium.org

Review URL: https://codereview.chromium.org/443763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287895 0039d316-1c4b-4281-b951-d872f2087c98

Each application <> shell connection is represented by a ShellImpl instance
on the shell side. This CL makes the Application watch its ShellPtr for pipe
errors so it can Quit() itself if the shell goes away (shell loop destroyed).

mojo_shell_tests starts using a new method to terminate all shell connections
in this CL, and waits afterward until KeepAlive quits the loop signifying that
all apps are gone. This is done prior to destroying the shell MessageLoop so
that the test ensures apps have all died before the next test. In the future
it would be a test failure if this wasn't a no-op, but we have things in the
shell that don't quit themselves right now.

The shell itself won't wait around for apps to die (as of this CL), but
~MessageLoop will still send the message to Application sides that will quit.

** NOTE ** This does not require an app build target to explicitly add magic
*.cc files to their sources.  It requires selecting an appropriate
mojo_application_{chromium, standalone} library akin to mojo_environment_*.
We can possibly combine these two in the future.

BUG=394477

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287680

Review URL: https://codereview.chromium.org/394903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287894 0039d316-1c4b-4281-b951-d872f2087c98

Instead of passing the sync server URL as a string, int, and bool, just
pass the GURL.  In a future CL SyncManager will make use of this GURL to
initialize an AttachmentUploader.

clang-format was used to format the modified lines.

BUG=

Review URL: https://codereview.chromium.org/442403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287893 0039d316-1c4b-4281-b951-d872f2087c98

Calling pushState when the search page is shown causes history entries after
the current one to be lost.

This mimics the pre-r271538 behavior where it set location.hash. Setting
location.hash is a no-op (rather than pushing a duplicate history entry) if the
hash has not changed.

BUG=401004

Review URL: https://codereview.chromium.org/446093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287892 0039d316-1c4b-4281-b951-d872f2087c98

NSS would use "" as the password while OpenSSL would use "\0\0" (UCS-2 encoding
of a NUL-terminated string) because of how PKCS#12 recommended encoding
passwords. Make the OpenSSL code use the same format so that we can freely switch
back and forth between NSS and OpenSSL.

(This is in case we need to roll back an OpenSSL cutover and the release has
hit some early release channel already.)

BUG=399121

Review URL: https://codereview.chromium.org/435593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/449603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287889 0039d316-1c4b-4281-b951-d872f2087c98

* Give it its own copy of its test data, instead of sharing with other
unrelated tests that live in src/chrome.
* Introduce ChromeComponentExtensionResourceManagerTest to address a TODO
and eliminate the src/chrome dependency.

BUG=397164
TEST=unit_tests, extensions_unittests

Review URL: https://codereview.chromium.org/439023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287885 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't seem to be a problem for release builds, but in debug builds the invalid array access causes STL errors:

    error: attempt to subscript container with out-of-bounds index 0, but
    container only holds 0 elements.

BUG=401161

Review URL: https://codereview.chromium.org/446853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287884 0039d316-1c4b-4281-b951-d872f2087c98

If new assertions fire or crashes occur, these PDBs are needed in
order to generate reasonable stack traces. Remove the comment about
their presence being temporary.

BUG=383963,385976

Review URL: https://codereview.chromium.org/448773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287882 0039d316-1c4b-4281-b951-d872f2087c98

This method is taking a non-trivial amount of time during a typical scroll
sequence, so convert the instant trace into a proper scoped trace.

BUG=401204
NOTRY=true

Review URL: https://codereview.chromium.org/446063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385992
TEST=MultiUserWindowManagerChromeOSTest.TestBlackBarCover & visual inspection

Review URL: https://codereview.chromium.org/448493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287880 0039d316-1c4b-4281-b951-d872f2087c98

Put the .d file in the same directory as the output from grit. Currently it
uses the default location for the .d file all the time, even in cases where the
output directory is overridden and the rest of the files go somewhere else.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/450483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal comment only change.

Review URL: https://codereview.chromium.org/427183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287876 0039d316-1c4b-4281-b951-d872f2087c98

The test case is a modification of the test html in the bug. The image was replaced and the code was reformatted because it was poorly spaced. The new test case still shows the same behavior. 

BUG=326834
NOTRY=true

Review URL: https://codereview.chromium.org/438963008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356763

Review URL: https://codereview.chromium.org/414253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287874 0039d316-1c4b-4281-b951-d872f2087c98

This uses the new "trim" input conversion option and also the default arguments to exec script to clean up some calls.

R=bbudge@chromium.org, bbudge

Review URL: https://codereview.chromium.org/138693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287873 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the precision requirements for
DrawPolygonTransformTest.TransformNormal.  This is required since it currently
fails on Arm64 due to gcc's use of a fused multiple instruction on mapMScalars.

Details of this issue are available on the associated bug.

BUG=401117

Review URL: https://codereview.chromium.org/443903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287871 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/445183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287870 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled for a memory leak. The bug was fixed already
but this test case was forgotten to be re-enabled.

BUG=399241
R=flackr@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/443273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392891

Review URL: https://codereview.chromium.org/450493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287868 0039d316-1c4b-4281-b951-d872f2087c98

Specifically linux_chromium_rel_swarming.

BUG=109173
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/451473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287866 0039d316-1c4b-4281-b951-d872f2087c98

This vector is now used to store all config lists. Previously the code did a bunch of work to uniquify configs at certain points (in target.cc) but direct_dependent_configs still ended up with lots of duplicates.

Before this patch the chrome/browser target has 41098 direct_dependent_configs, and after this patch it has 7. Apparently we were also spending a lot of time on these. Before this patch Windows wall clock time was 1031ms, and after this patch it's 831ms. Linux was 834ms before and 593ms after.

Also fix minor build issues in base I noticed while working on this.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/26537002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287865 0039d316-1c4b-4281-b951-d872f2087c98

RenderWidgetHostImpl tracks its visibility using the |is_hidden_| field.
This value should be not be reset when the renderer crashes, otherwise a
widget that crashes in backround will think it's already visible when
put in foreground, messing up process visibility accounting.

This patch fixes process visibility for processes that crashed in
background and are respawned upon foregrounding by preserving the
|is_hidden_| field through renderer crashes.

BUG=399521
R=aelias@chromium.org

Review URL: https://codereview.chromium.org/443133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287864 0039d316-1c4b-4281-b951-d872f2087c98

Currently NOTREACHED() is reached when the KDE file chooser is active.

TEST=Manually:
1. Start Chrome in a KDE environment
2. Visit data:text/html,<input type=file webkitdirectory>
3. Click on the file chooser and select any directory.
4. In KDE environments, NOTREACHED() is reached.

5. Repeat the same steps with the env var NO_CHROME_KDE_FILE_DIALOG=1,
   and observe that NOTREACHED() is not reached any more, because the
   gtk fallback is used (which works correctly since r240564).

Review URL: https://codereview.chromium.org/445883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399835

Review URL: https://codereview.chromium.org/446553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400538

Review URL: https://codereview.chromium.org/439893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287861 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the secure QUIC performance degradation has been
identified and fixed in r286400.

> Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation.
>
> The change to quic_stream_factory.cc disables
> https://codereview.chromium.org/346323002/
>
> The change to quic_crypto_client_stream.cc disables
> https://codereview.chromium.org/355293003/
>
> R=rch@chromium.org
> BUG=396185
>
> Review URL: https://codereview.chromium.org/414523004

R=rch@chromium.org
BUG=396185

Review URL: https://codereview.chromium.org/444123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287860 0039d316-1c4b-4281-b951-d872f2087c98

Crashes are reported around getting root window in UpdateShelf(),
however the new AshPopupAlignmentDelegate is mostly same as
old WorkAreaObserver. One difference is the location of getting
root window. This could fix the problem.

If this doesn't fix the problem, then the problem happens outside
of this file.

BUG=400492
R=stevenjb@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/441013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287859 0039d316-1c4b-4281-b951-d872f2087c98

See the bug for more details about the Finch experiment results.
BUG=372570

Review URL: https://codereview.chromium.org/438073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287856 0039d316-1c4b-4281-b951-d872f2087c98