GitLab

For multicol, PageLogicalHeightForOffset() would normally figure out what to
return by consulting the flow thread, which would find the appropriate column
set, which in turn would find the appropriate fragmentainer group and return
its height.

We used to treat a 0 value as "unknown" most of the time (but there were also
cases where we'd accept it as a column height). We now always have to call
IsPageLogicalHeightKnown() first to tell whether it's known or not. This is
reasonable, since the calling code always has to act upon the situation of not
knowing the height (typically skip some steps, since fragmentation is
impossible until height is known).

It is now forbidden to call PageLogicalHeightForOffset() if height is unknown
(there are DCHECKs). The height is unknown in many cases in the first multicol
balancing pass. The height will be known once we have made a column height
estimate. It doesn't have to be the final and correct height. This CL doesn't
change anything in that regard, but now we are required to be sure that we
have some clue at all before dealing with fragmentainer heights.

MultiColumnFragmentainerGroup now has a flag that tells whether the logical
height is known or not. We need the flag, because the logical height may
actually end up as 0, e.g. when a multicol container just has zero-height
content, or when the multicol container itself has a specified height of 0.
This unclamped height will be used as block progression for the column row,
which will contribute to the final height of the multicol container. The
actual column height will be clamped to not be less than 1px. This is in
accordance with the spec [1]. We previously used to treat truly zero-height
fragmentainer groups as having an unknown height in some parts of the code,
while in other parts of the code we'd just accept it and end up dividing by
it (to convert a flow thread offset to a column index, for instance).

This is a clean-up CL that happens to fix bugs.

[1] https://drafts.csswg.org/css-break/#breaking-rules

BUG=722041,722754

Change-Id: I63550d804bef073a5c24570d63bd55176ec5e396
Reviewed-on: https://chromium-review.googlesource.com/514049
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476270}

BUG=728527
NOTRY=true
TBR=smcgruer@chromium.org

Change-Id: Ia880080ed5b84dc6cebe5bf73e84fc100ad5074a
Reviewed-on: https://chromium-review.googlesource.com/520386Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476269}

There was one case that didn't update the FocusManager
correctly. Specifically in ~NativeViewHost it didn't update the
FocusManager. This meant if the NativeViewHost was hosting a child
widget and focus was in a view contained in the child widget, then the
FocusManager was left referencing a view it would never be told to
remove. This fixs that case.

I'm also leaving the ViewObserver case in the code as I think there
are other weird cases like this that are difficult to deal with from a
ViewRemoved perspective. I would really like to remove the explicit
calls to the FocusManager (e.g. ViewRemoved), but that would require
some changes to ViewObserver and WidgetObserver that I suspect would
be tricky to get right.

BUG=687232
TEST=covered by tests

Change-Id: I7ce7bf819f474eb975f74dc7fa1ed4708be2cf0b
Reviewed-on: https://chromium-review.googlesource.com/518542
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476268}

This change ends the WebUSB Origin Trial and enables the feature by
default.

Intent to Ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/KuXx_k2KIis/-g-75FScBgAJ

Bug: 492204
Change-Id: I8af69ccd39c9eb0d7200f0fb25566ad189d5f42e
Reviewed-on: https://chromium-review.googlesource.com/513366Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476267}

BUG=709483

Review-Url: https://codereview.chromium.org/2919503004
Cr-Commit-Position: refs/heads/master@{#476266}

https://codereview.chromium.org/2830713003 (r468137,
913ee5fe) changed the default threshold
of ElementVisibilityObserver from std::numeric_limits<float>::min() to
zero, assuming that they would behave the same.

It turns out that there's some confusion here - see
https://github.com/WICG/IntersectionObserver/issues/164 - and for now
we should continue to use std::numeric_limits<float>::min() to
distinguish between completely hidden and partially visible.

BUG=726839

Review-Url: https://codereview.chromium.org/2919543002
Cr-Commit-Position: refs/heads/master@{#476265}

TBR=fmalita@chromium.org
BUG=728566

Review-Url: https://codereview.chromium.org/2916873002
Cr-Commit-Position: refs/heads/master@{#476264}

Make the Battery Status API available only within a secure context that is
also a top-level browsing context. This disallows the use of the API within
framed content, as well as from any content that is not a secure context.

Details: https://github.com/w3c/battery/issues/10

WPT updated in https://github.com/w3c/web-platform-tests/pull/5871

BUG=661792

Review-Url: https://codereview.chromium.org/2880763002
Cr-Commit-Position: refs/heads/master@{#476263}

By auto-generating those entries, we can stop requiring people to manually
update lists such as |generated_core_dictionary_files| every time Blink's
lists of IDL dictionary files change.

Since the names of the generated .cpp/.h follow a fixed, specific format
that only depends on their respective IDL file's path and file name, we can
use GN itself to do some path introspection and generate the file names we
want in idl_impl().

While here, change the names of idl_impl()'s required arguments to make
their purpose more explicit: it is not immediately obvious that we
differentiate unions and callback functions from dictionary files in terms
of where the latter are generated and their file names, as well as why
idl_impl() only expects non-dictionary files in its outputs list. A good
next step would be generating dictionary impl files separately from unions
and callbacks to avoid the confusion altogether.

Bug: 725996
Change-Id: I41b06e8d71f33b21d77944216fcb07d0557ac47b
Reviewed-on: https://chromium-review.googlesource.com/517795
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476262}

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.

As memory benchmarks are being superseded by the ones based on memory-infra,
this code can be removed now.

BUG=581365

Change-Id: I19c2091d7eae643a37f051739a9d68b1bcbc6e71
Reviewed-on: https://chromium-review.googlesource.com/517482Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476261}

- It's not necessary to passthe LocalFrame argument and convert
  it back and forth from a WebLocalFrame. These functions only
  apply to the main frame, so just check that the frame is a
  main frame before calling in.
- ResizeAfterLayout() was passing the size parameter by value.

Change-Id: I68c76503679ee90be7cd7ee8a9566f9ba43e09ac
Reviewed-on: https://chromium-review.googlesource.com/517300
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476260}

BUG=chromium:714119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2902823005
Cr-Commit-Position: refs/heads/master@{#476259}

This CL adds an HomePageClient for Android that is only set if the
kChromeHome feature is enabled because the normal NTP has a working
home button.

If either kChromeHome or kPinHomePageAsTileFeature is not enabled,
the MostVisited tiles will not contain the home tile.

Special case: The home tile can be removed as every tile and will be
blacklisted then.
By explicitly enabling (or reenabling) the Homepage, the blacklisting
will be undone and the tile will reappear as first tile.

Removing the home tile does not disable the Homepage setting (because
this setting also controls the start-up page and the home tile is not
visually linked to the home page .... besides having the same URL).

BUG=703994

Review-Url: https://codereview.chromium.org/2897293002
Cr-Commit-Position: refs/heads/master@{#476258}

BUG=chromium:714119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2900043002
Cr-Commit-Position: refs/heads/master@{#476257}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/60074560..35b77a36

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2919763002
Cr-Commit-Position: refs/heads/master@{#476256}

Replaced by static methods in WebAXObject.

Bug: 71532
Change-Id: I30468a08cd0383f84461915bb087a5e0a198f1bb
Reviewed-on: https://chromium-review.googlesource.com/520904
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476255}

If multiple call to -saveSession:directory:immediately: are made
in quick succession, the SessionIOS objects are created to be
immediately destroyed when the scheduled save is cancelled.

Change the SessionServiceIOS API to instead take a block creating
the SessionIOS instance and invoke it on the main thread, before
requesting that the data be serialised to the disk (by sending a
task on IO thread).

BUG=725539

Change-Id: I82b42d2b46baf03a7280e60185973c635dc164a2
Reviewed-on: https://chromium-review.googlesource.com/513929
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476254}

A WebAXObject static function does the job now.

Bug: 71532
Change-Id: I4ca95eeee1bb9481fbf3713f759d9366f83de750
Reviewed-on: https://chromium-review.googlesource.com/520363
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476253}

BUG=616627

Review-Url: https://codereview.chromium.org/2913193002
Cr-Commit-Position: refs/heads/master@{#476252}

The state of "Always translate" should only be saved if the user
validate the change by using the "Done" button, so use a variable
to store the interaction and update the model when user taps on
the "Done" button.

BUG=724030

Change-Id: I421b274d3f067e569923731f7359348ab1948063
Reviewed-on: https://chromium-review.googlesource.com/519149Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476251}

Platform::LoadResource is confusing as it sounds like it's for
resource loading, while it is actually for getting bundled resource data.
This CL renames LoadResource to GetDataResource to unconfuse these.

BUG=n/a

Change-Id: I1c479c147f5aba7e9dbd919bb11f95d4c069c7f6
Reviewed-on: https://chromium-review.googlesource.com/517589Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476250}

Using wpt-import in Chromium b28a6524.

Reason for manual import: want my fullscreen/ tests ASAP.

BUG=571531,728522,728527
TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: I106230f7927f4a23a61d93ec3543cb900ea7ba24
Reviewed-on: https://chromium-review.googlesource.com/520384Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476249}

AuthPolicyCredentialsManager KeyedService service is created for every
Active Directory user profile.
It calls GetUserStatus at the start of service, each hour and on every
network connection.
Tests are coming...

BUG=662400

Review-Url: https://codereview.chromium.org/2860443002
Cr-Commit-Position: refs/heads/master@{#476248}

Story gets stuck while trying to scroll.

TBR=nednguyen@google.com,ulan@chromium.org

Bug: 728528
Change-Id: I19fbbab253bd0dce5a2c48a4a739b6b8474e01df
Reviewed-on: https://chromium-review.googlesource.com/520765
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476247}

This is a preparation CL for module loading for threaded worklets that is going
to be implemented on the off-main-thread-fetch feature.

This change provides WorkerFetchContext that is necessary for the
off-main-thread-fetch to worklet global scopes. The context is created on the
main thread before starting a worklet global scope and passed to worklet's
thread as WorkerThreadStartupData.

Note that this CL does not change the current script loading mechanism for
worklets yet.

Bug: 727194
Change-Id: I695bf8f64a583ac845a2d0a13076fda0667d8604
Reviewed-on: https://chromium-review.googlesource.com/519022Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476246}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/908a6304..60074560

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2916563004
Cr-Commit-Position: refs/heads/master@{#476245}

TBR=perezju@chromium.org, ulan@chromium.org
BUG=728464

Review-Url: https://codereview.chromium.org/2919753002
Cr-Commit-Position: refs/heads/master@{#476244}

Follow what's already done in bindings/core/v8 and add a
"bindings_modules_impl" target to bindings/modules/v8 to aggregate all the
.cpp/.h files generated by the other targets in the same BUILD.gn (the ones
processing the modules IDL files).

By declaring the target in the same GN file, we can use get_target_outputs()
to obtain some output names, which then allows us to get rid of
|bindings_modules_generated_interface_files| as well as
|bindings_modules_generated_partial_interface_files|.

This cleanup is also being done in preparation for getting rid of the
hardcoded list of generated dictionary impl files we currently maintain in
GN, as Source/modules:modules would not be able to retrieve any similar list
of generated files that it needs.

Bug: 725996
Change-Id: Ia53de40ef394af197351f218050af6d8a10f2c3a
Reviewed-on: https://chromium-review.googlesource.com/517955Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#476243}

Check whether a text node may be about to be redistributed in ShouldUpdateLayoutByReattaching(). Prevents use-after-free when SetTextWithOffset is called with dirty distribution.

BUG=726716

Review-Url: https://codereview.chromium.org/2913133002
Cr-Commit-Position: refs/heads/master@{#476242}

Bytes were being converted to kilobytes without a division.

BUG=707022

Review-Url: https://codereview.chromium.org/2914903002
Cr-Commit-Position: refs/heads/master@{#476241}

Firefox and Safari already shipped it.
This CL fixes 256 failing tests in external/wpt/.

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0P4_WvNr1xY

Bug: 724906
Change-Id: Ic55ead1509afd3e631ed0251fa312bd5b4a7001f
Reviewed-on: https://chromium-review.googlesource.com/521002Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476240}

Use PolicyData::management_mode to determine whether the device has a
local owner and only fall back to DM token in case management_mode is
unset.  That way, the correct determination is guaranteed for both
cloud and Active Directory management.  (Currently, the code is not
broken because AD policy doesn't include a user name, but that might
change in the future.)

Also update the PolicyData::management_mode documentation to include
Active Directory.

BUG=722799

Review-Url: https://codereview.chromium.org/2902183002
Cr-Commit-Position: refs/heads/master@{#476239}

BUG=712963

Review-Url: https://codereview.chromium.org/2919593004
Cr-Commit-Position: refs/heads/master@{#476238}

Bug: 710184
Change-Id: I3d1d506888657c5bd60a114609247c5f92c0edd7
Reviewed-on: https://chromium-review.googlesource.com/520443
Commit-Queue: Dominic Cooney <dominicc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476237}

Replace the raw ptr returned by ContentSettingsPattern::CreateBuilder
with a unique_ptr.
Remove legacy_validate parameter and function because it isn't used
anywhere.

BUG=
TBR=msarda@chromium.org,finnur@chromium.org,stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2909273003
Cr-Commit-Position: refs/heads/master@{#476236}

Defer deleting view after calling OnAllNotificationsCleared(). Views are deleted before OnAllNotificationsCleared(), but it causes crash. This CL moves the deletion as a temporary solution. We need to refactor the code around more in near feature.

BUG=725299
TEST=none

Review-Url: https://codereview.chromium.org/2913993002
Cr-Commit-Position: refs/heads/master@{#476235}

This CL introduces CalcSelectionPaintRange() and minimize Commit().

BUG=708453

Review-Url: https://codereview.chromium.org/2916803003
Cr-Commit-Position: refs/heads/master@{#476234}

The users of WebNode::AccessiblityObject should all be outside of core/

Bug: 71532
Change-Id: I5ff7e8bb28657408394a529ac8fe77e400d26472
Reviewed-on: https://chromium-review.googlesource.com/520542
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476233}

BUG=728086

Change-Id: Ib15f1714abb30b029b6e89facb51343fbfaa96e3
Reviewed-on: https://chromium-review.googlesource.com/519247Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476232}

static attributes must not be "keep_alive_gc".  keep_alive_gc
is a mechanism to associate a returned object with the receiver
object, however static attributes must not use the receiver
object.

BUG=

Review-Url: https://codereview.chromium.org/2913403003
Cr-Commit-Position: refs/heads/master@{#476231}