GitLab

R=asargent@chromium.org

Review URL: http://codereview.chromium.org/7741019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98272 0039d316-1c4b-4281-b951-d872f2087c98

Move resource_dispatcher_host_unittest.cc to content_unittests now that all its link time dependencies are in content.

BUG=90443
Review URL: http://codereview.chromium.org/7746008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98271 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7741002

TBR=tburkard@chromium.org
Review URL: http://codereview.chromium.org/7740029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94171
TEST=chromeos official builder dev channel goes green

Review URL: http://codereview.chromium.org/7747020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98267 0039d316-1c4b-4281-b951-d872f2087c98

This function should simplify some constructions.

Instead of:

if (!value->IsType(Value::TYPE_BINARY))
  return false;
  BinaryValue* binary_value = static_cast<BinaryValue*>(value);

You can do:

BinaryValue* binary_value = value->AsBinary();
if (!binary_value)
  return false;

BUG=None
TEST=base_unittests --gtest_filter=Values*

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7748017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: http://codereview.chromium.org/7743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98263 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO added by rogerta@chromium.org

BUG=None
TEST=None

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7717028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98259 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98258 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=levin
Review URL: http://codereview.chromium.org/7748019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98255 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7744028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92415
TEST=Manual

Review URL: http://codereview.chromium.org/7714026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22208

Review URL: http://codereview.chromium.org/7629003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98252 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7741002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98250 0039d316-1c4b-4281-b951-d872f2087c98

As identified by http://crbug.com/90867, we sometimes leaked render view hosts by overwriting them in the swapped out map of the render view host manager.
 
This should not happen (two different hosts with the same instance id) and will eventually be fixed, but in the mean time this CL recovers from that problem and prevent the leak, and also the memory corruptions that were caused by it.

The memory corruption were caused by the fact that the leaked host would not be told when their delegate_ would die and might try to call them post-mortem.

BUG=90867
TEST=RenderViewHostManagerTest.LeakingRenderViewHosts

Review URL: http://codereview.chromium.org/7725005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98249 0039d316-1c4b-4281-b951-d872f2087c98

I'd apply these to all doc channels.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7744001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7749007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98246 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98243 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98242 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of all chrome includes from RenderWidgetHostViewWin. We'll want to move this to content so that the content browser can reuse all this code.
Review URL: http://codereview.chromium.org/7741006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98240 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98236 0039d316-1c4b-4281-b951-d872f2087c98

- change aura GYP_DEFINE to use_aura to be consistent with other switches
- add gfx::NativeView/Window typedefs
- add NativeWidgetAura/etc.
- update some ifdefs and includes to build on windows.

http://crbug.com/93944
TEST=none
Review URL: http://codereview.chromium.org/7741001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98234 0039d316-1c4b-4281-b951-d872f2087c98

PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice.  The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.

PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7633040

TBR=twiz@chromium.org,jbates@chromium.org, dpolukhin@chromium.org, sanjeevr@chromium.org
Review URL: http://codereview.chromium.org/7754001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98233 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98232 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98231 0039d316-1c4b-4281-b951-d872f2087c98

PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice.  The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.

PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7633040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=57890
TEST=manual

Review URL: http://codereview.chromium.org/7745019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98229 0039d316-1c4b-4281-b951-d872f2087c98

The following tests fail:
BrowserWindowFullScreenControllerTest.TestFullscreenNotLion
BrowserWindowFullScreenControllerTest.TestActivateNotLion
FramedBrowserWindowTest.WindowWidgetLocation
HoverImageButtonTest.ImageSwap
HoverImageButtonTest.Opacity

BUG=93925,93926
TEST=Run unit_tests on Lion and don't crash.

Review URL: http://codereview.chromium.org/7715012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:5370
TEST=build

Review URL: http://codereview.chromium.org/7745018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98227 0039d316-1c4b-4281-b951-d872f2087c98

the error instead of aborting here.

BUG=75518
TEST=BUILD

Review URL: http://codereview.chromium.org/7743001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93366
TEST=TODO


Review URL: http://codereview.chromium.org/7740011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98224 0039d316-1c4b-4281-b951-d872f2087c98

This function should simplify some constructions.

Instead of:

if (!value->IsType(Value::TYPE_LIST))
  return false;
ListValue* list_value = static_cast<ListValue*>(value);

You can do:

ListValue* list_value = value->AsList();
if (!list_value)
  return false;

BUG=None
TEST=base_unittests --gtest_filter=Values*

R=evan@chromium.org,tony@chromium.org

Review URL: http://codereview.chromium.org/7714004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98223 0039d316-1c4b-4281-b951-d872f2087c98

Note new documentation at https://sites.google.com/a/chromium.org/dev/developers/design-documents/service-processes

BUG=None
TEST= 1) Build.
      2) Launch Chromium with cloud print disabled.
      3) Start Terminal
      4) launchctl list
      5) You should not see any org.chromium.Chromium.framework.service_process/* processes listed
      6) Go to Preferences in chromium
      7) launchctl list
      8) You should now see a org.chromium.Chromium.framework.service_process/* process
      9) Quit chromium
      10) launchctl list
      11) There should not be any org.chromium.Chromium.framework.service_process/* processes anymore

Review URL: http://codereview.chromium.org/7736002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=tonyg@chromium.org

Review URL: http://codereview.chromium.org/7715031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94228
TEST=none
TBR=sky

Review URL: http://codereview.chromium.org/7744022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98218 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98217 0039d316-1c4b-4281-b951-d872f2087c98