GitLab

The code had undefined behavior, depending on what order the compiler chose to evaluate the arguments in.  Specifically, the call to RegisterProfile() required evaluation of two arguments: |profile->object_path()| and |base::Bind(success_callback, base::Passed(&profile))|.  If the latter was evaluated first, then |profile| would be null by the time that the prior was evaluated.

The crash stack is:

Program received signal SIGSEGV, Segmentation fault.
std::string::compare() const ()
StartsWithASCII()
dbus::IsValidObjectPath()
dbus::MessageWriter::AppendObjectPath()
chromeos::BluetoothProfileManagerClientImpl::RegisterProfile()
chromeos::BluetoothAdapterProfileChromeOS::Register()
chromeos::BluetoothAdapterChromeOS::UseProfile()
chromeos::BluetoothSocketChromeOS::RegisterProfile()

BUG=457978
TEST=(see bug, comment #14)
R=armansito@chromium.org, jamuraa@chromium.org

Review URL: https://codereview.chromium.org/997023002

Cr-Commit-Position: refs/heads/master@{#320139}

This is a rebase of crrev.com/413823002 by msw@.

Cache RenderText instances, avoid Canvas::DrawString*.
(avoids repeating itemization, layout, etc. on each paint)
Recalculate colors and reset the layout as needed.
Large cleanup; remove obsolete flag tests; update tests.

Update App List's CachedLabel views::Label subclass use.
(SchedulePaintInRect triggered paint with color changes)
Ensure SetTitleSubpixelAA is otherwise called as needed.
(skip early return; which breaks folder reorganization)

This will increase the performance of painting
significantly. See https://docs.google.com/document/d/1q4RrBjNO52l1pNTkIZPhQ60aPfBZnV4Af0vdQNr2Juc/edit#
for the detailed analysis.

BUG=240037, 125348, 450791
TEST=no appearance changes with performance improvement as:
  On daisy with 15 bookmarks, repainting of bookmark is
  decreased as 135msec -> 2.8msec
R=sky@chromium.org

Review URL: https://codereview.chromium.org/867003002

Cr-Commit-Position: refs/heads/master@{#320138}

Delete obsolete tests. Proposal Doc: https://docs.google.com/a/google.com/document/d/1AAl82Ik1LzgMARS73HTAmh7pccoRV-29y3JR1AY2brQ/edit?usp=sharing

BUG=459420

Review URL: https://codereview.chromium.org/995003003

Cr-Commit-Position: refs/heads/master@{#320137}

Also add more logging to SocketHostTcp for easier debugging.

BUG=463680

Review URL: https://codereview.chromium.org/976903002

Cr-Commit-Position: refs/heads/master@{#320136}

Long ago, Chromium used fts2 for history full-text search.  It was
later replaced by fts3, and even later that feature was deleted
entirely.  fts2 is no longer used in the browser at all, so stop
compiling it.

Since SQLite is used by WebSQL, in theory this could affect web
authors, but WebSQL uses an authorizer to allow only specific virtual
table types.  fts2 is not one of those types, I have verified manually
that fts2 tables cannot be created using WebSQL.

BUG=455817

Review URL: https://codereview.chromium.org/999573003

Cr-Commit-Position: refs/heads/master@{#320135}

Currently, this preference is not monitored such that any change through the extension api will require a restart of chrome.

landed fix for crbug.com/457629 is to expose extension api to allow this be changed dynamically.

Tested with the extension.

BUG=466197

Review URL: https://codereview.chromium.org/999833002

Cr-Commit-Position: refs/heads/master@{#320134}

BUG=460553

Review URL: https://codereview.chromium.org/980413003

Cr-Commit-Position: refs/heads/master@{#320133}

Reorder uses-sdk and uses-permission to above application tag.
Remove INJECT_EVENTS permission since we don't need it.

BUG=

Review URL: https://codereview.chromium.org/998003002

Cr-Commit-Position: refs/heads/master@{#320132}

Root cause:
Merge conflict introduced in https://codereview.chromium.org/955283002/

The error handler is now called with an object instead of a string.

BUG=465902

Review URL: https://codereview.chromium.org/999133002

Cr-Commit-Position: refs/heads/master@{#320131}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/03f094d..4dd513a

TBR=adamk@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/995253003

Cr-Commit-Position: refs/heads/master@{#320130}

Revert of Raster into an SkP before rendering a DisplayList. (patchset #2 id:20001 of https://codereview.chromium.org/966443003/)

Reason for revert:
Fails several slimmingpaint layout tests on Linux

Failures that look to be real bugs include:

  virtual/slimmingpaint/fast/table/border-collapsing/adjacent-row-groups-multi.html
  virtual/slimmingpaint/fast/text/emphasis.html

Original issue's description:
> Raster into an SkPicture before rendering a DisplayList.
>
> Rasterizing a display list is more than 2x slower than rasterizing in the existing architecture. This is due to recording more with a display list and we have no bounding hierarchy to cull content quickly.
>
> We can address this by creating an SkPicture from the list, with a bounding hierarchy, and rasterizing that instead. The result is slightly faster than the non-S.P. pipeline but uses 2x more memory.
>
> BUG=464738
>
> Committed: https://crrev.com/de765f47e9449420e46d968ec40bb6f41a193990
> Cr-Commit-Position: refs/heads/master@{#319519}
>
> Committed: https://crrev.com/c54bea7972a4a26fe49fd43a07cc99bb3a0e1990
> Cr-Commit-Position: refs/heads/master@{#320097}

TBR=ajuma@chromium.org,enne@chromium.org,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464738

Review URL: https://codereview.chromium.org/997173003

Cr-Commit-Position: refs/heads/master@{#320129}

Explicitly enable WebUILoginView before launching kiosk so that
the bailout shortcut key works.

BUG=465561

Review URL: https://codereview.chromium.org/993423002

Cr-Commit-Position: refs/heads/master@{#320128}

The master device now sends ButtonPress event when touching a native
select menu, and it is converted to another TouchPress, so that the
gesture recognizer cannot generate the right gesture tap event, which
causes the drop-down menu does not response for the touches.

We set masks for the touch events in the GrabPointer, so that master device
will send touch events not button events any more for touch screen.

BUG=458773

Review URL: https://codereview.chromium.org/968343002

Cr-Commit-Position: refs/heads/master@{#320127}

That requires either a separate set of build bots, OR making separate targets for url/ and net/ that use that flag.

This change adds such targets (extracting net target into separate net_common.gypi).

BUG=430500

Review URL: https://codereview.chromium.org/933293003

Cr-Commit-Position: refs/heads/master@{#320126}

BUG=465771

Review URL: https://codereview.chromium.org/993003002

Cr-Commit-Position: refs/heads/master@{#320125}

This prevents tabbing when the profile name textfield is empty,
which was missing in my earlier CL.

This also improves upon that CL by using a different method to catch
event, which means no longer having to take care of blurring.

BUG=457585

Review URL: https://codereview.chromium.org/985193003

Cr-Commit-Position: refs/heads/master@{#320124}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d5b9840..cb251f1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1000683003

Cr-Commit-Position: refs/heads/master@{#320123}

Revert of Splitting of layers for correct intersections (patchset #20 id:370001 of https://codereview.chromium.org/595593002/)

Reason for revert:
Appears to be adding new static initializers and is breaking Mac/Linux builders, e.g.: http://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=34562

Original issue's description:
> Splitting of layers for correct intersections
>
> Sorting 3d-sorted layers and rendering them in that order causes issues
> when layers intersect. Instead place 3d-sorted layers in a bsp tree and
> fragment any intersecting layers into non-rectangular quads. We can then
> render the fragments in the correct sorted order regardless of
> intersections.
>
> BUG=455918,159225,132122,230833
>
> Committed: https://crrev.com/7e2af77dcd3b5df086be3421fad40b719779381c
> Cr-Commit-Position: refs/heads/master@{#320096}

TBR=enne@chromium.org,danakj@chromium.org,eroman@chromium.org,thakis@chromium.org,awoloszyn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455918,159225,132122,230833

Review URL: https://codereview.chromium.org/998023002

Cr-Commit-Position: refs/heads/master@{#320122}

BUG=https://groups.google.com/a/chromium.org/forum/#!topic/telemetry/WZVeSlNvJAg/discussion
TEST=Pick a page with  credentials='google', we should be update the credentials to 'google2' and re-record the page.

Review URL: https://codereview.chromium.org/1001433002

Cr-Commit-Position: refs/heads/master@{#320121}

When running this unittest in non-CrOS systems, DisplayConfigurator
configure_display_ needs to be initialized as true as well, so the Native
Display will actually be created properly at ::Init time.

BUG=none
TEST=video_decode_accelerator_unittest --vmodule=*/ui/ozone/platform/drm/*=3,
and check the Ozone DRM informational messages that creates the display

Review URL: https://codereview.chromium.org/995103002

Cr-Commit-Position: refs/heads/master@{#320120}

Suppose we have two Chromebook A and B with the same account and with surprise me enabled.
This CL handles two edge cases when "onChanged" and "onAlarm" are both fired on Chromebook B.
1) The last surprise wallpaper was set on A yesterday. Log into B today:
  Don't sync with A. A new surprise wallpaper should set for B.
2) The last surprise wallpaper was set on A today. Log into B later the same day:
  Don't set a surprise wallpaper for B anymore, instead B should sync the same wallpaper with A.

BUG=373682
TEST=Tested on devices

Review URL: https://codereview.chromium.org/956403003

Cr-Commit-Position: refs/heads/master@{#320119}

BUG=394842

Review URL: https://codereview.chromium.org/962753002

Cr-Commit-Position: refs/heads/master@{#320118}

Currently they hang (holding the cache lock) or crash. This plumbs
through a dedicated delegate interface. If the delegate is destroyed with
no notification, the request is aborted. This is distinct from
affirmatively continuing with no certificat (what you get from pressing
cancel). This is extremely bizarre UI, but this CL does not attempt to
address the existing UI being odd.

This fixes the following:
- Closing a tab with a client auth prompt acts as if you affirmatively selected
  to continue without a cert.
- A SharedWorker requesting client auth hangs the request.
- Hitting client auth in an extension background page crashes.

BUG=417092,410967

Review URL: https://codereview.chromium.org/859213006

Cr-Commit-Position: refs/heads/master@{#320117}

Add HttpServerProperties::IsAlternativeServiceBroken(), remove
AlternateProtocolInfo.is_broken.  An alternative service can be broken by
itself, not with respect to an origin.

BUG=392576
R=rch@chromium.org

Review URL: https://codereview.chromium.org/995013004

Cr-Commit-Position: refs/heads/master@{#320116}

This argument is used to identify the correct test suite when uploading perf dashboard data from gTests.

BUG=466110

Review URL: https://codereview.chromium.org/1001533003

Cr-Commit-Position: refs/heads/master@{#320115}

This patch renames the <webview> 'contextmenu' DOM event to 'contextmenushown', so as not to overload the existing general 'contextmenu' DOM event.

Review URL: https://codereview.chromium.org/1002433002

Cr-Commit-Position: refs/heads/master@{#320114}

BUG=368049

Review URL: https://codereview.chromium.org/961443002

Cr-Commit-Position: refs/heads/master@{#320113}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4412465..d5b9840

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1001553002

Cr-Commit-Position: refs/heads/master@{#320112}

This was dropped during BenchmarkingCanvas refactoring. Adding back for
feature parity.

BUG=461534
R=robertphillips@google.com,reed@google.com

Review URL: https://codereview.chromium.org/993893004

Cr-Commit-Position: refs/heads/master@{#320111}

BUG=411461

Review URL: https://codereview.chromium.org/974103002

Cr-Commit-Position: refs/heads/master@{#320110}

This is a regression issue caused by https://codereview.chromium.org/786023002.
After we imported text_default.css, a default font-size (75%) will be applied to body
unless we explicitly set the font-size value. To restore the previous font-size, we set the font-size in body to 100%.

BUG=465604
TEST=manually checked the keyboard overlay

Review URL: https://codereview.chromium.org/997033002

Cr-Commit-Position: refs/heads/master@{#320109}

Revert of kiosk: Fix bailout shortcut not working. (patchset #1 id:1 of https://codereview.chromium.org/995763004/)

Reason for revert:
Multiple KioskTest becomes flaky after the CL lands. Revert and investigate.

Original issue's description:
> kiosk: Fix bailout shortcut not working.
>
> Explicitly enable login display before launching kiosk so that
> the bailout shortcut key works.
>
> BUG=465561
>
> Committed: https://crrev.com/390c1768aa44713198ed393271d985ba2c628263
> Cr-Commit-Position: refs/heads/master@{#320088}

TBR=antrim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465561

Review URL: https://codereview.chromium.org/999143002

Cr-Commit-Position: refs/heads/master@{#320108}

Review URL: https://codereview.chromium.org/981243003

Cr-Commit-Position: refs/heads/master@{#320107}

This line was accidentally left out of a previous CL:
https://codereview.chromium.org/969883002

BUG=411461

Review URL: https://codereview.chromium.org/987053003

Cr-Commit-Position: refs/heads/master@{#320106}

Roll third_party/hunspell_dictionaries dependency after re-running
convert_dict for en-US and en-CA.

TBR=groby@chromium.org
BUG=165079

Review URL: https://codereview.chromium.org/997983002

Cr-Commit-Position: refs/heads/master@{#320105}

The test was checking for resources that did not load. Added wait for
the page to complete loading and then run actions.

BUG=465446

Review URL: https://codereview.chromium.org/996723002

Cr-Commit-Position: refs/heads/master@{#320104}

The purpose of this change is to ensure that if a client knows about an
attachment (i.e. has an AttachmentId or AttachmentIdProto) it will know
the attachment's size even if the attachment has never been available on
the local device.

The idea is that by storing size locally, we can simplify remote storage
management.

Move crc32c out of Attachment now that it's part of AttachmentId.

BUG=464431

Committed: https://crrev.com/23ae3128db0d84a6b1ffa640568a5ec90cfc8808
Cr-Commit-Position: refs/heads/master@{#319794}

Review URL: https://codereview.chromium.org/982883002

Cr-Commit-Position: refs/heads/master@{#320103}

This is a follow up change to https://codereview.chromium.org/974913006/

BUG=None

Review URL: https://codereview.chromium.org/997183002

Cr-Commit-Position: refs/heads/master@{#320102}

Brings in:
0b238cb  Minor test changes to fix compile errors.

Review URL: https://codereview.chromium.org/977373003

Cr-Commit-Position: refs/heads/master@{#320101}

Accidentally removed by https://codereview.chromium.org/971383002/

BUG=463088

Review URL: https://codereview.chromium.org/999793003

Cr-Commit-Position: refs/heads/master@{#320100}