- 08 Mar, 2018 40 commits
-
-
Dmitry Gozman authored
This will make it easier to support multiple models in PerformanceMonitor. Bug: none Change-Id: I7ea678fba1e4f634cd26ef05638cac2a8ec3414b Reviewed-on: https://chromium-review.googlesource.com/953713Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541695}
-
Pavel Feldman authored
Change-Id: I00e8c2f3a14e6adec6a85ccff2d68adcf41f1d6a Reviewed-on: https://chromium-review.googlesource.com/953964Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541694}
-
Adam Langley authored
These are probably no longer useful. BUG=782084,771030,753209,722663,673605,673603,619807 Change-Id: Ic302e42508386ea7a4a01d937509a6ab29711ed1 Reviewed-on: https://chromium-review.googlesource.com/953482Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541693}
-
Giovanni Ortuño Urquidi authored
Introduces BookmarkAppNavigationThrottle to handle out-of-scope navigations in app windows and puts BookmarkAppExperimentalNavigationThrottle behind kDesktopPWAsLinkCapturing. Changes kDesktopPWAsLinkCapturing to be on by default, so there should be no change in behavior for users. A follow up patch will change kDesktopPWAsLinkCapturing to be off by default. BookmarkAppNavigationThrottle and BookmarkAppExperimentalNavigationThrottle share some functionality that has been extracted into bookmark_app_navigation_throttle_utils.h [1] Specify that throttle and tests are for experimental feature (https://crrev.com/c/940824) [2] Extract tests that should run when link capturing is off (https://crrev.com/c/939883) [3] Handle out-of-scope navigations and stop link capturing by default (this patch) [4] Disable link capturing by default (https://crrev.com/c/950484) Bug: 814102 Change-Id: I7d394899d85922fce9e51831bf8705e31d8a53bf Reviewed-on: https://chromium-review.googlesource.com/942597Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541692}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. Bug: 550065 Change-Id: Ib370ef07bf5f2df00814aa063833486e30ecde6f Reviewed-on: https://chromium-review.googlesource.com/954202Reviewed-by:
-
Sammie Quon authored
Animations into overview has changed so that non visible windows do not need to animation. Previous rounded edges code relied on animation end to apply mask, this cl applies mask to all cases, and removes before animations, and reapplies after animation. Test: ash_unittests WindowSelectorTest.RoundedEdgeMaskVisibility Bug: 817860 Change-Id: I9da0e2a56e991a7c3073a4c2c0de79d8e3799915 Reviewed-on: https://chromium-review.googlesource.com/953135Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541690}
-
wutao authored
WindowGrid::PositionWindows is called at multiple places to animate windows in overview mode. Reset the should_animate_when_entering_ flag in order to animate in other situations. Bug: 817888 Test: WindowSelectorTest.WindowItemCanAnimateOnDragRelease Change-Id: I14a773033982c47823e6a0e331b7b8df4baa1791 Reviewed-on: https://chromium-review.googlesource.com/952671 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541689}
-
Becky Zhou authored
+ Using material icon for expand/collapse + Remove 10dp top padding from header view Bug: 818368 Change-Id: I7d9318e1a8c9b1edcf7b51aa9e4804eb82f38ea9 Reviewed-on: https://chromium-review.googlesource.com/952542Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541688}
-
Sunny Sachanandani authored
This broke because the direct composition path doesn't use swap interval set by eglSwapInterval in ANGLE. Since we only care about disabling via command line, it's ok to just handle that instead of SetSwapInterval. This will still not work when we use a direct composition surface instead of swap chain but that only happens when we use overlays. There may be no way to make this case work since the swap chain is not controlled by Chrome. Tested with vsynctester.com on my home desktop. R=kbr,piman BUG=480361,787485 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ife5804b4e9bcede41bb29cd01e54e81f0d278b62 Reviewed-on: https://chromium-review.googlesource.com/954020Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#541687}
-
Jeffrey Kardatzke authored
This is for automated testing. During testing, we need to automatically click on approval in the permissions dialog. This allows Android to have a mechanism by which it calls into Chrome and requests that it accepts the permission. This is ONLY allowed when the build is of type 'testimage'. This then allows the automatic test to proceed. It also disables showing the notification that screen capture is activate since during Android testing that is also not expected to be part of the screen. Bug: b:38452042, b:73045468 Test: CTS tests pass now Change-Id: I87d46b1d4859e3fe6b1b034e6a020ceafc9b7357 Reviewed-on: https://chromium-review.googlesource.com/909299 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541686}
-
Han Leon authored
As opposed to WebKit/public/mojom:mojom_platform, the gn target WebKit/public/mojom:mojom includes mojom interfaces which do use types that are typemapped to a type in Source/core, and its C++ bindings for Blink variant is embedded inside blink_core component. So, to avoid any confusion, this CL renames it to WebKit/public/mojom:mojom_core to announce explicitly the close relationship with Source/core. BUG= Change-Id: I3a9e68e8f7da5bf0c085d11e9a8cbd273247c638 Reviewed-on: https://chromium-review.googlesource.com/952113Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#541685}
-
David Tseng authored
Rich editables should be skipped entirely (and not fall through to output). Original change: - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. TBR=dmazzoni@chromium.org, dtseng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If555f157a7eeafe836929e9433891b2e7ae181df Reviewed-on: https://chromium-review.googlesource.com/953980 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541684}
-
Ken MacKay authored
This fixes DSCP flags for dual-stack IPv6 sockets (ie, IPv6 sockets that can also send/receive IPv4 packets). Otherwise, the DSCP flags are not set correctly when sending to IPv4 destinations. Test: set DSCP flags, observe set packet flags with tcpdump. Change-Id: I83619dfc44b764bfeab069e09e0026369882f1bb Reviewed-on: https://chromium-review.googlesource.com/953341Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#541683}
-
Nico Weber authored
Standard C++ forbids implicit conversion of function pointers to void*, so logging a function pointer to a stream normally picks the operator<<(bool) overload of the stream and prints '1' in practice. MSVC allows implicit conversion of function pointers to void*, so there the function's address is printed instead. This change makes behavior consistent between MSVC and non-MSVC. On Windows, clang-cl emulates MSVC behavior but emits a -Wmicrosoft-cast warning, so this change also allows building ui/gl with -Wmicrosoft-cast enabled. Also add a few comments ot the log parameter transform code and order the special types alphabetically. Bug: 550065 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I78e25467bfb069bf84216ded00ab20450b98ea40 Reviewed-on: https://chromium-review.googlesource.com/953385Reviewed-by:
-
Kent Tamura authored
Bug: 578345 Change-Id: I8b3013add389ea5ee5bce31e39b49284a1ab57ba Reviewed-on: https://chromium-review.googlesource.com/952743Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541681}
-
rajendrant authored
Bug: 818520 Change-Id: I6a5c98239f05caf3499ac6eb5de520160ae1bed0 Reviewed-on: https://chromium-review.googlesource.com/953202Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
lgcheng authored
Stores and restores persistent USB permission with Chrome prefs. Bug: 776476 Bug: b:24572867 Change-Id: I008166a32d47cba2edbdc54858b807491add6858 Reviewed-on: https://chromium-review.googlesource.com/944249 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#541679}
-
Koji Ishii authored
This is a cleanup refactoring without behavior changes. Line box fragment used to use line height as its height, and that when NGContainerFragmentBuilder was introduced as the super class of NGFragmentBuilder and NGLineBoxFragmentBuilder, Size() became virtual function. Currently, line box fragments includes floats in its height under some conditions, and that the block size of the line box fragment may be different from line height, but Size() still returns line height. This patch cleans this up, and make Size() always return the fragment size. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3f01b2c8810923fe64e1abb81d6af2c33f40bd4a Reviewed-on: https://chromium-review.googlesource.com/953026Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541678}
-
Pete Williamson authored
Since it is used by both downloads and offline_pages, moving it to a common namespace and directory Bug: 814492 Change-Id: I8781730c3025087ff0ab0a5473f1ae4231dbf775 Reviewed-on: https://chromium-review.googlesource.com/939701 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#541677}
-
Weidong Guo authored
After screen magnification is enabled/disabled, the preferences for the active profile have not been updated when the cursor compositing is being updated. Use MagnificationController::IsEnabled() instead. BUG=814634 Change-Id: Id72c579bd3395ae2e9748858622df37086bc4220 Reviewed-on: https://chromium-review.googlesource.com/951639Reviewed-by:
-
Ryan Sturm authored
Change-Id: I3c861fa6a83c862cfacef9393c64c23153eb72ba Reviewed-on: https://chromium-review.googlesource.com/954243Reviewed-by:
-
Aaron Leventhal authored
When a download starts or finishes, notify screen reader users with a friendly message that contains useful information such as the size and name of the file to be downloaded. In addition, for long downloads, provide screen reader update notifications every 30 seconds, and include the time or % remaining. Bug: 787139 Change-Id: I903dd626fddad16504079c69d4e1f3edd88d8052 Reviewed-on: https://chromium-review.googlesource.com/947769 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541674}
-
Peter Kotwicz authored
This CL refactors ReplacePlaceholders() to make it clearer that only placeholders in the url_template query and fragment are replaced. BUG=694380, 788191 Change-Id: I62672ae9e8386ef53ff532cf20a0d312fcba600f Reviewed-on: https://chromium-review.googlesource.com/925648 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Made GestureListenerManager a bit more responsible and take over update using the frame metadata from renderer. GestureListenerManager was already handling scroll/scale limit changed through frame metadata update, which I believe gives justification to the refactoring. This also helps reduce the layering-violating reference to ContentViewCore from RenderWidgetHostViewAndroid. Bug: 626765 Change-Id: Iaa63e2ccd2e3e3b87c8c06b140ff93687f6601a1 Reviewed-on: https://chromium-review.googlesource.com/950526 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541672}
-
Shuotao Gao authored
TBR=penghuang@chromium.org Bug: 819851 Change-Id: I79a372df597d64d4a0d1e5294c4f961e79e2d9f9 Reviewed-on: https://chromium-review.googlesource.com/954288Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#541671}
-
Ian Vollick authored
We have plumbed knowledge to blink that we are in immersive mode, but a spot was missed: when the preferences are updated, we failed to poll whether we were in immersive mode. The result is that we would often clobber the immersive mode setting. Bug: 817412 Change-Id: I402346a43d3d2214475d93a14208a92cfedfa00d Reviewed-on: https://chromium-review.googlesource.com/953168Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541670}
-
John Z Wu authored
This is in preparation for a FakeWebViewTranslateClient so unit tests can be written for the rest of the public methods. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7bb15cf38467b5a2b388fee7849599c1876ffa6c Reviewed-on: https://chromium-review.googlesource.com/953824Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541669}
-
Daniel Murphy authored
Bug: 810564 Change-Id: I69583e3e9bb54a4eff953e5893e0a23818e7ef64 Reviewed-on: https://chromium-review.googlesource.com/950132 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#541668}
-
Jinsuk Kim authored
The view height was not being set correctly when the device was rotated as reported in the bug. The bar height should have been taken into account like it was done at creation. This CL fixes that. This matters only for full-sized width contextual search panel only, where the cs panel is preserved upon rotation. Bug: 819506 Change-Id: I85b0795928a1faeb61b03b14af0ff035f4c1d001 Reviewed-on: https://chromium-review.googlesource.com/954242Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#541667}
-
Chris Kuiper authored
This includes two additional pieces of information in the log tag: 1) The castContentType number. 2) An instance counter that increases with each new instance created. Example: "cr_AATrack(0:3): Setting volume to 1.0" Bug: internal b/74338858. Test: Run new logic for actual troubleshooting session. Change-Id: I246e8d2fa10c0f3175dc143cb9395bfedcabe008 Reviewed-on: https://chromium-review.googlesource.com/953081Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#541666}
-
Jay Civelli authored
This CL moves the DoNotTrack header to be set in the NavigationRequest for frame navigations, and in RenderFrameImpl for sub-resrouces load, based on whether the containing frame has DNT set. This is now all done in the content layer. So the browser tests were also moved to content, leaving in Chrome 2 simple tests that validates that the Chrome preference is set on the WebContents. Bug: 808948 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifb57ab8bb9a2bd6231ec0cf93232306738b020dc Reviewed-on: https://chromium-review.googlesource.com/953077Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541665}
-
tzik authored
This updates //gin to use base::OnceCallback or base::RepeatingCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //gin from 8 to 1 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I5c4bb758181c09e2d7b0e2fec5c51a4e1eec24bb Reviewed-on: https://chromium-review.googlesource.com/952646Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#541664}
-
David Bokan authored
Turning on root-layer-scrolls caused the number of layers on the worldjournal story to almost double, causing regressions on many metrics. The reason for these extra layers is because we were now compositing iframes where we weren't before. These iframes have empty sizes: 0x0 but, when RLS is enabled, the LayoutView computes a non-empty layout overflow rect in LayoutBlock::ComputeOverflow (due to default margins on an empty page). The reason this differs based on RLS is because LayoutView has an overflow clip only when RLS is turned on. Thus, without RLS, ComputeOverflow doesn't add overflow from the old_client_after_edge and the LayoutView never gets any overflow. No overflow means DocumentRect in LocalFrameView::ScrollingReasons() does not exceed the empty VisibleContentRect size and we return kNotScrollableNoOverflow. With RLS this method returns kScrollable and we blindly mark it as needing compositing. The fix in this CL is to check that the iframe has some size in addition to being scrollable before we composite it. Bug: 811438 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iae82d124337088531ef94acac1e7383f08b852b5 Reviewed-on: https://chromium-review.googlesource.com/953332Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541663}
-
Michael Thiessen authored
This reverts commit 1ee268df. Original change's description: > Revert "Reland "Exclude unused java classes from gvr_common_java aar"" > > This reverts commit 03667272. > > Reason for revert: Causing crashes of unknown origin on K https://chromium-swarm.appspot.com/task?id=3c16a11a3d0f5b10&refresh=10&show_raw=1 (occurred with original CL as well) > > Original change's description: > > Reland "Exclude unused java classes from gvr_common_java aar" > > > > This reverts commit f04d3bde. > > > > Original change's description: > > > Revert "Exclude unused java classes from gvr_common_java aar" > > > > > > This reverts commit dbc48ca4. > > > > > > Reason for revert: Getting NoClassDefFoundError on Nougat https://chromium-swarm.appspot.com/task?id=3c01bdd86290b710&refresh=10&show_raw=1 > > > > > > Original change's description: > > > > Exclude unused java classes from gvr_common_java aar > > > > > > > > As far as I can tell this filters the rest of the unused java classes. > > > > > > > > Please revert this CL if you see ClassNotFound Exceptions. > > > > > > > > diagnose_bloat summary: > > > > MonochromePublic.apk_Breakdown (-4,097 bytes) > > > > +1,731 bytes Zip Overhead > > > > -1 bytes Package metadata size > > > > -5,827 bytes Java code size > > > > MonochromePublic.apk_Specifics > > > > -15,137 bytes normalized apk size > > > > -11,040 bytes main dex size > > > > > > > > Bug: 944791 > > > > Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4 > > > > Reviewed-on: https://chromium-review.googlesource.com/944791 > > > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#540549} > > > > > > TBR=mthiesse@chromium.org,bajones@chromium.org > > > > > > Change-Id: I1b4b8c2d4acaaa9eafde507ceeb32293a164ac2b > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 944791 > > > Reviewed-on: https://chromium-review.googlesource.com/946653 > > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#540672} > > > > TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 944791 > > Change-Id: I17e5095e0298d20bdd3876473e673f4ed5f07e5c > > Reviewed-on: https://chromium-review.googlesource.com/951826 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#541236} > > TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org > > Change-Id: I97a0f25703d4ebf80b357a8f63d4399c1fcfbb3f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 944791 > Reviewed-on: https://chromium-review.googlesource.com/951972 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541247} TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org Change-Id: Ia8c899645df903ee40c6cdfe1b0f1d614869df68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944791 Reviewed-on: https://chromium-review.googlesource.com/954183 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#541662}
-
Lukasz Anforowicz authored
This CL moves the core CORB logic (figuring out if a given response should be CORB-protected based on 1) response metadata like initiator, MIME type, CORS headers and 2) sniffing the first bytes of the response) from //content/common into //services/network. As part of the move, this CL makes some extra, opportunistic changes: - Renames the moved files (and the moved class) to match the name agreed upon in the explainer (s/CrossSiteDocumentClassifier/CrossOriginReadBlocking) - Also moves the explainer doc to //services/network - Tweaks the old CrossSiteDocumentMimeType enum so that - It is nested in CrossOriginReadBlocking::MimeType - The enum values have shorter names In the long-term, the core CORB logic should only be needed within services/network. In the short-term, this logic has the following consumers: - content/browser/loader/cross_site_document_resource_handler.cc (integrates CORB into the old, pre-network-service, ResourceHandler-based world; this can go away after the network service ships) - content/renderer/loader/site_isolation_stats_gatherer.cc (gathers UMA that help decide what responses can be blocked by CORB with acceptably low risk of breaking existing websites; this can go away after CORB ships) - WIP(https://crbug.com/792546): services/network/url_loader.cc (this will integrate CORB into the new, network-service world). Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib8fe412b1f807d23e41700b7f7090cd4b77c1783 Reviewed-on: https://chromium-review.googlesource.com/929446 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541661}
-
Sorin Jianu authored
Bug: 819706 Change-Id: I5d9a244871ec06b33babb56eb8bd2453133c3c8b Reviewed-on: https://chromium-review.googlesource.com/953243 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#541660}
-
Philip Rogers authored
LayoutObject::HitTest calls NodeAtPoint multiple times for different phases. We can avoid calling LayoutBox::NodeAtPoint if the point is known to be clipped out. This patch extracts this optimization from LayoutBox::NodeAtPoint and uses it in LayoutBox::HitTest to avoid several calls to LayoutBox::NodeAtPoint at the expense of making LayoutObject::HitTest virtual. HitTest has been renamed HitTestAllPhases to clarify the behavior. With this, blink_perf.events.hit-test-lots-of-layers improves by 7%. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib1a8a048d636fa63ad31347825660caf69fca1a0 Reviewed-on: https://chromium-review.googlesource.com/953378Reviewed-by:
-
Eric Karl authored
DelegatedFrameHostAndroid was updated to take a compositor lock when it attaches to the compositor. This patch adds unit tests verifying that this behavior works as expected. Bug: 792120 Change-Id: I0eb783e15663df1f1f9efce01249946aec7678a1 Reviewed-on: https://chromium-review.googlesource.com/952662 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#541658}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/57bbe676efe5..670a0ff9f5a1 $ git log 57bbe676e..670a0ff9f --date=short --no-merges --format='%ad %ae %s' 2018-02-21 baileyberro smbprovider: add GetDeleteList protos 2018-03-01 dgreid vm_concierge: Add a command to list VM disk images Created with: roll-dep src/third_party/cros_system_api Change-Id: I9abfc78a3d258b061d52d4b66f9fe925ad38ae25 Reviewed-on: https://chromium-review.googlesource.com/953180Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#541657}
-
Jared Saul authored
Bug: 789645 Change-Id: I6c07392942a49c7ce20ece83cdd5284310377559 Reviewed-on: https://chromium-review.googlesource.com/953969 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541656}
-
