- 24 Jun, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592936751-767ef07082a8dc3f12048c56b1a9381a023bc8f1.profdata to chrome-win32-master-1592953173-dfa217e6d4c03de878e7e0d7393e7f5bccc2ec20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id0d4bca59c2f07ff27b1796aa1cd1ed75bc2f51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781688}
-
danakj authored
Instead ask WebTestControlHost to create a JavaScriptDialogManager when it is present. This removes the 2nd-last dependency from shell/browser production code to shell/browser/web_test. The only last one is the WebTestControlHost. R=avi@chromium.org Bug: 866140 Change-Id: Ied37d492c520f5f274dc662f4f8782fb8544de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260941 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781687}
-
Asami Doi authored
Add a new metric that is used for the Finch experiment (CheckOfflineCapability) to record the time that a fetch event was queued. Bug: 965802 Change-Id: Ie7e579c138c69d96f18c8fff71c2ca5b9ea279bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245970Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781686}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592935173-8e4ecbeaa648b10e168b33ede78da61a4b393ac3.profdata to chrome-win64-master-1592953173-8fb0a7663f4cd8da151edd9da48fe9964b3af4db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaf237e8756a375d339c7db36968ea5c3431b0882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262053Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/825e09a61fc2..15444a50b912 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150,chromium:1096216 Tbr: johannkoenig@google.com Change-Id: I1b241463c01f0b7c9ed9a22c9a44a53c9eeac0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781684}
-
Jing Wang authored
The feature is behind the flag imeOptionsInSettings. Now we have real data displayed in these two options pages, and changing the options there will actually change values in prefs. US English and Pinyin are two representative input methods, so I first implement their pages. Add other pages should be easy after these two are done. Screenshots of the implemented UI: US English: https://screenshot.googleplex.com/eZNEF5mjste Pinyin: https://screenshot.googleplex.com/X0aDrc8SkiE Test: tested with Chrome on Linux Bug: 1086786 Change-Id: I083369526805c15f73049b23ce07edce76fe246e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228439 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#781683}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/613777a9..b2720383 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I254a9be54779eb3ad6491c8e22c3b83f1db4d340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260582Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781682}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I7ff46ac3e60e07130387c94335a3adbdbe8e385c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262493Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781681}
-
Aaron Tagliaboschi authored
Quite a fair amount of piping and mechanical changes Files of note: chrome/browser/chrome_content_browser_client.cc: connected policy pref to command line switch communicate ua ch disable to blink chrome/browser/ui/tab_helpers.cc chrome/browser/client_hints/client_hints_factory.cc: Added calls to |g_browser_process| to get policy prefs for clienthints constructor components/client_hints/browser/client_hints.h: added PrefServices to constructors weblayer*: superficial piping of PrefServices. They aren't actually doing anything apparently basically everything else is either boilerplate to get the enterprise policy/pref running or plumbing for the changes to the client hint delegate constructor Bug: 1097951 Change-Id: I907d9370c8378d0faaa2274864e94d53231e58c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248426 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781680}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62a2f51304f9..1496de215a39 2020-06-23 bpastene@chromium.org Remove implied CIPD packages from scripts/trigger.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:812428 Tbr: cwallez@google.com Change-Id: I932aa672b039a3bac7193351d0df19fbda5c3344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261069Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL relands crrev.com/c/2248729 that got reverted due to breaking Mac Builder (dbg) and others (power_monitor_device_source_unittest.cc did not include logging.h and it couldn't find 'DVLOG'). The original CL description only said "wip wip" o_O, which is sad. Essentially this CL adds a GetCurrentThermalState() to PowerMonitor to actively retrieve the current ThermalState. The ThermalState is sent to PowerObservers, but newly created clients still need to query it at least one time. TBR=fdoray@chromium.org since the diff is just an include file. Bug: 1071431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781322} Change-Id: Ia62ddfd8afc167473f3456e4982f51eaa52a833f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261363Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781678}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I28e473b62c3ad616abfd50993a491403a8558503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262252Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4ba1acf94b8c50c98094ddd46a1686768462baeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261796Reviewed-by:
-
Melissa Zhang authored
This CL adds the skeleton for the SharesheetService as a KeyedService with an adjoining SharesheetServiceFactory and ShareActionCache. BUG=1097623 Change-Id: I60d34f1f746117d2e430881eeb90f8ea7c3f64f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253261 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781675}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24762f207fa1..09f635e5871b 2020-06-23 danilchap@webrtc.org Delete RtpHeaderExtensionMap::Register deprecated long time ago If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe7a3107b03a4135918000e89491f4ec49220449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261070Reviewed-by:
-
Melissa Zhang authored
This CL adds a feature flag for enabling the sharesheet on desktop platforms. Bug: 1097623 Change-Id: I5a99db0ed041b3669046a900ad3bedfbbb3f57fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256941Reviewed-by:
-
Becca Hughes authored
BUG=1098391 Change-Id: If93a673b5eba6c297121bed5ddf2849b23290558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261183 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#781672}
-
Bettina authored
Previously blacklisted extensions were not updated, however disabled remotely extensions need to be able to updated as they're not part of the blacklist. Bug: 1098540 Change-Id: I735fbf8e334956b987598deecd1c1856e03123e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261110 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781671}
-
Peng Huang authored
Remove the CHECK(root_canvas_) in BindFramebufferToOutputSurfac() which causes crashes. However we cannot figure out why root_canvas_ is nullptr for those crashes. We just handle nullptr root_canvas_, and MarkContextLost() if some error happens later on the gpu thread. Bug: 1092911 Change-Id: I4a0f456aa96b4c5a61e19300effbe6e789a53a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261400 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#781670}
-
John Palmer authored
Bug: 1060433 Change-Id: I1dcf90e891633c50e8cfbbd0f80a8377491bb5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262152 Commit-Queue: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
-
Kent Tamura authored
- Do not use NGLineHeightMetrics The return value is unrelated to ascent/descent. - Do not use a single field for two difference purpose; overflow and space - Rename variables named |*_block_start/end| to |*_over/under| in ComputeAnnotationOverflow(). All variables representing offsets are in line-relative coordination system. |*_block_start/end| are confusing. This CL has no behavior changes. Bug: 1069817 Change-Id: Ida0f3abdb462fa0b35d4b0a9a299a1e1c1e5c442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260478 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#781668}
-
Cheng Zhao authored
The window of menu should have the WS_EX_TOOLWINDOW style, otherwise when showing tray context menu on Windows, its window would show in taskbar. Bug: 1094772 Change-Id: If822315b6b8d7322b919fb1c5e550c96cbbdb823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245941Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781667}
-
Jimmy Gong authored
- Updated icons to match specs Before: https://screenshot.googleplex.com/G3RvHUiZvvm After: https://screenshot.googleplex.com/QUKrXgmryLi Bug: 1053704 Change-Id: Ib56d41ae853b724394801f8db3405f6c995d2bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259474 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
-
Dale Curtis authored
Once we have a valid video frame back from the decoder, we assume the decoder is good and toss the encoded data we hold onto for fallback. It's unclear to me how the current tests have ever worked. Since we only fire canplaythrough after 4 frames have been decoded. The fix for this is to ensure we don't decode any frames before triggering the gpu crash. This is fine for the purpose of this test which is for testing the rendering and not decoding. R=kbr Bug: 1082761 Change-Id: I7e798ff219ded36582b1576919b6e5bf9541f5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258772 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781665}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49e6f89bf28a..42297a7669fc 2020-06-23 jalyn@microsoft.com Reveal which shortcuts are provided by preset 2020-06-23 mamir@chromium.org [Autofill] Remove unnecessary keypress in a test in Test.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1030649,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd7177cc54aadbd47b92be16857197628abb02fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261489Reviewed-by:
-
Bruce Dawson authored
This reverts commit ed0697fc. Reason for revert: crrev.com/c/2255126 fixes the midl.py failures on Windows 7 class OSes and crrev.com/c/2260933 rolls in a native_client change that stops preprocessing .S files with cl.exe. With those changes cl.exe is not used in the build on Windows 7 anymore and that should let this toolchain land. This change now locks the SDK version to 10.0.19041.0 for users who don't use a packaged toolchain which ensures consistency and should simplify future toolchain upgrades. This change was tested with the lock as shown and with a lock to a previous SDK version. Original change's description: > Revert "Reland "New toolchain for Windows 10 19041 SDK"" > > This reverts commit 424526a0. > > Reason for revert: win64-chrome build succeeded (progress) but > win32-chrome builder failed with a previously unseen error, shown > here: > > [170/58214] ACTION //remoting/host/win:remoting_lib_idl_idl_action(//build/toolchain/win:win_clang_x86) > FAILED: gen/remoting/host/win/chromoting_lib.h gen/remoting/host/win/chromoting_lib.dlldata.c gen/remoting/host/win/chromoting_lib_i.c gen/remoting/host/win/chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.tlb > c:\b\s\w\ir\cipd_bin_packages\cpython\bin\python.exe ../../build/toolchain/win/midl.py environment.x86 c:/b/s/w/ir/cache/builder/src/third_party/win_build_output/midl/remoting/host/win gen/remoting/host/win 7219b935-4873-533b-9ce1-20c9e9b12def chromoting_lib.tlb chromoting_lib.h chromoting_lib.dlldata.c chromoting_lib_i.c chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.idl /char signed /env win32 /Oicf > cl : Command line error D8027 : cannot execute 'c:\b\s\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\bin\..\..\VC\Tools\MSVC\14.26.28801\bin\HostX64\x86\c1.dll' > midl : command line error MIDL1003 : error returned by the C preprocessor (2) > > Original change's description: > > Reland "New toolchain for Windows 10 19041 SDK" > > > > This is a reland of 4a4f53a7 > > > > The original patch would fail to build on the mksnapshot step on > > Windows 7 (and server equivalents). This was due to two APISet DLLs > > that are required for the new dbghelp.dll. This change copies the two > > of them during gn gen. In order to have them as part of the isolates > > for cdb and in order to avoid dangerous ambiguity they are now > > required, which means that when this change lands the new SDK will be > > required. This is slightly disruptive for developers who aren't using > > our toolchain, but it seems unavoidable. > > > > Developers who don't have the latest SDK installed will hit this error > > message during gn gen: > > > > Exception: api-ms-win-downlevel-kernel32-l2-1-0.dll not found in "..." > > You must install the "Debugging Tools for Windows" feature from the > > Windows 10 SDK, the 10.0.19041.0 version. > > > > Original change's description: > > > New toolchain for Windows 10 19041 SDK > > > > > > This change updates the toolchain package used to build Chromium with > > > the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll > > > DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as > > > usual). > > > > > > The Debuggers directory was not swapped out this time because the > > > problem with loading dbghelp.dll on Windows 7 > > > (https://crbug.com/1021650) has been resolved. > > > > > > The output for the cdb copy step was updated because one additional UCRT > > > DLL is now copied. > > > > > > Packaging was done on a Windows Server 2019 VM, cleanly created for this > > > purpose. > > > > > > The package was created by downloading the VS Professional 2019 > > > installer from https://visualstudio.microsoft.com/downloads/ > > > (free trial, not preview) and then running the installer like this: > > > > > > $ PATH_TO_INSTALLER.EXE ^ > > > --add Microsoft.VisualStudio.Workload.NativeDesktop ^ > > > --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ > > > --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ > > > --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ > > > --includeRecommended --passive > > > > > > Then the latest Windows 10 SDK was downloaded and installed from > > > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ > > > > > > Then the packaging script was run like this: > > > > > > python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 > > > > > > Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid > > > shipping that (https://crbug.com/920704) the final packaging step was to > > > unzip the package, copy over the two copies of that DLL from the > > > previous toolchain's win_sdk\Redist, and then repackage the toolchain > > > with: > > > > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> > > > > > > UWP and ARM64 support and Python 3 compatibility were previously added > > > to package_from_installed.py. > > > > > > Future changes will require the new SDK, but for now the previous SDK > > > can also be used to build Chromium. > > > > > > The failures on the win*msvc* bots are unrelated. This was proven by > > > creating crrev.com/c/2245914 which is a NOP toolchain test. The existing > > > toolchain was repackaged with a single text file added and that caused > > > identical failures. > > > > > > Bug: 920704, 1014701, 10216507, 1089996 > > > Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 > > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#778924} > > > > Bug: 920704, 1014701, 10216507, 1089996, 1095767 > > Change-Id: I75e7653d57964e2929106e41b3f50594d3969e5f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249394 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780431} > > TBR=dcheng@chromium.org,henrika@webrtc.org,thakis@chromium.org,brucedawson@chromium.org,henrika@chromium.org,jessemckenna@google.com,jmadill@chromium.org > > Change-Id: If00e3865e66d9071189b2aca28f7541ecbdc6486 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 920704, 1014701, 10216507, 1089996, 1095767 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255558 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780467} TBR=dcheng@chromium.org,henrika@webrtc.org,thakis@chromium.org,brucedawson@chromium.org,henrika@chromium.org,jessemckenna@google.com,jmadill@chromium.org Bug: 920704, 1014701, 10216507, 1089996, 1095767 Change-Id: I68e4c246ee903ba48d59b3bdea913ea3975c49d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255527Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#781663}
-
James Cook authored
This CL introduces AshChromeService, which is a set of APIs that lacros-chrome will call into. With this CL, Mojo connection between ash-chrome and lacros-chrome is now bidirectional. Bug: 1094106 Test: Ran locally. Change-Id: I169d55ad964073e8faebe069917a6a3a67ed5c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254638Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#781662}
-
Saho Kobayashi authored
send api::automation::EVENT_TYPE_ARIAATTRIBUTECHANGED when ui::AXEventGenerator::Event::DESCRIPTION_CHANGED is sent to send description changed event when state description is changed. DESCRIPTION_CHANGED is disabled in CL:1073926, because state changes were noisy, but it should be safe to send DESCRIPTION_CHANGED. Bug: b:154433831 Test: manual Change-Id: I34f540a443eb58ff2978bdc17491c3117826afbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255737Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Saho Kobayashi <sahok@chromium.org> Cr-Commit-Position: refs/heads/master@{#781661}
-
Nick Harper authored
Change-Id: I4b09aff4eb42b4682c24bc0fc7e325f619e6acd1 Bug: 1090838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261616 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#781660}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592935173-d1033b26c7b78c08aca84bf70b5b5eb9d34e3499.profdata to chrome-mac-master-1592956785-31e85dda22463f39949762c5e4ca2295e5fc2ed3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibbf97b304722240d3b4370023a571983c5241328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260902Reviewed-by:
-
Claudio M authored
The flag has been enabled by default since Sept 02 2017: https://chromium.googlesource.com/chromium/src/+/6ddc1c3486a8c1bf76b69268984bb05409a2fb31 Bug: NONE Change-Id: I9c5c1db1113df9369656881906f687888c3c95d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260093Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Claudio M <claudiomagni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781658}
-
Hiroki Sato authored
Current AXTreeSourceArcTest is large, and some of them tests only the serialization of some nodes and don't need to interact with AXTreeSourceArc. This CL adds AccessibilityNodeInfoDataWrapperTest and moves some unit tests from AXTreeSourceArcTest. AX-Relnotes: n/a. Bug: b:158141903 Test: AXTreeSourceArcTest, AccessibilityNodeInfoDataWrapperTest Change-Id: I7505078b2df463a99dcbe20fa62ce3ca1f0a391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241092 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibd49454470abb8d876abbff2a23a91781e2944c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261109Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5afeb6651bad..bdfbdd275b29 2020-06-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ieb3b3ea602767ee28f38e82473a384def5620bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261776Reviewed-by:
-
Peng Huang authored
The bug is because X11 will present hided Window at 1Hz. So if there are two windows on screen. One is hided, vkAcquireNextImageKHR() will be blocked for 1 second, so the GPU main thread will be blocked with it. Fix this problem by add PostSubBufferAsync(). It will call vkAcquireNextImageKHR() off the GPU main thread. Bug: 1097014 Change-Id: I2dc7988d5c6320d167b3280b3f92ac9979644887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256589 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Nate Fischer authored
This adds an architecture overview to public docs, based on the Android WebView 101 talk. Fixed: 1064147 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I7f01707f7ca57a92939df53f60bd6eca96470ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261427 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781653}
-
Anand K Mistry authored
In normal execution, there is a ping-pong between ServiceDeviceTask() and DevicePollTask(), posting each other onto their respective threads. There should only be one instance of this ping-pong at any given time. However, if there is a resolution change event, |device_poll_thread_| is stopped, but there could be a ServiceDeviceTask() task pending. In this case, when |device_poll_thread_| is started again at the end of FinishResolutionChange(), there is both a pending ServiceDeviceTask() and DevicePollTask() which will result in _two_ instances of the ping-pong existing. This may, depending on timing, increase by one on every resolution change event. To solve this, use a CancelableCallback to cancel any pending ServiceDeviceTask() when |device_poll_thread_| is stopped. BUG=b:140420307,b:148355507 Change-Id: I267625f93cd8a36a5a1f4ea0c99a7d7289151795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247435Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#781652}
-
Anastasia Helfinstein authored
Reduce lag of several seconds following actions such as resizing a window by only responding to the most recent AutomationEvent. AX-Relnotes: n/a. Bug: 1095232 Change-Id: Ib797fd27415f937a550b6edf5dd0371ea3859fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Donn Denman authored
Adds support for a new Contextual Search Resolve-request parameter to provide a list of fluent languages. The server can use these as additional hints from the Chrome Language Model for the user's preferred languages to translate into. BUG= 1084600, 1093833, 1095090 Change-Id: Ieece911ca84854effcd830f4d0d7ec64e088f700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261422 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#781650}
-
Chong Gu authored
Adds support for sharding of Fuchsia gpu integration tests. Filter flaky tests. Bug: 1058255 Change-Id: Ie935d20182733f68cffb61142a35b811a7654798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261161Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#781649}
-
