GitLab

This item is only shown when in fullscreen, and allows users to exit
fullscreen using the mouse (for users who don't have a keyboard
attached).

This is still not foolproof (as it won't work on a site that captures
the right-click menu) but should work in the majority of cases.

BUG=594868
TEST=https://permission.site. Click Fullscreen. Right-click background; should
     see "Exit full screen ... Esc".
TEST=F11 to go fullscreen. Right-click background; should see
     "Exit full screen ... F11".

Review-Url: https://codereview.chromium.org/2116973002
Cr-Commit-Position: refs/heads/master@{#404589}

We issue a fine-grained runtimeEnabled/runtimeDiabled notification.

Introduced a new setting forceMainWorldInitialization, which inspector
uses to force contexts in all frames to be able to evaluate there.

Moved scriptBlockedByCSP pause reason to DOMDebugger agent,
similar to scriptFirstStatement.

BUG=580337

Review-Url: https://codereview.chromium.org/2112593003
Cr-Commit-Position: refs/heads/master@{#404588}

BUG=598841
TEST=Not easily testable, as this CL removes code that is no longer
active after a first Quirks server check; we expect nearly all devices
should have made a server check as of M-54, if they're ever going to.

Review-Url: https://codereview.chromium.org/2006143011
Cr-Commit-Position: refs/heads/master@{#404587}

AddingNonStringRemovesCachedString was failing because it is now an error to
copy an empty UIImage to the pasteboard.

BUG=626686

Review-Url: https://codereview.chromium.org/2134853002
Cr-Commit-Position: refs/heads/master@{#404586}

No functional change, not flag-protected.

This CL lands server change 126437339 by dahollings.

BUG=488484

Review-Url: https://codereview.chromium.org/2130153002
Cr-Commit-Position: refs/heads/master@{#404585}

This patch trivially encapsulates Layout Tree Construction
code in its own function -> Element::buildOwnLayout().

No behaviour change is expected from this patch since it is
merely moving code around.

With lots of help from @bugsnash

Design doc: http://bit.ly/29MBWvf

BUG=595137

Review-Url: https://codereview.chromium.org/2118393002
Cr-Commit-Position: refs/heads/master@{#404584}

https://chromium.googlesource.com/skia.git/+log/48898561db7d..4c42eebc5551

$ git log 48898561d..4c42eebc5 --date=short --no-merges --format='%ad %ae %s'
2016-07-10 update-skps Update SKP version

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2136843002
Cr-Commit-Position: refs/heads/master@{#404583}

Revert of Simplify ppapi Graphics3D size propagation a bit (patchset #5 id:80001 of https://codereview.chromium.org/2136743002/ )

Reason for revert:
Build breakage on Win8 GYP.
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/507

FAILED: nacl64.exe nacl64.exe.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True nacl64.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:nacl64.exe @nacl64.exe.rsp" 1 mt.exe rc.exe "obj\chrome\chrome_nacl_win64.nacl64.exe.intermediate.manifest" obj\chrome\chrome_nacl_win64.nacl64.exe.generated.manifest ..\..\build\win\compatibility.manifest
ppapi_ipc_win64.lib(ppapi_ipc_win64.ppapi_messages.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl gfx::Size::Size(void)" (__imp_??0Size@gfx@@QEAA@XZ) referenced in function "public: __cdecl std::_Tuple_val<class gfx::Size>::_Tuple_val<class gfx::Size>(void)" (??0?$_Tuple_val@VSize@gfx@@@std@@QEAA@XZ)

nacl64.exe : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Simplify ppapi Graphics3D size propagation a bit
>
> - after https://codereview.chromium.org/2104403003/ we parse the attributes from
>   the plugin side, so we know the correct size from the start, and we don't need
>   to track the original size.
> - we can also pass gfx::Size through IPC with some extra validation (negative
>   coordinates) in common code.
> - overall net fewer lines
>
> BUG=None
>
> Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
> Cr-Commit-Position: refs/heads/master@{#404580}

TBR=erikchen@chromium.org,bbudge@chromium.org,dcheng@chromium.org,danakj@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2135063002
Cr-Commit-Position: refs/heads/master@{#404582}

Revert of QUIC - Race Cert Verification with host resolution if certs are (patchset #6 id:140001 of https://codereview.chromium.org/2120703003/ )

Reason for revert:
Net unit tests are failing on buildbot

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
> Cr-Commit-Position: refs/heads/master@{#404568}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2137843002
Cr-Commit-Position: refs/heads/master@{#404581}

- after https://codereview.chromium.org/2104403003/ we parse the attributes from
  the plugin side, so we know the correct size from the start, and we don't need
  to track the original size.
- we can also pass gfx::Size through IPC with some extra validation (negative
  coordinates) in common code.
- overall net fewer lines

BUG=None

Review-Url: https://codereview.chromium.org/2136743002
Cr-Commit-Position: refs/heads/master@{#404580}

This CL removes InterfacePtr::WaitForIncomingResponse definition
and replaces usage of them with either [Sync] call or
a nested MessageLoop waiting asynchronously.

BUG=622438

Review-Url: https://codereview.chromium.org/2096293002
Cr-Commit-Position: refs/heads/master@{#404579}

Cr-Commit-Position: refs/heads/master@{#404578}

https://chromium.googlesource.com/skia.git/+log/443023975e33..48898561db7d

$ git log 443023975..48898561d --date=short --no-merges --format='%ad %ae %s'
2016-07-09 pdr Update markdown docs to specify --local for the local devserver
2016-07-09 dvonbeck Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2135043002
Cr-Commit-Position: refs/heads/master@{#404577}

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions can be evicted before Runtime.enable was called due to excessive number of console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882

Review-Url: https://codereview.chromium.org/2116563003
Cr-Commit-Position: refs/heads/master@{#404576}

This CL adds a local EffectStack class similar to ClipManager, that keep track
of effect state and assign generated cc effect node to layers. This is only
used for layer list mode.

BUG=609937

Review-Url: https://codereview.chromium.org/2052763002
Cr-Commit-Position: refs/heads/master@{#404575}

BUG=none

Review-Url: https://codereview.chromium.org/2138483002
Cr-Commit-Position: refs/heads/master@{#404574}

There is a problem with clearing mask layers when the textures are reused.
Trying therefore to find a solution to hide the frame headers that does
not rely on masks.

BUG=624431

Review-Url: https://codereview.chromium.org/2129213003
Cr-Commit-Position: refs/heads/master@{#404573}

https://chromium.googlesource.com/skia.git/+log/e930459a18ea..443023975e33

$ git log e930459a1..443023975 --date=short --no-merges --format='%ad %ae %s'
2016-07-08 robertphillips Add choke point for modifying non-AA rect draws (e.g., applying clipping)
2016-07-08 robertphillips Revert of Add choke point for modifying non-AA rect draws (e.g., applying clipping) (patchset #6 id:100001 of https://codereview.chromium.org/2125333002/ )
2016-07-08 bungeman Corrected test for gcc/libc++ workaround.
2016-07-08 robertphillips Add choke point for modifying non-AA rect draws (e.g., applying clipping)
2016-07-08 bsalomon Use clipped bounds for reordering decisions GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002
2016-07-08 bsalomon Revert change of bounds computation in MSAA path renderer. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2133773002
2016-07-08 dvonbeck Fixed error when normal.z = 1 in GPUs with binary16 floats
2016-07-08 reed deferred canvas
2016-07-08 bsalomon Don't scissor draws overlapping the render target's edges GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135673002
2016-07-08 bsalomon Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds.
2016-07-08 mtklein Move sRGB <-> linear conversion components to their own files.
2016-07-08 rmistry Revert of Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader (patchset #11 id:200001 of https://codereview.chromium.org/2062703003/ )
2016-07-08 brianosman Use sRGB pixel config for ARGB masks (color emoji)
2016-07-08 bsalomon Reland of Better encapsulate oval/rrect batchs. (patchset #1 id:1 of https://codereview.chromium.org/2121313004/ )
2016-07-08 reed update path->rsxform to correctly interp dy
2016-07-08 bsalomon Promote the GCC/libc++/<memory> 'typedef float float32_t' workaround to SkTypes.h
2016-07-08 bsalomon Make all parameters reqiured to GrReducedClip::ReduceClipStack GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130903002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2132913005
Cr-Commit-Position: refs/heads/master@{#404572}

If value="" is specified on an image-type form control then use "" as the alt-text
for the control if one is required. This matches Firefox and Edge, also IE11.

BUG=625604

Review-Url: https://codereview.chromium.org/2127093004
Cr-Commit-Position: refs/heads/master@{#404571}

What works:
- search+s toggles on / off a DOM-based selection
- selection by character, word, line, object work across multiple nodes*
- announcement of what gets read via a clipboard hack
- ctrl+c is observed and reads out copy events in lue of an actual copy event in the DOM (we're at a disadvantage here)

*works currently for basic examples. The underlying "framework" fails in slightly more complex cases like a paragraph with a link in it or a line break. For example, a link followed by a static text fails when attempting to select the static text via index offsets. Likely a Blink issue.

BUG=513716
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2121413002
Cr-Commit-Position: refs/heads/master@{#404570}

BUG=626823

Review-Url: https://codereview.chromium.org/2133713003
Cr-Commit-Position: refs/heads/master@{#404569}

availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Review-Url: https://codereview.chromium.org/2120703003
Cr-Commit-Position: refs/heads/master@{#404568}

This makes so that the fetch URL sent to the browser process for
navigations with the start provisional load notification is already the
final, potentially HTTPS upgraded one. This caused some problems with
upcoming changes where the URL stored in the NavigationHandle differed
from the actual URL being navigated to. A new test is also added to confirm
the upgrade is executed as expected.

BUG=618659
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2109633002
Cr-Commit-Position: refs/heads/master@{#404567}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/243e3dfbc911..6cad5da3c39e

$ git log 243e3dfbc..6cad5da3c --date=short --no-merges --format='%ad %ae %s'

BUG=625363,531641,472699,623058,472699,625852

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2136803002
Cr-Commit-Position: refs/heads/master@{#404566}

BUG=625254

Review-Url: https://codereview.chromium.org/2132193002
Cr-Commit-Position: refs/heads/master@{#404565}

- line/column -> lineNumber/columnNumber
- lineNumber is 0-based
- ExceptionDetails is hidden
- fixed +/-1 error

R=dgozman@chromium.org
BUG=591496

Review-Url: https://codereview.chromium.org/2130203002
Cr-Commit-Position: refs/heads/master@{#404564}

Revert of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (patchset #3 id:60001 of https://codereview.chromium.org/2131863003/ )

Reason for revert:
ATI GPU bots became green, no matter this CL. ATI GPU bot might be in bad shape for some reasons.
So revert this redundant speculative fix.

Original issue's description:
> WebGL: use storage texture for DrawingBuffer only if CMAA is enabled.
>
> It's because Linux ATI bot fails
> WebglConformance.conformance_textures_misc_tex_image_webgl
> When finding the solution for ATI driver, rollback this patch.
>
> BUG=557848
> TEST=WebglConformance.conformance_textures_misc_tex_image_webgl
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/65f8f6c737278a80acee2bcd407d1fdc15426fa8
> Cr-Commit-Position: refs/heads/master@{#404514}

TBR=piman@chromium.org,kbr@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557848

Review-Url: https://codereview.chromium.org/2133253003
Cr-Commit-Position: refs/heads/master@{#404563}

Cr-Commit-Position: refs/heads/master@{#404562}

Cr-Commit-Position: refs/heads/master@{#404561}

gpuMemoryBufferId is no longer necessary.

BUG=

Review-Url: https://codereview.chromium.org/2132913004
Cr-Commit-Position: refs/heads/master@{#404560}

It doesn't need to exist as a separate observer with a single function. This
simplifies ShellDelegate.

Addresses a TODO from https://codereview.chromium.org/2118593002/

BUG=619636
TEST=ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2134833002
Cr-Commit-Position: refs/heads/master@{#404559}

The current monospace font chain for windows doesn't cover arabic
symbols. "Courier New" has all the needed characters, let's fallback
to it.

BUG=616020
R=alph

Review-Url: https://codereview.chromium.org/2135803002
Cr-Commit-Position: refs/heads/master@{#404558}

This is simpler because we don't need to parse and copy lists of attributes.
We now only parse them in the same process that creates them, avoiding potential security issues.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc
Review-Url: https://codereview.chromium.org/2104403003
Cr-Original-Commit-Position: refs/heads/master@{#404024}
Cr-Commit-Position: refs/heads/master@{#404557}

Moves all service manager connections in the content layer
(connections owned by instances of MojoShellConnection and
MojoChildConnection) to the IO thread in all process types.
Note that instances of MojoShellConnection and
MojoChildConnection may still be created and used on
any thread.

Additionally exposes a way for InterfaceRegistry and
InterfaceProvider to forward to/from other instances
so we can still have a corresponding instance of each
on whatever thread owns the Mojo[Shell/Child]Connection
object.

This simplifies interface registration and acquisition
on process hosts and ChildThreadImpls, and makes it possible
for a future CL to introduce IO-thread service registration
to avoid thread hops when binding incoming interface requests.

BUG=623398,612500

Committed: https://crrev.com/439768f0aaaea83ffb7ce6c3ba4438804582c383
Review-Url: https://codereview.chromium.org/2111353002
Cr-Original-Commit-Position: refs/heads/master@{#404228}
Cr-Commit-Position: refs/heads/master@{#404556}

Preparation for using OpenGL ES rendering component on Android. This CL
leaves a FrameLayout placeholder for the DesktopView and creates the
implementation specific DesktopView in runtime.

BUG=385924

Review-Url: https://codereview.chromium.org/2132883002
Cr-Commit-Position: refs/heads/master@{#404555}

BUG=601310,620091
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart

Review-Url: https://codereview.chromium.org/2131173003
Cr-Commit-Position: refs/heads/master@{#404554}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4da7838..74a8e95

BUG=625363
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2135793002
Cr-Commit-Position: refs/heads/master@{#404553}

Removed the early return under condition 'isBody()' from
LayoutObjectChildList::invalidatePaintOnRemoval() to ensure the
painting layer and body object are invalidated.

BTW fixed issues of DisplayItemClient aliveness checking which made
it not actually work for subsequences. (If we didn't have the issues,
we should have caught this bug through aliveness-checking.)

Still not sure if we could have more reduced test. For the test, removing
anything from the test would make the test not reproducing the bug. A
normal removal of <body> couldn't reproduce the bug because we will
invalidate the painting layer in other paths (e.g. layout triggered
invalidation, etc.).

BUG=626182

Review-Url: https://codereview.chromium.org/2133603002
Cr-Commit-Position: refs/heads/master@{#404552}

Add implementation and testing for the keyboard shortcuts subpage.
This includes adding a shortcut-input component to handle much of the
requisite logic.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2101933005
Cr-Commit-Position: refs/heads/master@{#404551}

This implements progress for loading TOS content for OptIn
workflow with error/retry support. Also fixes few UI bugs
in OptIn layout windows.

BUG=b/29419423
TEST=Manually on device. Emulate error conditions on different
     stages of OptIn workflow. OptIn is correctly recoverable
     in each case.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2137713002
Cr-Commit-Position: refs/heads/master@{#404550}