GitLab

Patch by Joel Stanley <joel@jms.id.au>

Review URL: http://codereview.chromium.org/197055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20882

Review URL: http://codereview.chromium.org/199053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25698 0039d316-1c4b-4281-b951-d872f2087c98

This is based on the logic in the Firefox code.
It passes existing tests and one new test.

TEST=covered by new unit test

Review URL: http://codereview.chromium.org/200052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25697 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that JSON[Reader|Writer] cannot handle periods in key
names(!). Because of this, an also to avoid leaking a sort of ForceTLS
browser history in the state file, we hash the domain names.

Also, this patch tries to implement the RFCs with respect to
canonicalising the names. Since IDN processing has already occured by
the time the name reaches us, there's only so much that we can do
however.

http://codereview.chromium.org/201033


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21165

Review URL: http://codereview.chromium.org/201047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25695 0039d316-1c4b-4281-b951-d872f2087c98

It was failing to generate $(OutDir)\obj\global_intermediate\installer_util_strings\installer_util_strings.*

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/196046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25694 0039d316-1c4b-4281-b951-d872f2087c98

Add #include <stdio.h> for fclose et al.
Without stdio.h, we got errors like:
In file included from /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:5:
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h: In destructor 'virtual PipeReader::~PipeReader()':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h:33: error: 'fclose' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc: In member function 'virtual std::string PipeReader::Read(uint32)':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:11: error: 'fopen' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:12: error: 'fgets' was not declared in this scope
scons: *** [/usr/local/google/home/ukai/chrome/src/sconsbuild/Debug/obj/chrome/browser/chromeos/pipe_reader.o] Error 1

Review URL: http://codereview.chromium.org/199046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19675

Review URL: http://codereview.chromium.org/193052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25692 0039d316-1c4b-4281-b951-d872f2087c98

TBR=levin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25691 0039d316-1c4b-4281-b951-d872f2087c98

Also remove std::vector<> from StackTrace to reduce heap usage during potential unstable execution.

TEST=none
BUG=http://crbug.com/20996
Review URL: http://codereview.chromium.org/201050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/14478

Review URL: http://codereview.chromium.org/196050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25684 0039d316-1c4b-4281-b951-d872f2087c98

Add beginDragWithFiles to EventSendingController. Also implement WebKitClientImpl::fileExists. With these, we're able to enable all drag-file related layout tests.

BUG=19884
TEST=none

Review URL: http://codereview.chromium.org/187015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25683 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/197049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20927
TEST=none

Review URL: http://codereview.chromium.org/192039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25679 0039d316-1c4b-4281-b951-d872f2087c98

No significant code change, just preparing to redo the parsing
code and thinking I needed test coverage.

(Since the parse can fail now, made the parse error out
rather than continuing when it's unable to parse some fields.
This will have more failure cases in the next version of this
code.)

Review URL: http://codereview.chromium.org/193046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25678 0039d316-1c4b-4281-b951-d872f2087c98

I didn't convert the page/app menu to use the new helper class in an effort to keep this patch small and reviewable.

BUG=19675
BUG=15889
TEST=fiddled with it for while, and ran it under valgrind

Review URL: http://codereview.chromium.org/200029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20413
TEST=none

Review URL: http://codereview.chromium.org/194047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21321

TEST=None

Review URL: http://codereview.chromium.org/197048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25673 0039d316-1c4b-4281-b951-d872f2087c98

It appears that Nvidia's libGL.so is overriding dlopen/dlsym with
versions that don't fully function. So far, all the users reporting
this have been running Gentoo, but it might just be that they have
up-to-date drivers. The report[1] suggests that all drivers >= 180
have this issue.

[1] http://www.nvnews.net/vbulletin/showthread.php?t=132259

BUG=16800
http://codereview.chromium.org/201055


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21295

TEST=None

Review URL: http://codereview.chromium.org/200044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25670 0039d316-1c4b-4281-b951-d872f2087c98

Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168.

BUG=4360
BUG=21228
BUG=18792
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/200048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25667 0039d316-1c4b-4281-b951-d872f2087c98

This makes some plugins happy.  As described in the file comments,
this approach is also used by nspluginwrapper.

Review URL: http://codereview.chromium.org/202012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25665 0039d316-1c4b-4281-b951-d872f2087c98

The rendering of repaint areas is still different from upstream due to differences in repaint logic.

R=jparent
TEST=none
BUG=8630

Review URL: http://codereview.chromium.org/196047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25663 0039d316-1c4b-4281-b951-d872f2087c98

Pretty-up the blocked popup view by sharing code from the status bubble. Blocked Popup view is now themed as well.
BUG=20815
TEST=popup blocking and status bubble still work.
Review URL: http://codereview.chromium.org/196043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run the FocusManager unit tests

Review URL: http://codereview.chromium.org/200020


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25660 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions).
BUG=12122

Review URL: http://codereview.chromium.org/199018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25659 0039d316-1c4b-4281-b951-d872f2087c98

- verify main object is a dictionary
- verify load key is present and points to a bool
- verify all key values are dictionaries
- verify all key values have (correct) delta/var keys
- verify all keys are in correct format (a/b/c/d)

BUG=18597
TEST=verify unit tests catches these errors
Review URL: http://codereview.chromium.org/194032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=gregoryd

Review URL: http://codereview.chromium.org/196045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium.org/195027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25654 0039d316-1c4b-4281-b951-d872f2087c98

the URL that I shouldn't have (it won't be needed at some point, but it
is now).

BUG=21198
TEST=Select a URL and drag to the tab strip. Make sure you get the
     drop target and you can drop the text to create a new tab. Do the
     same with www.google.com, you shouldn't get a drop target.

Review URL: http://codereview.chromium.org/202010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25653 0039d316-1c4b-4281-b951-d872f2087c98

Adjusting installer_util_strings to attempt to avoid incredibuild
mysterious failure.

BUG=None
TEST=None
TBR=gregoryd

Review URL: http://codereview.chromium.org/200046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25652 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/200031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25650 0039d316-1c4b-4281-b951-d872f2087c98

get deleted anyway by jam's pending media player plugin changes.

I also disabled the DefaultPluginParsingTest as it fails when we remove these stub functions. However
this is also getting deleted in jam's media player change.

TBR=amit, jam(FYI)

Review URL: http://codereview.chromium.org/201051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25648 0039d316-1c4b-4281-b951-d872f2087c98

IDR_THEME_TOOLBAR is a generated blank image of the bg[SELECTED] color,
which will be drawn by default on GtkWidgets. Uploading an image of
said color to the X server on each expose and then asking it to tile the
image across the widget is silly; stop doing it.

Also sets clip rectangles correctly in a few places where we were using GdkGC
instead of skia.

Review URL: http://codereview.chromium.org/196044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25647 0039d316-1c4b-4281-b951-d872f2087c98

* Complete the 'contextID' to 'hostID' renaming since that terminology is now used in webcore ResourceRequest.

This patch depends on a corresponding webkit change in the chromium port.https://bugs.webkit.org/show_bug.cgi?id=28960

Review URL: http://codereview.chromium.org/201026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25646 0039d316-1c4b-4281-b951-d872f2087c98

Fix a suppression and remove one that duplicates it.
Widen a suppression
Add a bunch of new suppressions.

BUG=11333,21137,21279,21280,20580,21286
TEST=More green on the Mac valgrind bots.

Review URL: http://codereview.chromium.org/197043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25645 0039d316-1c4b-4281-b951-d872f2087c98

* Uses the awesome ChromeUILocalizer infrastructure.
* Also solves the issue of hard coded prodcut names.

BUG=19160,19651,19176
TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome".

Review URL: http://codereview.chromium.org/199035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25644 0039d316-1c4b-4281-b951-d872f2087c98