- 05 Nov, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium c7c30cb6. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6dfe163a57288084c8b97d3f89c712fcc29a34ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899793Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712770}
-
Collin Baker authored
Change-Id: I9096e540245b7d6fcdcf225d4ea3017ce1e151b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900426 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bce667b745aa..09a9385121be git log bce667b745aa..09a9385121be --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org Revert "[Telemetry] Do not percent encode story names" Created with: gclient setdep -r src/third_party/catapult@09a9385121be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:981349 Change-Id: I180bb5f63ac360c91bd15927d831d70518181e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712768}
-
Jack Lynch authored
This CL disables tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1889351 Bug: 963183 Change-Id: I4f660dfad9a8e4e44d5200f61642174fba875bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894014 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712767}
-
Dale Curtis authored
A recent try where we incorrectly set negative delay in FakeAudioOutputStream revealed this. It's certainly possible that this is happening in production with OS provided streams under odd conditions, so clamp to zero in these cases. R=tguilbert Change-Id: I032bb721f339cdbe34ed513d3c40223aca66fb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899560 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#712766}
-
Jinsuk Kim authored
The reported exception comes from HistoryNavigationDelgateFactory trying to get BottomSheetController when the activity is already destroyed. This CL puts a guard against the access to the activity in a wrong state. Bug: 990987 Change-Id: I86e9ea0611dafd301eefcb07a3a6b1ade5792a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898161Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712765}
-
meacer authored
A whole-script confusable Cyrillic domain consists of entirely Cyrillic characters that look identical to Latin characters (e.g. xn--80ak6aa92e[.]com decodes to аррӏе[.]com where аррӏе is in fact '\x0430\x0440\x0440\x04cf\x0435'). A previous change allowed whole-script confusable Cyrillic characters on non-ASCII top level domains only. This means that xn--80ak6aa92e[.]com remains punycode (TLD is .com) but xn--80ak6aa92e[.]xn--p1ai is decoded as аррӏе[.]рф (TLD is Cyrillic). However, this also allows spoofs in other non-ASCII TLDs such as аррӏе[.]中国 so it's not a sufficient measure. This change further limits allowable whole-script confusable Cyrillic domains to Cyrillic TLDs (instead of non-ASCII) and a small list of additional TLDs containing a large number of Cyrillic domains (bg, by, kz, pyc, ru, su, ua, uz). The idea is that users familiar with Cyrillic are more likely to encounter these TLDs and notice any discrepancies in the displayed domain name. Bug: 968505 Change-Id: Ib7462c9776f3640a5f60e5c79ac1a0c5d7b2028c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881887 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712764}
-
Mitsuru Oshima authored
* Take rotation into account * Fix when display zoom is applised. The overscan is dp but w/o display zoom. To convert to DP in UI coordinates, it first have to be converted to pixel then divided by the scale factor. Bug: 1021292 Test: unittests + manual Change-Id: I82785b74013c82e9eb20a7714510e62a421337db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896374Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712763}
-
Mason Freed authored
The Web Components V0 APIs were deprecated in August, 2018, in [1], and are being removed in M80. For those enterprises that need additional time, this new policy will enable the features to be re-enabled through M84. After M84, the policy will be removed, and the features will be disabled. For overall context on this removal, including motivation and ways to test/upgrade, see [2]. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade Bug: 911943 Change-Id: Iddf4c8294f19831705bf145b6840400adcd4baed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888598Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#712762}
-
Tommy Steimel authored
This CL pulls most of the logic out of MediaToolbarButtonController and puts it into MediaNotificationService which lives as a profile-keyed service. This allows the media session tracking to be shared between windows, and makes the MediaToolbarButtonController make more sense. Bug: 1021369 Change-Id: I03f302cb8b80099df011fa04e47df389c2d5d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898278Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712761}
-
Devlin Cronin authored
Make CreateExtension use the semantic ExtensionBuilder to cut down on boilerplate. Bug: None Change-Id: I19fc5c74efc7f67145e9f14b445bdeb66ca933c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896390Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712760}
-
Michael Spang authored
Move the pixel to DIP conversion into root_window_bounds_transform. Also rename CreateInsetsAndScaleTransform to CreateInsetsTransform because UI scale in the transform is no longer supported. Moving the DIP conversion avoids flooring the bounds twice (during DIP conversion, and after rotation & insets). Bug: 1019015 Change-Id: Ia065b1f8f6892a193e7f545475e7c7ddbcd76f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899835Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712759}
-
Manas Verma authored
The attestation conveyance preference will be set by Payments Server, and will fallback to 'none' if field was empty. Bug: 949269 Change-Id: Ib531f6380882f495bbb098d37127d6a92b4b7ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895329Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#712758}
-
Sammie Quon authored
Test: manual, added test Change-Id: Id7b6cf15b0efcbfcf714f63146c99695956d4e0a Fixed: 1020343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898748Reviewed-by:
Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712757}
-
Ahmed Mehfooz authored
Correcting the x position calculation of the MessageCenterBubble to correctly align with the quick settings bubble. If shelf is left aligned we need to add the left inset of the quick settings bubble to the horizontal position. Otherwise we need to subtract the right inset of the quick settings bubble from the horizontal position. Bug: 1021632 Change-Id: I8d449d3c297858283f41bcc10163a0e15b2965b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900161Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712756}
-
Owen Min authored
The util function returns the extension status based on if it's installed, disabled, terminated, blocked by policy and request status. This function will be used by CWS extension detail page. Bug: 1006899 Change-Id: I365caad7d99bb693aa664846f3d3a64ce424526d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894100Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712755}
-
Theresa Wellington authored
AppMenu shouldn't have specific knowledge of individual items shown in the menu. This CL moves some logging to ChromeTabbedActivity (which already handles menu item clicks) and makes item long-click handling more generic by using a (condensed) title set on the MenuItem to determine the anchored toast text. BUG=966644 Change-Id: Ibd569ef23f835f601aa9b4edd663fa6c3a61716c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894753 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712754}
-
Peter Boström authored
Adds an GetIconColor method to ToolbarIconContainerView and a method to override it. The latter is used by WebAppFrameToolbarView to set the icon color. Before this the icon color was never set for the container hosted inside WebAppFrameToolbarView so the icon image was never loaded -> never visible. Bug: chromium:1006162 Change-Id: Ic3566461f1bd7319944060db766b91ac38adef87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900090 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712753}
-
Robert Sesek authored
Tbr: jennyz@chromium.org Bug: 903800 Change-Id: Ib5ce7df0e1173bb8010d39168255f18a07e8a8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895911 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712752}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c04d8e10c3c..ad04327df8c5 git log 4c04d8e10c3c..ad04327df8c5 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 honghaiz@webrtc.org Add equals and hashCode method for IceCandidate class. 2019-11-05 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-05 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-05 gustaf@webrtc.org AEC3: Multichannel suppressor 2019-11-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ce02641..4186f99f (710014:712562) 2019-11-05 peah@webrtc.org Reland "Correct AEC3 multichannel functionality activation" Created with: gclient setdep -r src/third_party/webrtc@ad04327df8c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4a8be586c8ff5835a56507ff55f0cfe84c8cff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712751}
-
Takumi Fujimoto authored
Add test cases for the fix in crrev.com/c/1894970. Also make stylistic changes to other test cases. Bug: 1019925 Change-Id: I4c23339a4433a6230ffc17c8772a5dc37f0c3766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896298Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#712750}
-
Chris Lu authored
This addition is needed now that Translate can revert its Infobar action (e.g. show original source language). Bug: 1014959 Change-Id: I0d9e5537a77c08c6cefb453cb2e5e24c4adeece0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897906 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#712749}
-
Eugene But authored
Bug: 786960 TBR: gambard@google.com Change-Id: I84917ddc8551783db2f028806cca4ee662966f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899563Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712748}
-
Steve Kobes authored
Bug: 984109 Change-Id: I34290d577d9a96218dfbf892f669572a2c1b1395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895389 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712747}
-
Jack Lynch authored
This CL disables a few web tests that will be broken by [1] and reenabled by [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1884528 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1811866 Change-Id: I1c6527959c13ec3951425b5c3fd24876c59bbc34 Bug: 963183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887737Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712746}
-
Joshua Pawlicki authored
TBR=msarda@chromium.org Bug: 1021209 Change-Id: I16d475a6b4aa70b891eccc6ba47fadc171078de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898201Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712745}
-
Eugene But authored
Bug: 1021649 TBR: gambard@google.com Change-Id: I05486e779332ab8b3c79fb5b96cbc3fd5c458e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900289Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712744}
-
Joshua Pawlicki authored
Bug: 1020650 Change-Id: I4baa0a0612afb24689854f7109a65b7772a64b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895165 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712743}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f6a2232b48c2..0e2a4d97fd4c git log f6a2232b48c2..0e2a4d97fd4c --date=short --no-merges --format='%ad %ae %s' 2019-11-05 vadimsh@chromium.org [lucicfg] Update from v1.11.4 to v1.11.5. 2019-11-05 danakj@chromium.org Allow the bot_update api to not fetch tags from the git server. Created with: gclient setdep -r src/third_party/depot_tools@0e2a4d97fd4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: I656cc67bd3bcc899f2e5fd9e5e65f1e47e9c0b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712742}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4abff70f..4306aa57 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I383667e47e4073a93f0a756c71eccee51dc8e3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899791Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712741}
-
Mark Yacoub authored
- The kernel expects a rotation bit set even when a flip is required. Set ROTATE_0 bit as well when flipping horizontally or vertically. - Remove old ROTATE defines and use values from libdrm. BUG=1015433 TEST=Krane gets overlay Change-Id: Ia473bc3dee915c0b0fe5f13d8333738d7a14b7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894156 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#712740}
-
Gordon Guan authored
Collect memory statistics specific to MADV_FREE Discardable Memory which are useful for gauging its performance. Bug: 1014513 Change-Id: I5fed1aec612ddc32ae9d2ba347283a55fc69f8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863753Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Gordon Guan <gordonguan@google.com> Cr-Commit-Position: refs/heads/master@{#712739}
-
Dominik Röttsches authored
After r708747 the additional metrics show that the ratio of empty scanning results is either 100% or 0%, not in between. Recording additional failure reasons is required to dig in on why results come back empty. Add a member to FamilyResults to record the failure reason for why meta data on an IDWriteFont could not be extracted. Then, in the FinalizeFontTable() method, summarize and find the most frequent failure reason on why font names and file paths could not be extracted, and report that to UMA as a sparse enum of Windows HResult values. Bug: 1009402 Change-Id: Id57d97ad2eb270720e659315a5d092115324b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879899Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#712738}
-
Stephen Chenney authored
Plumb the metrics from LayerTreeHost through to CompositorFrameReporter and friends. Note the metrics are not always available and we use zeros when that happens (e.g. in tests the use SingleThreadProxy). Even if non-null, sub components might be zero times if, for instance, layout is clean but paint is not. Based on work from behdadb@: https://chromium-review.googlesource.com/c/chromium/src/+/1850106 Bug: 989138 Change-Id: I2357664cb22f9c76a1cdd5173bacc518bfc5e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861021 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712737}
-
Olivier Li authored
Bug: 910288 Change-Id: I4e5c75dddce89f2413412601e113df0e735df20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894629 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712736}
-
Scott Violet authored
visibility:collapse is only supported for tables, so all of the visibility checks in this class should be removed. BUG=1015987 TEST=wpt/compat/webkit-box-clamp-visibility-change.html Change-Id: Ib68b03a7942d6cd78b13e3d0bb11ba1a8742cb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898398 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712735}
-
Dale Curtis authored
BUG=919789,1021627 TBR=waffles Change-Id: I890aa4c6573f16ad66a353083bae85449313e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899320Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712734}
-
Marc Treib authored
It's still useful, see e.g. crbug.com/1021537 Bug: 1021168 Change-Id: I4f870f93c65532277763fb5dab1eb3096f5ea680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899846 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#712733}
-
Takumi Fujimoto authored
This prevents SelectFileDialog::Listener methods implemented by MediaRouterFileDialog from getting called after it is destroyed. Bug: 907273 Change-Id: I5ec03d832f1062ff1c2259f765f397b7af4c90a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898404Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#712732}
-
Joshua Pawlicki authored
Bug: 429358 Change-Id: I8703b47bb3094f7918456685545b786d78f09ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900291 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712731}
-