- 20 Mar, 2020 40 commits
-
-
Tricia Crichton authored
Since version 55, wasThrown is no longer a value in a command response dictionary. This CL removes the code that checked wasThrown, and updates the unittests to use the new exceptionDetails label to test for exception notification. Bug: chromedriver:3399 Change-Id: I6de07192d32e9f7a2a86649388cfe397f7694065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111032Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752021}
-
Elly Fong-Jones authored
These now use BrowserWithTestWindowTest instead. The only wrinkle was that both of these suites need to set up and wait for the bookmark service to be ready. Bug: 39725 Change-Id: I45be03eeade25ac2a0b5b002e81f2f8a46ae0d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108962Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752020}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1062725 Change-Id: I255dc421733cd0938a34ff02b1154d49327a47d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110830Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#752019}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3bc20cd8816..ed744e295fb9 git log e3bc20cd8816..ed744e295fb9 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 szuend@chromium.org Typecheck sdk/TracingManager.js with TypeScript 2020-03-20 aerotwist@chromium.org [global] Remaps self.SDK.consoleModel 2020-03-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-20 tvanderlippe@chromium.org Write .clang-format when updating node_modules 2020-03-20 szuend@chromium.org Typecheck sdk/SDKModel.js using TypeScript 2020-03-20 tvanderlippe@chromium.org Typecheck bindings/LiveLocation.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@ed744e295fb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id924fc767b11d86230045038b853f27668b1c2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752018}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1060689 Change-Id: I4de10f756760d1cc19183c449aa23fb107e2c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112408 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Stephen McGruer authored
On Chromium CI these are occasionally spiking to 7s, causing timeouts. Bug: 1062667 Change-Id: Ib4d21732c74c14b83b492945314813eff0f8c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110523 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
This removes an update that got accidentally duplicated in https://chromium-review.googlesource.com/c/chromium/src/+/2014926/1..2 Change-Id: I2b5a92d083c4ca3bbe83dae60408549055384b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111317Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#752015}
-
Brian White authored
Bug: 1053139 Change-Id: Ie9cec438ebfcfe99d1068fec9c89a969e958dd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108801Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#752014}
-
Stephen Chenney authored
When a background image is positioned with respect to the bottom edge of the background positioning area it may be incorrectly snapped. This is most obvious for very narrow images intended to attach to the edge of the positioning area. Fix such cases by accounting for the existing snapping changes in the positioning area when computing the offset. Bug: 994096 Change-Id: I24f971082a35c4bc9b3e85632f51511cdbf86c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108342 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752013}
-
Peter Wen authored
This clarifies the intent of the previous _java_header_patterns as well as includes more targets that ultimately uses java_library_impl. Also makes use of filter_exclude for header generation. Bug: 1056299 Change-Id: Ia241a8c7256a567d2d41cbb0901d90cb0c05a29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110686 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752012}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0199a91..65a94404 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia236ea464304831e945d269983f4da1987459a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111576Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752011}
-
Dan Harrington authored
And forward updates to FeedStream surfaces. Bug: 1044139 Change-Id: I3fada9c5054b2cfa8c3d412bca8a655ac38a2501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107706 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#752010}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/464e9ff4f368..44baaea9783e git log 464e9ff4f368..44baaea9783e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 Richard.Townsend@arm.com fix: use x86 Python 3 binary where available Created with: gclient setdep -r src/third_party/depot_tools@44baaea9783e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I12013be12f833dd927ed4cf4b683f5f1950b5f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112470Reviewed-by:
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I32068d58638d7dfaf94f1112d622118b6bdfafaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107993 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752008}
-
Fredrik Söderqvist authored
An <svg> element can have both a 'mask' and a '-webkit-mask' property (both yielding a Mask paint property), so we need to (re)check the existence of the masker LayoutObject before creating the SVGMaskPainter. Bug: 1063166 Change-Id: I55ce2b22185275b4dd23aefa65316230d98d960b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111316Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752007}
-
Liquan (Max) Gu authored
Context: * WebPaymentIntentHelper#createPayIntent * WebPaymentIntentHelper#createIsReadyToPayIntent Change: * throws IllegalArgumentException for these inputs - null or empty packageName - null or empty activityName - null or empty id - null merchantName - null or empty schemelessOrigin - null or empty schemelessIframeOrigin - invalid certificateChain - invalid methodDataMap - null total - invalid modifiers * test all these above Bug: 1057488 Change-Id: I5affd2503551f3976287d3f83c07a126bc8a933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103863 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752006}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4432f93ff194..8d03f6fcf682 Created with: gclient setdep -r src-internal@8d03f6fcf682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibf94e53eb941fc7e4e2464aa6d06eabb9a259e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112404Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752005}
-
Mathias Bynens authored
DevTools front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112361 Bug: chromium:1056588 Change-Id: Id9b97397d114a1fe2fb57ca10d0aad3131a7ae44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111179 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#752004}
-
Sami Kyostila authored
Story filters are now required for pinpoint job configs as of https://chromium.googlesource.com/catapult.git/+/41a6191ed80e747e0924c4f9286597f84492b530 Change-Id: I5f3ec92bd6f335ff683dcd002cc90487fce0bfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112468 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752003}
-
Gauthier Ambard authored
The |_documentController| wasn't reset between two files, leading to an issue where it wasn't pointing to the correct file. Fixed: 1062392 Change-Id: I5c4214c793c0e4e10f2c16af189c899683ba95b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111092 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#752002}
-
Mario Sanchez Prada authored
Create a dedicated method in content::mojom::RenderAccessibility to perform hit testing over an accessibility object that expects a reply that might include the required information to perform another hit testing, if a child frame was found to exist at the especified point. By doing this we can remove the HandleAXChildFrameHitTestResult() method, previously added to content::mojom::RenderAccessibilityHost, and fix the current situation where a message from an untrusted renderer would be sent to the browser when a child frame is found, since now such information would be shared as a reply to the original HitTest() method invoked from the browser process. Bug: 1010831, 1060223 Change-Id: I5b60d8a5e4b9f7fb2fc658c4f9156d7721b38db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105217Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#752001}
-
Elly Fong-Jones authored
This change: 1) Moves the bulk of CocoaTest to a separate class, CocoaTestHelper, that can be held as a member 2) Removes CocoaTest::Init, which was misnamed and mostly unused, and replaces it with MarkCurrentWindowsAsInitial for the one use case that does need it 3) Removes a lot of testing macros from the CocoaTest header since they are either unused or only used in a single place 4) Also creates a //chrome CocoaTestHelper analog that bootstraps the Cocoa app bundle, for use in tests that need Cocoa but don't inherit from CocoaTest (eg because they inherit from another fixture) Bug: 39725 Change-Id: I463480fbdbe4942561269478dc2f396db8ea8fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107766Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752000}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I39b6c4c28ce1ee69f078b3875308b6ca486f749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110871Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751999}
-
Mikhail Khokhlov authored
Change-Id: Ia2333c6856de7e9bb8ff1ddd26fba3d0af62d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112358Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#751998}
-
Luciano Pacheco authored
Use requestAnimationFrame() to change the CSS to collapsed the search box to give the chance for the button to process the collapse at the click. Add a test so we don't regress on this again. Test: browser_tests --gtest_filter="*searchButtonToggles*" Bug: 1062148 Change-Id: I628fb0b22f0a0223d659743618e7077ff0a7007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112171 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751997}
-
Elly Fong-Jones authored
This change removes the last BubbleDelegate subclass in //chrome. Specifically: 1) ChooserBubbleUiViewDelegate is now a subclass of LocationBarBubbleDelegateView, so that it will close on cross-origin navigations and fullscreen transitions; this behavior was previously provided by ChromeBubbleManager 2) ChooserBubbleUi is now removed, along with all references to it The next steps in this refactor are: 1) Removing the now-dead ChromeBubbleManager and all references to it 2) Removing BubbleUi itself, since ChromeBubbleManager is the last reference to it Bug: 496955 Change-Id: I558cecf89dee6c1dce987a678e2f25805f6f1f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109972 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751996}
-
Mugdha Lakhani authored
A delegate interface PageInfoDelegate has been introduced to allow the embedder to customize PageInfo. ChromePageInfoDelegate is Chrome's implementation of it. There will be follow up work to clean up chrome dependencies from PageInfo, after which, PageInfo can be moved to components. Bug: 1052375 Change-Id: I9b2ac5811ede505171787f23120cc46927e90f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089710 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#751995}
-
Ben Joyce authored
This is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2064823 After it was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2079147 This was caused by needing a new .info file because of breakage on https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9669 . Apparently the uploaded .info file had an extra newline character. Bug: 1005891,1054152 Change-Id: Ibe273671811a7e772b4a6a5dbafcf5ec97c0b820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079436Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#751994}
-
Brian White authored
Also converted all other calls from macros to functions which is the recommended method for any histogram emitted more than 1 per second or so. Bug: 1053105 Change-Id: Id9af6e33098de961f5e8cebf334615a12a0602e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108802 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751993}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I1bc03528cd22546c780b61002c290f23028b89aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112511Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03867b5533b7..e3bc20cd8816 git log 03867b5533b7..e3bc20cd8816 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 tvanderlippe@chromium.org Typecheck workspace/ with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@e3bc20cd8816 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib8374b36058e90db87b36ccaf49fb3c3a1ace14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112405Reviewed-by:
-
Stephen McGruer authored
According to FlakePortal[0] and the legacy dashboard[1] this hasn't flaked since 2019/09/09. It seems worth attempting to renable it. [0]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBleHRlcm5hbC93cHQvY3NzL2Nzcy1tYXNraW5nL2NsaXAtcGF0aC9jbGlwLXBhdGgtaW5saW5lLTAwMS5odG1sDA [1]: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=external/wpt/css/css-masking/clip-path/clip-path-inline-001.html Bug: 1001936 Change-Id: I85bbf8ec315c708244d42f9793d598865ad196f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110218Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751990}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic6127a4255dbb7852234f90a28c102f537a60cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112403Reviewed-by:
-
Demetrios Papadopoulos authored
It was previously failing because it was asserting on the value of a cr-link-row's sublabel before it was actually updated in the prod code. Introducing a 'site-settings-list-labels-updated-for-testing' event to give a singal on the test code on when to assert fixes the issue. Bug: 1061249 Change-Id: Ia9c31229da79ac83acb38254ccee053b26f3ec1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111778 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751988}
-
Anatoliy Potapchuk authored
This reverts commit cf2d38fa. Reason for revert: let's have it in. Original change's description: > Revert "Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications"" > > This reverts commit 181c9ba9. > > Reason for revert: reland by mistake, will reland it together with the fix > > Original change's description: > > Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications" > > > > This reverts commit 812f314f. > > > > Reason for revert: culprit found > > > > Original change's description: > > > Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications" > > > > > > This reverts commit 2f2a33d5. > > > > > > Reason for revert: <INSERT REASONING HERE> > > > It looks like this CL breaks some test case > > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab > > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0 > > > > > > > > > Original change's description: > > > > [Ash] Simplify AccessibilityControllerImpl to remove duplications > > > > > > > > AccessibilityControllerImpl had a lot of duplications. Let's fix that. > > > > Also, now it controls fullscreen and docked magnifiers. Before that, > > > > we have to go AccessibilityDelegate and MagnificationManager to do > > > > this. > > > > > > > > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d > > > > Bug: 1051892 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688 > > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#751086} > > > > > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com > > > > > > Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1051892 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028 > > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#751181} > > > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org > > > > Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1051892 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545 > > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#751188} > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org > > Change-Id: I382410f4fabc53c4ae5045310b22b729d5ec6cc7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1051892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107546 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751189} TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org Change-Id: I3143d661b24e4995161cd358b0a778562b292539 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1051892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108544Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751987}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/02c1ddad..a0199a91 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica0b20de175c18f1d3e0608b2594ea5734bcfd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111574Reviewed-by:
-
Noel Gordon authored
I believe "gear-menu" becomes before "install_linux_package_dialog" so be consistent with alpha-ordering in this BUILD.gn file. I was about to put "focus_visibilty.js" in this file, until I realized I don't need that file anymore, but it would have been adjacent to the gear_menu rule, from which I noted this minor alpha-order-disorder. Tbr: alex, lucmult Bug: Consult a dictionary. Change-Id: I84404d9c20054634552f1b9ed03e866594e27652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111514Reviewed-by:
-
Mark Brand authored
This adds the standalone code for MojoLPM; it's not functional by itself but it is a dependency for the generated code. This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Change-Id: I71deba7182adc31acde2546b42808a959a87b8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109698Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#751984}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/005d0fff3b9c..835dde17a0c9 git log 005d0fff3b9c..835dde17a0c9 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 578730be..2a41e24b (751777:751948) Created with: gclient setdep -r src/third_party/webrtc@835dde17a0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib84096f51a79c6626942ac79d5aea4ae21c51085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112398Reviewed-by:
-
Stepan Khapugin authored
Instead of using deferred initialization, show the account selector when a scene becomes active. This means if there are multiple scenes, the user will always have to go through this dialog even if they switch to another window. Also completely get rid of AppNavigation, as it's not used anymore. Bug: 1045663 Change-Id: Idbbd19f1e188b033e39ce318def6b1338ad3ac6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107581 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
