- 22 Oct, 2020 40 commits
-
-
Ian Wells authored
JDK library desugaring isn't needed for cronet and breaks tests on Kitkat. Bug: 1140401 Change-Id: I1b4eb25a8cd2564d0fce13e9780656c094c743b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490940Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#820046}
-
Ian Wells authored
When enable_jdk_library_desugaring=true and incremental_install=true, a new dex file will appear in the APK containing classes related to JDK library desugaring (as currently happens for non-incremental builds). Note 1: Since Proguard shrinking doesn't apply to incremental installs, the added dex file will be its full 400 kB size. Note 2: The crash described in the bug doesn't occur if is_java_debug=true. Bug: 1141199 Change-Id: Ib223abf168f7690ff1a5dfed5647521d10a2b42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492666 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820045}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2e5b59565826..6b3c8d667a5f 2020-10-22 primiano@google.com Merge "UI: Make unknown file type error more graceful" 2020-10-22 treehugger-gerrit@google.com Merge "Correct load bias in symbolizer." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4ff3c90497b8a647471380a01629c32fca7d4914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820044}
-
Elly Fong-Jones authored
There are some extremely useful DCHECKs that placeholders are used, but they are behind NDEBUG right now, so the normal CQ bots (which build with release + DCHECK_ALWAYS_ON) do not run them, and instead bugs of this type are caught on the waterfall by debug bots. To avoid that, enable these DCHECKs on builds with DCHECK_ALWAYS_ON. Bug: None Change-Id: I87d2d73dda42e9ba4235bd2c80cd10bbb80e5c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492303Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820043}
-
Michael Hansen authored
This change shifts the responsibility for setting and restoring the Bluetooth advertising interval from FastInitiationManager to the new BluetoothAdvertisingIntervalClient. We lower the advertising interval whenever Nearby Connections advertising or Fast Init advertising are active, and restore it to the default when both are stopped. Bug: 1119970 Change-Id: Ic301707f77b0360b0f6bc7673262d59f32fe20ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462671 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#820042}
-
Jonathan Ross authored
This test is flaking on Android Nexus 5 bot. Low rate of failure, so marking as a retry until the root cause can be fixed. TEST=conformance/extensions/oes-texture-float-with-video.html Bug: 891456 Change-Id: I25a6d4805bc2f904b9801c04821690a140c3f6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491678Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#820041}
-
Shakti Sahu authored
This CL cleans up the media session observer logic for triggering video player UI and metrics update. Change-Id: Ib6dcb8173206f7c0f0a5d53ddfbb5bf17654b893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465093 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820040}
-
Peter Boström authored
Bug: 1141224 Change-Id: Id2ff6354f5f8f7e29c7e20f1b27ee7fb10989386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481833 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#820039}
-
Patrick Monette authored
This reverts commit 1bc384a5. Reason for revert: This CL produced enough crashes that it is no longer needed. Original change's description: > [PM] Change DCHECKs into DumpWithoutCrashing in SWContextAdapter > > The DCHECKs were added to generate crashes to help me solve a lifetime > issue with service worker controllees, but I underestimated how often > the issue happens and have had no crashes yet. > > Changing them to DumpWithoutCrashing will make it so that anyone on > canary will be able to hit them. > > This CL is meant to be reverted as soon as enough crashes are received > to debug the root issue. > > Bug: 1086944, 1088353 > Change-Id: I50904f30ba8d23a5e5661edf8f1cf4d341e6dfef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444370 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813227} TBR=fdoray@chromium.org,pmonette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1086944 Bug: 1088353 Change-Id: Ic2ca0f2ea13ebcfb5f08c1f6cff312ef89078fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492620Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#820038}
-
Wei Li authored
Previously, Builder only creates the View object in Build() call. So we can not use the raw pointer passed in through CopyAddressTo() during the building process. This CL changes to create the object early on inside the constructor so we can use the raw address during the building process. Bug: 1130078 Change-Id: I893a567262bb31b9090012c1a74e899311d33182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490556Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820037}
-
Alex Turner authored
base::Bind and base::Closure are deprecated and should be replaced with the more explicit base::Bind{Once,Repeating} and base::{Once,Repeating}Closure. Bug: 1140564 Change-Id: Ieccd1f263d452a574cb439ca17e093c0fc5a94ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487708Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820036}
-
Zentaro Kavanagh authored
Bug: 1129141 Test: manual Change-Id: I2701c24fc5da4f51bf03fe1edbe038038c2f4c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493360Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820035}
-
Liquan (Max) Gu authored
Context: WebContents#getNavigationController() can return null. PaymentHandlerMediator should null-check the getter's return before using it. Bug: 1137695 Change-Id: I9a78ebfd60666268ef48566e0d7437a59e198a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463713Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820034}
-
Allen Bauer authored
Bug: 772945 Change-Id: Ibbbca14f5182b8f80c056ece9a9a63e74682ae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493086 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820033}
-
Etienne Bergeron authored
This CL is splitting the notion of PlatformImplAvailable in two different concepts: 1) PlatformSupported Whether or not the platform is supported. This state will remain the same for the whole existence of the TTS platform. 2) PlatformInitialized Whether the platform is loaded and are ready to process queries. Typically, it means the library are loaded and the voices are ready. From the controller point of view, the TTS platform can be used when it is "TtsPlatformReady(...)". Otherwise, the warmup is still going on and queries should be queued. The TTS controller is modified to avoid calls to the TTS platform until the initialisation is completed. This CL is *NOT* modifying the initialisation behavior of any TTS implementations. Platform that support asynchronous loading will be migrated separately in following CLs. Bug: 1133813 Change-Id: I5e236fb7cf39843e92acc8a6c5ec4d7af73a8fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472608Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820032}
-
Peter Kotwicz authored
Running androidx-packager will make it easier and faster to fix teething issues. BUG=1064277 Change-Id: If834742566d305d676c8f1503cef92c6326c86e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492300Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#820031}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/d975e29d1e93..83e50af3e0bd 2020-10-22 jophba@chromium.org Add version field to generated TLS certificates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ie63faad6ce4eb704633f425d57acbf8c1acc67db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492562Reviewed-by:
-
Sophey Dong authored
Bug: 1135311 Change-Id: I967300591d383a21b9f3f40233422b763180ddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459403Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#820029}
-
Trent Begin authored
This flag will control which Connectivity Diagnostics app is used. Enabling the flag will use the new application using WebUI. This flag is disabled by default. Bug: chromium:1140611 Change-Id: Ia29bd43937b563faf22a1b1b3fa6013fa924f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490404 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820028}
-
Aaron Leventhal authored
TBR=dmazzoni@chromium.org Bug: None Change-Id: I28136d26959cb694c6ddab896e1aab89000b2f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491116Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820027}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/8f7c80347dc6..88d705dc85ff 2020-10-22 rharrison@chromium.org [inspector] Extract UBO information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I2b919c2f71fb2694e466455407c86a118a7270ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492860Reviewed-by:
-
Ryan Sturm authored
When search prefetch service encounters a fetch error (either net or non-200) the service will back off for 60 seconds (finch controllable). Bug: 1138641 Change-Id: I9ee868b54b63088755a07a99d242bcc02db5dc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491181 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#820025}
-
Stephen McGruer authored
Bug: None Change-Id: Id5171276a3680a25937fadda0ad7d83eac72e3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493281Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820024}
-
Chan Li authored
`rdb stream` has slowed down blink_web_tests significantly. Bug: 1141606 Change-Id: I1df8d833eba37fbb3561d6f1ca51e24fce1ea432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493480 Auto-Submit: Chan Li <chanli@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#820023}
-
Mohammad Refaat authored
the didDiscardSceneSessions callback can be called when the browser state is not yet created, or it can be called when the browsing data remover service is not available. Once the callback is received mark the sessions for a later time removal by saving them on a plist on disk. And at the app initialization after the browser state its keyed services are initialized. schedule the cleanup for these sessions. Bug: 1136761 Change-Id: Ia5190866d4af7a041f0e5507fb7a88ea0ace9901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490788 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#820022}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f15a598ab083..65674e4c2e56 2020-10-22 kjlubick@google.com [canvaskit] Compile in most gms for testing 2020-10-22 johnstiles@google.com Reland "Add pooling support on iOS." 2020-10-22 egdaniel@google.com Fix asserts for npot tiling in gl. 2020-10-22 johnstiles@google.com Reland "Create a basic IRNode pooling system." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ic65792c405865244830047554e6d4d195a496232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492571Reviewed-by:
-
Kyle Milka authored
c/a/j/...Tab.java no longer exists. MediaViewerUtils is no longer used by share/ code. ApiCompatibilityUtils can be used to check for multiwindow mode. Bug: 1022172 Change-Id: I977e8764d7137071b5767c15a5e999926ab24b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472261Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#820020}
-
Kramer Ge authored
This is a reland of afa62bad Original change's description: > Reland "[ozone/wayland] Use 4x4 opaque background and stack underlay correctly" > > This is a reland of aa21781d > Root-cause of previous issue was Gnome's interpretation of whether > buffer.release should be triggered for buffers preempted from subsurface > cache. > > Original change's description: > > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > > > Using a 4x4 sized opaque background will not regress performance in > > underlay cases because the root surface is still opaque. The background > > will be stretched out by wayland viewporter extension. > > > > This is 6/? CL for overlay forwarding using wl_subsurface. > > > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#810527} > > Change-Id: I7ecbc27a82598479f7131b5645dfe96136d227a1 > Bug: 1133195, 1063865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442137 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819226} Bug: 1133195 Bug: 1063865 Change-Id: I7549538b847e895930999221e864dc3242e2a98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491924Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#820019}
-
Jamie Walch authored
Change-Id: I612abe51acde87b374038db519b1e5048ffc337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492943Reviewed-by:
Joe Downing <joedow@google.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#820018}
-
Henrique Nakashima authored
This breaks some dependencies from classes outside .tabmodel to TabModelImpl. Bug: 1139081 Change-Id: Ifda5b205f2cbe1cbc5f6d1b62de57ed258361503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477534Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#820017}
-
Ken Rockot authored
We use base::RandUint64 to warm the urandom FD on POSIX, ensuring it's open by the time the zygote forks. This was broken by https://chromium-review.googlesource.com/c/chromium/src/+/2380673 which results in RandUint64 generally not opening urandom. To avoid the issue, this CL explicitly calls base::GetUrandomFD() instead of RandUint64 during pre-zygote init. This way, if RandBytes needs to fall back onto urandom in a sandboxed process, it won't fail. Fixed: 1141593 Change-Id: I36996fafea79170e7c3dddb219695e88b8213033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492942Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#820016}
-
Aleks Totic authored
Full table layout algorithm. Binary-Size: Makes a lot of previously unreachable code reachable. Bug: 958381 Change-Id: Ie5354f200376f612e2a6e6e518188fcf166b0666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397009 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#820015}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3065fbe8b1b6..c97292f87f01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC robertocn@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115604,chromium:1138523 Tbr: robertocn@google.com,mmentovai@google.com Change-Id: Id209d58a54d494dd8c1a403b988116be2bcff9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492569Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820014}
-
Robert Ogden authored
The build guard, USE_GOOGLE_API_KEYS, is only used in DRP and is defined in DRP's build file. The correct usage of the google_apis library is to just call it outright, and let it take care of all the defines itself, which it does well. Also adds a check in the browsertest that the api key is actually set. Bug: 1135213 Change-Id: I87ac2e19db2c2310def38b2128821e43aa61fcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491987 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#820013}
-
Sergey Ulanov authored
Sysmem now supports R8 and R8G8 image formats, so it can be used to R8 and R8G8 GpuMemoryBuffers Bug: 1141538 Change-Id: I790c6886d67f49c09f2e2c4a93db7a27450aa30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491995 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#820012}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5641e3c185a8..9c8da02650bc 2020-10-22 cnorthrop@google.com Revert "Tests: Add FIFA Mobile trace" 2020-10-22 syoussefi@chromium.org Vulkan: Validate SPIR-V transformer at link time 2020-10-22 xiaoxuan.liu@arm.com Fix end2end tests VertexAttribute* failure 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 970c132746b1 to 91ce213a1d88 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ibcd63dae3ab0e3cbf06da55b97e6e34d6635372d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492566Reviewed-by:
-
chrome://translate-internalsShakti Sahu authored
When country code is undefined to start with, the UI doesn't provide an option to override it. Fixed this bug in this CL. Bug: 1141204 Change-Id: I0c6d9db4126e54f78096f6e44cd3dbaca5677d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491320Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820010}
-
rbpotter authored
Bug: 1132403 Change-Id: I08c8433377f124b7537ab88fd0ceb9d7be858702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492642Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#820009}
-
Sebastien Lalancette authored
Bug: 1136043 Change-Id: I57223f70738dbe3510ba587bef501a6244848e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491619 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820008}
-
Eric Robinson authored
This CL splits the FrameData class into two more specific classes, FrameTreeData (which collects information about frame-level activities such as activation, along with performance information), and AggregateFrameData (which collects some additional aggregations we do for the entire page, along with performance information). By doing this, we are able to reduce the scope of what's both visible and stored by each class as well as remove some of the extraneous page-level data members from APLMO (such as non_ad_frame_data and ad_frame_data_by_visibility) and store them all under aggregate_frame_data_ instead to centralize where information is stored. While this simplifies the code overall, the end goal is to have two completely independent classes, and make calls to smaller subclasses that will aggregate the various types of data we need (network, cpu, and memory) rather than relying on inheritance. This CL is a first step in this, as it makes the split between the two classes in APLMO and simplifies the variables there. Follow-ups for this include: 1) Rename all enums so that they aren't held by the parent class. This is split apart because of the amount of code it touches. Likely these can just sit inside a namespace. 2) Add classes for the various types of measurement and convert member variables in both Aggregate and FrameTree to use them. 3) Remove the FrameTree class, add functionality to the subclasses. This should require only small amounts of duplicate code, as updating fields should be a function of the measurement classes. 3) Potentially merge main_frame_data_ into aggregate_frame_data_, adding members as necessary, as it's the one outlier in terms of requiring the use of FrameTreeData. Change-Id: Ib21d6285361507fc3c0ae7d0208d8f704950ccd5 Bug: 1136068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359560 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820007}
-
