GitLab

Part of reducing the differences between the AudioNode connect/disconnect
variants.

Bug: 856641
Change-Id: I51cab0acd1b6ae8463dedd3b02b30e3b80dabbc7
Reviewed-on: https://chromium-review.googlesource.com/1126411Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573424}

The current logic for reusing the zoom bubble for extensions
1) prevents an extension initiated zoom change from reusing the zoom
bubble even when the bubble is showing for a previous zoom change by the
same extension, and
2) attributes a user initiated zoom to an extension if the extension
recently initiated a zoom change.

The logic for reuse is now essentially, allow reuse if the attribution
hasn't changed.

Bug: 849704
Change-Id: Ia4935fa84e30ab263772500f7ca566c0f5fc29be
Reviewed-on: https://chromium-review.googlesource.com/1124945
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573423}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: If313108d6055ac2bf1eb0933abacaad3996c9724
Reviewed-on: https://chromium-review.googlesource.com/1127367Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#573422}

Following bot results are included.
7655 7656 7659 7664 7671 7680 7683 7687 7697

12 lines were removed and 10 lines were deflaked by consecutive
results since 7649.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I59805929c4f94d914f833f3386131a4c27464092
Reviewed-on: https://chromium-review.googlesource.com/1127905
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573421}

Change-Id: I461eccdec572979b00e076422a3589f6dbcff760
Reviewed-on: https://chromium-review.googlesource.com/1129840Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573420}

This new test fails when using enable-blink-gen-property trees.
This is the intersection of two newly launching features and may block
the second one, whichever that happens to be.

Bug=861824

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib632eaa5377a7a5040597e8837dfa99e06883da0
Reviewed-on: https://chromium-review.googlesource.com/1129396Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573419}

Add and remove a double separator with NOTIFICATION_CONTAINER.

Bug: 843761
Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d
Reviewed-on: https://chromium-review.googlesource.com/1121243
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573418}

Similar to the OS_POSIX && !OS_FUCHSIA sites that need cleaning up, we
have a few sites which still use OS_POSIX || OS_FUCHSIA incorrectly, in
this case the ProcessUtilTests concerned with kill() / signals.

Bug: 854721
Change-Id: Id7896b1ca3ff3da3db6e6444eabc49bf9218de4b
Reviewed-on: https://chromium-review.googlesource.com/1129632
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573417}

Because Mac sometimes does not send the tablet events when a stylus is
approaching the tablet, it just sends mouse events. We have to always
check the mouse events' subtype to decide if it is a stylus input or a
mouse input.

Bug: 854354
Change-Id: Ibda91bf7c0970778b486ee4e0d7cb14650e18952
Reviewed-on: https://chromium-review.googlesource.com/1124984Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573416}

Using wpt-import in Chromium 7b9a39fe.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21128

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
mkwst@chromium.org:
  external/wpt/mixed-content
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-method-basic-card
  external/wpt/payment-request

TBR=kereliuk

No-Export: true
Change-Id: Ibcc9ba57d01f2ef4bc11e36f6d92eff08c22855f
Reviewed-on: https://chromium-review.googlesource.com/1129371
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573415}

This fixes some tests that depended on the correct value here when reading out
the margins via getComputedStyle().

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1f836ea8dc1243f1f2a1b36e69ba8d397417e3a2
Reviewed-on: https://chromium-review.googlesource.com/1127893
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573414}

Previously the threshold we were using to create/destroy scrim is the
same with the threshold to show indicators and scale down the source
window, this might cause a problem when dragging the dragged window back
toward to the top of the screen: the dragged window might be merged back
to the source window during the animation of the source window bounds
change, which then cause a flashness during dragging.

See before https://drive.google.com/open?id=1KETJtvc8GgQfZ7KhskqSaamoe5v8fz_m
and after https://drive.google.com/open?id=1_BeuzPtLPg8qNb1apJlaW2yDvZop5phZ

Bug: 823769
Change-Id: I349a1902543f0d334ebf8e8631dc1bdf31d5e396
Reviewed-on: https://chromium-review.googlesource.com/1119371
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima OOO (7/3 - 7/9) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573413}

The favicon img already returns an icon background, so we only need to render the background if the img fails to load. This will be the gray fallback monogram instead of the default missing favicon image.

Screenshot: https://screenshot.googleplex.com/a7PLVx5dahf.png

Bug: 859376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8dd376d435059803f7f8cd1bc64a4b3242f50027
Reviewed-on: https://chromium-review.googlesource.com/1123171
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573412}

BUG=861810

Change-Id: I26ddbc6dde99e3c26407e4fedfe379833c2ecd73
Reviewed-on: https://chromium-review.googlesource.com/1129389Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573411}

https://android.googlesource.com/platform/external/perfetto.git/+log/68eaa07bdfa0..916c76140064


git log 68eaa07bdfa0..916c76140064 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 hjd@google.com perfetto-ui: Add state holder
2018-07-09 hjd@google.com perfetto-ui: Fix copyright headers
2018-07-09 hjd@google.com perfetto-ui: Allow PascalCase component names


Created with:
  gclient setdep -r src/third_party/perfetto@916c76140064

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:111101304
TBR=perfetto-bugs@google.com

Change-Id: I35f1be9b54fd487b4962c11ca418b4ea11de679d
Reviewed-on: https://chromium-review.googlesource.com/1129379
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573410}

This CL includes the implementation class for the abstract class
HashUtils defined in the Nearby library. It implements a string-based
interface for MD5 and SHA-256 hashing.

Because the actual Nearby library has yet to be merged into the CrOS
directory, this CL includes stand-in Nearby abstract classes under
the temporary directory //chromeos/components/nearby/library.
This directory will be removed after the Nearby library gets imported
to //third_party (in-progress CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1113198).

Bug: 861813
Change-Id: I41dc7d74d5913ae8168041c82d3cacf70628ce19
Reviewed-on: https://chromium-review.googlesource.com/1119492
Commit-Queue: Kyle Qian <kyleqian@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573409}

OopAsh mode (enabled with --enable-features=OopAsh) on CrOS was
crashing at start because the Ozone/Drm DRM and cursor services
were not accessible to the Ash/WS2 host. In this change, the WS2
service is extended to add and bind these interfaces.

Tested by hand by running on device (chell):

	sudo -u chronos ./chrome  --enable-features=OopAsh \
		--user-data-dir=/home/chronos --homedir=/ --login-manager

BUG=850168
TBR=tsepez@chromium.org

Change-Id: I9b6a195f1f5fcce64174eb8e851561c70861dc81
Reviewed-on: https://chromium-review.googlesource.com/1121830
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573408}

Updated the privacy document (approved by msramek: https://docs.google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?usp=sharing)


Bug: 775644
Change-Id: If9e16711af2d27a7209366a61883997e865c9b50
Reviewed-on: https://chromium-review.googlesource.com/1126332Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573407}

This is a reland of db409e20

Original change's description:
> Truncate string attributes in the accessibility tree
> 
> Adds the helper function
> BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string
> attributes when Blink's tree is serialized for accessibility. String
> attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength
> bytes, currently set to 10000 bytes.
> 
> Bug: 644805
> Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b
> Reviewed-on: https://chromium-review.googlesource.com/1113946
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570818}

Bug: 644805
Change-Id: If084733234602882bbd37fc1891e49011b12ada8
Reviewed-on: https://chromium-review.googlesource.com/1129399Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573406}

These flags are old and no longer needed, so should be removed.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5

TBR=jam@chromium.org

Change-Id: Iad382b68937e084358f6d2bc9417a25aa1ecbfc5
Reviewed-on: https://chromium-review.googlesource.com/1128247Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573405}

Previously firing a notification only worked when an AccessibleNode
had an element. Add a quick fix to ensure it works even when it
doesn't.

Bug: 761901
Change-Id: I0ec6723e748947d94f1207f72f38ec94f0f6b335
Reviewed-on: https://chromium-review.googlesource.com/962862
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573404}

crypto::HKDF was originally written for QUIC and has QUIC-specific
assumptions in it, and hence it's moved into the QUIC codebase.

The new API is just a thin wrapper around BoringSSL's HKDF
implementation.  I intend to do the same to crypto::HKDF itself, but for
now it's parked in QUIC platform impl directory.

Change-Id: Ie60072dab4570bc840d9e6aaa5b1fef72fb387a2
Reviewed-on: https://chromium-review.googlesource.com/1122698
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573403}

When selecting the Leave option in the Leave Incognito Mode dialog that
launches an intent to the Play Store, Chrome crashes if the store is
disabled/uninstalled.

This fix checks whether the intent can be handled before showing the
dialog, and just avoids showing the dialog if not. It also removes the
need to check for ActivityNotFoundExceptions, and instead performs this
check first.

Tests are added to test behaviour with the Play Store installed and
uninstalled.

Bug: 820709
Change-Id: Ic6fec319887f77368262e825a95c419c1644b81b
Reviewed-on: https://chromium-review.googlesource.com/1113900Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573402}

Reminders is classified a web deep link, so it automatically will
open in the AssistantWebView (though we are only providing
placeholder content for the time being).

Onboarding will be wired up in a follow up CL.

This CL:
- Adds IsAssistantOnboardingDeepLink API.
- Adds IsAssistantRemindersDeepLink API.
- Adds ParseDeepLinkParams API. Some deep links, like onboarding, will
  have parameters and so I've added a method to parse parameters from
  a provided deep link and to return them in a provided map.
- Adds unit tests.

Bug: b:110986528
Change-Id: Ic17c625bd4b6869a256e1df09b4740fd2b6f1ee0
Reviewed-on: https://chromium-review.googlesource.com/1121581Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#573401}

This is the first step towards implementing a contact picker for
Chrome for Android, broken down into multiple steps for easier
reviewing.

First part includes simply showing a toast with the message
"Not implemented" when text/json+contacts is supplied as an
accepted file type.

Includes a Finch tie-in and a flag to turn this on manully
("Enable new contacts picker" in chrome://flags.

Bug: 860467
Change-Id: Ibbb2a3da6b5d60702bf833129bfbdebd38d03803
Reviewed-on: https://chromium-review.googlesource.com/1127023
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573400}

Bug: 861600
Change-Id: I8d78eacceae4d11ab3b5759a479915f79470072c
Reviewed-on: https://chromium-review.googlesource.com/1129470
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573399}

Change .4 to .5

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0adb555b7c75ccb2d05a04fc517cb952ae2b05c4
Reviewed-on: https://chromium-review.googlesource.com/1118856
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573398}

Network panel currently "translates" wheel events into
"set the new scrollTop" for its viewported scrolling.

This CL makes wheel events translate into smooth scrolls.
If all wheel ticks were smooth with scrollBy, consecutive
ticks would cancel each other out, so a burst of wheel
events will revert to instant jumping.

Screenshot: https://imgur.com/a/UB31WZs

Bug: 786796
Change-Id: If440e711369b8f35398004a2cfdd18e8c5e1ef87
Reviewed-on: https://chromium-review.googlesource.com/1112668Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573397}

Bug: 773382
Change-Id: I6cf4d2fc30efdd8f00d67badc1cb8233aab05f46
Reviewed-on: https://chromium-review.googlesource.com/1127353
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573396}

When a RenderWidgetHostViewBase doesn't have a valid InputTargetClient
in rare cases on Mac, fallback to early return itself as the target.

Bug: 859492
Change-Id: If473238b947ab2d13512c3ae8d5a818da71584dc
Reviewed-on: https://chromium-review.googlesource.com/1127358
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573395}

Mock:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHiVGjUR16sLc0S1m6c9nL_wMSJbxAVNpw

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10151db7eb9dc586af5987815e31abd72c8aa309
Reviewed-on: https://chromium-review.googlesource.com/1106804
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573394}

When a bad input is created the target indices can point far out of
bounds. Based on the fuzzing this should be promoted to a runtime
LOG(ERROR). Once we have a method to fail a write gracefully this
should be updated to fail the write step.

Bug: 860857
Change-Id: Ie8e4eaf9a655a71e0a2bf3efe2efae52574813db
Reviewed-on: https://chromium-review.googlesource.com/1128813
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573393}

This reverts commit 7521decc.

Reason for revert: Caused failures on fast/history/history-back-initial-vs-final-url.html (and possibly other tests, see https://crbug.com/861808)

Original change's description:
> Transmit the response's body datapipe in CommitNavigation().
> 
> # Summary of the current behavior:
> 
> When a navigation occurs, the mojo::URLLoaderClient interface is first
> bound to the content::NavigationURLLoaderImpl in the browser process.
> When the browser knows in which renderer process the navigation will
> commit, the interface is bound to the content::URLLoaderClientImpl in
> the renderer process to continue the navigation. The switching from one
> to another happens when mojo::URLLoaderClient::OnReceiveResponse() is
> called. This is described here: https://goo.gl/Rrrc7n
> 
> # What are we trying to do:
> 
> After the mojo::URLLoaderClient interface is unbound in the browser
> process and bound again in the renderer process, it takes some amount of
> time to receive URLLoader::OnStartLoadingResponseBody(). It may be worth
> sending the data pipe with RenderFrameHostImpl::CommitNavigation() and
> give it to the renderer process immediatly instead of waiting for it. It
> would allow the Renderer process to get the main resource's data
> earlier, especially when the renderer process is busy.
> 
> Note: It doesn't look like there are any strong reasons to make
>       URLLoaderClient::OnReceiveResponse(response_head) and
>       URLLoaderClient::OnStartLoadingResponseBody(response_body)
>       separate messages, maybe at some point, they could be merged into:
>       URLLoaderClient::OnReceiveResponse(response_head, response_body)
> 
> # What this CL does:
> 
> This CL makes the switch to happen in
> URLLoaderClient::OnStartLoadingResponseBody(). The data pipe is
> transmitted in CommitNavigation().
> 
> This is enabled/disabled using the NavigationImmediateResponse experiment
> The goal is to look for performance improvement or regressions on
> Canary.
> 
> Bug: 831155
> Change-Id: Id6cf667fdc1482baf27f41aab754e58d9a5a569b
> Reviewed-on: https://chromium-review.googlesource.com/1100830
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573276}

TBR=pkasting@chromium.org,kinuko@chromium.org,nasko@chromium.org,yhirano@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org

Change-Id: I22eac2d660f9cf1d8128331b547c304af729a85a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831155
Reviewed-on: https://chromium-review.googlesource.com/1129659Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573392}

TBR=jkarlin@chromium.org

Bug: 721512
Change-Id: Ia9d793aae153328d6ec7602f056017a3a6a93928
Reviewed-on: https://chromium-review.googlesource.com/1129325
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573391}

The (rva_lo_bits & 0xFFF) == rva_lo_bits DCHECK fails when the input
data is invalid. This occurs if the RelocHeader contains |rva_hi_bits|
which are mismatched from the |target_rva| for a given |ref|. This
results in |rva_lo_bits| which are invalid. Until Zucchini is
refactored to support failing to write gracefully we will just print
a loud error and skip the RVA.

This only fails in situations where the input is bad so shouldn't
occur in normal use.

Bug: 860857
Change-Id: I0472286fc54786be26b95f65e6bd18a587bc0c8b
Reviewed-on: https://chromium-review.googlesource.com/1128812
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573390}

- Change the owner of histograms to a current team member if the current
  owner has moved on to another team
- Make MediaRouter.Ui.FirstAction and MediaRouter.Route.CreationOutcome
  use enum= instead of units= so that the enums are actually used

Change-Id: I241848a8a955080673b9a9d144092cc0abf2e5fe
Reviewed-on: https://chromium-review.googlesource.com/1128208Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573389}

Change-Id: I4d0a224d4a256a96a6b8fdfa798f0b9a14c02ee1
Reviewed-on: https://chromium-review.googlesource.com/1129472
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573388}

Sadly, Julia is no longer working on Chrome, so she shouldn't be
expected to do reviews.

Also make all net/OWNERS owners of files where this change would leave
only one person as an owner.

Bug: none
Change-Id: I2a9ef11376eeea123096ca6f7cfc6b24134547cc
Reviewed-on: https://chromium-review.googlesource.com/1129324Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573387}

ToolbarManager#onDeferredStartup may post a delayed task to the UI thread that
calls itself. If the activity that owns the ToolbarManager is destroyed before
the task is run (and ToolbarManager#destroy is called) then the
mOmniboxStartupMetrics could be a null pointer. This cl adds a check to see if
the activity is finishing when the delayed task is run and noops out if it has.

Bug: 860449
Change-Id: Iac8333d26311142ce8e130b42aa5c7c551b844ca
Reviewed-on: https://chromium-review.googlesource.com/1127304Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573386}

Bug: None
Change-Id: I0e49baa5bdfffbd1a3280ff39281b3c1c3392088
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1128250Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573385}