- 13 Nov, 2018 40 commits
-
-
Sergey Ulanov authored
This reverts commit 75ffb181. Reason for revert: static initializer in about_flags.cc, see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/37607 Original change's description: > Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots. > > Change-Id: I88932442b714820944b4608e106eaf47536bf00d > Reviewed-on: https://chromium-review.googlesource.com/c/1329344 > Commit-Queue: Steven Valdez <svaldez@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607712} TBR=davidben@chromium.org,svaldez@chromium.org Change-Id: I638f9065d117b2885fa947c343234981eacfb991 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1334412Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607763}
-
Giovanni Ortuño Urquidi authored
Also remove some unnecessary functions. BUG=897996 Change-Id: I413001df24f29c5ccd4e3ed906727fd8152f0906 Reviewed-on: https://chromium-review.googlesource.com/c/1331287Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#607762}
-
kylechar authored
Don't pass GpuChannelManager to InProcessGpuMemoryBufferManager. Most of GpuChannelManager should only be accessed from the GPU thread so there is the potential for unsafe operations. Both SyncPointManager and GpuMemoryBufferFactory are thread safe so they should be fine. Also ensure that GpuMemoryBuffer destruction callbacks dereference their WeakPtr on the correct thread. GpuMemoryBuffers can be created and used on any thread, even though InProcessGpuMemoryBufferManager isn't used on multiple threads currently. Bug: 902163 Change-Id: I8118def4fabd0307f0a58d403b9f9c08bc72fc6b Reviewed-on: https://chromium-review.googlesource.com/c/1330030 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607761}
-
Vikas Soni authored
Add a GL backed skia representation of SharedImageBackingAHardwareBuffer. Update unit test. Bug: 891060 Change-Id: Ib3b458615be13e7a536a12097e8452052b78a14f Reviewed-on: https://chromium-review.googlesource.com/c/1330205Reviewed-by:
-
Ted Choc authored
Pre-P there is a problem with the ripple now growing with the omnibox as it expands from the fakebox to the omnibox at the top. Limit to P+ while we investigate other solutions to enable this on older versions. Original CL to compare what was enabled: https://chromium-review.googlesource.com/c/chromium/src/+/1054851/ BUG=878135 Change-Id: I2a45b398e7b67cf3a1b95aeea807485bcadc9968 Reviewed-on: https://chromium-review.googlesource.com/c/1334278Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607759}
-
Thomas Tangl authored
Bug: 872673 Change-Id: I7c304ab27f8fe2d4539be3ff99b962aefb392f89 Reviewed-on: https://chromium-review.googlesource.com/c/1333756Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#607758}
-
Thomas Tangl authored
Bug: 872642 Change-Id: I1b067bb722650752c00c43d0b77308214ae50fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1333655Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b73027ad4816..02761361bf6a git log b73027ad4816..02761361bf6a --date=short --no-merges --format='%ad %ae %s' 2018-11-13 treehugger-gerrit@google.com Merge "profiling: Check open of /proc/self/{maps,mem}." Created with: gclient setdep -r src/third_party/perfetto@02761361bf6a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibc279e1a2815f86433d69b6dd75b56cdc82c88f2 Reviewed-on: https://chromium-review.googlesource.com/c/1333862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607756}
-
Evan Stade authored
Passes 50x locally in both classic Ash and single process Mash. Bug: 693000 Change-Id: Ibc950f812b6195258609ca5ea1838331bf82aae3 Reviewed-on: https://chromium-review.googlesource.com/c/1334328Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#607755}
-
Sean Gilhuly authored
Create a server socket on the browser process and pass it to the viz process, where the Viz DevTools server is created. The server is enabled with the flag --enable-viz-devtools=<port>. If no port is specified, the default 9229 is used. Once running, you can connect to the server with the following url: chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9229/0 The viz devtools server should be connected on Android and when it runs in-process, but these haven't been tested yet. Bug: 816802 Change-Id: Ica6b98253b49e0658a680a71fa3fe7ad083610a9 Reviewed-on: https://chromium-review.googlesource.com/c/1309135 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Chase Phillips authored
The original CL was reverted due to an IndexedDB stability issue reported in https://crbug.com/899446. The stability issue was fixed as part of commit 48bcb8e3. A test to verify the issue doesn't regress was landed as part of commit 884a9b66. This change was originally a revert of the following commits: - commit 236db709 - commit 63debc65 - commit e14fc0ee Bug: 717812 Change-Id: I2e1d7a12fa30ccb8cdd5d792f8e7c72b40dc30c8 Reviewed-on: https://chromium-review.googlesource.com/c/1316830 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#607753}
-
Cathy Li authored
Null pointer crash is caused by CompositorViewHolder nulled out before onDestroy gets called in some cases. Bug: 904245 Change-Id: I4a8c3347a2bf7f0af2f704bc2e33cadc4534adc7 Reviewed-on: https://chromium-review.googlesource.com/c/1334273 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
-
Becca Hughes authored
Remove the ScoreAtStartup histogram as it was causing jank and we were not using it. BUG=900679 Change-Id: I004743c48425c9bb3fbbed67004c7616ef290cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1330211 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#607751}
-
Ken Rockot authored
Updates the Connector mojom and C++ APIs with clarifying naming and type usage. Connector has accumulated lots of cruft over the years and its API conveys a number of muddled concepts which have lead to general confusion, misuse, and abuse. This attempts to sort all that out. Namely: - All use of Identity in the Connector API has been migrated to ServiceFilter where appropriate. - StartService (first version) has been renamed to WarmService to convey the correct intent. Bugs filed and TODOs dropped in places where this is being used in an undesirable fashion. - StartService (second version) has been renamed to RegisterServiceInstance to convey more accurately what it does. It also requires a complete Identity to be provided by the trusted caller. - QueryService takes only a service name instead of an Identity, since it only needs to take a service name. It also makes no service connection so it no longer returns a ConnectResult. - FilterInterfaces is marked as deprecated on the mojom interface, because we want to obliterate it. - Test-only methods have been properly suffixed and made public, eliminating the need for the weird TestApi wrapper thing. A follow-up CL will delete TestApi and migrate its users. - Connector methods which have async replies have optional callbacks now instead of the Connector weirdly having a single catch-all (and dubiously named) "StartServiceCallback" to handle all replies. Bug: 902590 Change-Id: I5a986a5c114da914fd624dac7e6fd021cf139958 Reviewed-on: https://chromium-review.googlesource.com/c/1329845Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607750}
-
Ryan Daum authored
Draws an orange ring around the screen while magnification is enabled, as on Android. Bug: internal b/112634030 Test: manual Change-Id: Iac134759c7f6e931c7c4a4407d827fc7a75fedca Reviewed-on: https://chromium-review.googlesource.com/c/1334197Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#607749}
-
Ben Pastene authored
This is in preparation for their move from chromium.lkgr to chromium.fuzz Bug: 903591 Change-Id: Ic01978e91339d71a5e69880274fd91c299cb98b6 Reviewed-on: https://chromium-review.googlesource.com/c/1332770Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607748}
-
oysteine authored
This reverts commit c9720564. Reverting this; looks like the increased bytes used due to stringtable indices being hashes rather than sequential numbering is causing the trace chunks to fill up quicker and negates the optimization. BUG=903762 Original change's description: > Reland "Perfetto: Optimization to avoid string table lookup for _END events" > > This reverts commit 7acd0b52. > > Reason for revert: Re-landing with crashfix > > Original change's description: > > Revert "Perfetto: Optimization to avoid string table lookup for _END events" > > > > This reverts commit a7afe430. > > > > Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi# > > > > Original change's description: > > > Perfetto: Optimization to avoid string table lookup for _END events > > > > > > If we're emitting an _END trace event, we know that the string > > > table entries for the name and the categories have already been > > > emitted and so we don't need to check the string table in this > > > case. > > > > > > R=primiano@chromium.org,skyostil@chromium.org > > > > > > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f > > > Reviewed-on: https://chromium-review.googlesource.com/c/1258043 > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#600183} > > > > TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520 > > Reviewed-on: https://chromium-review.googlesource.com/c/1293612 > > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601586} > > TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I8f3b5c21494d66fe9e6c25363627ec156f5abf12 > Reviewed-on: https://chromium-review.googlesource.com/c/1325077 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606308} TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4719cde108d34cee7223615861c1f7cfac31bcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1334199Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#607747}
-
siyua authored
If one migration request is finished and the user submits another migration request in the same tab, the card would be automatically saved. Reason: The member variable user_accepted_main_migration_dialog_ is not correctly reset to false after a request is sent. So when next time the risk data is loaded, a request would be direcly sent to server. This is a bug for M71 code. Need to merge asap. Bug: 897998 Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f Reviewed-on: https://chromium-review.googlesource.com/c/1333122 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607746}
-
Justin Cohen authored
For native controllers, we don't update the contentInset, so it doesn't make sense to compare the native contentOffset to the CRWScrollViewProxy.contentInset. Change-Id: I4fda19725cecbd70af2a054bd3c2132d5b0a25fd Reviewed-on: https://chromium-review.googlesource.com/c/1333870Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607745}
-
Ian Clelland authored
Bug: 888668 Change-Id: Iec4e28d6f62d8b146b3e5311197e58e4df4b5dc2 Reviewed-on: https://chromium-review.googlesource.com/c/1331630Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#607744}
-
Regan Hsu authored
confirmation buttons. MultiDevice.VerifyButtonClicked MultiDevice.ForgetHostConfirmed Gauge if users are getting stuck in bad states or do not like our feature by logging when the Verify button or Forget Host confirmation buttons are pressed. Simply logging the count of these events isn't useful because there is no baseline; therefore, each of these should use the following buckets: 0) Button clicked. 1) Completed Setup. Bug: 903458 Change-Id: I1ad8e6a16a920b4dffdbcc70300bff354ef6f359 Reviewed-on: https://chromium-review.googlesource.com/c/1330294Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607743}
-
Hector Carmona authored
Screenshots in bug. Bug: 901210 Change-Id: I7a8cc24801ac66fd2d9e01a4bae03824811dd19d Reviewed-on: https://chromium-review.googlesource.com/c/1332715Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c14a383e61b4..6d64a5e5e40b git log c14a383e61b4..6d64a5e5e40b --date=short --no-merges --format='%ad %ae %s' 2018-11-13 benjhayden@chromium.org Add alerts-table to v2spa. 2018-11-13 perezju@chromium.org Reland "[Telemetry] Increase timeout on CollectChromeTracingData" Created with: gclient setdep -r src/third_party/catapult@6d64a5e5e40b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900920,chromium:902064 TBR=sullivan@chromium.org Change-Id: Ib20da9ac3441be3a3952d0812f9e9d918865e234 Reviewed-on: https://chromium-review.googlesource.com/c/1334248Reviewed-by:
-
Jeremy Manson authored
R=kmarshall@chromium.org, sky@chromium.org, wez@google.com Bug: FIDL-319 Change-Id: I536f7cbaa670b439be621bcda8439a9d4597ee41 Reviewed-on: https://chromium-review.googlesource.com/c/1324918 Commit-Queue: Jeremy Manson <jeremymanson@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607740}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b822560337a6..ab3176972380 Created with: gclient setdep -r src-internal@ab3176972380 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic8e2c07c732e0a891cb703d9849671e24772eccd Reviewed-on: https://chromium-review.googlesource.com/c/1333866Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607739}
-
Shawn Gallea authored
Moved text_input_manager_v1 interface into another file, to be followed by refactoring of more protocols. Refactor wayland_text_input_delegate.* from server.cc with no new code. Modify server_util to add more utilities Bug: 896710 Test: Compiled on ChromeOS. Change-Id: I2739c538a16640fdaebed1cd7493d300dd42a5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1306406Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Scott Violet authored
This is a copy of c/b/ui/ash/multi_user_window_manager_chromeos* to ash. I'm doing this as a precursor to a refactoring so you can better see what changes. I've only changed things necessary to avoid presubmit checks. This file is purposely not compiled now as it needs to be cleaned up first. BUG=756085 TEST=nothing new is compiled, so no tests. Change-Id: I946d9e3b582142761e6519bf754733649d1a7612 Reviewed-on: https://chromium-review.googlesource.com/c/1330078 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607737}
-
Dianna Hu authored
This CL updates Http2Random to use unsigned integers consistently, in hopes of being platform-agnostic (see, e.g., https://crrev.com/c/1310613). This CL lands server changes 221087569 by bnc and 221279592 by diannahu. Change-Id: Ifb1ea404887ab46569572a27b0c61c7e1bf1a26f Reviewed-on: https://chromium-review.googlesource.com/c/1334009Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607736}
-
Jun Choi authored
HoverListView is a model-agnostic view that holds multiple clickable item views. In WebAuthn, this view is used to display a list of BLE authenticators. This CL makes the view scrollable to handle an arbitrary number of BLE authenticators in the UI. Bug: 877344 Change-Id: I86f68bc3939ff661c982ae0e6bec1eed2d9a3a3a Reviewed-on: https://chromium-review.googlesource.com/c/1322832 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607735}
-
bsheedy authored
Automates the manual test for ensuring that the refresh button in the VR browser's overflow menu functions as expected. Bug: 887510 Change-Id: I9e97f5b5c313229e8845ef7fc0f1e2730434bf29 Reviewed-on: https://chromium-review.googlesource.com/c/1333111Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607734}
-
Charlie Reis authored
Change-Id: I968c0faf6ff19d6225015967d82440b1f80c4f0c Reviewed-on: https://chromium-review.googlesource.com/c/1333865Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#607733}
-
Henrique Grandinetti authored
Bug: 899980 Change-Id: I196999915290fe07322d934423430a0782c7ba55 Reviewed-on: https://chromium-review.googlesource.com/c/1330224Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#607732}
-
Ryan Meier authored
(Previously disabled due to apparent flakiness, but I've been unable to reproduce that behavior). Change-Id: I16433fa2ca8496cf2200f7a6948866b6b7e3efdf Reviewed-on: https://chromium-review.googlesource.com/c/1332208Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ryan Meier <rameier@chromium.org> Cr-Commit-Position: refs/heads/master@{#607731}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f47abb48757f..9d958b54af30 git log f47abb48757f..9d958b54af30 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Update several more oval ops to use WriteVertexData 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cd47a379f960..2778029563f2 (2 commits) 2018-11-13 mtklein@google.com remove opaque/alpha distinction in SSSE3 code 2018-11-13 herb@google.com Move strike cache backpointer to glyph cache 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1147fc2a5dac..6ed398b46847 (1 commits) 2018-11-13 mtklein@google.com drop sub_y == 0 optimization Created with: gclient setdep -r src/third_party/skia@9d958b54af30 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I2099d5fd7b5b651e9ef133c3784f282aeb8da16e Reviewed-on: https://chromium-review.googlesource.com/c/1333864Reviewed-by:
-
Kyle Milka authored
When the iframe finishes resizing send a postMessage to the doodle iframe letting it know the expansion has finished. b/118340003 Change-Id: Ic974ca58f51882d932e8de10c5706990f8f462cd Reviewed-on: https://chromium-review.googlesource.com/c/1323620Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#607729}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 95852cba. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I19cfd09cecfc2391f580e03ef1211f72e38d5e28 Reviewed-on: https://chromium-review.googlesource.com/c/1334189 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607728}
-
Tomas Popela authored
DHECK should be DCHECK. Change-Id: I3368631dee61b472d8bd58d38a4d3df3dd3900b1 Reviewed-on: https://chromium-review.googlesource.com/c/1332931Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
-
Sahel Sharify authored
With browser side fling instead of queuing a GFS in gesture event queue the fling controller processes the event immediately. It means that it is possible to process the GFS before arrival of the GSB's ack. This behavior does not cause any issues since after processing the GFS event the fling controller starts to generate GSU events at every begin frame. Since the generated GSU events are queued in gesture event queue they will wait for the ack of the GSB before getting processed. The only issue with the logic above is when we are bubbling GFS: It is possible that the fling controller processes the GFS before the ack of the GSB is arrived. In this case we won't bubble the GFS since we only bubble the rest of the scroll events in a sequence only when the GSB of the sequence is bubbled. This cl changes the scroll bubbling logic to avoid GFS bubbling. With this change the GFS won't get bubbled and the fling controller of the oopif will generate GSU events which will get bubbled. When the bubbling target did not consume a generated GSU event it will tell the oopif's fling controller (via RWH_input_event_router) to stop flinging. The first three tests are not new. They just show that the flinging on the oopif still causes the parent to scroll when we are bubbling scroll. The last test shows that the child's fling controller stops flinging when the parent's renderer does not consumed the generated GSUs that are bubbled. I also changed the following tests to be browser tests since instead of the fling controller cancelling the fling when generated GSUs are not consumed the RWHV_* calls stop fling. This change is necessary since the RWHV_* knows when the scroll is getting bubbled but the fling controller does not: -Early[Touchpad|Touchscreen]FlingCancelationOnInertialGSUAckNotConsumed BrowserSideFlingBrowserTest.TouchscreenInertialGSUsBubblesFromOOPIF, BrowserSideFlingBrowserTest.InertialGSEGetsBubbledFromOOPIF, BrowserSideFlingBrowserTest.InertialGSUBubblingStopsWhenParentCannotScroll Bug: 900357 Test: BrowserSideFlingBrowserTest.TouchpadInertialGSUsBubblesFromOOPIF, Change-Id: I784aa03b561d0482a95341544133761e40a1917f Reviewed-on: https://chromium-review.googlesource.com/c/1308598Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL extends the amount of useful information a popup tracker has, and reports it to UKM on close. This data will additionally be useful if we add spammy popup detection + enforcement at run time. Bug: 825875 Change-Id: I1366b795c500cbf58730887cf4e71c3f32b945a8 Reviewed-on: https://chromium-review.googlesource.com/c/1313508Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607725}
-
Tommy Martino authored
Multiline entries are used mostly for warnings and other edge cases where descriptive text is needed. By their nature the height is variable, so we need to set padding and use a content-wrapping height. This was done in the old implementation but errantly not carried over to the refactor. Bug: 903554 Change-Id: I6e9873c757fb9087af3066bb55017badccd15149 Reviewed-on: https://chromium-review.googlesource.com/c/1327579Reviewed-by:
-
