- 10 Jan, 2020 9 commits
-
-
meacer authored
Skeleton strings are used to detect confusable hostnames. They are generated in two places: 1. During build time in make_top_domain_skeletons: This binary takes a list of hostnames and generates their skeletons to be embedded statically to the Chrome binary. 2. During runtime idn_spoof_checker.cc: This class generates skeletons of a hostname to compare against a list of known skeleton strings. Before generating a skeleton string, this class applies a few additional transformations such as diacritic removal to the hostname to be able to detect more confusable hostnames. This CL extracts the skeleton generation in IDN spoof checker code to a separate file so that make_top_domain_skeletons can apply the same transformations to input hostnames when building the static top domain list. This CL also modifies top_domain_generator binary which generates the actual trie to be embedded to the binary. The trie currently doesn't allow non-ASCII characters in its fields. This CL stores unicode hostnames in punycode to overcome this restriction. Unicode hostnames may still have non-ASCII skeleton strings, and top_domain_generator still doesn't support that. However, the current top domain list doesn't have any IDN so this isn't a blocking issue. Bug: 1040607 Change-Id: I40c654152025d910cbeb8ba32bff5b7835f00104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992011Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#729987}
-
Annie Sullivan authored
This also adds indexing per https://chromium.googlesource.com/chromium/src/+/master/services/metrics/ukm_api.md#controlling-the-aggregation-of-metrics Change-Id: Ib69d097d6b5c1ecd1a11c32ac709ec6c0ae59d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989966Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729986}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b19b2734385..9a83dd729bf5 git log 3b19b2734385..9a83dd729bf5 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 steveanton@webrtc.org Batch process pending tasks in the libevent TaskQueue Created with: gclient setdep -r src/third_party/webrtc@9a83dd729bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie441a5b5874fea3dc6a550b7555770818b12e4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729985}
-
Henrique Nakashima authored
The cleanup period has already passed. Add the key to the deprecated list so it's not reused. Bug: 960767, 1022108 Change-Id: I8323c5bd897a041691f278da04861f4d799ca613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993642Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/12f8d69f1288..13928b7e7f1a git log 12f8d69f1288..13928b7e7f1a --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@chromium.org Revert "vpython: Specify interpreter to run." Created with: gclient setdep -r src/third_party/depot_tools@13928b7e7f1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1036606 Tbr: agable@chromium.org Change-Id: Id5680e4c2400f9d73177347cee9e4e1fd57e749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994115Reviewed-by:
-
Zhenyao Mo authored
We don't really care for devices where GPU process init takes more than 5 seconds. Even a low-end device like MS Surface Go only takes 1.2 seconds. With this CL, we can take a closer look at initialization time distribution. BUG=1039792 R=magchen@chromium.org,jwd@chromium.org Change-Id: I4363baa9743e55e27b48b48296029b305d95ddba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992692Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729982}
-
Ben Pastene authored
Needed to avoid "builders should be listed in this project's commit-queue.cfg" messages in CLs like crrev.com/c/1991950. Bug: 1037892 Change-Id: I9ca588b213822c5b40482a7239603f86ac7a7ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993903Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#729981}
-
Tibor Goldschwendt authored
Bug: 1040256 Change-Id: Ia8e1a17d65f85d5b6ae1218835fbdb1e308c6af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991809 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#729980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141fae8b9f4d..d9ef631c223a Created with: gclient setdep -r src-internal@d9ef631c223a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040284 Tbr: jbudorick@google.com Change-Id: I43cb78ac1dc71133147d87eb69fc66163ef8a847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729979}
-
- 09 Jan, 2020 31 commits
-
-
Christopher Grant authored
As per discussion with ssid@, 64-bit browser builds should not have a 32-bit unwind asset in them. R=estevenson Bug: 1038962 Change-Id: I012138cff1071d74f2722277a90758d44bf8677b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993676 Auto-Submit: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#729978}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f59495dd..bd2510d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3e28358e59d9ad271c08cd0069d9ffbc8245b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729977}
-
Matthew Denton authored
Bug: 1038828 Change-Id: I54fd66812c69937ef6d26770341eef147e861b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992215 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729976}
-
Mila Green authored
Bug: 1031552 Change-Id: I065956f2eb6cde4354fcff23d03912836b4a14c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993142Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729975}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/156cd8939c5f..f5acee902c4d $ git log 156cd8939..f5acee902 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 costan Move CI to Visual Studio 2019. 2019-11-07 costan Align CMake configuration with related projects. 2019-11-05 costan Remove redundant PROJECT_SOURCE_DIR usage from CMake config. 2019-11-04 costan Fix one forgotten instance of StringPrintf -> StrFormat. 2019-11-03 costan Fix build errors. 2019-11-03 costan Test CMake installation on Travis. 2019-10-30 no-reply Internal changes 2019-10-17 bitomaxsp Allow build with different standard if lib used as a subproject 2019-09-29 costan Fix Travis CI build. 2019-09-27 costan Remove snappy::string alias to std::string. 2019-09-26 costan Fully qualify std::string. 2019-08-20 costan Fix benchmarks. 2019-08-20 costan Fix benchmarks. 2019-08-20 costan Fix unused variable warnings in fuzzers. 2019-08-19 costan Rename zippy_*_fuzzer.cc -> snappy_*_fuzzer.cc. 2019-07-10 nafi Add BM_ZFlatAll, BM_ZFlatIncreasingTableSize benchmarks to see how good zippy performs when it is processing different data one after the other. 2019-07-27 bhargava.shastry Update travis config for fuzzer builds 2019-07-20 aman Updated to match .gitignore from google/leveldb 2019-07-13 aman Create .gitignore 2019-06-28 bshas3 Add libFuzzer harnesses, a cmake option to build them Created with: roll-dep src/third_party/snappy/src Change-Id: I2da25ef3b612cc68765065f0fb55df8c95254380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993145 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729974}
-
Takuto Ikuta authored
This is to fix base_unittests failure like https://luci-milo-dev.appspot.com/p/chromium/builders/ci/Mac%20Swarm/13268 Change-Id: I4c625d9aec7041ed8e688e4bceffa3dcba85b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993014 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#729973}
-
rajendrant authored
This CL gets the estimated data savings due to SaveData and updates as LiteMode savings. The savings are retrieved from field trial as json. Bug: 923551 Change-Id: Ia7c5518edfeaedce33e957c19224f6a2350df6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990989 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729972}
-
Nelson Billing authored
- Add '-Wl,-mllvm -Wl,-generate-type-units' to ldflags for Chrome Android builds using ThinLTO (use_thin_lto), which is typically the case just for official builds (is_official). - This brings the 32bit binary size of Chrome under the linker size limit, so symbol_level can be raised back to "2" for these builds. - Exclude builds with ThinLTO from the logic that lowers symbol_level to "1" for non-component Android builds. Change-Id: I26457985b26d0e84bf08640c5128b84eacdcc43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992240 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729971}
-
Bo Liu authored
In r728805, SelectionPopupControllerImpl post task was converged from View to Handler. However one of the removeCallbacks calls was accidentally not converted, which means the task to dismiss the pop up was never removed as expected sometimes, causing a flicker. Fixed: 1040457 Change-Id: Iad16cc958b4adce599255de7596b2cbec568154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994007 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729970}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3c04fb3a9464..9346b7c0ed1a git log 3c04fb3a9464..9346b7c0ed1a --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tsepez@chromium.org Remove several unused enums and structs from public/fpdf_fwlevent.h. Created with: gclient setdep -r src/third_party/pdfium@9346b7c0ed1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8369932c058c266597ef82438d72a81711ad7f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994109Reviewed-by:
-
Daniel Clark authored
Fixed the following issues that led to the revert: - Added missing mac image baseline updates - Some tests I added/extended were timing out in a linux MSAN run. I noticed that the color picker is slow to open in even a normal debug build, so I suspect that these are legit timeouts where the tests are just taking too long on the MSAN build. I've split the tests up to avoid this (color-picker-events-*, color-picker-escape-cancellation-*). Original change description follows: This CL updates the <input type="color"> popup UI in three related aspects per design feedback: 1) The in-page control now updates immediately as the selected color is changed in the popup, instead of waiting for the popup to be dismissed. The page can watch for these 'live' changes via the input event. 2) The UI is simplified by removal of the submit and cancel buttons. The popup is now dismissed only by clicking outside of it or with the Enter or Escape keys. 3) A 'double-escape' model is introduced in which if a user has opened the popup and changed the value, hitting Escape once will reset the value back to what it was when the popup was opened. Hitting Escape once more, when the popup value matches the value when opened, will dismiss the popup. Bug: 1001571 Change-Id: I1369851208c3da0231b6c1d6fb218b9c13e00ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992598 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#729968}
-
John Williams authored
This CL fixes a crash that can happen when closing a window after using the desktop media picker. In addition, async calls to OnPickerDialogResults are now done through a weak pointer. This change doesn't fix any specific issue I've observed, but it seems like a good defensive measure. Bug: 1032330 Change-Id: I9a2d6264becd805ae3d1ea66bd124c003f200fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988984 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729967}
-
Fabrice de Gans-Riberi authored
This reverts commit 27453d76. Reason for revert: Suspected cause for build failure: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-asan-rel/23333 Original change's description: > Add a flag for building HWASAN splits. > > The new build_hwasan_splits flag causes HWASAN splits to be created for > the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its > DFMs that contain native code. The intent is that this flag will eventually > default to true in official builds. > > The library is deliberately installed in TrichromeChrome6432 rather than > TrichromeLibrary6432 (where the regular native library lives) because the > Android platform does not support splits for the library containing the > WebView implementation. This means that only Chrome will use the HWASANified > native library, and WebView will use the regular native library. > > Bug: 916828 > Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729945} TBR=torne@chromium.org,cjgrant@chromium.org,pcc@chromium.org,agrieve@chromium.org Change-Id: Ic8ee9206385f27941f1fa12e7927376c673e4149 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 916828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993747Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729966}
-
Sammie Quon authored
- OverviewGridTest.SnappedWindow - SplitViewOverviewSessionTest.OverviewDragControllerBehavior. Test: ash_unittests *Overview* Bug: none Change-Id: Iec84d264f6f572cf8f84a16ed597e00bc0b2995d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992019 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#729965}
-
Allen Bauer authored
Bug: 245409 Change-Id: I6a96fcf3ab975146631137322f338d0841da3ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993678 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729964}
-
Andrew Xu authored
When relocating the pinned app across pages, a proxy image view is created in ScrollableShelfView. The proxy image view has the identical bounds with ShelfView::|drag_view_|. However, |drag_view_|'s bounds are adjusted to fit into the targeting icon slot. It is why the dragged icon may move under the finger by itself. To fix the issue, the proxy image's bounds should rely on the mouse/gesture event's location. This CL also adds the animation to move the drag icon from event location to the ideal place after drag ends. Bug: 1031367 Change-Id: I539abc1b97e061a50c2a53b1cc6b784e78c14983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990565 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729963}
-
Toni Barzic authored
A folow-up on CL:1988989 with a couple of things I realized can be done better: * use presenter_.GetTargetVisibility() to check if app list has been previously shown * Show app list in tablet mode using HomeScreenController::Show (it handles some additional tablet mode specific things - e.g. sets the show source) * Use last_target_visible_ to check if app list should be visible when session changes to active (instead of trying to recalculate target visibility state again) BUG=1038512 Change-Id: I6a1aa7613935ed042a45b4aa622bd7cf2203a071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992242Reviewed-by:Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#729962}
-
Lijin Shen authored
When closing the last tab through tab switcher longpress menu, there exists one monent at which there is no visible tab. Color.WHITE is hard-coded but the browser control background color should be determined based on whether chrome is on dark mode or light mode. Bug: 1034843 Change-Id: I332fee777cbc095704e19e786905c983778fcacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976434Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#729961}
-
Christopher Grant authored
R=estevenson Bug: None Change-Id: Ib35be0e583d9b5edcbd137a60cd51b3c4274fc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994242 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Christopher Grant authored
Bug: None Change-Id: I69df296a38cf8f082cff6e05b6fc5c81cce9da90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991751 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729959}
-
Patrick Monette authored
This simplifies the code a bit and removes any possibilities of mixing RenderProcessHost IDs and frame routing IDs. Change-Id: I0d7c8df9b6ebc9c7e20d5fbc6f36074125761f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977966 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729958}
-
Mehran Mahmoudi authored
This connects adds a paint_preview_base_service dependency on the player. Bug: 1019885 Change-Id: Ia1055d83591e828c3a945b0ddc948ec5496b2edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955819Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729957}
-
Tibor Goldschwendt authored
This prepares adding more pages to the customize dialog. Bug: 1040256 Change-Id: Ia16b4d7b50b630b7b1b0ce66768980027b628908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990879Reviewed-by:
-
Kevin Qin authored
OpenXR supports HTC Vive controller by adding the bindings. Fixed: 1034180 Change-Id: Id9a4acd7355dde7c205adf7483a7dd144d3044a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984620 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#729955}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f6a6a4162f28..a7e42ba7f855 git log f6a6a4162f28..a7e42ba7f855 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 bclayton@google.com Kokoro: Disable ASAN for debug mac builds Created with: gclient setdep -r src/third_party/swiftshader@a7e42ba7f855 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If67a94492a914b1ed5f8493bc8d753399849130b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993884Reviewed-by:
-
Hesen Zhang authored
Bug: 1013685 Change-Id: I875b920fbdd77b07d8f8ad4dea4d712393c8aeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993675Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729953}
-
Istiaque Ahmed authored
This CL restricts the type of ActivationSequence to StrongAlias instead of int, so that it cannot be used interchangeably with int anymore. This CL also moves the definition to //extensions/common so that renderer/ can use it. This CL doesn't produce any behavior changes. Bug: 1970854 Change-Id: I30a5acc19c87bb4d6d4ab8f3cb36f8b9af12c2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986327Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729952}
-
Gabriel Charette authored
But drop unused .SingleTab/.MultiTabs suffix. Current histogram values kept for posterity @ https://docs.google.com/document/d/18uYnVwLly7C_ckGsDbqdNs-AgAAt3AmUmn7wYLkyBN0/edit#heading=h.yy3qczapsgy7 R=fdoray@chromium.org, rkaplow@chromium.org Bug: 1037318 Change-Id: Ice8efe602d65c24d88d03bfb37882202e4c35881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990990 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#729951}
-
Eric Karl authored
Previous patch did not update GLTextureRepresentation's clear region on begin access. This allowed it to get out of sync if other (non-GL) components modified the clear rect. This patch updates the cleared rect on each begin access. Bug: 1039232 Change-Id: Iacc6e65b25d770e1d17e51a5f1c2c632dfad0101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990195Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#729950}
-
Daniel Rubery authored
Versions of vim with +python3 but -python currently display an error message at startup if they use ninja-build.vim. We can support these versions along with existing +python -python3 versions of vim by using pythonx instead. Change-Id: I389486aa5b49b3466514e98fa57b5dce3115273a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994080Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#729949}
-
Marijn Kruisselbrink authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1955823 the code was updated to match the terminology in the readme (blob key vs blob number), however in doing so accidentally the readme was also modified. This reverts the changes to the readme, as it already used the correct terminology for blob numbers and blob keys. Bug: 1027737 Change-Id: Ie4012688901b9813248e99bce93ee6b454eba53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993872 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#729948}
-
