Commits · 84d721aaad247c65c80e7157c8500536e0cb6902 · eriksson monteiro / tangled

02 Sep, 2015 40 commits

Change IdleCallbackDeadline.timeRemaining to be a function instead of an attribute. · 84d721aa

rmcilroy@chromium.org authored Sep 02, 2015

BUG=514651

Review URL: https://codereview.chromium.org/1309523008

git-svn-id: svn://svn.chromium.org/blink/trunk@201637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

84d721aa

Oilpan: fix build after r201632. · a36d4f72

sigbjornf@opera.com authored Sep 02, 2015

R=haraken
BUG=523249
NOTRY=true

Review URL: https://codereview.chromium.org/1325983003

git-svn-id: svn://svn.chromium.org/blink/trunk@201636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a36d4f72

[part 1] Make classes and structures in modules/ fast-allocated. · 697a99d3

tasak@google.com authored Sep 02, 2015

- Updated modules/accessiblity, app_banner, audio_output_device, bluetooth, 
  cachestorage, canvas2d, compositorworker, crypto, encryptedmedia, fetch, and filesystem.

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1315743003

git-svn-id: svn://svn.chromium.org/blink/trunk@201635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

697a99d3

Fix Resource leak in ActivityLoggerTest unit tests. · da3d74d2

sigbjornf@opera.com authored Sep 02, 2015

Evict resources from the memory cache upon shutdown.

R=haraken
BUG=526423

Review URL: https://codereview.chromium.org/1309843011

git-svn-id: svn://svn.chromium.org/blink/trunk@201634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

da3d74d2

Oilpan: Partially ship Oilpan for core/animations · bdf70bf0

haraken@chromium.org authored Sep 02, 2015

This CL ships Oilpan for core/animations except for temporary animation objects.
We confirmed that this CL won't regress any animation benchmark in telemetry.

Look at the discussion in the following thread for more details
and performance results: https://groups.google.com/a/chromium.org/d/topic/oilpan-reviews/V7d-7o4AbeA/discussion

BUG=340522

Review URL: https://codereview.chromium.org/1318543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bdf70bf0

Make classes and structures in core/inspector fast-allocated. · 95824c42

tasak@google.com authored Sep 02, 2015

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1308273007

git-svn-id: svn://svn.chromium.org/blink/trunk@201632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

95824c42

CREDENTIAL: Add 'PasswordCredential::toFormData()' · e647a2a4

mkwst@chromium.org authored Sep 02, 2015

The API has evolved a bit, dropping the 'password' and 'formData'
accessors in favor of a 'toFormData(FormDataOptions)' method which
is intended to be used in conjunction with 'fetch()' to submit
credentials to a server-side endpoint.

Defined at [1] and [2].

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential
[2]: https://w3c.github.io/webappsec/specs/credentialmanagement/#generate-formdata

BUG=526995

Review URL: https://codereview.chromium.org/1317043003

git-svn-id: svn://svn.chromium.org/blink/trunk@201631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e647a2a4

[Oilpan] De-oilpanize ScopedPageLoadDeferrer. · bfe6f774

yutak@chromium.org authored Sep 02, 2015

ScopedPageLoadDeferrer is an RAII-like class that does some work when it is
constructed and destructed, just like other ScopedXXX classes.

It was oilpanized in the past, and a new method, dispose(), was added to
do clean-ups that had been done in the destructor. However, a few stack-
allocated usages were overlooked in that change.

Garbage-collected objects shouldn't be allocated on the stack. So, stack-
allocated usages should be converted to heap-allocated, with dispose() calls
added in every single place where the object can go out of scope.

However, I find this conversion too cumbersome and less C++-idiomatic.

Therefore, this patch instead de-oilpanizes ScopedPageLoadDeferrer. The only
reference to will-be-heap-managed class in ScopedPageLoadDeferrer is
RefPtr<LocalFrame>, so it is safe to convert it to RefPtrWillBePersistent.

I think this patch makes the code cleaner overall.

BUG=486590
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1316663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bfe6f774

Oilpan: fix build after r201622. · 486c0df7

sigbjornf@opera.com authored Sep 02, 2015

TBR=oilpan-reviews
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1310633005

git-svn-id: svn://svn.chromium.org/blink/trunk@201629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

486c0df7

Fix flakiness of imported/web-platform-tests/html/syntax/parsing/html5lib_testsNN.html. · e78bb71d

tkent@chromium.org authored Sep 02, 2015

Root cause:
Our testharnessreport.js removes unnecessary text nodes in a callback registered
by add_completion_callback() [1]. The html5lib tests add other completion
callbacks to show failure reasons, and they run after the callback of
testharnessreport.js.  So, the failure reasons remain in *-expected.txt.

Resolution:
testharness.js doesn't provide a way to specify that "This callback must run at
the end of callbacks." So we delay the text nodes cleanup by setTimeout(done, 0).

[1] https://github.com/w3c/testharness.js/blob/master/docs/api.md#callback-api

BUG=527262

Review URL: https://codereview.chromium.org/1303313006

git-svn-id: svn://svn.chromium.org/blink/trunk@201628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e78bb71d

Correct handling of |for| and |event| attributes of script elements. · 7f241e07

tkent@chromium.org authored Sep 02, 2015

https://html.spec.whatwg.org/multipage/scripting.html#script-processing-for
> 12. If the script element has an event attribute and a for attribute, then run
> these substeps:

Our implementation was "... has a non-empty event attribute and a non-empty for
attribute, ...".  This CL corrects isEmpty() checks to isNull().
The new behavior is compatible with IE and Firefox.

BUG=520844

Review URL: https://codereview.chromium.org/1305213005

git-svn-id: svn://svn.chromium.org/blink/trunk@201627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7f241e07

Protect RawResource from deletion in RawResource::didSendData() and didDownloadData() · 98864def

tyoshino@chromium.org authored Sep 02, 2015

ResourceClientWalker uses a reference to m_clients (a member of the
RawResource instance). Therefore, when w.next() is invoked, the RawResource
instance must be alive.

RawResourceClient (e.g. DocumentThreadableLoader) may destroy the RawResource
in didSendData() and didDownloadData().

Like other methods (appendData(), willFollowRedirect(), ...) these methods
should also have a protect.

BUG=527046
R=japhet,hiroshige

Review URL: https://codereview.chromium.org/1307743009

git-svn-id: svn://svn.chromium.org/blink/trunk@201626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

98864def

Avoid to use static member function VisibleSelection::selectionType() in PendingSelection class · b8374b5f

yosin@chromium.org authored Sep 02, 2015

This patch replaces static member function |VisibleSelection::selectionType()|
by |VisibleSelection::Strategy::selectionType()| in |PendingSelection| class
as preparation of moving |VisibleSelection::selctionType()| out from
|VisibleSelection| as local static function, since it is used only
|PendingSelection| and |VisibleSelection| classes for ease of templatizing
|VisibleSelection| to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1323933003

git-svn-id: svn://svn.chromium.org/blink/trunk@201625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b8374b5f

Remove a GC_PLUGIN_IGNORE for an issue which has already been fixed. · 08118106

peria@chromium.org authored Sep 02, 2015


BUG=516604, 496496

Review URL: https://codereview.chromium.org/1320443005

git-svn-id: svn://svn.chromium.org/blink/trunk@201624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

08118106

remove TextResourceDecoder::detectJapaneseEncoding decl which is never defined · 7ad5b007

kouhei@chromium.org authored Sep 02, 2015

BUG=None

Review URL: https://codereview.chromium.org/1326773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7ad5b007

Move honorEditingBoundaryAtOr{Before,After}() for VisiblePosition to VisibleUnits.cpp · f1f0e5a0

yosin@chromium.org authored Sep 02, 2015

This patch moves |honorEditingBoundaryAtOr{Before,After}()| for
|VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make
"VisiblePosition.cpp" to simpler for improving code health and ease of
templatizing |VisiblePosition| class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173010

git-svn-id: svn://svn.chromium.org/blink/trunk@201622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f1f0e5a0

Assertion failures of 023.html and 026.html were gone. · 4ecc7300

tkent@chromium.org authored Sep 02, 2015

http://src.chromium.org/viewvc/blink?view=rev&rev=201530 fixed the assertion
failures.

BUG=519997
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1321663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4ecc7300

Add inline style in the element's scope. · 98ee5fa1

rune@opera.com authored Sep 02, 2015

Style attribute declarations were added in a separate scope after all
other author origins. Instead add style attribute declarations right after
collecting matching rules from the element's scope. This means that we can
override values set on the style attribute from outer scopes, like we can
with values from inner scope's stylesheet.

Without this fix, you would get green on orange below:

<style>html /deep/ span { color: green; background-color: lime }</style>
<host>
  <host:root>
    <style>span { color:red }</style>
    <span style="background:orange">Green on orange?</span>
  </host:root>
</host>

With this change, we will get green on lime.

The regression (issue 526634) was not relying on this, but it would be
more complex code to fix the regression without fixing the style attribute
cascading order.

R=kochi@chromium.org,hayato@chromium.org
BUG=526634

Review URL: https://codereview.chromium.org/1322753006

git-svn-id: svn://svn.chromium.org/blink/trunk@201620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

98ee5fa1

Use PositionWithAffinity as internal representation of VisiblePostion · db849a3b

yosin@chromium.org authored Sep 02, 2015

This patch replaces member variables |Position| and |TextAffinity| in
|VisiblePostion| class to |PositionWithAffinity| to simplify construction
of an object for preparation of templatizing |VisiblePostion| to introduce
composed tree version.

This patch also moves default constructor into .cpp file from header file to
reduce size of header file.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311913006

git-svn-id: svn://svn.chromium.org/blink/trunk@201619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

db849a3b

Fix formAction return value for empty formaction content attribute. · ea52a3bd

tkent@chromium.org authored Sep 02, 2015

According to the standard and web-platform-tests, empty attribute value should
return the document URL.
https://html.spec.whatwg.org/multipage/forms.html#dom-fs-formaction

> The formAction IDL attribute must reflect the formaction content attribute,
> except that on getting, when the content attribute is missing or its value is
> the empty string, the document's address must be returned instead.

This CL removes empty formaction tests in submit-form-attributes.html.
html/semantics/forms/attributes-common-to-form-controls/formaction*.html cover
them.

BUG=520835

Review URL: https://codereview.chromium.org/1321033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ea52a3bd

Removed m_isQuirkValue and used CSSPrimitiveValue::QuirkyEms instead · d4712291

sashab@chromium.org authored Sep 02, 2015

Removed m_isQuirkValue from CSSValue and updated callers to use
CSSPrimitiveValue::UnitType::QuirkyEms instead.

Review URL: https://codereview.chromium.org/1316153003

git-svn-id: svn://svn.chromium.org/blink/trunk@201616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d4712291

Auto-rebaseline for r201598 · ef9997b9

joelo@chromium.org authored Sep 02, 2015

http://src.chromium.org/viewvc/blink?view=revision&revision=201598

BUG=521730
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1329663002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ef9997b9

Removed unused parameters from StyleResolverState::styleImage · efb3d159

sashab@chromium.org authored Sep 02, 2015

Review URL: https://codereview.chromium.org/1314773006

git-svn-id: svn://svn.chromium.org/blink/trunk@201614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

efb3d159

Gardening: Add more expectations for Win 10 failures · a2ded469

falken@chromium.org authored Sep 02, 2015

BUG=521730
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1326593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a2ded469

Make VisiblePosition constructor private · 46fcae49

yosin@chromium.org authored Sep 02, 2015

This patch makes |VisiblePosition| constructor private by replacing it by
|createVisiblePosition()| as preparation of simplify implemenation of
|VisiblePosition| construction.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1317053004

git-svn-id: svn://svn.chromium.org/blink/trunk@201612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

46fcae49

Remove hard-coded origins in layout tests. · 7509687e

jeremyarcher@google.com authored Sep 02, 2015

Because the W3C's web-platform-tests are run using a
different origin (http://web-platform.test versus
http://127.0.0.1), we should use the existing host-
detection code in get-host-info.js.

BUG=462361

Review URL: https://codereview.chromium.org/1314123002

git-svn-id: svn://svn.chromium.org/blink/trunk@201611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7509687e

[VR, Permission] Use appopriate type parameters for WebCallbacks (3/3) · fa64f1d6

yhirano@chromium.org authored Sep 02, 2015

 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebVector<WebVRDevice>* (ownership not transferred)
  => const WebVector<WebVRDevice>&

1/3: https://codereview.chromium.org/1317243002/
2/3: https://codereview.chromium.org/1309803006/
3/3: https://codereview.chromium.org/1321763002/

BUG=493531

Review URL: https://codereview.chromium.org/1321763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fa64f1d6

Auto-rebaseline for r201592 · 6ca6f440

joelo@chromium.org authored Sep 02, 2015

http://src.chromium.org/viewvc/blink?view=revision&revision=201592

BUG=452914
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1317743004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6ca6f440

DevTools: Refactor memory counter display · 682e8129

paulirish@chromium.org authored Sep 02, 2015

Improve usability of jsHeapSize readability by formatting as bytes.
Refactor counter checkboxes to reuse CheckboxFilterUI. Delete swatch component.
Change default height of memory counters from 200 to 112px.

BUG=523697

Review URL: https://codereview.chromium.org/1309723003

git-svn-id: svn://svn.chromium.org/blink/trunk@201608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

682e8129

Revert of Remove old blink isolate files. (patchset #1 id:1 of... · 09e70088

joelo@chromium.org authored Sep 02, 2015

Revert of Remove old blink isolate files. (patchset #1 id:1 of https://codereview.chromium.org/1319753003/ )

Reason for revert:
broke android build

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37274

Original issue's description:
> Remove old blink isolate files.
> 
> BUG=524758
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201602

TBR=dpranke@chromium.org,maruel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524758

Review URL: https://codereview.chromium.org/1309323005

git-svn-id: svn://svn.chromium.org/blink/trunk@201607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

09e70088

[Background Sync] Allow sync manager access from uncontrolled clients · 231179ba

iclelland@chromium.org authored Sep 02, 2015

This patch cleans up the method which was deprecated in part 1, and
whose implementations were removed in part 2.

This is part 4 of a four-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003
Part 2: https://codereview.chromium.org/1324903002
Part 3: https://codereview.chromium.org/1316743002
Part 4: https://codereview.chromium.org/1314453003 (this patch)

BUG=518884

Review URL: https://codereview.chromium.org/1314453003

git-svn-id: svn://svn.chromium.org/blink/trunk@201606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

231179ba

Devtools[LayoutEditor]: Rework layout-editor workflow · cb0f1054

sergeyv@chromium.org authored Sep 02, 2015

BUG=501896

Review URL: https://codereview.chromium.org/1311783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cb0f1054

Add model listeners in the Security panel constructor (instead of in targetAdded). · 71e6f208

lgarron@chromium.org authored Sep 02, 2015

BUG=522762

Review URL: https://codereview.chromium.org/1311013007

git-svn-id: svn://svn.chromium.org/blink/trunk@201603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

71e6f208

Remove old blink isolate files. · 33bea975

joelo@chromium.org authored Sep 02, 2015

BUG=524758

Review URL: https://codereview.chromium.org/1319753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

33bea975

Force running GC on the worker thread before the unit test exits · f00440f5

kinuko@chromium.org authored Sep 02, 2015

For the main thread we seem to always run
v8::Isolate::RequestGarbageCollectionForTesting but it's
not the case on the worker thread, which seems to cause leaks
on the context object.

BUG=526424

Review URL: https://codereview.chromium.org/1316233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f00440f5

Include third_party/sqlite/sqlite3.h directly. · b35cbbd9

shess@chromium.org authored Sep 02, 2015

Chromium's third_party/sqlite build config arranges for
third_party/sqlite to be part of the include path so that <sqlite3.h>
works in these files.  The system version of sqlite3.h can still be used
with the use_system_sqlite build override.

BUG=526828

Review URL: https://codereview.chromium.org/1317683008

git-svn-id: svn://svn.chromium.org/blink/trunk@201600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b35cbbd9

WebGL 2: add readPixels API to read pixels into pixel pack buffer · 05cdea84

yunchao.he@intel.com authored Sep 02, 2015

BUG=295792

Review URL: https://codereview.chromium.org/1300573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

05cdea84

Update web-platform-tests/html bug numbers. · cac7cf4b

tkent@chromium.org authored Sep 02, 2015

We filed specific bugs.
Also, we confirmed form-validation-reportValidity.html just needs rebaseline.

BUG=526930,526898,526920,527262
TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1305923006

git-svn-id: svn://svn.chromium.org/blink/trunk@201598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cac7cf4b

Update the visibility of XHR-related interfaces to match spec · cc05eb73

philipj@opera.com authored Sep 02, 2015

https://github.com/whatwg/xhr/issues/19

BUG=395931
R=dominicc@chromium.org

Review URL: https://codereview.chromium.org/1310543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cc05eb73

Gardening: update TestExpectations · 11ce9d0e

falken@chromium.org authored Sep 02, 2015

BUG=527270,524804,527278,527281
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1302323007

git-svn-id: svn://svn.chromium.org/blink/trunk@201596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

11ce9d0e