GitLab

Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455 :

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
>
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
>
> TBR=dpranke
>
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2308953002
Cr-Commit-Position: refs/heads/master@{#416439}

Revert of Move more of webcore_remaining into GN build files. (patchset #2 id:20001 of https://codereview.chromium.org/2301383003/ )

Reason for revert:
Trying to get https://codereview.chromium.org/2308953002/ to apply

Original issue's description:
> Move more of webcore_remaining into GN build files.
>
> This makes more GN build files for various subdirectories of core and adds the
> file lists from the .gypi to those files.
>
> Since there are now so many places requring WebCOre boilerplate, this adds a
> new template for defining core components that automatically does most setup.
> This also cleans up the existing callers.
>
> Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
> Cr-Commit-Position: refs/heads/master@{#416344}

TBR=dpranke@chromium.org,dglazkov@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2304353002
Cr-Commit-Position: refs/heads/master@{#416438}

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807

Review-Url: https://codereview.chromium.org/2301053004
Cr-Commit-Position: refs/heads/master@{#416437}

CompositorFrame is to be submitted from OffscreenCanvas from
either main or worker thread (but not both at the same time);
therefore, another interface "OffscreenCanvasFrameReceiver"
is created only when commit() is invoked.

This CL follows the class design structure in this diagram:
www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e

Currently, we only submit a Green color frame for simplicity.
More CLs will follow to fill in image data to the compositor
frame.

BUG=563852

Review-Url: https://codereview.chromium.org/2294963002
Cr-Commit-Position: refs/heads/master@{#416436}

Cr-Commit-Position: refs/heads/master@{#416435}

BUG=555865

Review-Url: https://codereview.chromium.org/2292393004
Cr-Commit-Position: refs/heads/master@{#416434}

This is the first part of a multi-part series of patches:

   1   This patch
   2-N Additional support in Blink, Media Router, UX, etc.
   N+1 https://codereview.chromium.org/2148643002 with Intent to Implement+Ship

This patch:

- Adds support to WebPresentationClient for passing multiple URLs to startSession/joinSession/setDefaultPresentationUrls
- Updates PresentationService mojo interface
- Updates PresentationServiceImpl/PresentationServiceDispatcher
- Passes a single URL from Blink to WebPresentationClient
- Passes a single URL from PresentationServiceDispatcherImpl to MR
- Updates unittests

BUG=627655

Review-Url: https://codereview.chromium.org/2174693004
Cr-Commit-Position: refs/heads/master@{#416433}

BUG=643383

Review-Url: https://codereview.chromium.org/2308893002
Cr-Commit-Position: refs/heads/master@{#416432}

This change rolls in a few changes:
- Removes DelegateState::PAUSED_BUT_NOT_IDLE state.
- Removes all blocks against suspending prior to kHaveFutureData.
- If suspended, triggers resume when prior to have kHaveFutureData
if the didLoadingProgress() timer reports true.
- Always notifies the delegate of DelegateState::GONE; this ensures
the idle timer is always restarted if we didn't quite get enough
data to reach kHaveFutureData.
- Fixes pause timer to handle newly supported background video;
which doesn't set a state of DelegateState::GONE

BUG=612909, 643383
TEST=new and updated unittests.

Review-Url: https://codereview.chromium.org/2289543005
Cr-Commit-Position: refs/heads/master@{#416431}

BUG=598073, 504347

Review-Url: https://codereview.chromium.org/2302873005
Cr-Commit-Position: refs/heads/master@{#416430}

https://pdfium.googlesource.com/pdfium.git/+log/fc1d16f76f17..d21f22e2c07d

$ git log fc1d16f76..d21f22e2c --date=short --no-merges --format='%ad %ae %s'
2016-09-02 tsepez Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.
2016-09-02 tsepez Remove CFX_Matrix::Copy() in favor of assignment
2016-09-02 tsepez Make CPDF_GeneralStateData private.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2305173002
Cr-Commit-Position: refs/heads/master@{#416429}

And tidy up proguard_config -> proguard_preprocess_config rename

Verified locally that ChromePublic.apk had no size change from
this patch.

BUG=640836

Review-Url: https://codereview.chromium.org/2310473002
Cr-Commit-Position: refs/heads/master@{#416428}

BUG=641594

Review-Url: https://codereview.chromium.org/2286883003
Cr-Commit-Position: refs/heads/master@{#416427}

CancelPendingSeek() was called from the render thread, but the
WeakFactory in FFmpegDemuxer is for use on the media thread.

BUG=643441
TEST=none

Review-Url: https://codereview.chromium.org/2305923002
Cr-Commit-Position: refs/heads/master@{#416426}

* Improve comments
* Eliminate -webkit-transition that seems to do nothing
* Group related CSS selectors near each other in preparation for combining/modifying them
* Don't use RTL folder images on Mac (see https://cs.chromium.org/chromium/src/chrome/browser/resource_delegate_mac.mm?rcl=0&l=50 )
* Use "x .y" instead of "x > * > .y" when the two will select the same elements, for brevity
* Remove unnecessary size arg to getFaviconImageSet() (matches default value)
* Don't use the name "scale_factor" for floats relating to scale, as "scale" and "scale factor" are distinct concepts.  Use "scale" when that's what is meant.
* Avoid unnecessary using directives.
* Use a helper function to avoid repeating the same multi-part conditional
* NULL -> nullptr
* Improve function and variable names
* Eliminate NOTREACHED() that can, in fact, be reached

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2278423002
Cr-Commit-Position: refs/heads/master@{#416425}

Delete corresponding GYP files.

TBR=dpranke
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2304303002
Cr-Commit-Position: refs/heads/master@{#416424}

OSCrypt can now save its encryption password in gnome-keyring, where
that library exists.

BUG=602624

Review-Url: https://codereview.chromium.org/2297573002
Cr-Commit-Position: refs/heads/master@{#416423}

https://pdfium.googlesource.com/pdfium.git/+log/bbee445c5a77..fc1d16f76f17

$ git log bbee445c5..fc1d16f76 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 tsepez Make CPDF_Path have a CFX_Path rather than inheriting

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2302743005
Cr-Commit-Position: refs/heads/master@{#416422}

BUG=609156

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2306183002
Cr-Commit-Position: refs/heads/master@{#416421}

invalidateCaret() once had another caller, but that day is long gone, as in, yesterday.

Review-Url: https://codereview.chromium.org/2306813004
Cr-Commit-Position: refs/heads/master@{#416420}

Made changes so that MacViews can accept drops from
other applications.

BUG=599585

Review-Url: https://codereview.chromium.org/2307633002
Cr-Commit-Position: refs/heads/master@{#416419}

This inlines the .gypi variables and deletes the obsolete files.

TBR=dpranke

Review-Url: https://codereview.chromium.org/2308173002
Cr-Commit-Position: refs/heads/master@{#416418}

BUG=635203

Review-Url: https://codereview.chromium.org/2272493002
Cr-Commit-Position: refs/heads/master@{#416417}

When building midi_manager_winrt.cc, following warning is raised:
warning C4467: usage of ATL attributes is deprecated.

Attributed ATL code has been deprecated. New code style can be found in
https://msdn.microsoft.com/en-us/library/mt723604.aspx.

BUG=512433

Review-Url: https://codereview.chromium.org/2301523008
Cr-Commit-Position: refs/heads/master@{#416416}

This CL adds RenderStub and RenderCallback interface for GlDisplay in
preparation of moving render controlling logic out of DesktopView and
removing GlDesktopView.

BUG=641123

Review-Url: https://codereview.chromium.org/2282783003
Cr-Commit-Position: refs/heads/master@{#416415}

https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6

$ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2307183002
Cr-Commit-Position: refs/heads/master@{#416414}

This adds IsAttributePresented which checks the present of an attribute by the
given attribute ID.

BUG=b:29314637
TEST=call IsAttributePresented on a predefined service record

Review-Url: https://codereview.chromium.org/2302963002
Cr-Commit-Position: refs/heads/master@{#416413}

Make sure Tab gets notified of Blimp start and stop loading states so
that it can decide whether or not to show NativePages or BlimpContents.
BUG=

Review-Url: https://codereview.chromium.org/2300103004
Cr-Commit-Position: refs/heads/master@{#416412}

CL ca3656dc added the --wm-user-time-ms command line argument so that
window activation would be more reliable.  However, its implementation
was awkward and complex, and is no longer needed now that
X11EventSource::GetTimestamp() provides the correct functionality.

Explanation: X11EventSource::GetTimestamp() gives the timestamp of the
event currently being dispatched.  If there's no event being
dispatched, or the event does not have a timestamp, we fall back on
making a round trip.  Simply using last_seen_server_time like we did
with activation before ca3656dc meant that the timestamp we used could
be out of date if we were activating in response to anything other
than a user input event.  This is what led to the --wm-user-time-ms
hack.

Review-Url: https://codereview.chromium.org/2287583003
Cr-Commit-Position: refs/heads/master@{#416411}

This change addresses comments left on
https://codereview.chromium.org/2277553002/ after it was checked in.

The comments were around improvements to the switch used to set the
current authenticator state.  I addressed them by removing the default
case (and leaving a comment on why) and moving the success case into the
switch.

BUG=617185

Review-Url: https://codereview.chromium.org/2308133002
Cr-Commit-Position: refs/heads/master@{#416410}

BUG=640294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2274733002
Cr-Commit-Position: refs/heads/master@{#416409}

With more functionalities added to BluetoothChooserController,
it is necessary to add unit test to it.

BUG=639163

Review-Url: https://codereview.chromium.org/2275173002
Cr-Commit-Position: refs/heads/master@{#416408}

Revert of Quic: add unittests for reduced PING Timeout (patchset #2 id:20001 of https://codereview.chromium.org/2307933003/ )

Reason for revert:
Broke cronet compile:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/1164

../../net/quic/core/quic_connection_test.cc:2980:8: error: redefinition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test'
 TEST_P(QuicConnectionTest, ReducedPingTimeout) {
        ^
../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_'
   test_case_name##_##test_name##_Test
   ^
../../net/quic/core/quic_connection_test.cc:2980:1: note: in expansion of macro 'TEST_P'
 TEST_P(QuicConnectionTest, ReducedPingTimeout) {
 ^
../../net/quic/core/quic_connection_test.cc:2935:8: error: previous definition of 'class net::test::{anonymous}::QuicConnectionTest_ReducedPingTimeout_Test'
 TEST_P(QuicConnectionTest, ReducedPingTimeout) {
        ^
../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note: in definition of macro 'GTEST_TEST_CLASS_NAME_'
   test_case_name##_##test_name##_Test
   ^
../../net/quic/core/quic_connection_test.cc:2935:1: note: in expansion of macro 'TEST_P'
 TEST_P(QuicConnectionTest, ReducedPingTimeout) {
 ^

Original issue's description:
> Quic: add unittests for reduced PING Timeout
>
> BUG=
>
> Committed: https://crrev.com/df9cb098cf816fb589e0ad6627012b524c78e9eb
> Cr-Commit-Position: refs/heads/master@{#416401}

TBR=rch@chromium.org,zhongyi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2296393005
Cr-Commit-Position: refs/heads/master@{#416407}

This avoids some issues with showing multiple palettes at the same time since each palette tool has some state that needs to be synchronized across each instance.

TEST=ash_unittests
BUG=642887

Review-Url: https://codereview.chromium.org/2297393002
Cr-Commit-Position: refs/heads/master@{#416406}

This is in its own commit so that the commits for the two Page Info sections are easier to understand.

BUG=512442

Review-Url: https://codereview.chromium.org/2283753003
Cr-Commit-Position: refs/heads/master@{#416405}

The purpose of this CL is to remove unnecessary blocking on UI thread which
happens when BrowserViewRenderer sends a synchronous IPC message to get the
next hardware frame. This new implementation instead sends an async message
and receives the frame with another async message from render thread.
This change alone is not sufficient as it causes scroll latency.
The async implementation is turned on by command line param.

Review-Url: https://codereview.chromium.org/2174203002
Cr-Commit-Position: refs/heads/master@{#416404}

Also move the list of quic flags and their values into quic_flags_list.h which can be #included elsewhere.

Review-Url: https://codereview.chromium.org/2306173003
Cr-Commit-Position: refs/heads/master@{#416403}

Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ )

Reason for revert:
Relanding after fixing android webview issues

Original issue's description:
> Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ )
>
> Reason for revert:
> Speculative revert for failing WebView tests on Lollipop:
>
> https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794
> https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054
>
> Both phone and tablet started failing and this is the most "suspicious" change.  boliu@ can help investigate further assuming this holds true.
>
> Original issue's description:
> > Default enable main frame before activation and remove finch experiment.
> >
> > The finch experiment hasn't revealed any regressions other than in page
> > load times which has been deemed a blink scheduler issue (see
> > crbug.com/614482).
> >
> > R=piman@chromium.org,rkaplow@chromium.org
> > BUG=612596
> >
> > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed
> > Cr-Commit-Position: refs/heads/master@{#406916}
>
> TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=612596
>
> Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44
> Cr-Commit-Position: refs/heads/master@{#407003}

TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org
BUG=612596

Review-Url: https://codereview.chromium.org/2184243003
Cr-Commit-Position: refs/heads/master@{#416402}

BUG=

Review-Url: https://codereview.chromium.org/2307933003
Cr-Commit-Position: refs/heads/master@{#416401}

BUG=

Review-Url: https://codereview.chromium.org/2307933003
Cr-Commit-Position: refs/heads/master@{#416400}