- 12 Jul, 2019 40 commits
-
-
Rayan Kanso authored
Check that the icon is valid and within the size limits, and also that the launch URL is valid and belongs to the renderer's origin. Remove the `SERVICE_WORKER_UNAVAILABLE` error since it's unused. Bug: 973844 Change-Id: I59f47602174fe5310713460adf50c5f85ebe1459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698405 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677026}
-
Devlin Cronin authored
Antony is no longer doing Chromium reviews. Bug: None Change-Id: I18eaba51859e55a512a351bc873387693f856de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700283Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677025}
-
Roman Sorokin authored
Will enable the tests in a follow-up CL Bug: 911154 Change-Id: I9741e55cacb4522fdcfedb4c090b7007ef50b9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697608Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677024}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/06ab6e5b1330..2a1d8c2b1d32 git log 06ab6e5b1330..2a1d8c2b1d32 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 cwallez@chromium.org Remove ShaderStage that doesn't exist in WebGPU. Created with: gclient setdep -r src/third_party/dawn@2a1d8c2b1d32 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Id1e17c2ad8ef6966c17063f6850752834bbd20f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677023}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c146083d510..214323b343e9 git log 7c146083d510..214323b343e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 vapier@chromium.org [Typ] fix artifact test encoding 2019-07-12 vapier@chromium.org [Typ] clean up obsolete codereview.settings Created with: gclient setdep -r src/third_party/catapult@214323b343e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:983432,chromium:983432 TBR=zhanliang@google.com Change-Id: Iee8a560f09253ebdb96272e75f1a851a328e9133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699408Reviewed-by:
-
Mei Liang authored
In addition, this CL hides the tab switcher button on the top toolbar when duet and clank to start are enabled. Change-Id: Id7f24a5708e9f6136c71346e19e0cd9715d877f7 Bug: 979325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700282Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677021}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01d04fac7548..24192c267a40 git log 01d04fac7548..24192c267a40 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 ivoc@webrtc.org Revert "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker." 2019-07-12 mbonadei@webrtc.org Revert "Remove the injectable bitrate allocation strategy API." 2019-07-12 philipel@webrtc.org Use nalus_length instead of is_first_packet_in_frame to insert startcodes in the H264SpsPpsTracker. 2019-07-12 mbonadei@webrtc.org Use -Wno-undef to compile jsoncpp. 2019-07-12 henrika@webrtc.org Minor modifications for ADM2 on Windows. 2019-07-12 ilnik@webrtc.org Partially revert of ColorSpace information copying around decoders 2019-07-12 mbonadei@webrtc.org Revert "Reland "Add ability to set RTCP sender ssrc at construction time"" Created with: gclient setdep -r src/third_party/webrtc@24192c267a40 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:982260,chromium:none,chromium:982486 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib59f3238d9051158b0b573e4680ae2bee012dbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699407Reviewed-by:
-
Kyle Milka authored
This histogram is no longer useful. Bug: 975798 Change-Id: I12ee0e9316e3a0739a10722d3273b4ed85b1aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693815Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#677019}
-
Akihiro Ota authored
This change adds an API to accessibility private called getDisplayLanguage(str), which translates an abbreviated language code into the human-readable string. For example, when calling getDisplayLanguage('fr'), the API would return 'francais'. This change is large and does the following: 1. Adds hooks for accessibilityPrivate API in the renderer to support synchronous calls and returns. 2. Adds unit tests for new API. 3. Adds end-to-end tests for new API. 4. Hooks up the API to ChromeVox, where we prepend the human-readable language string to output when the language switches. 5. Adds tests in ChromeVox to assert new behavior. Bug: 923068 Change-Id: Ie1b9fa446a1b5e2893899dd8ee283dbb462010c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659131 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:Katie Dektar <katie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677018}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2420af4d84b1..8a1cca44b936 git log 2420af4d84b1..8a1cca44b936 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 tsepez@chromium.org Push some page object logic back into appropriate files. 2019-07-12 thestig@chromium.org Roll third_party/freetype/src/ 8cf046c38..b110acba9 (4 commits) 2019-07-12 thestig@chromium.org Add the ability for pdfium_test to use FPDF_LoadMemDocument(). 2019-07-12 thestig@chromium.org Roll third_party/skia/ 520f85b55..34d63e6b4 (801 commits; 178 trivial rolls) 2019-07-12 thestig@chromium.org Update skcms.h includes to its new location. 2019-07-12 thestig@chromium.org Use more Google-style C++ variable names in RenderPdf(). Created with: gclient setdep -r src/third_party/pdfium@8a1cca44b936 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id9e68f5031c3326edb8bf98874c838efea661e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699595Reviewed-by:
-
Nate Fischer authored
No change to logic, only docs. This resolves a TODO to explain how to determine device API level. Bug: 956316 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I00df52d2930b145d5569b4bc5b97064ded24647a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699259Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#677016}
-
Ben Kelly authored
Bug: 975077 Change-Id: Ia8eda9dab4e6fde47470bc5417ad5cc947307556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692156Reviewed-by:
-
Gabriel Charette authored
A nested Run() wouldn't auto-advance time as expected. This is an edge case but it's surprising when it doesn't. Turns out we didn't need the SetAutoAdvanceOnIdle(false) logic as RunUntilIdle()'s relies strictly on RunUntilIdle() which already quits when idle per the request to MaybeFastForwardToNextTask(/* quit_when_idle_requested */ true). Also removed the new extra large comment on what happens in nested FastForwardBy(). It detracted from the main purpose of the method and 99.9% of the time, there's no nesting. R=fdoray@chromium.org Bug: 946657 Change-Id: I8f2141c36023a577336bdb7301fd841068bb9313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698651 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#677014}
-
Jian Li authored
Stylesheets defined in html import is not incorporated into master document. So we need to handle them separately. Bug: 981196 Change-Id: I6e1d94e59df6d0a57a17570405de119b5192106c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698983 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#677013}
-
Eli Ribble authored
When generating a license we scan the third_party directories for their README.chromium files. Before this change any directory that was missing either a special exception or a README.chromium file would lead to an unhandled LicenseError. Now we simply message that a particular directory was missing the file and exit cleanly. GenerateLicenseFile only ever returned success, so I removed the boolean return value in favor of just using exception handling. Bug: 983599 Change-Id: I8f9db3787cbfc527639f047e5388bcc63749b46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699729 Commit-Queue: Eli Ribble <eliribble@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#677012}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 616447 Change-Id: Id2576315fc6e0315be1375351fdbd9aabc9e8325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636062 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#677011}
-
Brandon Wylie authored
Bug: 943593 Change-Id: Ie5197a5a491c30758179b1af279b9c0374f2b9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700115Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#677010}
-
Brian Sheedy authored
Updates the VR HTTP/HTTPS golden images to pick up a change in the capitalization of "Site Settings". The N updates are handled in crrev.com/c/1700047. TBR=alcooper@chromium.org Bug: 983569 Change-Id: I3cc4981d53c333cae4c947f04667bf3e9452fa9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700301Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#677009}
-
Min Qin authored
If intermediate download file was deleted during resumption, we need to generate the file path again. Currently Android always overwrite the existing file on resumption, and non-dangerous intermediate file is simply generated by appending ".crdownload" to the final target. So this CL just implements the above logic in reduced mode. BUG=983228 Change-Id: Ib856eadbd0fe1252e76ea5547c9edcbb423da45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699365 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#677008}
-
Devlin Cronin authored
Instead of registering the pageAction and browserAction API functions manually in ExtensionActionAPI's ctor, have them registered through the typical generated code by telling the schema compiler where the functions are implemented. Bug: None Change-Id: Ice1e0e4d2e9f2acb246b00e07d2a7d68c11b691a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691786 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#677007}
-
John Delaney authored
This test is flaky on all platforms for non-obvious reasons. Disable on all platforms. Bug: 983586 Change-Id: I942274fbe62c1b25533ecc1e68cdf83107a3bdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700262Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#677006}
-
Nick Diego Yamane authored
As part of large refactoring in X11 code, crrev.com/c/1695008 introduces ui::XWindow, a reusable X11 Window class extracted from views::DesktopWindowTreeHostX11, it also modified DWTHX11 to leverage ui::XWindow, making it more like DesktopWindowTreeHostPlatform, which uses Ozone/PlatformWindow to abstract platform-specific window implementation. This CL does an initial refactoring in X11WindowOzone, so that it starts using ui::XWindow to back its PlatformWindow implementation, which already fixes previous broken functionality, such as window activation. Other improvements/fixes will be addressed in followup patches. Bug: 981606, 789065 Change-Id: I9f7f686bbcaa51d391e77ce77b5dcfd15c91dc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698263Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#677005}
-
Mounir Lamouri authored
Bug: 967484 Change-Id: Ic497e75c48c491f0ac0f58e373757beb684ddf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691246Reviewed-by:
-
Eric Stevenson authored
That CL added a check that forces all code paths that query the list of locale paks to have explicitly set the list of pak locales. Test: chromium_linker_test_apk runs successfully. Bug: 960025 Change-Id: I622b3b0679ea385bc8fa4b6848b2f7623f27cb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699510 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#677003}
-
Pavel Yatsuk authored
I'm trying to eliminate causes of crbug.com/978183. - References in ToolbarManager and TopToolbarCoordinator can be made final, they are set in ctor and never changed. - Reference in TopToolbarController cannot be null. I'm removing checks for nullness. R=twellington@chromium.org Change-Id: I4bcf9072fc63c023a0c912cd536ad51203d8b46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700289Reviewed-by:
-
Min Qin authored
If native DownloadManagerService is created, we should use GetDownload() to retrieve the DownloadItem. As that method works safely in reduced mode. BUG=983073 Change-Id: I2a63217d85ed49b672980de45e7712447b2bc2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699792Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677001}
-
Ahmed Fakhry authored
See issue 970324 for details. The new keyboard shortcuts are: Search+Shift+= : New desk. Search+Shift+- : Remove desk. Search+] : Activate desk on the right (if any). Search+[ : Activate desk on the left (if any). Search+Shift+] : Move active window (or highlighted window in overview) to desk on the right (if any). Search+Shift+[ : Move active window (or highlighted window in overview) to desk on the left (if any). for minor change in c/b/ui/ash: TBR=sky@chromium.org BUG=866622, 970324 Change-Id: I4ba22219e35f1a07b6714ae88710ed46b06e44dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696903Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#677000}
-
W. James MacLean authored
It seems that RenderWidgetHostViewAura::ExtendSelectionAndDelete fails to respect the active widget of the TextInputManager, and since different widgets can have completely separate FrameTrees, getting the correct focused frame relies on routing to the active widget. Bug: 971985 Change-Id: I4bf5e21b8d928692a64315fe71a43ea5d874102b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692877 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676999}
-
John Budorick authored
Rather than always being gs://chromium-result-details. Will be used by internal android builders. Change-Id: I9f12ac2c25f64eb77d1a2931382cf252a005edfc Bug: 983644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699598 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#676998}
-
Sky Malice authored
The articles implementation watches for 2+ history rows to be deleted, and if this ever happens, it removes all articles and suppresses automatic refreshes for the next 30 minutes. This is supposed to be watching for time range deletions, which this is not the case here. Since history is not a supported feature on touchless, there isn't much point to actually deleting the history here, so just don't. Bug: 982973 Change-Id: Ia7ab87d2910c0b206a65854ddb3262f936f2631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699370 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#676997}
-
Rakesh Soma authored
non-AD scenarios. Bug: 980030 Change-Id: Ia119a47e3ad0cf5ad134aa474061e9e5678f9f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693203Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#676996}
-
chrome://welcome-win10Hector Carmona authored
Bug: 956680 Change-Id: Idc0df04472e69ab42ab128210d109db6848c8ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699045Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676995}
-
behdad authored
CompositorFrameReportingController will now track a frame's latency until the frame is presented, instead of until the compositor frame is submitted. Change-Id: I3258c550a1baaa897df8b7c985fbcae46d0b3dd6 Bug: chromium:963778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672201Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676994}
-
Yue Zhang authored
https://crrev.com/c/1659848 uses TabModelFilter.getCount() to decide whether we have incognito tabs or not. However, this doesn't work in the case where we use "Close incognito tabs" in the menu to close all incognito tabs. This is because when we call closeAllTabs() to close all incognito tabs, the tab model selection changes, which triggers onIncognitoStateChanged(), which actually happens after the first incognito tab is closed. So if there are multiple incognito tabs, there is a state where the incognito state is changed but not all incognito tabs are closed. This CL fixes this issue. Bug: 977546 Change-Id: I65114ecfc168c04eb6533dbafd3070684d9c6a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684214 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676993}
-
chrome://discardsRyan Powell authored
Added field "state_change_time" to discards.mojom, which is initialized in discards_ui.cc:GetTabDiscardsInfo(). Since TimeTicks are not measured from a constant origin, TimeTicks::UnixEpoch() is called and subtracted from the lifecycle_unit StateChangeTime. This subtraction results in a TimeDelta, so in order to print the time in a human-readable way the internal microseconds value is accessed and converted to milliseconds and then used to initialize a javascript Date object. Change-Id: Ie63e4587462c1f2c1a1411c932eb420ca33bf161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680731 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#676992}
-
François Doray authored
This is required to expose the opt-in/opt-out trials on the public developer console (https://developers.chrome.com/origintrials/#/trials/active). Bug: 844426 Change-Id: I1d44bf87fd10660fcf30d7c97c4beff05b41482b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691041 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676991}
-
Toby H authored
Removed calls to RunAllPendingInMessageLoop() because not necessary to pass tests and to satisfy pre-submit warnings Bug: 943208 Change-Id: I3da66ab11f80ef6c7e5c66c524d0e9b09baa372f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696276Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676990}
-
yilkal authored
This cl merges the DefaultShelfView into ShelfView class. Bug: 977019 Change-Id: Ia02e0b3a2a122785fdcc9dfc5a7456ccdf0e448b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699202 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#676989}
-
Sahel Sharify authored
The transactions fall into one of the three categories after converting the to the approximated USD equivalent: 1-zero transactions (==0) 2-micro transactions (<=1$) 3-regular transactions (>1$) TBR=msramek@chromium.org Bug: 970597 Change-Id: Ie4f8c5d6ea75900f37cd11ab85cf068c82267979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659016 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676988}
-
Wei-Yin Chen (陳威尹) authored
When the transition animation to Grid Tab Switcher (GTS) is disabled, the thumbnail of the current tab is already updated when showing the grid view. There is no need to force update it again after GTS has finished showing. However, this is still needed when the animation is enabled because the downsampled thumbnail is not written to cache. This CL makes non-animation tests less flaky. Animation tests are still flaky because the 2nd capturing might be skipped if the 1st one takes too long. Bug: 964406, 983448 Change-Id: Iabc8d360707fe78c3dea2b6e02c687c7d5b3bfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694929Reviewed-by:
-
