GitLab

It's always true, so we can remove some checks and unused code.

We can actually remove MaybeCheckCSP method, but it has some
valuable comments. We'll remove it either by removing the comments
or finding a better place for them.

Bug: 789577
Change-Id: I891407ad35230be936164acdfbe26f6123c3a0a9
Reviewed-on: https://chromium-review.googlesource.com/1037804
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555384}

This reverts commit 1cd5356f.

Reason for revert: Breaks tree with error
ninja: Entering directory `/b/c/b/ios_simulator/src/out/Debug-iphonesimulator'
ninja: error: '../../ios/chrome/browser/ui/authentication/resources/identity_picker_view_arrow_down.imageset/Contents.json', needed by 'gen/ios/chrome/browser/ui/authentication/resources/identity_picker_view_arrow_down.xcassets/identity_picker_view_arrow_down.imageset/Contents.json', missing and no known rule to make it
step returned non-zero exit code: 1

Original change's description:
> [iOS] Adding unified consent dir
> 
> Moving all files related to unified consent into:
> ios/chrome/browser/ui/authentication/unified_consent/
> 
> Bug: 827072
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I36bbca2d9f3392da5243e524bdc2276ba35d906d
> Reviewed-on: https://chromium-review.googlesource.com/1039187
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555375}

TBR=msarda@chromium.org,jlebel@chromium.org

Change-Id: I7cbba26291b97afbe4206b31fe39ad7c8079b070
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1039745Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555383}

This fixes ReloadPostNavigation and ForwardPostNavigation from
navigation_and_load_callbacks_inttest with WKBasedNavigationManager.

Bug: 807428
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7fd87c0a04c896570daa0ad35c6324867465702b
Reviewed-on: https://chromium-review.googlesource.com/1038655
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555382}

This CL updates the string used for Unified Consent in the welcome page
and in the settings sign-in and sync promos.

Bug: 820585
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib575cd6307440a7e92379940f41c862b13578d1d
Reviewed-on: https://chromium-review.googlesource.com/1019324
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555381}

Now that input mode has shipped in a stable release remove the setting.

BUG=642800

Change-Id: I0aecb0261ba17be7bd911fc2c420d0e3c5dd783f
Reviewed-on: https://chromium-review.googlesource.com/1037983Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555380}

Remove owners who've left Chrome and add myself.

Change-Id: Icd28c0432ba688b4e5cff23310425e93f3d7ab09
Reviewed-on: https://chromium-review.googlesource.com/1037934Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555379}

Only straightforward usage has been removed, identified with regexp
"URL.createObjectURL.*stream".

Bug: 800767
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I83d563080b2f534e7d9e3062b1633017dc9a01a8
Reviewed-on: https://chromium-review.googlesource.com/878741
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555378}

CreateRequest() needs to take in a traffic annotation.

Bug: 837333
Change-Id: Iaa4b8e0cbff89a4ffff4afef9c9cc6accdaba26f
Reviewed-on: https://chromium-review.googlesource.com/1039124Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555377}

By default VC++ doesn't like having a variable declared with extern
const and then defined with constexpr. They have a switch to allow this
but it's off by default. In this case constexpr was not intended or
necessary and is inconsistent with nearby definitions so removing it is
reasonable. Long-term we can eventually switch to /Zc:constExpr to make
the const/constexpr mixing legal.

This was reported by the VC++ team who still use Chromium as the best
compiler test suite ever.

Change-Id: I9a1463c37495a9532ecc2f0b1bbbef5ff9ecd999
Reviewed-on: https://chromium-review.googlesource.com/1039193Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555376}

Moving all files related to unified consent into:
ios/chrome/browser/ui/authentication/unified_consent/

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I36bbca2d9f3392da5243e524bdc2276ba35d906d
Reviewed-on: https://chromium-review.googlesource.com/1039187
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555375}

TBR=sergeyberezin@chromium.org

Bug: chromium:838854
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idbbfc62396a4676737146671be714e5302a45063
Reviewed-on: https://chromium-review.googlesource.com/1039565Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555374}

Seems the field trial config was left around even though this feature
was removed.

Change-Id: Id718a32c1e3e2397ac995547e0fa83d939d34ee8
Reviewed-on: https://chromium-review.googlesource.com/1037808Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555373}

The fix is to use BrowserNativeWidgetWindow only for tabbed windows.

Bug: 769327
Change-Id: Ice36d327c2c27411ed2a4d15a8c6a78a9e55e347
Reviewed-on: https://chromium-review.googlesource.com/1038545Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555372}

The ModelTypeSet(ModelType) constructor does not create a
ModelTypeSet containing only ModelType.
On debug builds, the variable initializations of bitset to 0 make the
test working as expected.
On release builds, the preferred data types is set to a random value.
Fix by calling an explicit ModelTypeSet constructor.

Bug: 837553
Change-Id: I55c83a16ce391fdc908f0247d2dd1c7e510d54d7
Reviewed-on: https://chromium-review.googlesource.com/1039192Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555371}

Using wpt-import in Chromium e3e32d3d.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
7dea9b2c "[css-grid] Subtract scrollbar in ComputeReplacedLogicalHeightUsing()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16684

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=kereliuk

No-Export: true
Change-Id: I2fd899568bca26164c2410322e1dbd4bb1282af0
Reviewed-on: https://chromium-review.googlesource.com/1039244
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555370}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2194d161..99550832

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1f04861e6bc6f416a23294bc2595185fc7e7b7c1
Reviewed-on: https://chromium-review.googlesource.com/1038914Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555369}

TBR=jbudorick@chromium.org

Bug: 828031
Change-Id: If91d7f84eacb767e49899bf697b12957cbf64f8a
Reviewed-on: https://chromium-review.googlesource.com/1039605Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555368}

https://skia.googlesource.com/skia.git/+log/3fef39d94d2a..eaded9d09c31

$ git log 3fef39d94..eaded9d09 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 robertphillips Fix DDL blur image filter

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Idc47520cdc406b9fee3347c4538e35d43994334c
Reviewed-on: https://chromium-review.googlesource.com/1039070Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555367}

All code in third_party/WebKit/Tools/Scripts was moved to
third_party/blink/tools.
This CL also fixes references to old names of scripts in Tools/Scripts.

* third_party/WebKit/PRESUBMIT.py:
 Remove dead code. This PRESUBMIT.py doesn't use
 |audit_non_blink_usage|.

Bug: 829697
Change-Id: I6c482a795708fa207124cb2030a4fdaa8ceac343
Reviewed-on: https://chromium-review.googlesource.com/1038863Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555366}

It seems like the issue with the v8::Locker has been fixed at some
point. I cannot reproduce the issue anymore.

Bug: chromium:189177
Change-Id: Ie2929429735dc0b08dc7241986e7a95cf9d6c845
Reviewed-on: https://chromium-review.googlesource.com/1034685
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555365}

When closing the window on Mac via the system menus, Textfields can end up
with their caret bounds changed (through a roundabout route) while they
have a context menu open. This causes a reset of the context menu's model
with the runner still referencing the old model, which leads to chaos. To
fix that, reset the runner as well when updating the bounds.

Bug: 837767
Change-Id: Id955d84c525f8d71121414f2784f216b4d9e6a65
Reviewed-on: https://chromium-review.googlesource.com/1037404Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555364}

This patch fixes a bug to update the selected identity when the identity
list is updated.

Related to:
crrev.com/c/1025895

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I772d3be25f6b280370c9d949487a7c2570fa6fc4
Reviewed-on: https://chromium-review.googlesource.com/1032741
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555363}

Some DNS transaction tests require ScopedTaskEnvironment(MainThreadType::IO),
some require ScopedTaskEnvironment(MainThreadType::MockTime). Factor out
common stuff to DnsTransactionTestBase and create two derived test classes.

This is prework for https://crrev.com/c/1037405.

Bug: 791831
Change-Id: I4e8c1b94f41d824a467fc0cee8349c821662721f
Reviewed-on: https://chromium-review.googlesource.com/1037703Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555362}

The callback should only be called after the notification close event
has completed. This change postpones execution of the callback until
the proper time.

I had to add some workarounds because for some reason it seems the
callback does not now get called from tests.

R=peter@chromium.org

Bug: 787459
Change-Id: I4450d54894f79f3e83581686965a328ef961e383
Reviewed-on: https://chromium-review.googlesource.com/1018461
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555361}

NewPasswordFormManager (details go/new-cpm-design-refactoring) will
send a fill message to the Renderer. This CL extracts this logic
from PasswordFormManager and PasswordManager to the separate file,
without changing any logic so that NewPasswordFormManager can reuse it.

Since now it is in a separate function, we can test it separately.
So unit tests were written.

Bug: 831123
Change-Id: Ibc448d7c287b1599bbbd8a721ca36a464b5b4a48
Reviewed-on: https://chromium-review.googlesource.com/1026111
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555360}

Part of elimination DMTokenStorage effort. DMToken will be stored in
the device policy. Same as for cloud management.

BUG=chromium:809914
TEST=existing unit and browsertests

Change-Id: I90c6417399f55d07bbb815db76c365593cfe88e6
Reviewed-on: https://chromium-review.googlesource.com/1019326
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555359}

This patch modifies the behavior of ChromeSigninViewController to
support the user UnifiedUserConsentCoordinator if the
signin::kUnifiedConsent flag is enabled.

ChromeSigninViewController has 3 main states:
  - IDENTITY_PICKER_STATE
  - SIGNIN_PENDING_STATE
  - IDENTITY_SELECTED_STATE

UnifiedUserConsentViewController is shown in IDENTITY_PICKER_STATE.
Once the primary button (of ChromeSigninViewController) is pressed, the
sign-in starts using SIGNIN_PENDING_STATE.
After the sign-in is done, -[acceptSignInAndCommitSyncChanges] is called
called to finish.
IDENTITY_SELECTED_STATE state is not used for unified user consent.

Related patch:
crrev.com/c/995417
crrev.com/c/1009906

Screenshots:
https://drive.google.com/open?id=1-fg35E2myznknRMauJN3HxAu-j_FARfD
https://drive.google.com/open?id=1hGTTqKGQCihp2EN-zgIWrLDsdjzfPNV-
https://drive.google.com/open?id=1EI1VPXtpJ4c1oW1hunkGvdYXB_Fw1EhW

Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g353bc22139_3_19

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1545ed03f38ebb8868e84577ae19adea61d80be1
Reviewed-on: https://chromium-review.googlesource.com/1010346
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555358}

Unify FrameSchedulerImpl's UpdateTaskQueues, UpdateTaskQueue,
UpdateThrottlingState and UpdateTaskQueueThrottling methods.

R=alexclarke@chromium.org

Change-Id: Iecdbe636511626e681afd17fca6224a1dfdc90fd
Reviewed-on: https://chromium-review.googlesource.com/1039194Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555357}

https://chromium.googlesource.com/catapult.git/+log/5b642efe8459..86d3e79d8882

$ git log 5b642efe8..86d3e79d8 --date=short --no-merges --format='%ad %ae %s'
2018-05-02 mattcary [Tracing] Android native library resident size statistics.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:758566


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I9887f72a3ecf93a97d56d4cc4b6ffb4b6f4b59b1
Reviewed-on: https://chromium-review.googlesource.com/1039264
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555356}

These methods are not used outside tests that verify their functionality.
Time to remove them 🔪⏰.


Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaad6cd50ae9f69b8d20e06e0b9274b5f6909539e
Reviewed-on: https://chromium-review.googlesource.com/1036259Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555355}

This is a preparation CL to migrate
OneGoogleBarFetcherImpl::AuthenticatedURLFetcher from using URLFetcher
to SimpleURLLoader.

In practice, when creating an OneGoogleBarFetcherImpl instance, we need
to pass the |api_url_override| as a parameter. When running SimpleURLLoader and
EmbeddedTestServer (for unit testing), we can only set the proper
|api_url_override| value after EmbeddedTestServer is instantiated, which
will happen from ::SetUp (see [1]).

This CL prepares the ground for it. No functionality change.

[1] https://crrev.com/c/1031450/

BUG=773295

Change-Id: Iebd0d8dc0134a343e5187812982b6b5570f3ebe3
Reviewed-on: https://chromium-review.googlesource.com/1035862
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555354}

These tests were filtered due to threading issues in the production
code leading to crash flakes.

Bug: 813795, 827450
Change-Id: I1c5f69a3d26e23eec5e25c391bfe20422252c360
Reviewed-on: https://chromium-review.googlesource.com/1039068Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555353}

This CL adds a check to help investigate crbug.com/826627. The assumption
is that merge_.start_interpolable_value is turning out to be nullptr in the
TransitionInterpolation constructor. Working this backwards, it appears
that the only way this could happen is if SetValue was called with a
TypedInterpolationValue that had no interpolable value stored within it.

Bug: 826627
Change-Id: I3c5159fa0314bf5651bdbda68ef9c97b5a1a567c
Reviewed-on: https://chromium-review.googlesource.com/1032874Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555352}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/43880122c4f3..d45ce7d90232

$ git log 43880122c..d45ce7d90 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 emaxx cryptohome: Delete obsolete challenge-response APIs
2018-04-19 hashimoto Add constants for ArcAppFuseProvider

Created with:
  roll-dep src/third_party/cros_system_api

BUG=837161
BUG=806788

Change-Id: I31ebc9bd3b5338fcd69a61848054ab50ec0d63b7
Reviewed-on: https://chromium-review.googlesource.com/1039306Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555351}

https://chromium.googlesource.com/angle/angle.git/+log/57d9cbb67f2d..9aef81c7cec0

$ git log 57d9cbb67..9aef81c7c --date=short --no-merges --format='%ad %ae %s'
2018-04-30 oetuaho Validate blitFramebuffer for overflows on all platforms
2018-04-26 oetuaho Clean up BlitGL

Created with:
  roll-dep src/third_party/angle
BUG=chromium:830046,chromium:830046


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If5d19b20e6dc7096d7724d9fac6702427f560351
Reviewed-on: https://chromium-review.googlesource.com/1039067Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555350}

Ran into an "unimplemented" message from
RenderWidgetHostViewBase::GetCaptureSequenceNumber()
when trying to run Layout Tests using SwiftShader on
MacOS. The implementation for RenderWidgetHostViewMac
is a copy of the implementation done in
RenderWidgetHostViewAura. It appears to work properly.

Bug: chromium:726075
Change-Id: I45f3a9f213e9f1c1d3f733ca9238c80c2b94dd22
Reviewed-on: https://chromium-review.googlesource.com/1035142Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555349}

The solution to this was kind of subtle. Here are some notes for posterity:

* ash::Shell::local_state_ (the device PrefService used by Ash) is
  loaded asynchronously, after Shell::Init.
* Display preferences need to be initialized synchronously; there are
  currently too many dependencies to make asynchronous initialization
  robust.
* Thus for 'classic' mode, we need to provide initial display prefs from
  the synchronously loaded browser local state prefs to ash::Shell::Init.
* Registering prefs has to occur early (before feature flags are loaded),
  so using different registration for classic/mus/mash would be
  complicated. Instead we always register display prefs in chrome and
  treat them as foreign prefs in ash (except for tests).
* Because of the complications of pref registration, accessing a second,
  synchronously loaded, PrefService instance in Ash would be difficult.
  Instead we extract a base::Value dictionary of display prefs and pass
  that in ShellInitParams.

This fixes 'classic' mode, but does not solve the problem for mus/mash
(which has never worked). Potential long term solutions:
(a) Store display prefs in an Ash specific value store that is
    synchronously loaded (along with other similar prefs).
(b) Initialize Shell::local_state_ with the initial state before the Mash
    process forks (solving any registration issues this entails).
(c) Make initial display configuration work asynchronously.

Bug: 834775
Change-Id: I75e561394c817e7c93d8c724bdadcaa37ef868af
Reviewed-on: https://chromium-review.googlesource.com/1028479Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555348}

This reverts commit 40ba1dc5.

Reason for revert: Does not fix the problem.

Original change's description:
> Disable caching of video-device enumerations on Mac.
>
> There is an issue with the Mac video device monitor that is causing
> cache inconsistencies.
>
> Bug: 834581
> Change-Id: Idc1a0d953509fee7787fb07d19376d4800f76939
> Reviewed-on: https://chromium-review.googlesource.com/1023855
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552689}

TBR=hbos@chromium.org,guidou@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 834581
Change-Id: I7e46c1a336d03511d97b2c7a02192e3474c9693a
Reviewed-on: https://chromium-review.googlesource.com/1033732
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555347}

This CL changes the background color of the selected items of the Popup
Menu, displayed when the cell is highlighted.

Bug: 834201
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I704837ded09d5bbd35c4beabb188216dc27383ed
Reviewed-on: https://chromium-review.googlesource.com/1039365
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555346}

https://skia.googlesource.com/skia.git/+log/ef4142a9bc5f..3fef39d94d2a

$ git log ef4142a9b..3fef39d94 --date=short --no-merges --format='%ad %ae %s'
2018-05-02 angle-skia-autoroll Roll third_party/externals/angle2/ 57d9cbb67..47155b171 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Iaa49f817fe3b794f02f5bf030a9c2e50a2e9caf5
Reviewed-on: https://chromium-review.googlesource.com/1039069Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555345}