GitLab

Bug 1057571 (broken stencil buffer functionality in WebXR) was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2084067. This commit adds a test for the issue.

Bug: 1057571
Change-Id: I9390aa47a3eabc1d8cf2d0717fb020b70e455ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093391
Commit-Queue: Artem Bolgar <artyom@fb.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748462}

The native MRP was assuming mirroring sessions don't send messages
to the client, which is incorrect.  Fixing that assumption involved
moving quite a bit of functionality from CastActivityRecord to its
base class, ActivityRecord.

Bug: 1047834
Change-Id: Ie35b5d518af78a01451fc6e7b0f13be7024d115c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064813Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: John Williams <jrw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748461}

Bug: 1059102
Change-Id: Ie92e9bbec7584f21e1b6408168be9c558b89003b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092206Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748460}

Change caret image RTL transform CSS rotate(-180deg) to scaleX(-1) for
the same visual result.

Bug: 1035691
Change-Id: I3140cc2356118b27cced786fbad335bab2d6ea6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094903Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748459}

https://chromium.googlesource.com/angle/angle.git/+log/1cd52d2cfe4c..c2d817317046

git log 1cd52d2cfe4c..c2d817317046 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 geofflang@google.com Allow referencing buganizer issues with ANGLE CLs.
2020-03-09 geofflang@google.com Generate arch-specific defines in Android.bp
2020-03-09 geofflang@google.com Improve GN args for generating Android rolls.

Created with:
  gclient setdep -r src/third_party/angle@c2d817317046

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: I5550fb5c96d793c55d4162f3d594d76d23ff5d18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748458}

Some test targets for iOS are shared (for example, basic_unittests).
As all iOS test targets are wrapped with the generate_wrapper
template, we need a mechanism to execute these shared targets
without changing the test type in gn_isolate_map.pyl. Thus,
for iOS, we force tests that are not "generated_script" type to
behave as such by mimicking its behaviour in the GetIsolateCommand.

Change-Id: I67f9fea82f8ac3cfe765441a3cb0e6f4ab61bd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035052
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748457}

This is a reland of c401a7d6, which
should be fine to land now that we have merged
https://chromium-review.googlesource.com/c/chromium/src/+/2089827

Original change's description:
> [tbmv3] Add an integration test for run_tbmv3_metric
>
> Adding a simple smoke test to make sure run_tbmv3_metric does not break
> silently.
>
> Change-Id: I54f4d525e221eef403678034efde505ee19cbc1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078736
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Deep Roy <dproy@chromium.org>
> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
> Commit-Queue: Deep Roy <dproy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747385}

Change-Id: I6fbaa19940658ad17ec805c0b29cca7dd5d9690c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091588Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Deep Roy <dproy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748456}

For now, ignoring importHref() line. Once lazy loading is added for
Polymer 3 settings, this will be updated to be replaced by dynamic
import() instead.

Bug: 1026426
Change-Id: Ib8e6585b7ad8f4b1585635eae3a09a2259c7fdbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091657Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748455}

Add an optional API to check whether the platform can play video with
requested profile/size/framerate smoothly.

Merge-With: eureka-internal/373033

Bug: internal b/150214233
Test: dev console
Change-Id: Ib0886b51a46e3e33a3b9a4dd413b8dd32185b603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094576Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748454}

This change adds a hidden-by-default entry in the passwords settings
UI on Android that triggers the Phone as a Security Key prototype code.

The most important thing to verify about this change is that it doesn't
have any effect unless the user manually sets the flag: the UI is
intended for experimentation and for UX-team to consider at this point.

BUG: 1002262
Change-Id: I17d1077002b53198bc1d2422e28d13c6611dfc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079614
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748453}

Bug: 993895
Change-Id: Id1d68e92f06f00bb6f6b1ea632df34c8f5f76624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095408Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748452}

By default bubbles attempt to mirror when off screen, this change lets LocationBarBubbleDelegateViews that are anchored to icons within the ToolbarAccountIconContainerView to offset instead of mirror. This change makes this the behavior on all desktop platforms, usually Mac and Linux do not adjust bubbles.

Bug: 1056305
Change-Id: Iff14e308ba76673b2269c7bcdece1ba443dc3874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094483
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748451}

Clicking anywhere on the action bar causes the search box to collapse
unless it contains text input.

Change the search box collapse logic to respond to clicks anywhere in
the Files App rather than just the action bar area.

Bug: 1058547, 1002413
Change-Id: I5e09ad4eb7ec3e5bf0b732d45665dbbc6af7bb0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094377Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748450}

The problem is SearchResult kept its own property of is_recommendation_,
instead of using metadata_'s is_recommendation attribute.Therefore, it
is out of sync of ArcAppReinstallAppResult for its is_recommendation setting.

Bug: 1050761
Change-Id: Id5d503b0541626ccfdde7b7a9b8dbc3784cfe655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090835Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748449}

--enable-arc-oobe-optin-no-skip commandline switch is no longer needed
as all Chrome OS devices enable it. This change removes the switch and
makes its behavior the default so we can remove it from the Chrome OS
builds.

Bug: 1059048
Test: OOBE flow on Chromebook
Change-Id: Idf85a61afa34077691edf5d7f261f96c4e81e4f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091652
Auto-Submit: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Long Cheng <lgcheng@google.com>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748448}

https://webrtc.googlesource.com/src.git/+log/4e1d6ce38422..a1ac244222a5

git log 4e1d6ce38422..a1ac244222a5 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b57f55e2..5a78076c (748149:748288)
2020-03-09 aluebs@webrtc.org Remove RTC_NOTREACHED from audio_send_stream when ANA didn't work
2020-03-09 minyue@webrtc.org Add NtpTimeMs as a method in EncodedImage.

Created with:
  gclient setdep -r src/third_party/webrtc@a1ac244222a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I944da2630307a1868a3b961e36246cd3f192a9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748447}

The BubbleDialogDelegateView constructor set margins based on provider
GetDialogInsetsForContentType(TEXT, TEXT).
ExtensionUninstallDialogDelegateView then adjusted these margins.

The WebAppUninstallDialogDelegateView logic is based on
ExtensionUninstallDialogDelegateView, but it doesn't have the same
base class, so it was previously adjusting from 0 margins instead of
adjusting layout provider insets.

We now have consistent margin behavior between
ExtensionUninstallDialogDelegateView and
WebAppUninstallDialogDelegateView.

Bug: 1059166
Change-Id: I97ad4cacdf346b4686c6d76ab38ef84d34a6e871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094917
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748446}

Bug: b/150783279
Test: manual
Change-Id: I9c9e37ff8ec2be5ec5f47af54a751019401d53b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092932
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748445}

And also add services/service_manager/sandbox/linux/ to the
"linux_sandbox" watchlist definition.

Bug: None
Change-Id: Id66946cd60ecb415a540d77fa6be35de0a71948f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093393
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748444}

follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2078738

TBR=hans

Bug: none
Change-Id: I4fb2eebbddd3687849ca87e74479d34e05d3edd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095439Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748443}

Position relative the <span elider> child with 48px size, and shift it
into place for centering.

Bug: 1035691
Change-Id: I06e9b6e0e2ed4527902c25265a709682f013a1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094428
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748442}

When a frame is presented on screen, the frame token may not exactly
match the awaiting-presented main frame token. In this case, our
current code won't count as main frame produced. But instead, we
should count this frame as main frame produced, as long as the
presented frame token is >= any main frame token that is waiting to
be presented.

Bug: 1055848
Change-Id: I5e0fb3e65a6581c8348e5e074cac6fc9a746356f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075040
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748441}

Bug: 1059870
Change-Id: I0ce2c19a24f25b361e21d76b03929187bbed9533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094546Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748440}

This CL disables unmuted video autoplay for webapps. This was
unintentionally enabled in
https://chromium-review.googlesource.com/c/chromium/src/+/1621415

This CL also introduces utility class -
CustomTabActivityTypeTestUtils.java - for running a test against
several activity types and makes CustomTabDeferredStartupTest.java use
it.

BUG=1059579
TEST=CustomTabAutoplayUnmutedTest.*

Change-Id: I5a0446d896f3f9f8337a1e4b4febe4460ab87ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093932
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748439}

The browser-side quota implementation currently lives in
//content/browser/quota_dispatcher_host.{cc,h}. This CL moves it in a
separate directory, to match the rest of the storage features.

The code is intentionally left as-is, to make the CL easy to review.

Bug: 1016065, 1030901
Change-Id: I7d5252bd14527d693611d42a564f19e152485862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095562
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748438}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I50992ba7fca4f0ffef3082ecce82afb0d8aa23d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095161Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748437}

This introduces support for typemaps specified as GN targets, with new
cpp_typemaps and blink_cpp_typemaps variables that mojom() targets can
used to reference their typemap rules.

The underlying work to use the typemap configuration is shared with the
existing typemap infrastructure, but the net result is that we no longer
need separate .typemap files or global "bindings configurations" once
everything is converted to this approach.

NOTE: The original version of this CL used GN's generated_file() target,
which did not properly support MSVC project generation. As this was the
first use of generated_file() for non-Android build rules, it ended up
breaking some Windows developers' builds.

Bug: 1059389
Change-Id: I9ade2071933bdc0384e1b3af1cbc106152b68038
Tbr: oksamyt@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094254
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#748436}

Bug: 1059868
Fixed: 1059868
Change-Id: I18ef0066a357d0eab02568645a02c4f306ae2abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095461Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748435}

Also add some tests.

Bug: b/145555027
Change-Id: I3c155ab9930a2b8fcfbdcbc57f558eda1cb6a080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087876Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#748434}

Removes expected leftover minidumps from several tests that
intentionally crash a Chrome process. This is so that these
intentional crashes are not caught as failures once pre/post test
minidump checking is enabled with crrev.com/c/2090590.

Bug: 1056235
Change-Id: Iad026563b3a7acfc6e2078ffec36a000ed4b2dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080863
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748433}

Bug: 925965
Change-Id: I9f90480657c8ff856555c4d68c687cb7880265e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095411
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748432}

BUG=1040648

Change-Id: I897158eb5098bd08d36b2a37b0a1731909ae51e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095669Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Gil Dekel <gildekel@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748431}

gpu::MemoryTracker is created inside InProcessCommandBuffer and
SkiaOutputSurfaceImplOnGpu. Plumb them out to be shared with
OverlayProcessor.

OverlayProcessor for Android classic only reads the shared image, so
it was not required to plumb the memory tracker correctly. This is in
preparation for other overlay platforms.

TBR=boliu, kylechar
R=rjkroege

Bug: 979788
Change-Id: I73d6d8e34fd7ef9e0c61df3d25ce4e7af954ef54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042385Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748430}

Non-tabbed apps (such as settings) now have the same
themepack color for frame and active_tab.  Previousley,
autogenerated theme pack colors always force these colors
to have some contrast.  In the case of settings, the contrast
color is light grey, and it is the color used for
NTP_BACKGROUND (bg shown until page loads).  Given that there
is no need for frame/active_tab contrast for a non-tabbed app,
it is better to have them both the same color.

Bug: 1053823
Bug: 1059696
Change-Id: Iaf2e6cbf6f3db9fe2c1d98c32692e3e74e8a7ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094484
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748429}

AbstractFile.overwriteOriginal is implemented in the guest context to
send IPC to the privileged host to achieve the file write. To ensure
the correct file is written, a token is passed on IPC load requests.

Only the file that the privileged context determines is "current" may
be written to by the unprivileged guest.

Testing
 - Remove receiver_api.js and depend on receiver.js directly for
   type checking.
 - Mock out the native file system on the host side.
 - Add a test-only IPC to trigger AbstractFile.overwriteOriginal().

Bug: b/146580738
Change-Id: Ie68213e3e1412a2d1fd63d8039d71858f5b4c740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090992
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748428}

These histograms are still relevant from a UX perspective, so this CL
extends their expiry dates to 1 year from now.

Fixed: 1053274,1053275
Change-Id: I9449dc9fa7578b977e2ff174b7b11832968f1a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095061Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#748427}

https://crrev.com/c/2076423 added new templated methods to
base::TaskRunner, which use base::BindOnce and base::Owned. These are
declared in //base/bind.h, which is not included.

This IWYU omission results in occasional compilation errors. Example in
the attached bug.

Bug: 1059591
Change-Id: Ia927ec3fac35966793b801059925d7c950319c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094086
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748426}

A recent change broke this test's intended purpose by moving the point
where it started Chromium. Avoid this happening again in future by
better documenting what the test is actually doing and why.

Change-Id: I1fc3de0bb3b0d63e3c9063aa733fb200a959336e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095441
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748425}

Some of the existing file icons look bad in the chips, because the
chips have a different background colour that results in them being
low-contrast. This CL refactors the file_icon_util.* files to allow
either the original or new icons to be retrieved.

The main change is to split
  GetIconResourceIdForLocalFilePath
into
  GetIconTypeForPath
  GetResourceIdForIconType
  GetChipResourceIdForIconType

The former method took a file path, found correct Icon enum, then found
the correct resource ID for the enum.

The new methods separate out the enum-finding step from the resource-
loading step, so that the Chip function can first try and return a
chip-specific icon, and then fall back to the original icons if needed.

Bug: 1034842
Change-Id: Ia7c3310c771993909f8d8b535229173bedb528d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089182
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748424}

This is inspired on [1], by kinuko@.

[1] https://crrev.com/c/2016524

BUG=704136
R=dcheng@chromium.org, sky@chromium.org

Change-Id: Ic3a503229b346c3236b113804eca0279cff025ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090733
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748423}