- 30 Mar, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a46c6ae7a64f..7dda200ba41b git log a46c6ae7a64f..7dda200ba41b --date=short --no-merges --format='%ad %ae %s' 2019-03-30 dhanyaganesh@chromium.org generic_stages: Stop sending stage_id to test commands 2019-03-30 akeshet@chromium.org test_stages: fix account inference for CQ jobs Created with: gclient setdep -r src/third_party/chromite@7dda200ba41b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5b1a3e5ea79696e1eb7e6754e68fdbae19f46d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646093}
-
Hanfeng Zhu authored
Bug: 946332 Change-Id: Ic418c0b48653a8478e20c678366f125063e305d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546790Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Cr-Commit-Position: refs/heads/master@{#646092}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c826554a049..274c82fc5378 Created with: gclient setdep -r src-internal@274c82fc5378 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ia7cebdd6f96dd12d1492c2d30e49ae475823698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546973Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646091}
-
Andrew MacPherson authored
Now that the AudioContext supports the optional sampleRate parameter MediaStreamTrack data needs to be resampled to this rate and not the hardware rate. Bug: 945305 Change-Id: If34b72f0aee864148aa44531e87e3816ae05a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541078Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#646090}
-
Alex Clarke authored
We want to prioritize because ResourceExtractor is on the critical path. To facilitate the use of traits in ui/ we split UiThreadTaskTraits.java off into a new content_java_task_traits library. Bug: 863341 Change-Id: Ia2adc4ce58480b07a84e4f7e1f96283df2035b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526187Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#646089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bc36bade1e16..21d000094ade git log bc36bade1e16..21d000094ade --date=short --no-merges --format='%ad %ae %s' 2019-03-30 thestig@chromium.org Roll third_party/skia/ ea8900e74..191e64b6c (73 commits) 2019-03-30 thestig@chromium.org Roll tools/clang/ 207fd1e5d..adc6ac450 (14 commits) 2019-03-30 cliffsmo@microsoft.com Update IsGdiAvailable to check for Win32k lockdown Created with: gclient setdep -r src/third_party/pdfium@21d000094ade The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8e8d8ad9a3353280dc8a548a0e980ddfa86dba56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546971Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11eb51b11e4e..5c826554a049 Created with: gclient setdep -r src-internal@5c826554a049 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I830434db19bbf0f57cab78f2ebac46f830ef5cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546970Reviewed-by:
-
Mike West authored
As per the conversation in mikewest/sec-metadata#23 and mikewest/sec-metadata#19, this patch drops the `Sec-Fetch-User` header for non-navigational requests, and for navigational requests that are not user-activated. Bug: 947444 Change-Id: Ica4846bda6ccf4e8bce1323803954f4fef9c18a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545871Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#646086}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59b733715141..265fd3de3527 git log 59b733715141..265fd3de3527 --date=short --no-merges --format='%ad %ae %s' 2019-03-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@265fd3de3527 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I395ec1d47ce40572a7d8e87b6018f2c18182a454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546348Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90699aaf784a..11eb51b11e4e Created with: gclient setdep -r src-internal@11eb51b11e4e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I9794bf84a65de54a51d7b8f9532df7c06b5c0ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546347Reviewed-by:
-
Peter Kasting authored
This is more performant and avoids invalidating outstanding iterators. Bug: none Change-Id: I73a340c6c16ce8f5c9dd0d28e7cd66a9e5f16aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526299 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#646083}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3553b10..ee319536 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3df449d93538aeb4aa20775a35248c3dc4300aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646082}
-
Peter Kasting authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1526311 , AddChildView() was supposedly changed to "always add to end". However, due to an oversight, that didn't actually occur, because it mapped to ReorderChildView(v, child_count()), which would be treated as a no-op. This CL makes ReorderChildView() accept child_count() as a synonym for "add to end", which matches the behavior of AddChildViewAtImpl(), and makes AddChildView(existing_child) actually move to end like the other CL claimed it would. It also allows larger values, since doing so seems harmless, and would be useful if we ever change ReorderChildView() to take |index| as a size_t. Bug: 942298 Change-Id: I5ea26f34f66aeb303e11eceb81490bc4eaaa023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531609 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#646081}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3295c01df233..0c7a9cae28ed git log 3295c01df233..0c7a9cae28ed --date=short --no-merges --format='%ad %ae %s' 2019-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3265fd12..0dd6679b (645967:646074) Created with: gclient setdep -r src/third_party/webrtc@0c7a9cae28ed The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf6cfe12da08e4541750e7a19f8bc0d05b815518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546346Reviewed-by:
-
Peter Kasting authored
The behavior of AddChildView() on an already-existing child is in flux. In this case, either the addition was pointless extra work (likely) or else it caused bugs (less likely); just avoid doing it. Bug: none TBR: jamescook Change-Id: Ifcf5ed631fb7fcdfb89e6f22cb1fe5d9d9d7c0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545515Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#646079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6512b3755d9..90699aaf784a Created with: gclient setdep -r src-internal@90699aaf784a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ic6f981bd1b51ec15068ca08ddc1a67b6a09276cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546345Reviewed-by:
-
Aleks Totic authored
Another fix for "Legacy OOF descendant did not get laid out" The cause here was: - if #container had a legacy descendant, and - legacy descendant had an oof descendant whose containing block was #container, that oof descendant would get added to #container's list of legacy oof, but would never get laid out. This bug was hidden, because it would not happen if layout happened twice, which we often do. Seen in the wild at https://www.humblebundle.com/ when scrolling down. Bug: 946986 Change-Id: I183f3d5dfe79b49c5c6aadad0ee2cfcb8bb6849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546713 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#646077}
-
Findit authored
This reverts commit 6af49b04. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 646061 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmFmNDliMDQ5ZDEwZTMzZTYyNjY0MzY0YjAzNjMzMjE3NjhhOTE0Mww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/22098 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: RecommendAppsScreenTest.SelectionChange Original change's description: > Add browser tests for RecommendAppsScreen > > Note that recommned_apps_fetcher implementation has not really changed, > except for: > * Made RecommendAppsFetcherImpl implement RecommendAppsFetcher > interface > * Moved some logic from RecommentAppsFetcherImpl ctor to newly > introduced Start() method > > Added methods to check whether an element is enabled/disabled to > js_checker, and new methods for checking element visibility that > test element's offsetHeight and offsetWidth - the approach with > checking hidden property does not work for elements that are hidden > using "display: none" CSS (e.g. recommend_apps screen buttons). > > BUG=947203 > > Change-Id: Ib38d07e7f75bed64ff909c927d29d0c2e365c815 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544794 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646061} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=947203 Change-Id: I344e73e283dd76578637d521ceffb94f3126f498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546638 Cr-Commit-Position: refs/heads/master@{#646076}
-
Findit authored
This reverts commit 48169718. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 645809 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDgxNjk3MTgzOWYwMTgxNmY3ZjAxMjYwMGU3OTg2YTA0NWQxZjQ1NQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32395 Sample Failed Step: browser_tests Sample Flaky Test: ExistingUserControllerActiveDirectoryTest.PolicyChangeTriggersFileUpdate Original change's description: > Fix ExistingUserControllerActiveDirectoryTest tests > > Likely fix for flakiness in PolicyChangeTriggersFileUpdate and > UserKerberosFilesChangedSignalTriggersFileUpdate tests. Properly waits > for Kerberos file changes. > > BUG=chromium:865206 > TEST=ExistingUserControllerActiveDirectoryTest.* tests pass for me. > > Change-Id: I56558fa5a2f853591e2d3ec5496103cba32f7ff7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482454 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645809} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:865206 Change-Id: If8d6bc824a56718c5446608aeb57b2cdf0d607a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546637 Cr-Commit-Position: refs/heads/master@{#646075}
-
Andrew Grieve authored
This doesn't fix any problems that we have, but is technically more correct and uses a bit less reflection as well. Noticed this was happening when running unit tests, as we have multidex-related code in a custom instrumentation that was not being run. It now gets run (but is a no-op since multidex isn't needed for incremental install). Change-Id: Iee914ec40b98417e7e1ab74aa2fe2afba8bd98c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546141Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#646074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/823aaabfd18c..d6512b3755d9 Created with: gclient setdep -r src-internal@d6512b3755d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I0bf849d99cdd9f8bfd16c549b0994c2368eb3905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546344Reviewed-by:
-
Jeffrey Cohen authored
SendTabToSelf's MVP is changing to target a specific other device, I'm adding this field as the first step towards implementing that. Bug: 946224 Change-Id: I70fc16995e1675a33777fd2965555a218b6b8d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540293 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#646072}
-
Findit authored
This reverts commit a78d9786. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 645869 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTc4ZDk3ODZhMWE5OTI1NmRiNmY5YzA2NTZlMWY0MWZhOGY1N2Y5NQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/41071 Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5 Sample Flaky Test: virtual/nobinary-for-inspector-protocol/inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers.js Original change's description: > [DevTools] Internally use binary protocol by default. > > There's now a switch --disable-internal-devtools-binary-protocol. > > Also: > - Remove the old virtual test suites since the enable flag is gone. > - Introduce new virtual test suites to test the diable flag. > > There's one test for which behavior changes just a tad (more precision), > so I'm updating the expectations and also keeping the old state > for the virtual test suite. > > Change-Id: Iab705aa2b7cfb996a05ce1a7d0804ca20adad009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544735 > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645869} Change-Id: I99dc80b0774884819d11d6611c787b9bc485eec6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546634 Cr-Commit-Position: refs/heads/master@{#646071}
-
Robert Ogden authored
This allows us to turn on the URLLoader feature and have it be a no-op for clients that do not have NetworkService enabled. Bug: 921736 Change-Id: I9ad2612cd13798b2c4362cb07fa22be06f8aa5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546133 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#646070}
-
Robert Ogden authored
light_icon_color is modern_grey_500 Change-Id: I77bcd24538b0a74c7819c00397da2195bcefa6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546505Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#646069}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic9376635317c13371fde8c45a4080fb521f1471c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546194Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#646068}
-
Andrew Grieve authored
Bug: 882524 Change-Id: I3d6e9a7000d33e15ac0ed61873b91b12097db190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545094 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Sammie Quon authored
Add a post task to call OnStartingAnimationComplete later. This will push several animations such as shelf color, adding rounded corner mask until after the original setup phase. Test: manual Bug: 944964 Change-Id: I613e103bedde57219effa880112f7413f37d6e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535346 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#646066}
-
Ehsan Karamad authored
This CL contains the following additions: A- RenderFrameLifetimeObserver instantiated for MimeHandlerViewFrameContainers that are created by browser. These containers could leak before if the embedder RenderFrame would go away. B- Modify the test MimeHandlerViewCrossProcessTest.EmbedderRemovedNoCrash to actually catch regressions for the embedded MimeHandlerView type. This test was initially working fine because all created MimeHandlerView were embedded. After change crrev.com/c/1460426 the MimeHandelrViewGuest created in the test became full page and the test was passing regardless. This CL changes the test to make sure the created guest is embedded. It is very hard to test the full-page case as MHVContainerManager goes away after deleting the embedder frame and there is no way to send IPCs after frame destruction to verify everything is clean up; nonetheless, item A ensures that MHVFCs are all gone after RenderFrame is deleted. Bug: 650759, 930803 Change-Id: I8938f25a005f050cfacf32292f152277397ce836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546171Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#646065}
-
Robert Flack authored
To avoid overlap, we should separate the methods that deal with ensuring we maintain the map from element id to layer and the list of element ids in the property trees. Bug: 934511 Change-Id: I1e1d4ca3d11ae9becec208748701358b31facba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506592 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#646064}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b19816173e81..823aaabfd18c Created with: gclient setdep -r src-internal@823aaabfd18c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ic3871479f7dbd969111b92c8134eba044c116a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546343Reviewed-by:
-
rbpotter authored
In destination settings: - Do not hide the dropdown if the destination is ready or expected to be ready imminently (i.e. capabilities are already known, and just waiting for the event from DestinationStore). This causes a loss of focus. - Disable the dropdown only for fatal errors which should disable the entire UI, or when there is a validation error and the destination is updated and the state is not NOT_READY. Need to check state explicitly, as the destination needs to be updated before updating the state to READY. If we only check destinationState and disabled, the dropdown will be momentarily disabled when the destination updates, causing a loss of focus. Also: - Introduce a new error property. This simplifies propagating printer errors between the preview area and the destination settings, so that the dropdown will be disabled correctly. - Remove some redundant states in destination settings and preview area, and use the error property to distinguish where necessary. Bug: 943072, 942444 Change-Id: Ib2ff3f65971ace8f5db71ed1bf2a33b9bf28dbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539189Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#646062}
-
Toni Barzic authored
Note that recommned_apps_fetcher implementation has not really changed, except for: * Made RecommendAppsFetcherImpl implement RecommendAppsFetcher interface * Moved some logic from RecommentAppsFetcherImpl ctor to newly introduced Start() method Added methods to check whether an element is enabled/disabled to js_checker, and new methods for checking element visibility that test element's offsetHeight and offsetWidth - the approach with checking hidden property does not work for elements that are hidden using "display: none" CSS (e.g. recommend_apps screen buttons). BUG=947203 Change-Id: Ib38d07e7f75bed64ff909c927d29d0c2e365c815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544794Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#646061}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9b8530af4dcb..5b63b1f34a1b git log 9b8530af4dcb..5b63b1f34a1b --date=short --no-merges --format='%ad %ae %s' 2019-03-30 crouleau@chromium.org [Telemetry] Fix browser command line print out. Created with: gclient setdep -r src/third_party/catapult@5b63b1f34a1b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947711,chromium:943650 TBR=simonhatch@chromium.org Change-Id: I3d57732693949cc1b2219d70b9f3131b1b1d3d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546342Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c8695a9. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 6f2e9bd4 "webrtc wpt: add test for ice disconnection" be4bce5d "[WPT] Merge subresource scripts into common/security-features" d1ac10ff "Revert "webrtc wpt: add test for ice disconnection"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I288b5c4ef781cb35f7ecd3be65845900f4b2d262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546754Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646059}
-
Junyi Xiao authored
Automated testing revealed: 1. the three-dot button on tabbed pane of the drawer view doesn't have a name property which can impair screenreader's ability to announce the appropriate context of focus; 2. the tab close button doesn't have have a name property which can impair screenreader's ability to announce the appropriate context when users try to access the control with some pointing device; This change adds 1. a title to the three-dot button mentioned above; 2. a title to the tab close button; 3. a minor fix for misused even.key of Space key. Change-Id: Ieca67cc385d57fac534d28a2a3631c155e1e27ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536444 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#646058}
-
Eric Seckler authored
Potentially fixes some importing issues in catapult trace viewer. Change-Id: I890255020e4abf019b9f3acdfcf77f7bdec020a1 Bug: 947226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545899Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#646057}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e82407530873..bc36bade1e16 git log e82407530873..bc36bade1e16 --date=short --no-merges --format='%ad %ae %s' 2019-03-29 tsepez@chromium.org Use span rather than raw string in FindSubWordLength(). Created with: gclient setdep -r src/third_party/pdfium@bc36bade1e16 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ieda30849c3bb10310fffbd35613cd1357c43901d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546340Reviewed-by:
-
Caleb Rouleau authored
TBR=benjhayden@chromium.org Bug: 947035 Change-Id: Icaca98244e73d0aab0acf9273ee3365f59f7b450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546855Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#646055}
-
Regan Hsu authored
Currently, the checkmark only persists on the thumbnail of the active thumbnail when the user visits Wallpapers, selects a wallpaper that has been retrieved online, goes to another category, and returns to the same category as the currently active wallpaper. The checkmark does not persist in 2 cases: (1) When user first opens Wallpapers, the checkmark is not visible on the currently active wallpaper's thumbnail. (2) When user selects a wallpaper in 'My Images', clicks on a different category, and revisits "My Images", the checkmark is not visible on the currently active wallpaer's thumbnail. This CL ensures all cases are covered. Bug: 945807 Change-Id: I9707ae765283853db602ca71b6a174af54fe16e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545209Reviewed-by:May Lippert <maybelle@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#646054}
-
