GitLab

- A user is now allowed to bypass entering their old password when
updating their windows password if they forgot their old password.
- The user's password will be forcefully reset once they confirm
they wish to reset their password. This will cause them to lose
all their encrypted data.

Bug: 912609
Change-Id: I308a41d2ba278c0e15c6976fb41bb0ebcf9bd414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551465
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647766}

This CL prepares CanAccessDataForOrigin (which can be called on the UI
or IO thread) to support citadel-style enforcement (which requires
calling DoesSiteRequireDedicatedProcess).  See https://crbug.com/764958
for more details.

Bug: 764958
Tbr: servolk@chromium.org (for mechanical //chromecast changes)
Change-Id: Iec64cbe3a42164c1993d2e41ee1ec18655160626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546323
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647765}

https://android.googlesource.com/platform/external/perfetto.git/+log/b053961e125c..9c85e2560369


git log b053961e125c..9c85e2560369 --date=short --no-merges --format='%ad %ae %s'
2019-04-04 lalitm@google.com Merge "trace_processor: fix generation of proto names"
2019-04-04 treehugger-gerrit@google.com Merge "Do not start heapprofd in integrationtest."


Created with:
  gclient setdep -r src/third_party/perfetto@9c85e2560369

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I5a942d8f6879586226034e9808079e6e8fdcfa90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553030Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647764}

A previous update to AXPlatformNodeWin caused get_localizedExtendedRole
to return S_OK and empty strings when the role description was not
explicitly set. Consequently, the UA would report empty descriptions
instead of the implicit defaults. This had wide impact since as most
objects do not set their role descriptions.

This change ensures that the function returns S_FALSE when the role
description is not explicitly set. This tells the UA that it should use
the default description.

Bug: 947762
Change-Id: I124d2c61d5f6e3d9545bd350cabd674f7f5fe354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545685Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647763}

Bug: 948646, 949538
Change-Id: Ib439b1111be76febdd212e00e8895a65cc2b0387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553160Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#647762}

... to 454b6bcf7d08535681bbd967030f5248bcbc8e6a

This bumps the stack limit for JSON / CBOR to 300.

Change-Id: I6549765c1d9e23072c488dd4f7ec8437bd8d1a66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552648
Auto-Submit: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647761}

Makes Frame a top-level class so that it can be reused in unwinding code
independent of building a profile.

Bug: 909957
Change-Id: I8864863b41f7846eca8efa220cec8476e4875a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543809
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647760}

https://webrtc.googlesource.com/src.git/+log/6c371ca7005a..21f6fd79ad05


git log 6c371ca7005a..21f6fd79ad05 --date=short --no-merges --format='%ad %ae %s'
2019-04-04 jakobi@webrtc.org Add preemptive rate and preferred buffer size plots to event log visualizer.
2019-04-04 gustaf@webrtc.org AEC3: Remove unused config parameters


Created with:
  gclient setdep -r src/third_party/webrtc@21f6fd79ad05

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib6de7e58af4c8c72ff7cff37b71eb38bfa44d889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553029Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647759}

Currently, after calling OverrideBinderForTesting, we completely drop
the existing registered interface binders. This CL modifies this
behavior, and lets us fall back to the pre-existing registered
binder for an inteface if it hasn't been explicitly overriden by
OverrideBinderForTesting.

Change-Id: I59673ac42f98615451be518bfd61dd0f8f6b3ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543455Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647758}

A missing dependency made chromedriver builds flaky.

This was reported as a dependency error by
gn check --check-generated after enabling dependency checks
of chrome/test/* in .gn so having those dependency checks
enabled would have prevented this.

Bug: 949518
Change-Id: I3be5864d27e8258be193e67dc9f05f303b7c00fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552849
Auto-Submit: Daniel Bratell <bratell@opera.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647757}

Change-Id: Ia520380215f04c3686ad96b88a2db7f170b8852a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552220
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647756}

Suffix all GC calls for testing as such to illustrate this these methods should
never be called from production code.

Rename full GC to forced GC for testing.

Bug: 948807
Change-Id: I03e6139ee365b575e7634a4058419af9b0c90cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549259
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647755}

* Remove RetainWrapperDuringConstruction().
* Remove warnings about special GC semantics.
* Remove holder_ hack from transform_stream_test.cc.

Change-Id: Iaf5d5868679b33c1411fb944120c4711d8d00a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547715Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647754}

This is the 5th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

For classification, document suggestion contents and historyUrl
suggestion descriptions currently use
a) bookmarks::CleanUpTitleForMatching,
b) AutocompleteProvider::TermMatchesInString, and
c) HistoryProvider::SpansFromTermMatch.

Document suggestion descriptions (e.g. 'Google Drive') are not
classified, and historyUrl suggestion contents have unique
classification logic which this CL does not address.

This CL changes document suggestion contents and historyUrl suggestion
descriptions to use FindTermMatches and ClassifyTermMatches defined in
autocomplete_match_classification.cc instead. These methods were created
in the previous refactoring CL's and are based on the methods (a), (b),
and (c). But unlike the previous methods, these are located adjacently
in a single file and are more generic to allow reuse by ideally all
providers.

Additionally, this CL removes the
AutocompleteProvider::TermMatchesInString method as it's no longer used.

Migrating from the previous to the new classification methods has a few
behavior changes as well:

1) The document and historyUrl suggestions now check for prefixes
matching, where if the user text is an exact prefix of the suggestion
text, further occurrences of the user text are not styled. E.g., the
user text "the" will bold only the first occurrence in the suggest text
"[the] dog ate the moon".

2) The document and historyUrl suggestions do not restrict matches when
the user text contains symbols. Previously, the user text 'the-' would
match the suggest text '[the-]dog' but not the suggest text 'the dog'.
With this CL, symbols in the user text are disregarded unless prefix
matching, and 'the-' matches '[the] dog'.

Bug: 366623
Change-Id: I48a7d06e05f5c77551033bc085a263b57840cd57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552140Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647753}

OnForwardScrollUpdateToMainThreadOnImpl is used to record latency
components that aren't used downstream.

There is still some follow-on work to remove the unused latency
components definitions from LatencyInfo.

Change-Id: I7d54a3fcabecd63ddabfc4705924a3c37d2ad480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551063Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647752}

Fixes Cmd+C and Cmd+V in pre-edit. Adds a unit test to prevent
future regressions. Currently an EGTest is not possible, as EGTest
doesn't have actions for sending keyboard events.
Removes a DCHECK for OmniboxTextFieldIOS' delegate to be a more
specific subclass, which seems fine as all of the methods of
OTFIDelegate are optional


Bug: 945024
Change-Id: I216bc8361e01e9874623e2105416e2cfa9ff03aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547747
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#647751}

Change-Id: Ib825aec08f3d55d6e4c6cbf25ba63c5f36bb41c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552899
Auto-Submit: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647750}

The old JSON-RPC endpoint is still the default one, but we will
gradually transition users to the new REST endpoint, as the JSON-RPC
one is being deprecated.

The difference between the 2 endpoints is very small and are
highlighted in the following doc:
docs.google.com/document/d/1tmqz3QTF-lhbbkBxqOSYMdNZ-OOhlMIhb8hczhbZVhQ

Bug: 943108
Change-Id: I87a9fc8bbe9c4571528256d20d86748384caed61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542418
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Auto-Submit: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647749}

BCKSF (BrowserContextKeyedServiceFactories) can depend on SKSFs
(SimpleKeyedServiceFactories), but adding the dependency to
DependencyManager cause issues as they are two separate graphs.

https://chromium-review.googlesource.com/c/chromium/src/+/1534708
allows these dependencies and makes them no-op using a workaround.

Bug: 944906
Change-Id: Iea4fa4655ff06a9903c92648a8f744878d7f7787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551933Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647748}

The problem is because the window size and swapchain's
size do not match during resizing, and then the
vkQueuePresentKHR() will fail. This CL create a child
window, and create a surface and swapchain from it.
During resizing, we will resize the child window and
re-create the swapchian at same time.

Bug: None
Change-Id: I160dd26d6de2a8f2b2a01d201d5a2c428c2f2139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548315Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647747}

https://skia.googlesource.com/skia.git/+log/98f4e81d49dc..a064c2812eb5


git log 98f4e81d49dc..a064c2812eb5 --date=short --no-merges --format='%ad %ae %s'
2019-04-04 kjlubick@google.com [canvaskit] Make SkImageShader from SkImage
2019-04-04 ethannicholas@google.com SkSL now properly errors when invocations are used outside of a geometry shader
2019-04-04 robertphillips@google.com Stop using pendingIO in read/writeSurfacePixels
2019-04-04 kjlubick@google.com [canvaskit] adding drawAtlas to canvas API


Created with:
  gclient setdep -r src/third_party/skia@a064c2812eb5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@chromium.org

Change-Id: Ibdc2ce8e24d6e3be4757127e6c1801672e4ce9e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647746}

This CL use R.color.sheet_bg_color for the background color of the
Chrome BottomSheet instead of R.color.modern_primary_color.

This should have no visible effect in the default/light theme. In the
dark theme, the background color will now be
modern_grey_900_with_white_alpha_6 (#2D2E31) instead of modern_grey_900
(#202124), to match with the payment request sheet background.

Change-Id: I936f4399d013445e38c215b9f3da52aadb5156c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552872Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647745}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddb565a9417c..98c9c09ca5ff


Created with:
  gclient setdep -r src-internal@98c9c09ca5ff

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fergal@chromium.org,alph@chromium.org,avi@chromium.org,cfroussios@chromium.org

Change-Id: I367c32702020945862f0a5f6b8d78e85d9d9ca9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553239Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647744}

This CL is removing the deprecated flag to disable DWrite rendering.
The renderers are only using DWrite. Chrome should not work without
DWrite.

The current CL is changing the GDI path to a CHECK.

Renderers removed GDI path:
  https://bugs.chromium.org/p/chromium/issues/detail?id=579678

R=robliao@chromium.org, asvitkine@chromium.org
CC=dfried@chromium.org

Bug: 944227
Change-Id: I466732d9f46c009834532461dc45f3136264b6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551121
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647743}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/602fef8f..15b234e4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I52d8c0583fc989b10a36bcff43fe0fd1680de988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553000Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647742}

Change-Id: I8dff6c35380c758cc6ece64eba617e175720c824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551912
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647741}

This CL adds logic to set_form_field_action, such that when the default approach
of SetValue does not work (that is field is not set), try again with keyboard
simulation turned on. Also report to server when a fallback has happened.

Change-Id: Iad8a77e204c7034fb9fb4581afe14ff6867eeb41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548636
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647740}

Explicitly include <memory>, which also fixes the libstdc++ build:

    In file included from ../../components/language/core/browser/fluent_language_model.cc:5:
    ../../components/language/core/browser/fluent_language_model.h:32:8: error: no template named 'unique_ptr' in namespace 'std'
      std::unique_ptr<LanguagePrefs> language_prefs_;

Bug: 819294
Change-Id: Ie4ba3c59d46b6b14467a73e41a040997dd2c21ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552864
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647739}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/111a25e4ae45..2434b89345a5


git log 111a25e4ae45..2434b89345a5 --date=short --no-merges --format='%ad %ae %s'
2019-04-04 johnkslang@users.noreply.github.com Merge pull request #100 from jeffbolznv/hasresult


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@2434b89345a5

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id3d4c2ee8d2d5cb84a1cf1949d9291592c0e4cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553028Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647738}

`wpt_staging/` was incorrectly mentioned. Also adjust the wording to
highlight the intention of this directory.

No-Try: True
Bug: 853815
Change-Id: Iee9c0fdcbb1829c58670c4ebcadafb43ad2dd462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551566
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647737}

Change-Id: I329052cdc9728421a0c106584d7a990556538731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553101
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647736}

Example error on a Windows x64 jumbo build:
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes "-imsvc..\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27508\ATLMFC\include" "-imsvc..\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27508\include" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD "-DCR_CLANG_REVISION=\"356356-3\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_RS2 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_HAS_ITERATOR_DEBUGGING=0 -DBASE_IMPLEMENTATION -I. -I../.. -Igen -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fcomplete-member-pointers /Gy /FS /bigobj /utf-8 /Zc:sizedDealloc- /X -fmsc-version=1911 /guard:cf,nochecks /Zc:dllexportInlines- -m64 /Brepro -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -no-canonical-prefixes /W4 -Wimplicit-fallthrough -Wthread-safety -Wextra-semi /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 /wd4702 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-ignored-pragma-optimize /Od /Ob0 /GF /MDd -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-char-subscripts -Wglobal-constructors -Wexit-time-destructors /FIbuild/precompile.h -Wshadow -Wno-shorten-64-to-32 -Wexit-time-destructors /Fpobj/base/base_cc.pch /Yubuild/precompile.h -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare /TP /wd4577 /GR- /c gen/base/base_jumbo_8.cc /Foobj/base/base/base_jumbo_8.obj /Fd"obj/base/base_cc.pdb"
In file included from gen/base/base_jumbo_8.cc:28:
.\../../base/win/scoped_hstring.cc(18,13): error: redefinition of 'g_load_succeeded'
static bool g_load_succeeded = false;
            ^
.\../../base/win/hstring_reference.cc(18,6): note: previous definition is here
bool g_load_succeeded = false;
     ^
1 error generated.

Change-Id: I25bcdc80a69768ac99d373d41fd98080ccd63aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552852
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647735}

This CL adds background image support to Element Timing. For each
element and each background image affecting it, we have a potential new
entry. Therefore, in order to keep track of the first paint, we keep a
HashSet of pairs of pointers (LayoutObject, ImageResourceContent). We
need to remove a pair from the HashSet when the corresponding
LayoutObject is no longer observing the image, so we add a new method in
ImageResourceObserver to support this removal.

Bug: 879270
Change-Id: If7bc70df30ba0a9ed8335e67e09f52d6f9ba849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545167Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647734}

https://android.googlesource.com/platform/external/perfetto.git/+log/e7647416811d..b053961e125c


git log e7647416811d..b053961e125c --date=short --no-merges --format='%ad %ae %s'
2019-04-04 fmayer@google.com Merge "Enable LTO in Android tree."
2019-04-04 lalitm@google.com Merge "trace_processor: import android memory metric protos into metrics folder"


Created with:
  gclient setdep -r src/third_party/perfetto@b053961e125c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ic3ac8951cdf6dd5db60ae658b93a62a394ddb744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553027Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#647733}

This include is no longer used since net::CompletionCallback has now
been replaced by net::Completion{Once|Repeating}Callback everywhere,
so we can remove those stale includes and keep only the ones needed
for those other callbacks.

TBR=sergeyu@chromium.org

Bug: 807724
Change-Id: I538fcf00183f870db4507504c32818d4117c5b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549257Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#647732}

Adds supports for message types (including transferable types like
array buffers and message ports).

Bug: 914120
Change-Id: I8d33bfdc81ac1b959c4392dd33f1e037e163f743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1449821Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647731}

There was a typo and hence filtering of the benchmarks wasn't working.

Change-Id: If556f1cce7b8c44e667d5d0f361f45f257d0b5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550421Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647730}

It is flaky (timeout, crash)

TBR=sky@chromium.org

Bug: 803510
Change-Id: Ia27b59a5cf78d3016479c5333483828f1c9e6174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552857Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647729}

There is a missing nullptr check in the render frame
observer. If the sender does not exist, we won't try
to call into it

Bug: 949507
Change-Id: I92af9c53af082800155b955e74ac0ac771d4369e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553100
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647728}

This is a proof a concept, minimal pref service to demonstrate that
Chrome updater can build with //components/prefs, and use the
service as a persistence mechanism.

Bug: 949396
Change-Id: I7c3816f92416d74c94bd1fd066f32c167bc177e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552424Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647727}