GitLab

This rounds out my patch series to point image decoding benchmark at
image_decoding_benchmark.json but also get a tough_image_cases pageset
established.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11783086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176139 0039d316-1c4b-4281-b951-d872f2087c98

Also remove invalid ANNOTATE_LEAKING_OBJECT_PTR
annotation for an object that _does_ get deleted.

This is for now disabled on Windows because of tsan compile issues.

TBR=jar

BUG=30715

Review URL: https://codereview.chromium.org/11826062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176138 0039d316-1c4b-4281-b951-d872f2087c98

[net/dns] Add per-address-family histograms AsyncDNS.ResolveSuccess_FAMILY_* and per-qtype histograms AsyncDNS.TransactionSuccess_*.

Currently observed AsyncDNS.ResolveSuccess (duration of DnsTask) is almost twice as long as AsyncDNS.TransactionSuccess (duration of DnsTransaction). This could be attributed to dual-stack resolutions which involve two DnsTransactions, but at the same time the difference between DNS.ResolveSuccess_FAMILY_IPV4 and ..._UNSPEC (duration of ProcTask) is much less pronounced suggesting that SystemDNS resolves names on dual-stack hosts differently than AsyncDNS.

This measurement will allow us to determine how much of the observed overhead of DnsTask over DnsTransaction can be attributed to dual-stack lookups.

BUG=169257

Review URL: https://codereview.chromium.org/11783076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168984


Review URL: https://chromiumcodereview.appspot.com/11819045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176136 0039d316-1c4b-4281-b951-d872f2087c98

Checking the command line in LayerTreeSettings is dangerous, as both the
browser and the renderer will have the same command line args.  Moving this
flag first, as it causes asserts in debug for --enable-impl-side-painting.  The
other flags can be moved separately.

R=danakj@chromium.org
BUG=169173,155209


Review URL: https://chromiumcodereview.appspot.com/11829052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176135 0039d316-1c4b-4281-b951-d872f2087c98

This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.

Benefits:
 - 41 fewer extraneous results when grepping Java string IDs
 - Switching from maintaining strings in strings.xml over to using a
   grd file is One Trivial CL* away: just include English in the list
   of languages for which we generate strings.xml files.

*Restrictions may apply

BUG=167248

Review URL: https://codereview.chromium.org/11659006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176134 0039d316-1c4b-4281-b951-d872f2087c98

The destructor for base::SharedMemory closes its handle on destruction.
To keep a shared memory region alive after using it, we need to
duplicate the handle. This uses dup(), which is available in native
client.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11817020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176133 0039d316-1c4b-4281-b951-d872f2087c98

This uses inspector timeline and telemetry to get an estimate of time consumption during page load.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11791043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176132 0039d316-1c4b-4281-b951-d872f2087c98

Fix the same incorrect use of "Message::PopString" for Connect previously
fixed for CreateDevice and CreatePairedDevice. grep doesn't show any other missing
usage to fix. See previous crrev.com/11669016 .

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11734014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176131 0039d316-1c4b-4281-b951-d872f2087c98

Revert 176126 - the reverted change depends on another CL, so reverting it breaks the build. Undoing the revert.

> Revert 175648 because it causes http://crbug.com/169126.
> 
> > Connect to DesktopEnvironment's stubs only when audio/video schedulers are about to be created.
> > 
> > This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment.
> > 
> > Related changes in this CL:
> >   - MouseClampingFilter receives screen size on the proper thread.
> >   - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change.
> >   - ClientSession does not expose DesktopEnvironment.
> >   - InputEventTracker can be re-attached to a different InputStub.
> > 
> > BUG=104544
> > 
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11781003
> 
> TBR=alexeypa@chromium.org
> BUG=104544,169126
> Review URL: https://codereview.chromium.org/11817048

TBR=alexeypa@google.com

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161769


Review URL: https://chromiumcodereview.appspot.com/11663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176128 0039d316-1c4b-4281-b951-d872f2087c98

TEST=
BUG=

Review URL: https://codereview.chromium.org/11778098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176127 0039d316-1c4b-4281-b951-d872f2087c98

> Connect to DesktopEnvironment's stubs only when audio/video schedulers are about to be created.
> 
> This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment.
> 
> Related changes in this CL:
>   - MouseClampingFilter receives screen size on the proper thread.
>   - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change.
>   - ClientSession does not expose DesktopEnvironment.
>   - InputEventTracker can be re-attached to a different InputStub.
> 
> BUG=104544
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11781003

TBR=alexeypa@chromium.org
BUG=104544,169126
Review URL: https://codereview.chromium.org/11817048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176126 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176125 0039d316-1c4b-4281-b951-d872f2087c98

r176100: disable c4267 for hunspell for building on win x64

TBR=jschuh@chromium.org
BUG=167187


Review URL: https://chromiumcodereview.appspot.com/11817046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176124 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11821051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176119 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11833028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176118 0039d316-1c4b-4281-b951-d872f2087c98

This is a second upload of https://codereview.chromium.org/11786010/
Review URL: https://codereview.chromium.org/11783098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11830051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176114 0039d316-1c4b-4281-b951-d872f2087c98

This patch appears to be responsible for failures on multiple Chrome OS bots.
> Only show start/stop mirroring button when there are multiple displays.
> 
> Also, redirect the page to chrome://settings when only one monitor is
> connected, so we can stop showing the dialog for now. In the future
> we may decide to show the page for some reason.
> 
> BUG=169124
> TEST=manually on parrot
> 
> Review URL: https://codereview.chromium.org/11818043

TBR=hshi@google.com
Review URL: https://codereview.chromium.org/11824070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176113 0039d316-1c4b-4281-b951-d872f2087c98

ChromeGeolocationPermissionContext is RefcountedThreadsafe and
may lose it's last reference from either the UI thread or the
IO thread. GeolocationInfobarQueueController must be destroyed
on the UI thread, however.

Depends on https://codereview.chromium.org/11587003/

TEST=
BUG=127751

Review URL: https://chromiumcodereview.appspot.com/11590002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176112 0039d316-1c4b-4281-b951-d872f2087c98

The revert didn't fix the ChromeOS failures so I'm restoring the change.
> Revert 176087
> 
> Appears to break ChromeOS browser_tests.
> 
> > Re-introduce the partial magnifier
> > 
> > Major Changes:
> > - Adding a selectbox at the right of screen magnifier setting on the setting page.
> > - Adding 'screen_magnifier_type2' pref.
> > - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> > - Add IsMagnifierEnabled() to shell delegate.
> > 
> > BUG=166832
> > TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> > 
> > R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> > TBR=jhawkins@chromium.org
> > # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11642014
> 
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/11821053

TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11783097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/11745003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11783092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176109 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to be using dup2() to set up an FD with a fixed
number; this risks overwriting an FD.  The point of
base::GlobalDescriptors is that it provides a level of indirection
that allows any FD number to be used.

Remove kNaClBrowserDescriptor.  Remove the browserdesc argument that
is not used for anything other than an assertion and so isn't needed.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2096
TEST=NaCl tests in browser_tests

Review URL: https://codereview.chromium.org/11819021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176106 0039d316-1c4b-4281-b951-d872f2087c98

In order to remove sleep-waiting from debug stub, we need to send events on
exceptions in NaCl program from Chrome process to debug stub. This requires
duplicating event handle from NaCl process to Chrome process.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2952
TEST= none


Review URL: https://chromiumcodereview.appspot.com/11819057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176105 0039d316-1c4b-4281-b951-d872f2087c98

Also
- removed the temp work-around in disabled_extensions_view.cc.
- pngcrushed the images in common/.

BUG=165808
TEST=Verify hotdog menu bubble does not go beyond browser window.

R=oshima@chromium.org,finnur@chromium.org
TBR=msw@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/11778074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176104 0039d316-1c4b-4281-b951-d872f2087c98

The setting is mapped directly onto WebKit's WebSettings.viewportEnabled

R=benm@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11759023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176103 0039d316-1c4b-4281-b951-d872f2087c98

Appears to break ChromeOS browser_tests.

> Re-introduce the partial magnifier
> 
> Major Changes:
> - Adding a selectbox at the right of screen magnifier setting on the setting page.
> - Adding 'screen_magnifier_type2' pref.
> - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> - Add IsMagnifierEnabled() to shell delegate.
> 
> BUG=166832
> TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> 
> R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> TBR=jhawkins@chromium.org
> # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> 
> Review URL: https://chromiumcodereview.appspot.com/11642014

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11821053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176102 0039d316-1c4b-4281-b951-d872f2087c98

Active Setup is a Windows "Run-once-for-each-user-at-next-login" mechanism which we use to install per-user shortcuts on system-level installs.

It currently points to setup.exe --configure-user-settings --...

Windows' clever heuristics detect that this is an installer solely based on the process name and tries to elevate (this is mitigated on Vista since we set requestedExecutionLevel="asInvoker" in setup's manifest; on XP however this results in a blocking "Install Program as Other User" dialog at log in...).

BUG=166473
TEST=
On Windows XP:
0) Have User A (admin) and User B (non-admin, logged out)
1) Install system-level Chrome from User A
2) Log in to User B
3) See that the per-user Quick Launch shortcut has been installed (and that you weren't prompted by the "Install Program as Other User" dialog).

More Active Setup testing can be done as per the TEST block on https://codereview.chromium.org/11465025/.

Review URL: https://chromiumcodereview.appspot.com/11733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176101 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11823037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176099 0039d316-1c4b-4281-b951-d872f2087c98

the same way they have the ability to provide a custom view for page widgets.
All the widget views are created using WebContentsView, which can be
overriden by embedders with ContentBrowserClient::OverrideCreateWebContentsView
Contributed by rosca@adobe.com

BUG=155761

Review URL: https://chromiumcodereview.appspot.com/11773042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176092 0039d316-1c4b-4281-b951-d872f2087c98

Also, redirect the page to chrome://settings when only one monitor is
connected, so we can stop showing the dialog for now. In the future
we may decide to show the page for some reason.

BUG=169124
TEST=manually on parrot

Review URL: https://codereview.chromium.org/11818043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176089 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176088 0039d316-1c4b-4281-b951-d872f2087c98

Major Changes:
- Adding a selectbox at the right of screen magnifier setting on the setting page.
- Adding 'screen_magnifier_type2' pref.
- Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
- Add IsMagnifierEnabled() to shell delegate.

BUG=166832
TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.

R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
TBR=jhawkins@chromium.org
# TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/

Review URL: https://chromiumcodereview.appspot.com/11642014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176087 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new public InternalAccessDelegate interface
on AwContents.
The purpose of the new interface is to support adding new internal
access methods that are required by AwContents but not by
ContentViewCore. An added benefit is isolating the embedder from
one more org.chromium.content.* type.

BUG=None
TEST=compile
Java-only change.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11828045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176086 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11820038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176085 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176084 0039d316-1c4b-4281-b951-d872f2087c98