GitLab

Also fix passing by non-const reference in chromedriver.

Review URL: https://codereview.chromium.org/635623003

Cr-Commit-Position: refs/heads/master@{#300629}

Previously ui::SelectedFileInfo's constructor has a fallback to use the file
path instead of an emtpy local path. But this fallback can assign non-native
paths like '/special/drive/xxx' to local_path variable when the file does not
have a snapshot.

The CL removes the fallback, and modify the default behavior of
FileSelectDialog::Lister so that it routes an empty local_path to file_path.

BUG=126902
TEST=manually

Review URL: https://codereview.chromium.org/666693004

Cr-Commit-Position: refs/heads/master@{#300628}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/183e985..b4384b9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/665983005

Cr-Commit-Position: refs/heads/master@{#300627}

PictureLayerImpl
* Rerasterize on every animated frame
* pass animated flag to picture pile

PicturePileImpl
* Store has_transform_animated, used as a transport to get data
  to GPU's RasterBufferImpl

ResourceProvider
* Provide a method to recreate the surface with the correct dff
  flag.
* Provide a method in the lock to set the dff setting
 * This has the side effect that the surface may be created
   twice for a new animated layer, but surface creation is
   cheap, I don't see this as a huge issue

RasterBufferImpl
* In playback, call the method on the lock to assign the dff
  setting that comes from the picture pile.

BUG=372391

Review URL: https://codereview.chromium.org/648293006

Cr-Commit-Position: refs/heads/master@{#300626}

In the current method of pinch-zoom, position: fixed elements stick to
the visual viewport (i.e. the screen). This means when the user pinch
zooms in, the viewport gets smaller so the fixed layers attached to the
right and bottom need an adjustment to keep them fixed to the screen.

In the new virtual viewport mode, the fixed elements stick to the layout
viewport, which doesn't change under scale so we no longer need to scale
this adjustment. Additionally, the adjustment that previously came from
pinch zooming is not needed at all.

BUG=420277

Review URL: https://codereview.chromium.org/646623003

Cr-Commit-Position: refs/heads/master@{#300625}

This will replace 'ui_unittests' soon.

BUG=331829, 373148, 299841, 103304
TEST=None
R=glider@chromium.org,timurrrr@chromium.org

Review URL: https://codereview.chromium.org/645143003

Cr-Commit-Position: refs/heads/master@{#300624}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463
R=agl@chromium.org

Review URL: https://codereview.chromium.org/666493005

Cr-Commit-Position: refs/heads/master@{#300623}

To enable data reduction proxy on the commandline, you need:

build/android/adb_android_webview_command_line --enable-spdy-proxy-auth
--spdy-proxy-auth-value=[your real key]

BUG=

Review URL: https://codereview.chromium.org/664243003

Cr-Commit-Position: refs/heads/master@{#300622}

It has a virtual method and is derived from by PEImageAsData.
Clang would warn about it not having a virtual destructor when
used in a delete expression in
module_integrity_verifier_win_unittest.cc.

Suppress the benign warning about the destructor not being
called during SEH unwinding.

BUG=82385

Review URL: https://codereview.chromium.org/667573009

Cr-Commit-Position: refs/heads/master@{#300621}

BUG=417463
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/658563010

Cr-Commit-Position: refs/heads/master@{#300620}

BUG=425256

Review URL: https://codereview.chromium.org/668123002

Cr-Commit-Position: refs/heads/master@{#300619}

Updates the UI button text to reflect the latest mocks.

BUG=390086

Review URL: https://codereview.chromium.org/669603007

Cr-Commit-Position: refs/heads/master@{#300618}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/667283002

Cr-Commit-Position: refs/heads/master@{#300617}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=425814
TBR=rdsmith@chromium.org

Review URL: https://codereview.chromium.org/673513002

Cr-Commit-Position: refs/heads/master@{#300616}

Move PostMessageToFrame method from ContentViewCore to WebContentsAndroid
which is a more suitable location.

BUG=393291

Review URL: https://codereview.chromium.org/649933006

Cr-Commit-Position: refs/heads/master@{#300615}

Recipes interprets all nonzero exit codes as errors.

BUG=424587

Review URL: https://codereview.chromium.org/651833004

Cr-Commit-Position: refs/heads/master@{#300614}

WebView does not gather data_reduction_proxy related
statistics at the moment. WebView's statistics object writes
the data to pref service which does not upload the data to
anywhere.

BUG=b/17998706

Review URL: https://codereview.chromium.org/651443005

Cr-Commit-Position: refs/heads/master@{#300613}

Fix the DCHECK in ValidateLayout for symmetric channel layouts.

Add 'const' to methods that don't mutate class members.

Include "base/macros.h" for the DISALLOW_COPY_AND_ASSIGN macro.

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/645853011

Cr-Commit-Position: refs/heads/master@{#300612}

(These aren't built on Mac, only on Linux, hence were missed.)

BUG=417463
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/670013002

Cr-Commit-Position: refs/heads/master@{#300611}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sky@chromium.org

Review URL: https://codereview.chromium.org/666673010

Cr-Commit-Position: refs/heads/master@{#300610}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=scheib@chromium.org

Review URL: https://codereview.chromium.org/666213002

Cr-Commit-Position: refs/heads/master@{#300609}

BUG=

Review URL: https://codereview.chromium.org/667023004

Cr-Commit-Position: refs/heads/master@{#300608}

BUG=

Review URL: https://codereview.chromium.org/669733009

Cr-Commit-Position: refs/heads/master@{#300607}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/661423008

Cr-Commit-Position: refs/heads/master@{#300606}

BUG=394993
TBR=felt

Review URL: https://codereview.chromium.org/667023005

Cr-Commit-Position: refs/heads/master@{#300605}

When a new cross-site frame is created, RFHM::CreateProxiesForSiteInstance walks the frame tree and creates proxies for the new frame in other nodes' SiteInstances.  This traversal currently hits this CHECK in RFHM::CreateRenderFrameProxy in cases where the new frame is added to a SiteInstance that already has other frames:

  CHECK_NE(instance, render_frame_host_->GetSiteInstance());

For example, if site A embeds two frames, B1 and B2, both pointing to site B, we hit this when we are visiting B1's frame tree node to create a proxy for B2, since B2's and B1's SiteInstance is the same.

This CL ensures that we aren't trying to create a proxy at frame tree nodes that share the new frame's SiteInstance.

BUG=None

Review URL: https://codereview.chromium.org/660083003

Cr-Commit-Position: refs/heads/master@{#300604}

BUG=

Review URL: https://codereview.chromium.org/667453004

Cr-Commit-Position: refs/heads/master@{#300603}

Review URL: https://codereview.chromium.org/656583006

Cr-Commit-Position: refs/heads/master@{#300602}

These targets are being developed canonically in the mojo repo and
tested there, no reason to run the tests in the chromium repo. The mojo
tests that should run in the chomium repository are:

mojo_public_* - the mojo SDK tests
mojo_system_unittests - mojo EDK tests
mojo_common_unittests - tests for mojo<->chromium glue
mojo_*_js_unittests - mojo JS bindings tests, which is being developed
in chromium.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/656423003

Cr-Commit-Position: refs/heads/master@{#300601}

This adds a gclient hook that downloads prebuilt mojo_shell binaries
from google storage (linux only for now) and gyp/gn flags to toggle
using these prebuilt binaries instead of ones built from source. This
also adds a helper script that uploads a locally built mojo_shell binary
to the appropriate place in google storage.  The versioning scheme is:

*) mojo/public/VERSION contains an identifier (committish currently) for
  the mojo public SDK. The mojo_shell binary must match the interfaces
  defined in this version of mojo/public/.

*) gs://mojo/shell/$VERSION/$PLATFORM.zip contains a prebuilt mojo_shell
  binary for a particular version. $PLATFORM for now must be linux-x64,
  but we can add more later as needed.

gclient runhooks downloads the shell binary referred to by
mojo/public/VERSION if it is available for the host platform to
mojo/public/tools/prebuilt/ and updates mojo/public/tools/prebuilt/VERSION
to tag the version downloaded if successful. On subsequent runs the hook
will check this against mojo/public/VERSION and avoid downloading again if
the binary is up to date.

This also adds variables to the GYP and GN builds that control if building
'mojo' builds a mojo_shell binary from source or copies the prebuilt binary
into the outdir.  They both default to false for now.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/667853002

Cr-Commit-Position: refs/heads/master@{#300600}

This reworks the way typ handles multiprocessing again, to make the API
(and the implementation) simpler for the common case.

TBR=dtu@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/664123005

Cr-Commit-Position: refs/heads/master@{#300599}

When I changed this PRESUBMIT.py in http://crrev.com/292434, I didn't properly test it, so it hasn't actually been checking auto_bisect/bisect.cfg as it was supposed to.

This change makes so that the files listed in the CONFIG_FILES list here will be checked (including run-perf-test.cfg, even though it's outside of the auto_bisect directory).

BUG=

Review URL: https://codereview.chromium.org/669543002

Cr-Commit-Position: refs/heads/master@{#300598}

This brings in:
767aebb Update openjpeg to r2908
bff247d More fixes in sycc422_to_rgb and sycc420_to_rgb when image width is odd
f71c2d0 Add missing parenthesis in FXARGB_GETDIB macro
fe45372 Make DEPS not add an extra pdfium directory.
175998f Fix standalone build on Linux and Mac.

Review URL: https://codereview.chromium.org/638883004

Cr-Commit-Position: refs/heads/master@{#300597}

Reverting instrumentations.

The bug is practically fixed, and profiler instrumentations are not necessary anymore.
BUG=417106
TBR=zelidrag@chromium.org, xians@chromium.org, hans@chromium.org, plundblad@chromium.org, komatsu@chromium.org, mfoltz@chromium.org, dcheng@chromium.org, tommycli@chromium.org, erikwright@chromium.org, rpaquay@chromium.org, mkwst@chromium.org, hongbo.min@intel.com, dvh@chromium.org, tbarzic@chromium.org, vitalybuka@chromium.org, jyasskin@chromium.org

Review URL: https://codereview.chromium.org/671783002

Cr-Commit-Position: refs/heads/master@{#300596}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=tommycli@chromium.org

Review URL: https://codereview.chromium.org/660343006

Cr-Commit-Position: refs/heads/master@{#300595}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/631653002

Cr-Commit-Position: refs/heads/master@{#300594}

This is necessary to roll in a new NaCl revision after I committed a
NaCl-side change which cleans up the service_runtime/include/ headers.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3909
TEST= build

Review URL: https://codereview.chromium.org/651643007

Cr-Commit-Position: refs/heads/master@{#300593}

This pulls in the following Native Client changes:

r13948: (mseaborn) Clean up sys/errno.h's #include guard to match the file's name
r13949: (glider) Filter -fsanitize=undefined from cflags when nacl_bootstrap_lib.
r13950: (jvoung) Build gold.nexe with a segment gap, and supply -B, to later support IRT use.
r13952: (jvoung) Add irt_load_optional flag to chrome_main args. Helps w/ making pnacl ld.nexe use IRT.
r13953: (nfullagar) Prep for sdk inclusion - make source more relocatable, so

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/666493004

Cr-Commit-Position: refs/heads/master@{#300592}

 * Fixes app_shell_browsertests on windows.

BUG=399363

Review URL: https://codereview.chromium.org/663203006

Cr-Commit-Position: refs/heads/master@{#300591}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/659563005

Cr-Commit-Position: refs/heads/master@{#300590}