GitLab

Revert of Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1017183004/)

Reason for revert:
Suspecting goma flake. Relanding.

Original issue's description:
> Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/)
>
> Reason for revert:
> Broke compilation on Mac Builder:
> https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio
>
> when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc
>
> Original issue's description:
> > Unflake V8 sampling profiler tests.
> >
> > BUG=406277
> >
> > Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95
> > Cr-Commit-Position: refs/heads/master@{#321970}
>
> TBR=yurys@chromium.org,alph@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=406277
>
> Committed: https://crrev.com/3703085199a63732add21d955c6280765e3c480e
> Cr-Commit-Position: refs/heads/master@{#321975}

TBR=yurys@chromium.org,pneubeck@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406277

Review URL: https://codereview.chromium.org/1029353002

Cr-Commit-Position: refs/heads/master@{#321977}

If a canonical server advertises an alternative service without an explicit
hostname, or an alternative protocol, then it is implied that the same
alternative service works on other hosts.  This CL adds a test to verify that if
SetAlternativeService is called with an empty host (denoting no explicit
hostname in the alternative service advertisement), then
GetAlternativeService(origin) returns alternative services with host ==
origin.host().  This will be important once HttpServerProperties starts storing
alternative services with hostname to make sure current behavior is preserved.

BUG=392576

Review URL: https://codereview.chromium.org/1029633002

Cr-Commit-Position: refs/heads/master@{#321976}

Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/)

Reason for revert:
Broke compilation on Mac Builder:
https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio

when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Original issue's description:
> Unflake V8 sampling profiler tests.
>
> BUG=406277
>
> Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95
> Cr-Commit-Position: refs/heads/master@{#321970}

TBR=yurys@chromium.org,alph@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406277

Review URL: https://codereview.chromium.org/1017183004

Cr-Commit-Position: refs/heads/master@{#321975}

From the documentation:
"Provides the Apple-recommended user-visible name for an endpoint, by combining the device and endpoint names."

This fixes the problem of port names of "Out Port 1", "Out Port 2" without a sense of the device it belongs to.

Review URL: https://codereview.chromium.org/1025903003

Cr-Commit-Position: refs/heads/master@{#321974}

This benchmark is causing redness on the perf tree.

BUG=470071
TBR=dtu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1029603005

Cr-Commit-Position: refs/heads/master@{#321973}

BUG=439423

Review URL: https://codereview.chromium.org/1019243007

Cr-Commit-Position: refs/heads/master@{#321972}

This reverts commit 82072cae.

The benchmark doesn't fail anymore with the new V8 roll.

BUG=469146

TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1026303002

Cr-Commit-Position: refs/heads/master@{#321971}

BUG=406277

Review URL: https://codereview.chromium.org/1032633002

Cr-Commit-Position: refs/heads/master@{#321970}

R=isherman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1022383003

Cr-Commit-Position: refs/heads/master@{#321969}

BUG=468778

Review URL: https://codereview.chromium.org/1014003004

Cr-Commit-Position: refs/heads/master@{#321968}

BUG=432280

Review URL: https://codereview.chromium.org/1006913004

Cr-Commit-Position: refs/heads/master@{#321967}

The predictor usually serializes its state on a clean shutdown, so doesn't on
Android. This fixes it.

BUG=467007

Review URL: https://codereview.chromium.org/1004093003

Cr-Commit-Position: refs/heads/master@{#321966}

Some pages contain a login form and a sign-up form squashed in one <form> element. While that is a bad practice, Chrome should be able to distinguish these forms from change-password forms (the difference being that the former will have at least one non-password text field between the login-part password field and the sign-up part password fields). This distinction enables Chrome to work on the login forms.

BUG=449714

Review URL: https://codereview.chromium.org/1014683006

Cr-Commit-Position: refs/heads/master@{#321965}

This prevents the location bar appearing and then disappearing when a
bookmark app is first opened.

BUG=463405

Review URL: https://codereview.chromium.org/1028503002

Cr-Commit-Position: refs/heads/master@{#321964}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/99a9e15..7f4313b

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/1012903003

Cr-Commit-Position: refs/heads/master@{#321963}

BUG=470013

Review URL: https://codereview.chromium.org/1033633002

Cr-Commit-Position: refs/heads/master@{#321962}

This CL fixes a bug with the classic app list where the search box
would turn grey when typing into it. This was happening because the
shadow value from the experimental app list was being used.

BUG=469983

Review URL: https://codereview.chromium.org/1027513004

Cr-Commit-Position: refs/heads/master@{#321961}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e26a365..99a9e15

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/1011703007

Cr-Commit-Position: refs/heads/master@{#321960}

The service path argument to set the 'connect behavior' was wrong.
Now, one can again pass the command line argument
 --shill-stub="wifi=portal"
and then connect to the WiFi "Portaled Wifi", which will correctly trigger the captive portal notification.

Review URL: https://codereview.chromium.org/1029563002

Cr-Commit-Position: refs/heads/master@{#321959}

In particular use the new components/device_event_log/device_event_log.h .
No functional change.

Review URL: https://codereview.chromium.org/1030603002

Cr-Commit-Position: refs/heads/master@{#321958}

This patch adds tests of transition of tabfocus in Files.app.

BUG=469061

Review URL: https://codereview.chromium.org/1010213006

Cr-Commit-Position: refs/heads/master@{#321957}

This makes the algorithm name a mandatory argument of getKeyPair().
In a later CL, this name will be compared with the key restrictions that the certificate puts onto the key usage.

BUG=466584

Review URL: https://codereview.chromium.org/1001853003

Cr-Commit-Position: refs/heads/master@{#321956}

Note that real PNACL module of PiexLoader has not been submitted.

BUG=396702
TEST=manually

Review URL: https://codereview.chromium.org/1027283005

Cr-Commit-Position: refs/heads/master@{#321955}

This comment was left behind when corresponding code was
removed in https://codereview.chromium.org/6597038 (rev fbd31eb8).

TEST= none
BUG= none

Review URL: https://codereview.chromium.org/1025523002

Cr-Commit-Position: refs/heads/master@{#321954}

When grid item is created or metadata is updated, shared status of placeholder was updated, but the icon on the bottom was not updated.
By this CL, updateSharedStatus() updates both.

BUG=469963
TEST=manual test

Review URL: https://codereview.chromium.org/1033553004

Cr-Commit-Position: refs/heads/master@{#321953}

BUG=443151

Review URL: https://codereview.chromium.org/1027823003

Cr-Commit-Position: refs/heads/master@{#321952}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/de093d2..e26a365

TBR=dglazkov@chromium.org,alph@chromium.org

Review URL: https://codereview.chromium.org/1031773002

Cr-Commit-Position: refs/heads/master@{#321951}

This CL makes the app list speech view query able to span multiple lines.
This was made possible by a change in Label which drastically speeds up
layout of a label. which has to happen each time the query string changes.

BUG=443762

Review URL: https://codereview.chromium.org/1028023002

Cr-Commit-Position: refs/heads/master@{#321950}

This CL fixes the test by using FocusManager::GetNextFocusableView
instead of actually setting focus, which was causing flake because other
concurrent browser tests could change the focused view.

BUG=463456

Review URL: https://codereview.chromium.org/984813002

Cr-Commit-Position: refs/heads/master@{#321949}

Tests are flaky, especially on WinXP bots.

BUG=470013
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/1033593002

Cr-Commit-Position: refs/heads/master@{#321948}

BUG=438525

Review URL: https://codereview.chromium.org/1027683002

Cr-Commit-Position: refs/heads/master@{#321947}

Cr-Commit-Position: refs/heads/master@{#321946}

A new way to enable collection of power data that is not
dependant on the divice was implemented in
https://codereview.chromium.org/993733002/
This CL is to change telemetry to use this when getting dumpsys data.
This method of disabling charging does not work with monsoon since
it does not actualy disable charging, but just starts the dumpsys collection.

BUG=

Review URL: https://codereview.chromium.org/1010213008

Cr-Commit-Position: refs/heads/master@{#321945}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/201fd41..de093d2

TBR=dglazkov@chromium.org,alph@chromium.org

Review URL: https://codereview.chromium.org/1029223004

Cr-Commit-Position: refs/heads/master@{#321944}

Add a new method base::File::FlushData to use fdatasync.

BUG=469071

Review URL: https://codereview.chromium.org/1023103002

Cr-Commit-Position: refs/heads/master@{#321943}

Instead of allowing all component apps, this CL whitelists only those apps
which need access to this API.

TEST=All current tests pass.
BUG=323422

Review URL: https://codereview.chromium.org/1030533002

Cr-Commit-Position: refs/heads/master@{#321942}

BUG=295792

Review URL: https://codereview.chromium.org/1025303006

Cr-Commit-Position: refs/heads/master@{#321941}

BUG=367631
TEST=None

Review URL: https://codereview.chromium.org/1031573002

Cr-Commit-Position: refs/heads/master@{#321940}

The latest angle roll fixed the problem, so the suppression can be
removed.

TBR=glider@chromium.org
BUG=468638

Review URL: https://codereview.chromium.org/1015243003

Cr-Commit-Position: refs/heads/master@{#321939}

The new logic was trying to mount all volumes in R/W mode, which was failing
for read-only volumes.

TEST=Tested manually with read only volumes.
BUG=None

Review URL: https://codereview.chromium.org/1024553005

Cr-Commit-Position: refs/heads/master@{#321938}