- 12 Feb, 2018 39 commits
-
-
Henrik Boström authored
Implementation: - addStream() is defined in terms of addTrack() and adding a listener of tracks being added/removed from the stream. The listener uses addTrack()/removeTrack(). - removeStream() is defined in terms of removeTrack() and removing the listener of tracks being added/removed from the stream. This fixes: https://crbug.com/738929 Related bug fixes: - By getting rid of local_streams_, this also fixes the issue where createDTMFSender() could only be called for tracks added with the legacy APIs. https://crbug.com/806875 - By adding code checking if a stream was the first/last stream added/removed, the chrome://webrtc-internals events related to adding or removing a stream are triggered by addTrack/removeTrack, fixing the bug where addTrack-streams did not appear in chrome://webrtc-internals. https://crbug.com/801093 Old code no longer exercised is removed. MockPeerConnectionImpl is updated to work with track-based APIs. We should get rid of this class in future CLs, it's a maintenance burden. Design doc: https://docs.google.com/document/d/1Obbeg-B4_04twVctHdf7C7vkUQrGlLvOaV0C8J5_-Gs/edit?usp=sharing Bug: 738929, 803021, 806875, 801093 Change-Id: I77541a3dce180e1cf8b311cb7803047215b0af7b Reviewed-on: https://chromium-review.googlesource.com/899346 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#536052}
-
Bhagirathi Satpathy authored
Modified StyleSheet |media|and CSSPageRule |style| IDL attribute to match the specification. https://drafts.csswg.org/cssom/#the-stylesheet-interface https://drafts.csswg.org/cssom/#the-csspagerule-interface Bug: 811173 Change-Id: Ifa2630e72fb66898fcb82a444162c8f2f41c7ac2 Reviewed-on: https://chromium-review.googlesource.com/903803 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#536051}
-
Meredith Lane authored
Instead of streaming live updates, a ComputedAccessibleNode must be manually refreshed. This change adds the IDL code and implementation of this behaviour by requesting a fresh tree snapshot when a node needs to be refreshed. As all ComputedAccessibleNodes refer to the same tree snapshot, when ensureUpToDate is called on one node, all others are also refreshed, ensuring that all references to ComputedAccessibleNodes are consistent with the same snapshot. BUG=792783 Change-Id: I0ff900c947a8e005a64c9d1e9ef24f6908206e6c Reviewed-on: https://chromium-review.googlesource.com/905702Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@google.com> Cr-Commit-Position: refs/heads/master@{#536050}
-
Alan Cutter authored
This CL fixes nits from https://chromium-review.googlesource.com/c/chromium/src/+/910329 that didn't make it into the landed CL. Change-Id: I82d7312a40a6c182985ec10cdd166307b08ecf32 Reviewed-on: https://chromium-review.googlesource.com/913190Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536049}
-
Takuto Ikuta authored
This reverts commit 536b1e56. Reason for revert: This looks to drop necessary info for android crash report. crbug.com/809573 Original change's description: > Use -g0 in minimal_symbols config in non-sanitizer build > > I confirm that how -g0 affects stacktrace shown in test failure/crash. > With -g1: https://chromium-review.googlesource.com/c/chromium/src/+/892540/1 > With -g0: https://chromium-review.googlesource.com/c/chromium/src/+/892187/3 > > I summarize how stacktrace is shown on each builder affected by this CL. > This CL does not change stacktrace. > > |--------------------------+---------------+------------------+---------------+------------------| > | builder | -g0 crash | -g0 CHECK(false) | -g1 crash | -g1 CHECK(false) | > |--------------------------+---------------+------------------+---------------+------------------| > | android_n5x_swarming_rel | no stacktrace | correct | no stacktrace | correct | > | cast_shell_linux | correct | correct | correct | correct | > | ios-simulator | no stacktrace | no stacktrace | no stacktrace | no stacktrace | > | linux-chromeos-rel | correct | correct | correct | correct | > | linux_android_rel_ng | no stacktrace | correct | no stacktrace | correct | > | mac_chromium_rel_ng | correct | correct | correct | correct | > |--------------------------+---------------+------------------+---------------+------------------| > > > I see improved link time of some large binary on (very slow) andrdoin_n5x_swarming_rel builder. > > With this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave603-c4/ninja_log.slave603-c4.chrome-bot.20180130-001251.4049.gz/table?dedup=true > taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350571 > > Without this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave604-c4/ninja_log.slave604-c4.chrome-bot.20180130-005043.1186.gz/table?dedup=true > taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350593 > > |-----------------------------------------+---------+-----------| > | link time of each target | -g0 | -g1 | > |-----------------------------------------+---------+-----------| > | android_clang_arm/libmonochrome.so | 14.206s | 27.25s | > | android_clang_arm/libwebviewchromium.so | 12.355s | 1m44.577s | > | lib_components_unittests__library.so | 22.194s | 1m17.442s | > | libwebviewchromium.so | 30.729s | 1m45.147s | > | libmonochrome.so: | 31.862s | 1m33.027s | > | lib_unit_tests__library.so | 53.444s | 44.943s | > |-----------------------------------------+---------+-----------| > > This patch improved link time in most cases. > > Bug: 794423 > Change-Id: I757a8a01bed0dea4c62e2f8ebfccc5a163d8cc18 > Reviewed-on: https://chromium-review.googlesource.com/892187 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@google.com> > Cr-Commit-Position: refs/heads/master@{#533158} TBR=thakis@chromium.org,dpranke@chromium.org,tikuta@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 794423, 809573 Change-Id: Ica7c67699ebb388f2d0148173d3e254d45ac058e Reviewed-on: https://chromium-review.googlesource.com/912848Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#536048}
-
Marc Treib authored
This reverts commit e012089d. Reason for revert: use-of-uninitialized-value failures on MSan bots in the new tests, see FindIt comment or here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/5691 Original change's description: > Remove event coalescing from RenderWidgetTargeter. > > The code removed in this CL is believed to be the root cause of the > crash in the associated bug. > > The mechanism is this: when events are coalesced, some event types still > expect all of the original events to be properly acked, and at present > RenderWidgetTargeter doesn't implement this. The crash, in particular, > is the result of touch events being acked in a way that the unique ids > don't line up with the queue in > TouchDispositionGestureFilter::OnTouchEventAck() > because some of the ids are missing after being coalesced. > > At present we will only disable coalescing for touch and gesture > events,but that's reasonable since in most cases we only everhit-test > the initial TouchStart and everything else in the sequence latches to > its target. > > Further, it's not obvious if there's a significant performance > benefit to the coalescing these events, so for now we remove it. > In any case, implementing proper acking of these events would result > in a patch too big to merge back to M65. > > Bug: 807507 > Change-Id: I50dbef4f16f4b451321564e1e0c9cfb352aafabd > Reviewed-on: https://chromium-review.googlesource.com/905459 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535895} TBR=sadrul@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807507 Change-Id: Id5559d992b6e088996e42057f46854031bf2ad48 Reviewed-on: https://chromium-review.googlesource.com/913229Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#536047}
-
Patrik Höglund authored
This test has been broken for a couple months, we have no idea how to fix it, and its value is questionable compared to its complexity anyway. It finds ~1 bug per year, tops, and even when it does it's hard to troubleshoot. Also, the code to interact with Firefox has aged badly and is hard to extend. Bug: chromium:751211 Change-Id: I0b4f84d80a3f8c05fd40fe3d58b82ccabbb4e9d2 Reviewed-on: https://chromium-review.googlesource.com/913248Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#536046}
-
Filip Gorski authored
A promissed follow-up test refactoring, which removes friending of test classes. It also found a bug, already fixed in original patch. Bug: 805171 Change-Id: I1d7c3a8043df705f3e21cd7dabdab401b424f08f Reviewed-on: https://chromium-review.googlesource.com/903586 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#536045}
-
Morten Stenshorne authored
The presence of floats complicate min/max intrinsic inline size calculation. They affect lines and child blocks in the same block formatting context. Therefore, when calculating min/max sizes of a child, we need to pass along information about floats adjacent to the current "virtual" block position. This change actually makes NG slightly "better" than legacy Blink layout, Edge and Firefox. This may be an issue for compatibility. It should be fairly easy to "dumb down" the machinery to be compatible with the others, though, if this should become an issue. Two tests regressed because of this. Reported bug 810370. This change also caused grid-item-margins-not-collapse-expected.html to make room for the floats to fit beside each other, so I modified it. Also removed bogus "margin" attributes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I59730d7333fa7699a42ab93d2c4674c267d834aa Reviewed-on: https://chromium-review.googlesource.com/908753 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536044}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13101a6e42d1..705e51807fec $ git log 13101a6e4..705e51807 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 mgiuca git_test_utils: Fixed custom git metadata in git commit schemas. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I87814d775ac3f683374737b8f52ae586ef7accb4 Reviewed-on: https://chromium-review.googlesource.com/911983Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536043}
-
https://skia.googlesource.com/skia.git/+log/a76f6161f1c2..56a4a099e707 $ git log a76f6161f..56a4a099e --date=short --no-merges --format='%ad %ae %s' 2018-02-12 liyuqian Add init-once to threaded backend Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I30debaabfdbe13743cfb47195188671c3f719b60 Reviewed-on: https://chromium-review.googlesource.com/912521 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536042}
-
Marc Treib authored
This reverts commit 58525850. Reason for revert: Broke fast/webgl/texImage-imageBitmap-from-image-resize.html on Mac 10.11: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/23254 Original change's description: > opt Chromium back into HQ scaling clamps > > Change-Id: I2693be780057c1ba715fce3ae3c398c536f147ea > Reviewed-on: https://chromium-review.googlesource.com/911734 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536009} TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org Change-Id: I01d68484de5892eeab4c1ec42e389ab8c0fdbde7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/912471Reviewed-by:
-
Patrik Höglund authored
The idea is to add a bot and an empty target such that we invoke gcc empty_main.cc with Chromium's build flags. The intention is to catch clang-only flags that break the gcc build. Bug: chromium:776284 Change-Id: I9e7dc21b15e0903c813de31d4b0731515e6e4426 Reviewed-on: https://chromium-review.googlesource.com/876010 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
-
Tim Schumann authored
Change-Id: I54f63844b7c664553434008aafcf98e2d115d669 Reviewed-on: https://chromium-review.googlesource.com/913129 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 3674 3678 3684 3686 3688 3689 3690 3694 3696 3697 3698 3699 3693 39 lines were removed and 35 lines were deflaked by consecutive results since 3664. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I623bd148abe99a0982386e4ac746a4c42902bfa1 Reviewed-on: https://chromium-review.googlesource.com/912208 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Eero Häkkinen authored
This improves VectorMath performance on X86 platform by 7 to 25 percent depending on aligment of source and destination vectors. Bug: 778262 Change-Id: I8f1b6b7bce4d4ebfc254ed7d67758a68c20ec93a Reviewed-on: https://chromium-review.googlesource.com/738242Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#536037}
-
Noel Gordon authored
Run git cl format over BUILD.gn, and add a line space here and there to increase readability. Tbr: cavalcanti@chromium.org Bug: None Change-Id: Id46ff314c0fe820880fd441858cbaca6d7754b46 Reviewed-on: https://chromium-review.googlesource.com/912209Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#536036}
-
https://skia.googlesource.com/skia.git/+log/3a2b8031331c..a76f6161f1c2 $ git log 3a2b80313..a76f6161f --date=short --no-merges --format='%ad %ae %s' 2018-02-12 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Id16619608021c9df2134631ebfb89a6b06091290 Reviewed-on: https://chromium-review.googlesource.com/912662 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Ramin Halavati authored
Update annotations.xml policy fields to match field numbers in traffic_annotation.proto. Bug:656607 Change-Id: Iba28b3090b9a65f06f505551812a77429801b43c TBR=msramek@chromium.org Change-Id: Iba28b3090b9a65f06f505551812a77429801b43c Reviewed-on: https://chromium-review.googlesource.com/911549Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#536034}
-
Han Leon authored
This CL mojofies the legacy IPC ServiceWorkerHostMsg_TerminateWorker. BUG=772713 Change-Id: If91640688b0c7e7d08b7d375a7776d7c19c17781 Reviewed-on: https://chromium-review.googlesource.com/897582 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#536033}
-
Filip Gorski authored
Bug: 805177 Change-Id: I81bc5c2b54304f60123f464b155c3a1ee8182c72 Reviewed-on: https://chromium-review.googlesource.com/910148 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Meredith Lane authored
After multiple problems with running async_tests and them timing out, we have decided to move all tests to just synchronous test runners. BUG=792783 Change-Id: I300c94795ea0c9a657561916eccc86bbed0be0a9 Reviewed-on: https://chromium-review.googlesource.com/913051Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I37ac0069eba0216f798a8d05d2adcbf4947bcdfe Reviewed-on: https://chromium-review.googlesource.com/912034Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#536030}
-
Han Leon authored
In the implementations of ServiceWorkerRegistrationObjectHost.{SetNavigationPreloadHeader,EnableNavigationPreload}, if ServiceWorkerStorage::{UpdateNavigationPreloadHeader,UpdateNavigationPreloadEnabled} failed, a ServiceWorkerErrorType::kUnknown error code is sent back to Blink side, over there it's mapped as an ExceptionCode::kUnknownError to construct a DOMException to be exported to JavaScript context. This is an acceptable behavior, as all of other core DOMException codes are not appropriate to indicate such an storage access failure, and we're already putting an error message "Failed to access storage." into the JavaScript DOMException mentioned above. Based on above explanations, this CL removes an unnecessary DCHECK against the kUnKnownError in Blink side. BUG=807239 Change-Id: Ic2222e264139abc000f5a8894bb0b33932b5335d Reviewed-on: https://chromium-review.googlesource.com/908059Reviewed-by: -
Darren Shen authored
Currently, clicking on a dropdown when the VK is active will cause the VK to hide, which sends out a resize message to RenderViewImpl, which then forces the newly opened dropdown to hide again. The resize message sent by the VK doesn't actually change the size, so we can prevent the popup from hiding if the new requested size is the same as the old. The hope is that this doesn't affect any other existing behaviour. Bug: 761908 Change-Id: I0d2d7e876b42cced2be867ebc5ad3432a4d045c7 Reviewed-on: https://chromium-review.googlesource.com/909869Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Sasha Morrissey authored
Break down 'other' in FileBrowser.QuickView.FileType UMA to 'directory', 'no extension' and 'unknown extension'. extension and a file with a .gn extension. Then check values 59 through 62 inclusive Bug: 772599 Test: Quick View and Open on a folder, a .zip file, a file without an chrome: //histograms has 4 entries for FileBrowser.QuickView.FileType, Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id13b8734e96b238bfb98b98b0062d1f0721180c7 Reviewed-on: https://chromium-review.googlesource.com/907992Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#536027}
-
https://skia.googlesource.com/skia.git/+log/78c110e2f0fa..3a2b8031331c $ git log 78c110e2f..3a2b80313 --date=short --no-merges --format='%ad %ae %s' 2018-02-12 liyuqian Remove SK_SUPPORT_LEGACY_AAA_SMOOTH Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I079db80d8c7b4eb3051102b22cc9828eea306e05 Reviewed-on: https://chromium-review.googlesource.com/911979Reviewed-by:
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I755e7f48ea7f7f558e9ed6cc386af8e87b20ec66 Reviewed-on: https://chromium-review.googlesource.com/910473Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536025}
-
Nico Weber authored
Found by PVS-Studio. Bug: 805881 Change-Id: I96cd4b37494514ae784a2583d31738e8d3ef616a Reviewed-on: https://chromium-review.googlesource.com/912252 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536024}
-
Darren Shen authored
There are some layout tests in typedcssom that are now covered by other tests (either WPT or IDLHarness). We can remove them. Bug: 774887 Change-Id: I39277868e2a656d66795753c984755ac8a5d330d Reviewed-on: https://chromium-review.googlesource.com/912850Reviewed-by:
-
Darren Shen authored
This patch implements CSSTransformComponent.toMatrix(), which was previously implemented as AsMatrix() but just not webexposed. We also split up the tests since it makes more sense. Bug: 807877 Change-Id: Icee742fdde033d63cea85a27250e91a71ad67e2a Reviewed-on: https://chromium-review.googlesource.com/910529 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Darren Shen authored
Currently, our per-property tests only test that styleMap.set accept valid values. This patch refactors the per-property tests a bit to also test that we reject invalid values. Bug: 774887 Change-Id: I41b5c4c1a6dfe6e766ff37fdc1b1f890dfb81aac Reviewed-on: https://chromium-review.googlesource.com/905523 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Noel Gordon authored
This reverts commit b07c92a1. Reason for revert: the litmus test of running this code on linux x86 bots worked. However, performance-wise we're not so sure. Back this change out to restrict it to Intel x64 for now. Original change's description: > Add x86 bots to the read64le party > > thestig@ reminds me we do have linux x86 bots on the waterfall. Add them > to the read64le party. Minor: run git cl format over BUILD.gn, and add a > line space here and there for readability. > > Bug: 760853 > Change-Id: Ia47296a26bff77f9be699e31053d8b94aac583f4 > Reviewed-on: https://chromium-review.googlesource.com/910328 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535612} TBR=noel@chromium.org,mtklein@chromium.org,nigeltao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 760853 Change-Id: If3d24a2cdc6614ff82c781019623108a52dbd16a Reviewed-on: https://chromium-review.googlesource.com/913029 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Yuqian Li authored
TBR: fmalita@chromium.org Bug: skia:7573 Change-Id: I7c7fb884003038a016db36bafe6031c89757d84a Reviewed-on: https://chromium-review.googlesource.com/912909Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#536019}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 121b6cfa. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12452 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I17d74a4ba963d0150744fd14a30472fe7c9941a0 Reviewed-on: https://chromium-review.googlesource.com/912251 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#536018}
-
Alan Cutter authored
frames() is no longer being shipped in M60 [0], as a result we cannot refer to it as a replacement for step-middle. [0] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/j7l8_DjMsVE/0HKZgZXNAQAJ Bug: 646265 Change-Id: I8f828fabd7c6c8ccc5e72d393ef260de31fcb23c Reviewed-on: https://chromium-review.googlesource.com/557481 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Suzy Howlett <suzyh@chromium.org> Cr-Commit-Position: refs/heads/master@{#536017}
-
Jinsuk Kim authored
WebContentsUserData-backed objects requires its WebContents instance from CVC be non-null, which causes numerous null checking statments. This CL examines callsites to the methods that contains accesses to those objects, adds null-checking statements if missing, and removes it if redundant. Some observations the changes are based on: - private native method doesn't need null check; WebContents is certainly valid at that point. - CVC.destroy() itself or calls from it (before it nulls out WebContents) doesn't need null check since WebContent is valid up to that point. Added null check: ... since clusterfuzz results warn that these need it: - setTouchScrollInProgress - destroyPastePopup ... by moving it over from the 2 callsites: - updateTextSelectionUI (onAttachedToWindow, onDetachedFromWindow) Removed null check as callsites already have null checking/assert, or assure WebContents is not null: - hidePopupsAndClearSelection (WebContentObserver.resetPopupsAndInput, onFocusChanged, showSelectPopup) - hidePopupsAndPreserveSelection (destroy, onHide, updateTextSelectionUI, onFocusChanged, onRotationChanged) - hidePopups (above 2) - onAttachedToWindow, onDetachedFromWindow: moved to updateTextSelectionUI - onRotationChanged: consolidated null checks Inlined one-liner restoreSelectionPopupsIfNecessary into callsites to eliminate the concern on null check on it (much clearer when inlined). Bug: 810179 Change-Id: I55aab2b1f7917a9af4522a1bcf8d3e7d9b172f2a Reviewed-on: https://chromium-review.googlesource.com/907770 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#536016}
-
Patti authored
Update the "clear all text" button's icon and show it while editing in touch mode. Screenshots - https://drive.google.com/file/d/1EFdKPFsvo70ZD0FfK0mfKLS-avijyCtN/view?usp=sharing Bug: 801583 Change-Id: I9b5dca22654d8f24c467e3f9c21d278a7c63005e Reviewed-on: https://chromium-review.googlesource.com/910828 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#536015}
-
Alan Cutter authored
Bookmark apps don't get special Chrome app permissions and it doesn't make sense to display the permissions allocated to them when it will always be none. This CL changes the "App info" context menu entry to go to "Site settings" for the bookmark app's URL. This is inline with our UX mocks for PWAs. Bug: 800205 Change-Id: I8e0135836c44bd7c88a22ea87b7bf1526dba14eb Reviewed-on: https://chromium-review.googlesource.com/910329 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
- 11 Feb, 2018 1 commit
-
-
Giovanni Ortuño Urquidi authored
When a website calls window.open() with a URL for which there is a PWA installed, we cancel the navigation in the newly opened tab and start a new navigation in a new app window. This patch plumbs the opener that would have existed in the new tab to the new app window, so that the new app window can access it. This only takes care of the child window. The parent window is not yet able to access the newly opened app window. Bug: 804881 Change-Id: Ie08c3425b13b4940435e6cf3614a015d61ed10a3 Reviewed-on: https://chromium-review.googlesource.com/906042Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#536013}
-
